)]}'
{"octavia/api/drivers/amphora_driver/v1/driver.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"28aba6117b10577eb92fdd76ab810054f810975e","unresolved":false,"context_lines":[{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    # Member"},{"line_number":165,"context_line":"    def member_create(self, member):"},{"line_number":166,"context_line":"        pool_id \u003d member.pool_id"},{"line_number":167,"context_line":"        db_pool \u003d self.repositories.pool.get(db_apis.get_session(),"},{"line_number":168,"context_line":"                                             id\u003dpool_id)"},{"line_number":169,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_caf563ce","line":166,"updated":"2019-07-02 14:58:14.000000000","message":"nit: We are going to create a validation module for these at some point. I expect there will be more in the future. However, this is a nit as we can do that in the future when we add the next one.","commit_id":"17c478c07fc816f8d795864b3b57c18efafb6945"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"28aba6117b10577eb92fdd76ab810054f810975e","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        db_pool \u003d self.repositories.pool.get(db_apis.get_session(),"},{"line_number":168,"context_line":"                                             id\u003dpool_id)"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        if db_pool.protocol \u003d\u003d consts.PROTOCOL_UDP:"},{"line_number":171,"context_line":"            member_is_ipv6 \u003d utils.is_ipv6(member.address)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"            # For UDP LBs, check that we are not mixing IPv4 and IPv6"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_aa158fe7","line":170,"updated":"2019-07-02 14:58:14.000000000","message":"This needs unit test coverage. We should be testing that the exception is raised.\nhttp://logs.openstack.org/17/668617/2/check/openstack-tox-cover/1bda842/cover/octavia_api_drivers_amphora_driver_v1_driver_py.html#n170","commit_id":"17c478c07fc816f8d795864b3b57c18efafb6945"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"eef05bd577a33b24ab6e3a66fd21b679ce5204f4","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        db_pool \u003d self.repositories.pool.get(db_apis.get_session(),"},{"line_number":168,"context_line":"                                             id\u003dpool_id)"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        if db_pool.protocol \u003d\u003d consts.PROTOCOL_UDP:"},{"line_number":171,"context_line":"            member_is_ipv6 \u003d utils.is_ipv6(member.address)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"            # For UDP LBs, check that we are not mixing IPv4 and IPv6"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_df70b60b","line":170,"in_reply_to":"9fb8cfa7_aa158fe7","updated":"2019-07-03 06:53:08.000000000","message":"done","commit_id":"17c478c07fc816f8d795864b3b57c18efafb6945"}],"releasenotes/notes/validate-same-ip-protocol-in-udp-lb-2813b545131097ec.yaml":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"28aba6117b10577eb92fdd76ab810054f810975e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add a validation step when adding a member in a UDP load balancer in the"},{"line_number":5,"context_line":"    amphora driver, it checks that the load balancer uses the same IP protocol"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fb8cfa7_67335215","line":2,"updated":"2019-07-02 14:58:14.000000000","message":"This is really only a bug fix, so we should not duplicate it in the features section.\nHaving features in release notes can raise red flags with the stable branch team when we try to backport and release. So if something is really just a bug fix, we should not use the feature section.","commit_id":"17c478c07fc816f8d795864b3b57c18efafb6945"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"eef05bd577a33b24ab6e3a66fd21b679ce5204f4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add a validation step when adding a member in a UDP load balancer in the"},{"line_number":5,"context_line":"    amphora driver, it checks that the load balancer uses the same IP protocol"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fb8cfa7_5f5e0677","line":2,"in_reply_to":"9fb8cfa7_67335215","updated":"2019-07-03 06:53:08.000000000","message":"done. removed the features section","commit_id":"17c478c07fc816f8d795864b3b57c18efafb6945"}]}