)]}'
{"octavia/certificates/common/local.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"cc0be8e09bb3153b418f346768c7ff3a6e948788","unresolved":false,"context_lines":[{"line_number":50,"context_line":"               default\u003dTLS_PKP_DEFAULT,"},{"line_number":51,"context_line":"               help\u003d\u0027Passphrase for the Private Key. Defaults\u0027"},{"line_number":52,"context_line":"                    \u0027 to env[OS_OCTAVIA_CA_KEY_PASS] or None.\u0027),"},{"line_number":53,"context_line":"    cfg.StrOpt(\u0027server_certs_key_passphrase\u0027,"},{"line_number":54,"context_line":"               default\u003dTLS_PASS_AMPS_DEFAULT,"},{"line_number":55,"context_line":"               help\u003d\u0027Passphrase for encrypting Amphora Certificates and \u0027"},{"line_number":56,"context_line":"                    \u0027Private Keys. must be 32 characters long. \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_b0b6633d","line":53,"updated":"2019-07-19 22:26:15.000000000","message":"The fernet documentation describes this key as \"A URL-safe base64-encoded 32-byte key.\"\nWhy don\u0027t you add a \"regex\" and \"max_length\" to this StrOpt that validates for that criteria?\nAs a (not correct) example: ^[a-zA-Z]{32}$ would match a string of letters exactly 32 characters long.","commit_id":"84eac0873905367ab85baed1fee437e3a74f0623"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"fcac5c64665fa60908016aa80139f2fc1b1c1025","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    cfg.StrOpt(\u0027server_certs_key_passphrase\u0027,"},{"line_number":54,"context_line":"               default\u003dTLS_PASS_AMPS_DEFAULT,"},{"line_number":55,"context_line":"               help\u003d\u0027Passphrase for encrypting Amphora Certificates and \u0027"},{"line_number":56,"context_line":"                    \u0027Private Keys. must be 32 characters long. \u0027"},{"line_number":57,"context_line":"                    \u0027Defaults to env[TLS_PASS_AMPS_DEFAULT] or \u0027"},{"line_number":58,"context_line":"                    \u0027insecure-key-do-not-use-this-key\u0027,"},{"line_number":59,"context_line":"               required\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_1095f786","line":56,"range":{"start_line":56,"start_character":35,"end_line":56,"end_character":62},"updated":"2019-07-19 22:28:25.000000000","message":"Does the pass phrase need to be 32 characters log or the final base64 encoded string?","commit_id":"84eac0873905367ab85baed1fee437e3a74f0623"}]}