)]}'
{"octavia/tests/unit/common/jinja/haproxy/split_listeners/test_jinja_cfg.py":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"f9d0fd8f8de0e628f23a9fdc0ee59df8b604ffd6","unresolved":false,"context_lines":[{"line_number":900,"context_line":"    def test_transform_listener(self):"},{"line_number":901,"context_line":"        in_listener \u003d sample_configs_split.sample_listener_tuple()"},{"line_number":902,"context_line":"        ret \u003d self.jinja_cfg._transform_listener(in_listener, None, {},"},{"line_number":903,"context_line":"                                                 in_listener.load_balancer)"},{"line_number":904,"context_line":"        self.assertEqual(sample_configs_split.RET_LISTENER, ret)"},{"line_number":905,"context_line":""},{"line_number":906,"context_line":"    def test_transform_listener_with_l7(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_9efabf72","line":903,"range":{"start_line":903,"start_character":49,"end_line":903,"end_character":74},"updated":"2019-07-31 09:21:10.000000000","message":"In your branch in octavia/common/jinja/haproxy/split_listeners/jinja_cfg.py, _transform_listener doesn\u0027t have \u0027load_balancer\u0027 as 4th argument (but the same function in combined_listener has this argument)","commit_id":"7afc98e5ab677dd6c66bf4c0bfb5bf2ce73ed78f"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"533e3fa9ec9736a21bbd702e50bc91ba3208ef5b","unresolved":false,"context_lines":[{"line_number":900,"context_line":"    def test_transform_listener(self):"},{"line_number":901,"context_line":"        in_listener \u003d sample_configs_split.sample_listener_tuple()"},{"line_number":902,"context_line":"        ret \u003d self.jinja_cfg._transform_listener(in_listener, None, {},"},{"line_number":903,"context_line":"                                                 in_listener.load_balancer)"},{"line_number":904,"context_line":"        self.assertEqual(sample_configs_split.RET_LISTENER, ret)"},{"line_number":905,"context_line":""},{"line_number":906,"context_line":"    def test_transform_listener_with_l7(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_3e52ab3c","line":903,"range":{"start_line":903,"start_character":49,"end_line":903,"end_character":74},"in_reply_to":"7faddb67_9efabf72","updated":"2019-07-31 09:41:42.000000000","message":"Woah, that\u0027s eagle-eye right there! :D\n\n_transform_listeners in split_listeners does not have the \u0027loadbalancer\u0027 argument because it was solely used for log offloading, a feature not available before Train. The same method in combined_listener uses the \u0027loadbalancer\u0027 argument.\n\nSo, yes, we should drop \u0027in_listener.load_balancer\u0027 here. Thank you!","commit_id":"7afc98e5ab677dd6c66bf4c0bfb5bf2ce73ed78f"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"f9d0fd8f8de0e628f23a9fdc0ee59df8b604ffd6","unresolved":false,"context_lines":[{"line_number":906,"context_line":"    def test_transform_listener_with_l7(self):"},{"line_number":907,"context_line":"        in_listener \u003d sample_configs_split.sample_listener_tuple(l7\u003dTrue)"},{"line_number":908,"context_line":"        ret \u003d self.jinja_cfg._transform_listener(in_listener, None, {},"},{"line_number":909,"context_line":"                                                 in_listener.load_balancer)"},{"line_number":910,"context_line":"        self.assertEqual(sample_configs_split.RET_LISTENER_L7, ret)"},{"line_number":911,"context_line":""},{"line_number":912,"context_line":"    def test_transform_loadbalancer(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_bef77b8b","line":909,"range":{"start_line":909,"start_character":49,"end_line":909,"end_character":74},"updated":"2019-07-31 09:21:10.000000000","message":"same here","commit_id":"7afc98e5ab677dd6c66bf4c0bfb5bf2ce73ed78f"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"533e3fa9ec9736a21bbd702e50bc91ba3208ef5b","unresolved":false,"context_lines":[{"line_number":906,"context_line":"    def test_transform_listener_with_l7(self):"},{"line_number":907,"context_line":"        in_listener \u003d sample_configs_split.sample_listener_tuple(l7\u003dTrue)"},{"line_number":908,"context_line":"        ret \u003d self.jinja_cfg._transform_listener(in_listener, None, {},"},{"line_number":909,"context_line":"                                                 in_listener.load_balancer)"},{"line_number":910,"context_line":"        self.assertEqual(sample_configs_split.RET_LISTENER_L7, ret)"},{"line_number":911,"context_line":""},{"line_number":912,"context_line":"    def test_transform_loadbalancer(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_de427768","line":909,"range":{"start_line":909,"start_character":49,"end_line":909,"end_character":74},"in_reply_to":"7faddb67_bef77b8b","updated":"2019-07-31 09:41:42.000000000","message":"Also drop it here.","commit_id":"7afc98e5ab677dd6c66bf4c0bfb5bf2ce73ed78f"}]}