)]}'
{"id":"openstack%2Foctavia~679753","triplet_id":"openstack%2Foctavia~stable%2Fstein~Icddd2873abeb56a389a35356995df6dde70872b2","project":"openstack/octavia","branch":"stable/stein","topic":"patch-jinja2-stable/stein","hashtags":[],"change_id":"Icddd2873abeb56a389a35356995df6dde70872b2","subject":"Fix template that generates vrrp check script","status":"MERGED","created":"2019-09-03 11:13:45.000000000","updated":"2019-09-17 21:18:00.000000000","submitted":"2019-09-17 21:16:31.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"679753-1568754991531-1830412a","meta_rev_id":"d5eada2357a249c1f276af8341ae1723cd391343","_number":679753,"virtual_id_number":679753,"owner":{"_account_id":30619,"name":"Ajay Kumar","email":"mahajanajay33@gmail.com","username":"ajaykumar33"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":2,"date":"2019-09-17 21:16:31.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},{"value":0,"_account_id":30881,"name":"Rene Luria","email":"rene.luria@infomaniak.com","username":"reneluria"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"all":[{"value":2,"date":"2019-09-17 16:03:35.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-09-16 07:13:48.000000000","_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},{"value":0,"_account_id":30881,"name":"Rene Luria","email":"rene.luria@infomaniak.com","username":"reneluria"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"all":[{"value":1,"date":"2019-09-17 16:03:35.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},{"value":0,"_account_id":30881,"name":"Rene Luria","email":"rene.luria@infomaniak.com","username":"reneluria"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},{"value":0,"date":"2019-09-03 11:13:45.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":30881,"name":"Rene Luria","email":"rene.luria@infomaniak.com","username":"reneluria"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":30881,"name":"Rene Luria","email":"rene.luria@infomaniak.com","username":"reneluria"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-09-03 11:13:45.000000000","updated_by":{"_account_id":30881,"name":"Rene Luria","email":"rene.luria@infomaniak.com","username":"reneluria"},"reviewer":{"_account_id":30881,"name":"Rene Luria","email":"rene.luria@infomaniak.com","username":"reneluria"},"state":"REVIEWER"},{"updated":"2019-09-16 07:13:48.000000000","updated_by":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"reviewer":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"state":"REVIEWER"},{"updated":"2019-09-17 16:03:35.000000000","updated_by":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"reviewer":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"state":"REVIEWER"},{"updated":"2019-09-17 21:16:31.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"8e723db66d7d6d0fdfd99007004d626c1aa3b54b","author":{"_account_id":30619,"name":"Ajay Kumar","email":"mahajanajay33@gmail.com","username":"ajaykumar33"},"date":"2019-09-03 11:13:45.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"9f8d6c65b68825948e6d8e82cb0c5f3feabf8e61","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-03 13:42:54.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/f93551f211094af9899fc37ba8c25ae7 : SUCCESS in 9m 19s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/3c98e51200c848a395f66e60f3c360df : SUCCESS in 7m 24s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c7acae6edece47598c878e6f02aa0ca8 : SUCCESS in 6m 40s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/2f3b396070514a73bfd97fd063c85fdb : SUCCESS in 4m 52s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/85cd20a3003144f5bc8b639c61013891 : SUCCESS in 5m 06s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/9b14fdd9a48d4cd4969afeed736106ef : SUCCESS in 5m 06s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e8966ab696ef43abaa6c58077d36fe1a : SUCCESS in 8m 05s\n- neutron-lbaasv2-dsvm-api https://zuul.opendev.org/t/openstack/build/7a2d3afeaa924ae6817c7dbd75d0e035 : SUCCESS in 1h 25m 26s\n- neutron-lbaasv2-dsvm-py3x-api https://zuul.opendev.org/t/openstack/build/7fb07caaf96b42d48019ffda678215a4 : SUCCESS in 1h 20m 05s\n- neutron-lbaasv2-dsvm-scenario https://zuul.opendev.org/t/openstack/build/b5fe4d645da645d6b700ec6f22c91fb3 : SUCCESS in 1h 33m 36s (non-voting)\n- neutron-lbaasv2-dsvm-py3x-scenario https://zuul.opendev.org/t/openstack/build/5cdd55da585d49a191e697e97116eb0b : SUCCESS in 1h 25m 28s (non-voting)\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/c616469df8f8477e938b87acc1a1545b : SUCCESS in 5m 33s\n- openstack-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/b9f73151bf1244d287ac3ffc180231fe : SUCCESS in 7m 13s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/13829c9736974308873a7c0a981d7092 : SUCCESS in 6m 55s\n- octavia-v1-dsvm-scenario https://zuul.opendev.org/t/openstack/build/f23c4a3bc6284948b15b977cf6cc5512 : SUCCESS in 1h 08m 46s\n- octavia-v1-dsvm-py3x-scenario https://zuul.opendev.org/t/openstack/build/219ab1a78aa843c2990290b32f56a957 : SUCCESS in 1h 11m 27s\n- octavia-v2-dsvm-noop-api https://zuul.opendev.org/t/openstack/build/da22ce1b61b94d3599e6f6a7bb1e8ac7 : SUCCESS in 48m 53s\n- octavia-v2-dsvm-noop-py2-api https://zuul.opendev.org/t/openstack/build/524a2037ade84826b653926c09b536d5 : SUCCESS in 41m 59s\n- octavia-v2-dsvm-scenario https://zuul.opendev.org/t/openstack/build/336995cfc3fe4e4a9cce66702656941d : SUCCESS in 1h 31m 27s\n- octavia-v2-dsvm-py2-scenario https://zuul.opendev.org/t/openstack/build/b10dd32e6a9f42a29bd0031d0cf9c03a : SUCCESS in 1h 43m 06s\n- octavia-v2-dsvm-scenario-ubuntu-xenial https://zuul.opendev.org/t/openstack/build/435395b2dd624cf8837bd3bee40e2ad9 : SUCCESS in 1h 45m 30s\n- octavia-v2-dsvm-py2-scenario-centos-7 https://zuul.opendev.org/t/openstack/build/5827ae5ce5dd494197c8ce9fdce9454c : SUCCESS in 2h 21m 09s (non-voting)\n- octavia-v2-dsvm-scenario-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/83620e4401e349c48525759f68f74a33 : FAILURE in 35m 13s (non-voting)\n- octavia-v2-dsvm-scenario-two-node https://zuul.opendev.org/t/openstack/build/dfbf658687e84259b0b62008cf915c1e : SUCCESS in 1h 47m 08s (non-voting)\n- octavia-v2-dsvm-py2-scenario-two-node https://zuul.opendev.org/t/openstack/build/7c404e3c57284457945c9c3b85f87ea7 : SUCCESS in 1h 28m 31s (non-voting)\n- octavia-grenade https://zuul.opendev.org/t/openstack/build/be5e4fcb0d6044e585be22173062c34c : SUCCESS in 1h 15m 51s\n- octavia-v2-dsvm-tls-barbican https://zuul.opendev.org/t/openstack/build/218a11229aca4fbdbe5242435be4a1f4 : SUCCESS in 1h 00m 44s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"7ef5b53bf8f1a891bafefd315c8c15d5000c8877","author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"date":"2019-09-16 07:13:48.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"f83368088d291a37904783627dd2cd2a048bc70b","author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"date":"2019-09-16 07:14:29.000000000","message":"Patch Set 1: Cherry Picked\n\nThis patchset was cherry picked to branch stable/rocky as commit 6906f9f88df0d3de1680bfe57563594f728cc718","accounts_in_message":[],"_revision_number":1},{"id":"02e72e4bc859d4913107b56e3ed75ca8ec15cb6a","author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"date":"2019-09-17 16:03:35.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nLGTM","accounts_in_message":[],"_revision_number":1},{"id":"4f88a6fae0ff3aeda7323593bdd8d255d65390b2","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-17 16:03:58.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"205c44c702af41c2132da675e96abdb9b53c6004","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-17 21:16:31.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"ca0e400287ba505889a847f6af491cad3a7feebd","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-17 21:16:31.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/696849ed0eb3436b8899cf78f7504ef0 : SUCCESS in 7m 26s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/cc5b2072899a42119c5837ae16bacd34 : SUCCESS in 6m 23s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/766f0c48d94047dab30233c7893f5f2d : SUCCESS in 4m 30s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/206047ac35d14e9594e50a985c8cc51c : SUCCESS in 6m 48s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/9b9b51a2737d4f798287eba079229b60 : SUCCESS in 6m 21s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f813aa244633463abefdf534d2bce1e7 : SUCCESS in 8m 35s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/8de90bba428d46619c86d03e536881e5 : SUCCESS in 7m 07s\n- openstack-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/d7b80b1e04744826b5a89daae8331b09 : SUCCESS in 6m 09s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/222082952efb4d8e909a06d45a7a9d7d : SUCCESS in 7m 22s\n- octavia-v1-dsvm-scenario https://zuul.opendev.org/t/openstack/build/a50301f3a05f49479b763485a4f862fa : SUCCESS in 1h 07m 48s\n- octavia-v1-dsvm-py3x-scenario https://zuul.opendev.org/t/openstack/build/e66233d8702a4645a8b2af50ab169e77 : SUCCESS in 1h 14m 23s\n- neutron-lbaasv2-dsvm-api https://zuul.opendev.org/t/openstack/build/0522c5af2de34c22a1321b63cd7f23f7 : SUCCESS in 1h 22m 25s\n- neutron-lbaasv2-dsvm-py3x-api https://zuul.opendev.org/t/openstack/build/dfd404da47c64588903b4e7a886ef824 : SUCCESS in 1h 23m 38s\n- octavia-v2-dsvm-noop-api https://zuul.opendev.org/t/openstack/build/71cd34e634044d11874906da9b5f0659 : SUCCESS in 47m 18s\n- octavia-v2-dsvm-noop-py2-api https://zuul.opendev.org/t/openstack/build/ee94abdc9dc8497f9aa5e49d23bcbc17 : SUCCESS in 45m 16s\n- octavia-v2-dsvm-scenario https://zuul.opendev.org/t/openstack/build/e0d55c1f815a4cbd8e3e24f16e6884de : SUCCESS in 1h 41m 39s\n- octavia-v2-dsvm-py2-scenario https://zuul.opendev.org/t/openstack/build/b3723136e53b4442b34be7ec1f41e8a1 : SUCCESS in 1h 38m 32s\n- octavia-v2-dsvm-scenario-ubuntu-xenial https://zuul.opendev.org/t/openstack/build/5133447c1a4c413bb8458a3d39be748e : SUCCESS in 1h 47m 54s\n- octavia-grenade https://zuul.opendev.org/t/openstack/build/1977831f79c945dfb25e455ef7391c58 : SUCCESS in 1h 24m 08s","accounts_in_message":[],"_revision_number":1},{"id":"4a89c2cd2ecc97f404442e0fa4a5398c959f42dc","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-17 21:18:00.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0b914ed7c7354a18b2bdb0a205461634 : SUCCESS in 1m 04s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"896b1cfde1761e78688e9216cb05331baddb1eea","revisions":{"896b1cfde1761e78688e9216cb05331baddb1eea":{"kind":"REWORK","_number":1,"created":"2019-09-03 11:13:45.000000000","uploader":{"_account_id":30619,"name":"Ajay Kumar","email":"mahajanajay33@gmail.com","username":"ajaykumar33"},"ref":"refs/changes/53/679753/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/octavia","ref":"refs/changes/53/679753/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/octavia refs/changes/53/679753/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/octavia refs/changes/53/679753/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/octavia refs/changes/53/679753/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/octavia refs/changes/53/679753/1"}}},"commit":{"parents":[{"commit":"49990fd89fefb852b8d26415431818833902d3a6","subject":"Merge \"Fix listener deletion in ACTIVE/STANDBY topology\" into stable/stein","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/49990fd89fefb852b8d26415431818833902d3a6"}]}],"author":{"name":"Rene Luria","email":"rene.luria@infomaniak.com","date":"2019-08-26 11:50:42.000000000","tz":120},"committer":{"name":"Ajay Kumar","email":"ajay.k@india.nec.com","date":"2019-09-03 11:13:45.000000000","tz":0},"subject":"Fix template that generates vrrp check script","message":"Fix template that generates vrrp check script\n\nCorrect the inline comment to not include an empty new line at the start\nof generated /var/lib/octavia/vrrp/check_script.sh that leads to this\nkind of error:\n\n\u003e  Aug 26 11:49:32 amphora-12184e15-1ec3-4d80-98a7-c7d1ddb6716f\n\u003e Keepalived_vrrp[15265]: Error exec-ing command\n\u003e \u0027/var/lib/octavia/vrrp/check_script.sh\u0027, error 8: Exec format error\n\nChange-Id: Icddd2873abeb56a389a35356995df6dde70872b2\n(cherry picked from commit 905499162b33fbac1fd604688d21b73f559ab70d)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/896b1cfde1761e78688e9216cb05331baddb1eea"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/896b1cfde1761e78688e9216cb05331baddb1eea"}]},"branch":"refs/heads/stable/stein"}},"requirements":[],"submit_records":[],"submit_requirements":[]}