)]}'
{"octavia/api/drivers/amphora_driver/v2/driver.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"b0040b5eaa6eea1fdd3a4c7be946a8c6f98c1a61","unresolved":false,"context_lines":[{"line_number":290,"context_line":"        if \u0027max_retries\u0027 in healthmon_dict:"},{"line_number":291,"context_line":"            healthmon_dict[\u0027rise_threshold\u0027] \u003d healthmon_dict.pop("},{"line_number":292,"context_line":"                \u0027max_retries\u0027)"},{"line_number":293,"context_line":"        healthmon_dict.pop(\u0027healthmonitor_id\u0027)"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"        payload \u003d {consts.ORIGINAL_HEALTH_MONITOR: old_healthmonitor.to_dict(),"},{"line_number":296,"context_line":"                   consts.HEALTH_MONITOR_UPDATES: healthmon_dict}"}],"source_content_type":"text/x-python","patch_set":18,"id":"3fa7e38b_6a273620","line":293,"updated":"2019-12-03 16:42:16.000000000","message":"Why are we removing the ID?","commit_id":"c4926fabb57f77679a7fc558696d7f8f8df62e09"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"093d188656adeaf96bce7e1e423e9704fb31a0ee","unresolved":false,"context_lines":[{"line_number":290,"context_line":"        if \u0027max_retries\u0027 in healthmon_dict:"},{"line_number":291,"context_line":"            healthmon_dict[\u0027rise_threshold\u0027] \u003d healthmon_dict.pop("},{"line_number":292,"context_line":"                \u0027max_retries\u0027)"},{"line_number":293,"context_line":"        healthmon_dict.pop(\u0027healthmonitor_id\u0027)"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"        payload \u003d {consts.ORIGINAL_HEALTH_MONITOR: old_healthmonitor.to_dict(),"},{"line_number":296,"context_line":"                   consts.HEALTH_MONITOR_UPDATES: healthmon_dict}"}],"source_content_type":"text/x-python","patch_set":18,"id":"3fa7e38b_0ad242d0","line":293,"in_reply_to":"3fa7e38b_6a273620","updated":"2019-12-03 16:44:35.000000000","message":"The id is in the old_healthmonitor and it will be conflicting with the one in update_dict","commit_id":"c4926fabb57f77679a7fc558696d7f8f8df62e09"}],"octavia/common/constants.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"cc60948004c2cf7f8a8627218f5add15ee1d7356","unresolved":false,"context_lines":[{"line_number":327,"context_line":"HEALTH_MON \u003d \u0027health_mon\u0027"},{"line_number":328,"context_line":"HEALTH_MONITOR \u003d \u0027health_monitor\u0027"},{"line_number":329,"context_line":"HEALTH_MONITOR_ID \u003d \u0027health_monitor_id\u0027"},{"line_number":330,"context_line":"HEALTHMONITOR_ID \u003d \u0027healthmonitor_id\u0027"},{"line_number":331,"context_line":"HEALTH_MONITOR_UPDATES \u003d \u0027health_monitor_updates\u0027"},{"line_number":332,"context_line":"ID \u003d \u0027id\u0027"},{"line_number":333,"context_line":"IMAGE_ID \u003d \u0027image_id\u0027"}],"source_content_type":"text/x-python","patch_set":19,"id":"3fa7e38b_571e97bb","line":330,"updated":"2019-12-04 03:08:01.000000000","message":"I\u0027m confused why there is two almost identical values, but Adam knows best.","commit_id":"488db09ad52d327150616592fe272ce1144129e7"}],"octavia/controller/worker/v2/controller_worker.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"4da6be9ebd616f43f0f2a24e676786fbbb5546a6","unresolved":false,"context_lines":[{"line_number":188,"context_line":"                              health_monitor_updates):"},{"line_number":189,"context_line":"        \"\"\"Updates a health monitor."},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        :param health_monitor: Provider health monitor dict"},{"line_number":192,"context_line":"        :param health_monitor_updates: Dict containing updated health monitor"},{"line_number":193,"context_line":"        :returns: None"},{"line_number":194,"context_line":"        :raises HMNotFound: The referenced health monitor was not found"}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_8656aacd","line":191,"range":{"start_line":191,"start_character":15,"end_line":191,"end_character":29},"updated":"2019-11-01 20:33:46.000000000","message":"nit: s/origin_health_monitor","commit_id":"0a00137973ecbf4fd4f125749ecd6a059cf61fa9"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"e429f85cf3ec5a9a2b78d7ce5aa7e34f65cf886f","unresolved":false,"context_lines":[{"line_number":188,"context_line":"                              health_monitor_updates):"},{"line_number":189,"context_line":"        \"\"\"Updates a health monitor."},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        :param health_monitor: Provider health monitor dict"},{"line_number":192,"context_line":"        :param health_monitor_updates: Dict containing updated health monitor"},{"line_number":193,"context_line":"        :returns: None"},{"line_number":194,"context_line":"        :raises HMNotFound: The referenced health monitor was not found"}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_baa70e51","line":191,"range":{"start_line":191,"start_character":15,"end_line":191,"end_character":29},"in_reply_to":"3fa7e38b_8656aacd","updated":"2019-11-06 11:44:31.000000000","message":"Done","commit_id":"0a00137973ecbf4fd4f125749ecd6a059cf61fa9"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"4da6be9ebd616f43f0f2a24e676786fbbb5546a6","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        :returns: None"},{"line_number":194,"context_line":"        :raises HMNotFound: The referenced health monitor was not found"},{"line_number":195,"context_line":"        \"\"\""},{"line_number":196,"context_line":"        db_health_monitor \u003d None"},{"line_number":197,"context_line":"        try:"},{"line_number":198,"context_line":"            db_health_monitor \u003d self._get_db_obj_until_pending_update("},{"line_number":199,"context_line":"                self._health_mon_repo,"}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_c60582c3","line":196,"updated":"2019-11-01 20:33:46.000000000","message":"doesn\u0027t look necessary unless keeping pep8 happy?","commit_id":"0a00137973ecbf4fd4f125749ecd6a059cf61fa9"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"e429f85cf3ec5a9a2b78d7ce5aa7e34f65cf886f","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        :returns: None"},{"line_number":194,"context_line":"        :raises HMNotFound: The referenced health monitor was not found"},{"line_number":195,"context_line":"        \"\"\""},{"line_number":196,"context_line":"        db_health_monitor \u003d None"},{"line_number":197,"context_line":"        try:"},{"line_number":198,"context_line":"            db_health_monitor \u003d self._get_db_obj_until_pending_update("},{"line_number":199,"context_line":"                self._health_mon_repo,"}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_da79aac5","line":196,"in_reply_to":"3fa7e38b_c60582c3","updated":"2019-11-06 11:44:31.000000000","message":"Done","commit_id":"0a00137973ecbf4fd4f125749ecd6a059cf61fa9"}],"octavia/controller/worker/v2/tasks/database_tasks.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"4da6be9ebd616f43f0f2a24e676786fbbb5546a6","unresolved":false,"context_lines":[{"line_number":199,"context_line":"    def execute(self, pool_id):"},{"line_number":200,"context_line":"        \"\"\"Delete the health monitor in the DB."},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"        :param pool: A pool which health monitor should be deleted."},{"line_number":203,"context_line":"        :returns: None"},{"line_number":204,"context_line":"        \"\"\""},{"line_number":205,"context_line":"        db_pool \u003d self.pool_repo.get(db_apis.get_session(),"}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_46f992c5","line":202,"range":{"start_line":202,"start_character":15,"end_line":202,"end_character":19},"updated":"2019-11-01 20:33:46.000000000","message":"s/pool_id","commit_id":"0a00137973ecbf4fd4f125749ecd6a059cf61fa9"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"e429f85cf3ec5a9a2b78d7ce5aa7e34f65cf886f","unresolved":false,"context_lines":[{"line_number":199,"context_line":"    def execute(self, pool_id):"},{"line_number":200,"context_line":"        \"\"\"Delete the health monitor in the DB."},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"        :param pool: A pool which health monitor should be deleted."},{"line_number":203,"context_line":"        :returns: None"},{"line_number":204,"context_line":"        \"\"\""},{"line_number":205,"context_line":"        db_pool \u003d self.pool_repo.get(db_apis.get_session(),"}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_fa5b4652","line":202,"range":{"start_line":202,"start_character":15,"end_line":202,"end_character":19},"in_reply_to":"3fa7e38b_46f992c5","updated":"2019-11-06 11:44:31.000000000","message":"Done","commit_id":"0a00137973ecbf4fd4f125749ecd6a059cf61fa9"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"4da6be9ebd616f43f0f2a24e676786fbbb5546a6","unresolved":false,"context_lines":[{"line_number":212,"context_line":"    def revert(self, pool_id, *args, **kwargs):"},{"line_number":213,"context_line":"        \"\"\"Mark the health monitor ERROR since the mark active couldn\u0027t happen"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"        :param pool: A pool which health monitor couldn\u0027t be deleted"},{"line_number":216,"context_line":"        :returns: None"},{"line_number":217,"context_line":"        \"\"\""},{"line_number":218,"context_line":"        db_pool \u003d self.pool_repo.get(db_apis.get_session(),"}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_66f4cecf","line":215,"range":{"start_line":215,"start_character":15,"end_line":215,"end_character":19},"updated":"2019-11-01 20:33:46.000000000","message":"s/pool_id","commit_id":"0a00137973ecbf4fd4f125749ecd6a059cf61fa9"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"e429f85cf3ec5a9a2b78d7ce5aa7e34f65cf886f","unresolved":false,"context_lines":[{"line_number":212,"context_line":"    def revert(self, pool_id, *args, **kwargs):"},{"line_number":213,"context_line":"        \"\"\"Mark the health monitor ERROR since the mark active couldn\u0027t happen"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"        :param pool: A pool which health monitor couldn\u0027t be deleted"},{"line_number":216,"context_line":"        :returns: None"},{"line_number":217,"context_line":"        \"\"\""},{"line_number":218,"context_line":"        db_pool \u003d self.pool_repo.get(db_apis.get_session(),"}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_1a59825a","line":215,"range":{"start_line":215,"start_character":15,"end_line":215,"end_character":19},"in_reply_to":"3fa7e38b_66f4cecf","updated":"2019-11-06 11:44:31.000000000","message":"Done","commit_id":"0a00137973ecbf4fd4f125749ecd6a059cf61fa9"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"4da6be9ebd616f43f0f2a24e676786fbbb5546a6","unresolved":false,"context_lines":[{"line_number":2486,"context_line":"    def execute(self, project_id):"},{"line_number":2487,"context_line":"        \"\"\"Decrements the health monitor quota."},{"line_number":2488,"context_line":""},{"line_number":2489,"context_line":"        :param health_mon: The health monitor to decrement the quota on."},{"line_number":2490,"context_line":"        :returns: None"},{"line_number":2491,"context_line":"        \"\"\""},{"line_number":2492,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_4622f253","line":2489,"range":{"start_line":2489,"start_character":15,"end_line":2489,"end_character":25},"updated":"2019-11-01 20:33:46.000000000","message":"s/project_id, and description","commit_id":"0a00137973ecbf4fd4f125749ecd6a059cf61fa9"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"e429f85cf3ec5a9a2b78d7ce5aa7e34f65cf886f","unresolved":false,"context_lines":[{"line_number":2486,"context_line":"    def execute(self, project_id):"},{"line_number":2487,"context_line":"        \"\"\"Decrements the health monitor quota."},{"line_number":2488,"context_line":""},{"line_number":2489,"context_line":"        :param health_mon: The health monitor to decrement the quota on."},{"line_number":2490,"context_line":"        :returns: None"},{"line_number":2491,"context_line":"        \"\"\""},{"line_number":2492,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_da520a36","line":2489,"range":{"start_line":2489,"start_character":15,"end_line":2489,"end_character":25},"in_reply_to":"3fa7e38b_4622f253","updated":"2019-11-06 11:44:31.000000000","message":"Done","commit_id":"0a00137973ecbf4fd4f125749ecd6a059cf61fa9"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"4da6be9ebd616f43f0f2a24e676786fbbb5546a6","unresolved":false,"context_lines":[{"line_number":2509,"context_line":"    def revert(self, project_id, result, *args, **kwargs):"},{"line_number":2510,"context_line":"        \"\"\"Re-apply the quota"},{"line_number":2511,"context_line":""},{"line_number":2512,"context_line":"        :param health_mon: The health monitor to decrement the quota on."},{"line_number":2513,"context_line":"        :returns: None"},{"line_number":2514,"context_line":"        \"\"\""},{"line_number":2515,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_06187a1b","line":2512,"range":{"start_line":2512,"start_character":15,"end_line":2512,"end_character":25},"updated":"2019-11-01 20:33:46.000000000","message":"same, and is result arg required as it\u0027s not used.","commit_id":"0a00137973ecbf4fd4f125749ecd6a059cf61fa9"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"e429f85cf3ec5a9a2b78d7ce5aa7e34f65cf886f","unresolved":false,"context_lines":[{"line_number":2509,"context_line":"    def revert(self, project_id, result, *args, **kwargs):"},{"line_number":2510,"context_line":"        \"\"\"Re-apply the quota"},{"line_number":2511,"context_line":""},{"line_number":2512,"context_line":"        :param health_mon: The health monitor to decrement the quota on."},{"line_number":2513,"context_line":"        :returns: None"},{"line_number":2514,"context_line":"        \"\"\""},{"line_number":2515,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_75fbe714","line":2512,"range":{"start_line":2512,"start_character":15,"end_line":2512,"end_character":25},"in_reply_to":"3fa7e38b_06187a1b","updated":"2019-11-06 11:44:31.000000000","message":"\u0027result\u0027 is a special arg here that contains the result of execute function, it will be passed to this function anyway.","commit_id":"0a00137973ecbf4fd4f125749ecd6a059cf61fa9"}]}