)]}'
{"id":"openstack%2Foctavia~683070","triplet_id":"openstack%2Foctavia~stable%2Fstein~I334364d4654491bc0d289472ca9ab5fe462d5139","project":"openstack/octavia","branch":"stable/stein","topic":"OctaviaServerCertsKeyPassphrase-32chars-stable/stein","hashtags":[],"change_id":"I334364d4654491bc0d289472ca9ab5fe462d5139","subject":"Validate server_certs_key_passphrase is 32 chars","status":"MERGED","created":"2019-09-19 09:15:08.000000000","updated":"2019-09-19 22:06:11.000000000","submitted":"2019-09-19 22:04:25.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"683070-1568930665927-fa3c3f25","meta_rev_id":"f29385a2c541f6bb28be1e45b748ee508faca9a9","_number":683070,"virtual_id_number":683070,"owner":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},{"value":0,"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},{"value":0,"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":2,"date":"2019-09-19 22:04:25.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"all":[{"value":2,"date":"2019-09-19 20:03:08.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},{"value":0,"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},{"value":2,"date":"2019-09-19 13:49:16.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"all":[{"value":1,"date":"2019-09-19 20:03:08.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},{"value":0,"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},{"value":0,"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},{"value":0,"date":"2019-09-19 09:15:08.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},{"value":0,"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-09-19 09:15:08.000000000","updated_by":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"reviewer":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"state":"REVIEWER"},{"updated":"2019-09-19 13:49:16.000000000","updated_by":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"reviewer":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"state":"REVIEWER"},{"updated":"2019-09-19 20:03:08.000000000","updated_by":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"reviewer":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"state":"REVIEWER"},{"updated":"2019-09-19 22:04:25.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"6a4122721066543b69f7faef7062d667e0617f3e","author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"date":"2019-09-19 09:15:08.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"f6c8b96b51e63f3c454aecae8a1358ac7bb3c202","author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"date":"2019-09-19 09:15:13.000000000","message":"Patch Set 1: Cherry Picked\n\nThis patchset was cherry picked to branch stable/rocky as commit 1756b19e4bc6e05598b1566af288a63a2bb95d19","accounts_in_message":[],"_revision_number":1},{"id":"cf41950d186d879d6156d4731960ef7737b47c2c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-19 11:57:39.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/f46bef0b13bf402e972a5933409f7baf : SUCCESS in 8m 29s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/823626b9918b4d11aff8e63ff523b95c : SUCCESS in 8m 46s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/6450d399d48b40b9a37a57d3dd12f221 : SUCCESS in 7m 56s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/1e79fde237a64c248fc775caaf78ec46 : SUCCESS in 4m 55s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/f56ce649383243ebbe5f6395f96a69d3 : SUCCESS in 3m 45s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/19ac08ea17d24777916cd47a44f1b933 : SUCCESS in 4m 28s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/061d4efba70c4e2782f06746e652a881 : SUCCESS in 7m 15s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/2510014bf48e4186b64acd527b98ded2 : SUCCESS in 5m 42s\n- neutron-lbaasv2-dsvm-api https://zuul.opendev.org/t/openstack/build/855f108e0f734eea9da62fee9493bbba : SUCCESS in 1h 24m 43s\n- neutron-lbaasv2-dsvm-py3x-api https://zuul.opendev.org/t/openstack/build/0d68937770ca4372852b3fce83e6e8ba : SUCCESS in 1h 56m 11s\n- neutron-lbaasv2-dsvm-scenario https://zuul.opendev.org/t/openstack/build/7a272743e8c44e7fa46715446a5fc4a1 : SUCCESS in 1h 49m 23s (non-voting)\n- neutron-lbaasv2-dsvm-py3x-scenario https://zuul.opendev.org/t/openstack/build/aa1ec6fbddc0409ab420b647263a30c5 : FAILURE in 1h 39m 24s (non-voting)\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/ac003c25fa404583a783e59c199e828f : SUCCESS in 6m 14s\n- openstack-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/96758e6adb6e4586b915862dd5292196 : SUCCESS in 7m 45s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/65403a8704a54f94a40e3fc94f2f8254 : SUCCESS in 8m 55s\n- octavia-v1-dsvm-scenario https://zuul.opendev.org/t/openstack/build/05a59d3c63d447dbb63f02cfec36ecff : SUCCESS in 57m 06s\n- octavia-v1-dsvm-py3x-scenario https://zuul.opendev.org/t/openstack/build/460fd4ae669d46f49d54ffb04b7337fa : SUCCESS in 1h 01m 55s\n- octavia-v2-dsvm-noop-api https://zuul.opendev.org/t/openstack/build/49363d4fcc544bb0abe121f55a2673ad : SUCCESS in 46m 56s\n- octavia-v2-dsvm-noop-py2-api https://zuul.opendev.org/t/openstack/build/c8917ee214f24905975210a7ce861547 : SUCCESS in 44m 48s\n- octavia-v2-dsvm-scenario https://zuul.opendev.org/t/openstack/build/b650f61093074b14bc637a6f2545ad40 : SUCCESS in 1h 23m 55s\n- octavia-v2-dsvm-py2-scenario https://zuul.opendev.org/t/openstack/build/c2b61112946e49bd97ddcb6939de81f1 : SUCCESS in 1h 48m 48s\n- octavia-v2-dsvm-scenario-ubuntu-xenial https://zuul.opendev.org/t/openstack/build/1b64f5236530441e9d0df5c4f24c0a8b : SUCCESS in 1h 34m 05s\n- octavia-v2-dsvm-py2-scenario-centos-7 https://zuul.opendev.org/t/openstack/build/ca9e38a38d6047008544c49019dd84b5 : SUCCESS in 1h 52m 32s (non-voting)\n- octavia-v2-dsvm-scenario-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/9710bbdc23204f3aa2b8dd0bf5a6e7d5 : FAILURE in 31m 00s (non-voting)\n- octavia-v2-dsvm-scenario-two-node https://zuul.opendev.org/t/openstack/build/3958508bce7044f3aa20d6bfd1db3141 : TIMED_OUT in 2h 33m 57s (non-voting)\n- octavia-v2-dsvm-py2-scenario-two-node https://zuul.opendev.org/t/openstack/build/5462c71af04b49aba3fca920187626bd : SUCCESS in 1h 50m 51s (non-voting)\n- octavia-grenade https://zuul.opendev.org/t/openstack/build/6c213c9228714e4f91b5e92acc72fcd7 : SUCCESS in 1h 15m 20s\n- octavia-v2-dsvm-tls-barbican https://zuul.opendev.org/t/openstack/build/3c344cf77f694800bb520a2dff87754c : SUCCESS in 52m 56s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"225ff26498eaf14bedb1662a278cbbda74c30065","author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"date":"2019-09-19 13:49:16.000000000","message":"Patch Set 1: Code-Review+2\n\nLGTM","accounts_in_message":[],"_revision_number":1},{"id":"2a546f735c8b462f6ff297f8da22caac72aadcae","author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"date":"2019-09-19 20:03:08.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"0273d7d2c276901108b7736adb8c60d2cb96bd9b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-19 20:03:25.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"b0898113607fe56854f111c8b7f837c00af0cd9b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-19 22:04:25.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"fc00d5a50d2e4059ce717f9daef5f250e45a5af4","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-19 22:04:25.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/3c7ed15b6ac745ea86b2ef7e31655204 : SUCCESS in 7m 06s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/1d1a2eba8ff94bb0b979725ad8bcdb71 : SUCCESS in 5m 31s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/58be571743b84ccda416b9c417ff490f : SUCCESS in 4m 56s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/25ab14593f4e4ed1bd80bb9d3b56c1f4 : SUCCESS in 4m 29s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/a64b7b64484d4fbcaa8502a58c0d6a0c : SUCCESS in 4m 27s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c826d1cbcb8045d0a8cbd1836dd13da4 : SUCCESS in 7m 33s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/c86d2e6d73794fc7988e39e6eb2ba7ba : SUCCESS in 4m 57s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/0fc48f8dce69478e8e37633608701447 : SUCCESS in 7m 14s\n- openstack-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/ec0194f5904e4ba3a81b2915d15c2c08 : SUCCESS in 5m 50s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/43f7af3146064919b85e6ca69b084bf5 : SUCCESS in 6m 02s\n- octavia-v1-dsvm-scenario https://zuul.opendev.org/t/openstack/build/56cf1e0bff8a48dca6dd5a8e36352837 : SUCCESS in 1h 07m 54s\n- octavia-v1-dsvm-py3x-scenario https://zuul.opendev.org/t/openstack/build/fc167b30338e4abdb5a18955ad0edb70 : SUCCESS in 1h 10m 57s\n- neutron-lbaasv2-dsvm-api https://zuul.opendev.org/t/openstack/build/2336a0fd339640f0add611df0907f478 : SUCCESS in 1h 22m 08s\n- neutron-lbaasv2-dsvm-py3x-api https://zuul.opendev.org/t/openstack/build/3aecad6d76eb41ac925d000236c20b46 : SUCCESS in 1h 19m 30s\n- octavia-v2-dsvm-noop-api https://zuul.opendev.org/t/openstack/build/2ecf43ad9139466f84bf8f2a7e992a58 : SUCCESS in 43m 28s\n- octavia-v2-dsvm-noop-py2-api https://zuul.opendev.org/t/openstack/build/3bb63ac057bc4c14b88d7962a4eacac6 : SUCCESS in 49m 14s\n- octavia-v2-dsvm-scenario https://zuul.opendev.org/t/openstack/build/ba3a5a1865144148bc3ec4b736d42f29 : SUCCESS in 1h 18m 26s\n- octavia-v2-dsvm-py2-scenario https://zuul.opendev.org/t/openstack/build/ce8052e44d16497d98dfc9fc8d0985b0 : SUCCESS in 1h 25m 48s\n- octavia-v2-dsvm-scenario-ubuntu-xenial https://zuul.opendev.org/t/openstack/build/600d05a3d4bd4c52a913a80fa0917a1a : SUCCESS in 1h 42m 39s\n- octavia-grenade https://zuul.opendev.org/t/openstack/build/21b4b4f30e4843c6818beb6fd86e2b2e : SUCCESS in 1h 19m 56s","accounts_in_message":[],"_revision_number":1},{"id":"e8f94c1ce1a956713683febc8406557c892abfa5","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-19 22:06:11.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/aad61c977fad4621be0cae3819f34086 : SUCCESS in 1m 21s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/295cbc26552b456dae0ac72464bea969 : SUCCESS in 1m 04s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"1b9881dc3adb65f59e0bcbda17d5876331de759f","revisions":{"1b9881dc3adb65f59e0bcbda17d5876331de759f":{"kind":"REWORK","_number":1,"created":"2019-09-19 09:15:08.000000000","uploader":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"ref":"refs/changes/70/683070/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/octavia","ref":"refs/changes/70/683070/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/octavia refs/changes/70/683070/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/octavia refs/changes/70/683070/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/octavia refs/changes/70/683070/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/octavia refs/changes/70/683070/1"}}},"commit":{"parents":[{"commit":"c9660fa196f01902a25f901efc34e3e46f9fcb3d","subject":"Merge \"Fix base (VRRP) port abandoned on revert\" into stable/stein","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/c9660fa196f01902a25f901efc34e3e46f9fcb3d"}]}],"author":{"name":"Nir Magnezi","email":"nmagnezi@redhat.com","date":"2019-07-14 14:50:43.000000000","tz":180},"committer":{"name":"Carlos Goncalves","email":"cgoncalves@redhat.com","date":"2019-09-19 09:15:08.000000000","tz":0},"subject":"Validate server_certs_key_passphrase is 32 chars","message":"Validate server_certs_key_passphrase is 32 chars\n\nFernet checks[1] for 32 characters long key, so Octavia should validate\nthe value provided for server_certs_key_passphrase, to reject an invalid\npassphrase as early as possible.\n\nThis[2] Red Hat Bug showed a case in which an invalid passphrase got\nconfigured, and as a result, Octavia was unable to create any\nload balancers.\n\nRelated-bug: #1833942\n\n[1] https://github.com/pyca/cryptography/blob/784676de3381f039f95f998505d45fb9d56bd300/src/cryptography/fernet.py#L36\n[2] https://bugzilla.redhat.com/show_bug.cgi?id\u003d1723051\n\nChange-Id: I334364d4654491bc0d289472ca9ab5fe462d5139\n(cherry picked from commit a77667339d735ec0757d1e46d80f0010b1bb3d4f)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/1b9881dc3adb65f59e0bcbda17d5876331de759f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/1b9881dc3adb65f59e0bcbda17d5876331de759f"}]},"branch":"refs/heads/stable/stein"}},"requirements":[],"submit_records":[],"submit_requirements":[]}