)]}'
{"id":"openstack%2Foctavia~683071","triplet_id":"openstack%2Foctavia~stable%2Frocky~I334364d4654491bc0d289472ca9ab5fe462d5139","project":"openstack/octavia","branch":"stable/rocky","topic":"OctaviaServerCertsKeyPassphrase-32chars-stable/stein-stable/rocky","hashtags":[],"change_id":"I334364d4654491bc0d289472ca9ab5fe462d5139","subject":"Validate server_certs_key_passphrase is 32 chars","status":"MERGED","created":"2019-09-19 09:15:13.000000000","updated":"2019-09-19 22:06:09.000000000","submitted":"2019-09-19 22:04:23.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"683071-1568930663831-4b665cae","meta_rev_id":"ce3948abb5afb91042b71734a509c04be33ea059","_number":683071,"virtual_id_number":683071,"owner":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},{"value":0,"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},{"value":0,"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":2,"date":"2019-09-19 22:04:23.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"all":[{"value":2,"date":"2019-09-19 20:02:51.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},{"value":0,"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},{"value":2,"date":"2019-09-19 13:50:45.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"all":[{"value":1,"date":"2019-09-19 20:02:51.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},{"value":0,"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},{"value":0,"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},{"value":0,"date":"2019-09-19 09:15:13.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},{"value":0,"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-09-19 09:15:13.000000000","updated_by":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"reviewer":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"state":"REVIEWER"},{"updated":"2019-09-19 13:50:45.000000000","updated_by":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"reviewer":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"state":"REVIEWER"},{"updated":"2019-09-19 20:02:51.000000000","updated_by":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"reviewer":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"state":"REVIEWER"},{"updated":"2019-09-19 22:04:23.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"2b73eb2da7c9ad2d5c65236bdee33fa3f39955f8","author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"date":"2019-09-19 09:15:13.000000000","message":"Patch Set 1: Cherry Picked from branch stable/stein.","accounts_in_message":[],"_revision_number":1},{"id":"1f56479daa6b7a3382252a05063093617689d4f4","author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"date":"2019-09-19 09:15:19.000000000","message":"Patch Set 1: Cherry Picked\n\nThis patchset was cherry picked to branch stable/queens as commit 1769de3549e81a965ed93bca3cbbd9daa9a5b87a","accounts_in_message":[],"_revision_number":1},{"id":"5738fd0c27d402b5a031f3b76c3a4ae8321c47d1","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-19 12:28:42.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/580ee486278c46f1bc78a90bdbaf036b : SUCCESS in 7m 13s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/f22c31e2f25849058b77825f2ed2d87d : SUCCESS in 6m 57s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/94b715eac6704f22a8daa0830e44f158 : SUCCESS in 7m 41s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/4d0dd9af9a3d4003a47ff9a82559a886 : SUCCESS in 6m 06s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b6fb0eb4bdac4327af44b03ac0f136cc : SUCCESS in 6m 28s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/707fc7a369eb4b279d063ae5704f0f10 : SUCCESS in 5m 10s\n- neutron-lbaasv2-dsvm-api https://zuul.opendev.org/t/openstack/build/75898414b4804b85ace5136c6fe38a96 : SUCCESS in 1h 25m 36s (non-voting)\n- neutron-lbaasv2-dsvm-py3x-api https://zuul.opendev.org/t/openstack/build/0ae665fc28ac4b718da3e75912f74e5f : SUCCESS in 1h 22m 17s\n- neutron-lbaasv2-dsvm-scenario https://zuul.opendev.org/t/openstack/build/694f9449a3ed47b3a3e3b163c986a8bd : SUCCESS in 1h 34m 57s (non-voting)\n- neutron-lbaasv2-dsvm-py3x-scenario https://zuul.opendev.org/t/openstack/build/488a9980007f489791712fd16c6a522e : FAILURE in 1h 29m 48s (non-voting)\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/de45e50cc18e448eac24c64e0433384f : SUCCESS in 6m 22s\n- openstack-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/38a1dbfcc97d47d2ac2a3901d74354d2 : SUCCESS in 7m 08s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/8ecccdf120ca419298989c981c4b31c7 : SUCCESS in 5m 11s\n- octavia-v1-dsvm-scenario https://zuul.opendev.org/t/openstack/build/59e028f7eb084472a48f2fe3b22a33b9 : SUCCESS in 1h 12m 21s\n- octavia-v1-dsvm-py3x-scenario https://zuul.opendev.org/t/openstack/build/3bd260dca86343049f985530db36af70 : SUCCESS in 1h 10m 45s\n- octavia-v1-dsvm-scenario-multinode https://zuul.opendev.org/t/openstack/build/0c3338d95ad0405c80fc04281fc5e40e : FAILURE in 1h 33m 44s (non-voting)\n- octavia-v1-dsvm-py3x-scenario-multinode https://zuul.opendev.org/t/openstack/build/5dccdeaa31d74f0db1c0f65dcfbb600c : FAILURE in 1h 28m 31s (non-voting)\n- octavia-v1-dsvm-scenario-kvm-centos.7 https://zuul.opendev.org/t/openstack/build/58bb08dc056e486f8680588ea0a9091c : SUCCESS in 1h 30m 03s (non-voting)\n- octavia-v2-dsvm-noop-api https://zuul.opendev.org/t/openstack/build/4829d39a8e3743fca6accbc75a94aefb : SUCCESS in 41m 43s\n- octavia-v2-dsvm-noop-py35-api https://zuul.opendev.org/t/openstack/build/d8adf9d78d9642e39be6ff88edf38e74 : SUCCESS in 47m 43s\n- octavia-v2-dsvm-scenario https://zuul.opendev.org/t/openstack/build/43fcabf4f1364200b1c0b5ca556f8db6 : SUCCESS in 1h 41m 50s\n- octavia-v2-dsvm-py35-scenario https://zuul.opendev.org/t/openstack/build/e9f536745a6945868259528172116f23 : SUCCESS in 1h 35m 09s\n- octavia-grenade https://zuul.opendev.org/t/openstack/build/6a3f4635fa3a4d5694f3a700b2d1e06b : SUCCESS in 1h 14m 43s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/34ff633ea0974daa8b4b2006f3624ccf : SUCCESS in 8m 59s","accounts_in_message":[],"_revision_number":1},{"id":"aeecdfd1bbbf3efcc07e2d04f040b3842e188365","author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"date":"2019-09-19 13:50:45.000000000","message":"Patch Set 1: Code-Review+2\n\nLGTM","accounts_in_message":[],"_revision_number":1},{"id":"23d7a3784e8e9a64bfed567066863e79d274bbf9","author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"date":"2019-09-19 20:02:51.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"c2727b10913911b18a347928ff7e6607b38e5d6d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-19 20:03:04.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"b7d442eee3e70aa818ba4418d73216407869b9b2","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-19 22:04:23.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"2e827ad045bb3ccb33a87b812646f4d4215dc387","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-19 22:04:23.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/dc833248b3ce4b00abe8dadc5ab27d1d : SUCCESS in 7m 57s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c276c6a9f5334baba3cbfd8f4a03c65c : SUCCESS in 8m 22s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/711c9ed452184a82a7ee25e8f8919fd5 : SUCCESS in 5m 15s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/f2024743d07d45b8b13781143022f79b : SUCCESS in 5m 23s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/66b18f8c19d74bef933d7ec7f5bf62b7 : SUCCESS in 6m 17s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/f14b4038596b48c6947763bf0c878cd7 : SUCCESS in 4m 16s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/2125f97e03e94b31b1359220fd54ef33 : SUCCESS in 5m 49s\n- openstack-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/8cf343bd95294358b7ac75e2ef18fd3f : SUCCESS in 6m 24s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/1bd5a77fbe2647ca8ea41c6a69258cb7 : SUCCESS in 6m 13s\n- octavia-v1-dsvm-scenario https://zuul.opendev.org/t/openstack/build/31de8b19922d4dbeb6ea7c6d2611090f : SUCCESS in 52m 35s\n- octavia-v1-dsvm-py3x-scenario https://zuul.opendev.org/t/openstack/build/7fb46f17150142e69bda804af034453f : SUCCESS in 57m 32s\n- neutron-lbaasv2-dsvm-py3x-api https://zuul.opendev.org/t/openstack/build/814d7466765747e6925fddb47af1bdfe : SUCCESS in 1h 22m 18s\n- octavia-v2-dsvm-noop-api https://zuul.opendev.org/t/openstack/build/d50494601be34fe58cef5b1cc1c5c8a3 : SUCCESS in 43m 20s\n- octavia-v2-dsvm-noop-py35-api https://zuul.opendev.org/t/openstack/build/09a630bf69fa47348c26a2daa8bce0d7 : SUCCESS in 47m 02s\n- octavia-v2-dsvm-scenario https://zuul.opendev.org/t/openstack/build/1d68631208344e5c8cae3106f2a1d2d9 : SUCCESS in 1h 49m 10s\n- octavia-v2-dsvm-py35-scenario https://zuul.opendev.org/t/openstack/build/6bfe4aa88eb34dca8936988eac68973d : SUCCESS in 1h 56m 16s\n- octavia-grenade https://zuul.opendev.org/t/openstack/build/39abf53e1d3944c887c6864cadcce296 : SUCCESS in 1h 25m 56s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/94719d0b97e445d28e2b91bc97596428 : SUCCESS in 9m 38s","accounts_in_message":[],"_revision_number":1},{"id":"03662a444094e1f41c83629727e7faa83d6e0971","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-19 22:06:09.000000000","message":"Patch Set 1:\n\nBuild failed (promote pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/fa048e5f79724ca6b5d38f355b3d642b : SUCCESS in 1m 18s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/09d78ab699254316ac3263bcc137a8f8 : FAILURE in 1m 05s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"1756b19e4bc6e05598b1566af288a63a2bb95d19","revisions":{"1756b19e4bc6e05598b1566af288a63a2bb95d19":{"kind":"REWORK","_number":1,"created":"2019-09-19 09:15:13.000000000","uploader":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"ref":"refs/changes/71/683071/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/octavia","ref":"refs/changes/71/683071/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/octavia refs/changes/71/683071/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/octavia refs/changes/71/683071/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/octavia refs/changes/71/683071/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/octavia refs/changes/71/683071/1"}}},"commit":{"parents":[{"commit":"af41c75033e95ec9fbd3b008921f2c7648a7a471","subject":"Merge \"Do not run non-voting jobs in gate\" into stable/rocky","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/af41c75033e95ec9fbd3b008921f2c7648a7a471"}]}],"author":{"name":"Nir Magnezi","email":"nmagnezi@redhat.com","date":"2019-07-14 14:50:43.000000000","tz":180},"committer":{"name":"Carlos Goncalves","email":"cgoncalves@redhat.com","date":"2019-09-19 09:15:13.000000000","tz":0},"subject":"Validate server_certs_key_passphrase is 32 chars","message":"Validate server_certs_key_passphrase is 32 chars\n\nFernet checks[1] for 32 characters long key, so Octavia should validate\nthe value provided for server_certs_key_passphrase, to reject an invalid\npassphrase as early as possible.\n\nThis[2] Red Hat Bug showed a case in which an invalid passphrase got\nconfigured, and as a result, Octavia was unable to create any\nload balancers.\n\nRelated-bug: #1833942\n\n[1] https://github.com/pyca/cryptography/blob/784676de3381f039f95f998505d45fb9d56bd300/src/cryptography/fernet.py#L36\n[2] https://bugzilla.redhat.com/show_bug.cgi?id\u003d1723051\n\nChange-Id: I334364d4654491bc0d289472ca9ab5fe462d5139\n(cherry picked from commit a77667339d735ec0757d1e46d80f0010b1bb3d4f)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/1756b19e4bc6e05598b1566af288a63a2bb95d19"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/1756b19e4bc6e05598b1566af288a63a2bb95d19"}]},"branch":"refs/heads/stable/rocky"}},"requirements":[],"submit_records":[],"submit_requirements":[]}