)]}'
{"id":"openstack%2Foctavia~683072","triplet_id":"openstack%2Foctavia~stable%2Fqueens~I334364d4654491bc0d289472ca9ab5fe462d5139","project":"openstack/octavia","branch":"stable/queens","topic":"OctaviaServerCertsKeyPassphrase-32chars-stable/stein-stable/rocky-stable/queens","hashtags":[],"change_id":"I334364d4654491bc0d289472ca9ab5fe462d5139","subject":"Validate server_certs_key_passphrase is 32 chars","status":"MERGED","created":"2019-09-19 09:15:19.000000000","updated":"2019-09-19 22:06:06.000000000","submitted":"2019-09-19 22:04:24.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"683072-1568930664916-f233d7c7","meta_rev_id":"3925cac1518462e05cdc2b27cd0f18be27b296ab","_number":683072,"virtual_id_number":683072,"owner":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},{"value":0,"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},{"value":0,"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":2,"date":"2019-09-19 22:04:24.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"all":[{"value":2,"date":"2019-09-19 20:03:01.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},{"value":0,"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},{"value":2,"date":"2019-09-19 13:49:30.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"all":[{"value":1,"date":"2019-09-19 20:03:01.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},{"value":0,"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},{"value":0,"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},{"value":0,"date":"2019-09-19 09:15:19.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},{"value":0,"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-09-19 09:15:19.000000000","updated_by":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"reviewer":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"state":"REVIEWER"},{"updated":"2019-09-19 13:49:30.000000000","updated_by":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"reviewer":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"state":"REVIEWER"},{"updated":"2019-09-19 20:03:01.000000000","updated_by":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"reviewer":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"state":"REVIEWER"},{"updated":"2019-09-19 22:04:24.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"1d207ee4b730eb5787c578182bb1492f12a4a877","author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"date":"2019-09-19 09:15:19.000000000","message":"Patch Set 1: Cherry Picked from branch stable/rocky.","accounts_in_message":[],"_revision_number":1},{"id":"ffc742aa38638a21958834c9b9af579817a847c0","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-19 12:45:36.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/14f42686cfb6492cbc9e52e8a944058c : SUCCESS in 9m 07s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/d0a5956f3f6f40938c05af6f0e2519c0 : SUCCESS in 4m 37s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/d4ea879bb3b34fc8a82903b56f94a2f9 : SUCCESS in 5m 06s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/271f6770790145b99e84b8caf9a9e2c1 : SUCCESS in 6m 47s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/982445069fe847c4aacf2345b5dbce84 : SUCCESS in 6m 56s\n- neutron-lbaasv2-dsvm-api https://zuul.opendev.org/t/openstack/build/cb407d6a173c45c8845009adc253febf : SUCCESS in 1h 14m 46s\n- neutron-lbaasv2-dsvm-py3x-api https://zuul.opendev.org/t/openstack/build/5fe637ec73ee425d8f0ddb5e7ec72e5d : SUCCESS in 1h 20m 58s\n- neutron-lbaasv2-dsvm-scenario https://zuul.opendev.org/t/openstack/build/4d5a75174f0a47fe83071123fe99a87a : SUCCESS in 1h 09m 42s (non-voting)\n- neutron-lbaasv2-dsvm-py3x-scenario https://zuul.opendev.org/t/openstack/build/2ec23b9e39d847c0a7a1838e76e5c801 : SUCCESS in 1h 26m 58s (non-voting)\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/fdfb77401d89404caa7442a23c4f5500 : SUCCESS in 10m 16s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/8647c730f0364b2c9d568367d04e7877 : SUCCESS in 7m 59s\n- openstack-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/15bdb031c1484ab7991644aba217f9da : SUCCESS in 5m 49s\n- octavia-v1-dsvm-scenario https://zuul.opendev.org/t/openstack/build/d67c48bfddb84beba0de2ac452733040 : SUCCESS in 59m 31s\n- octavia-v1-dsvm-py3x-scenario https://zuul.opendev.org/t/openstack/build/d039353c859b48a7944dceea74d70e68 : SUCCESS in 1h 04m 45s\n- octavia-v1-dsvm-scenario-multinode https://zuul.opendev.org/t/openstack/build/cb92d2308d0243a193881c7cdb46549f : SUCCESS in 1h 15m 06s\n- octavia-v1-dsvm-py3x-scenario-multinode https://zuul.opendev.org/t/openstack/build/4b1eabeaa9b24fdfb57229ec49e40adc : SUCCESS in 1h 19m 36s\n- octavia-v1-dsvm-scenario-kvm-centos.7 https://zuul.opendev.org/t/openstack/build/0277aec5f25b4b738161d1e0b62f0b96 : SUCCESS in 48m 34s (non-voting)\n- octavia-v2-dsvm-noop-api https://zuul.opendev.org/t/openstack/build/cfe5022c57ad48ad9f64bd8ffe48aedf : SUCCESS in 47m 17s\n- octavia-v2-dsvm-noop-py35-api https://zuul.opendev.org/t/openstack/build/af410b141d114c8f8e268749591e5b9e : SUCCESS in 51m 06s\n- octavia-v2-dsvm-scenario https://zuul.opendev.org/t/openstack/build/97ad9634d5514061a872b638b970f8c5 : SUCCESS in 1h 32m 28s\n- octavia-v2-dsvm-py35-scenario https://zuul.opendev.org/t/openstack/build/c08b4aefba384d548d1c515222527d25 : SUCCESS in 1h 53m 15s","accounts_in_message":[],"_revision_number":1},{"id":"2de9ca95bea5312bc86b65b0f92cee3827ab77bc","author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"date":"2019-09-19 13:49:30.000000000","message":"Patch Set 1: Code-Review+2\n\nLGTM","accounts_in_message":[],"_revision_number":1},{"id":"be085310dda4a55eea15ce5d28f1c5a6da81857d","author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"date":"2019-09-19 20:03:01.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"f54ddf34442addb35fe4be9a3e1b43d44bac5244","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-19 20:03:13.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"a8cdedecb772ae65ef5e434d685838a3acc1c08d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-19 22:04:24.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"6372b0dff61835c762c176f7d0ca3c908ea08ef5","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-19 22:04:24.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/7c4361be729d4065b4348b7311eb702b : SUCCESS in 9m 27s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/8cf202b5a0864cc5bf71f6ac70a5a612 : SUCCESS in 6m 17s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/c6dda44917554498b73a33a656257bfe : SUCCESS in 5m 48s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4925b9db809447af9874169d07e901c0 : SUCCESS in 6m 58s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/98d89ed766614f3ca93b3f490cde31c1 : SUCCESS in 5m 59s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/5ef8b0db4927476e80a8a6dff4249608 : SUCCESS in 10m 04s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/3196a215eff342cea269fee29fc5809e : SUCCESS in 6m 38s\n- openstack-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/661210b7fba942b1ae29d6b734a8ff78 : SUCCESS in 6m 44s\n- neutron-lbaasv2-dsvm-api https://zuul.opendev.org/t/openstack/build/9e07cc5303e246bebf0af4c7d8f27405 : SUCCESS in 1h 21m 06s\n- neutron-lbaasv2-dsvm-py3x-api https://zuul.opendev.org/t/openstack/build/1945aae0aa0340f79a3636fb1957b889 : SUCCESS in 1h 24m 03s\n- octavia-v1-dsvm-scenario https://zuul.opendev.org/t/openstack/build/d1455d8fa2a34287abdba8b1dd46803a : SUCCESS in 57m 44s\n- octavia-v1-dsvm-py3x-scenario https://zuul.opendev.org/t/openstack/build/390f3fe0c95d4df092f500bb8e8b2df0 : SUCCESS in 59m 00s\n- octavia-v1-dsvm-scenario-multinode https://zuul.opendev.org/t/openstack/build/6c40dfc0d0664b87a3aa66250d60da3b : SUCCESS in 1h 10m 54s\n- octavia-v1-dsvm-py3x-scenario-multinode https://zuul.opendev.org/t/openstack/build/2c44aefc9f7142a3b432f6e598cda16f : SUCCESS in 1h 21m 17s\n- octavia-v2-dsvm-noop-api https://zuul.opendev.org/t/openstack/build/b2e40b3a48e2464ea668a12685b507aa : SUCCESS in 52m 53s\n- octavia-v2-dsvm-noop-py35-api https://zuul.opendev.org/t/openstack/build/8702707ca3264f72ad1e5766045efe22 : SUCCESS in 46m 30s\n- octavia-v2-dsvm-scenario https://zuul.opendev.org/t/openstack/build/11d695b5382149c59a8d5e42d76b6a08 : SUCCESS in 1h 45m 36s\n- octavia-v2-dsvm-py35-scenario https://zuul.opendev.org/t/openstack/build/01430ae9606640188b6051908f00a75d : SUCCESS in 1h 48m 52s","accounts_in_message":[],"_revision_number":1},{"id":"ec453dca0afee53d6cb82e9e400b8503e8e4db15","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-19 22:06:06.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d11a86706f9b4a5981276f8fe7448b7c : SUCCESS in 1m 14s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/c159ec7a8e124132b0dbc88c4eeff650 : SUCCESS in 1m 06s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"1769de3549e81a965ed93bca3cbbd9daa9a5b87a","revisions":{"1769de3549e81a965ed93bca3cbbd9daa9a5b87a":{"kind":"REWORK","_number":1,"created":"2019-09-19 09:15:19.000000000","uploader":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"ref":"refs/changes/72/683072/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/octavia","ref":"refs/changes/72/683072/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/octavia refs/changes/72/683072/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/octavia refs/changes/72/683072/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/octavia refs/changes/72/683072/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/octavia refs/changes/72/683072/1"}}},"commit":{"parents":[{"commit":"de0827e464feeb0eab193d100d90d32e6030e418","subject":"Merge \"Add warning log if auth_strategy is not keystone\" into stable/queens","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/de0827e464feeb0eab193d100d90d32e6030e418"}]}],"author":{"name":"Nir Magnezi","email":"nmagnezi@redhat.com","date":"2019-07-14 14:50:43.000000000","tz":180},"committer":{"name":"Carlos Goncalves","email":"cgoncalves@redhat.com","date":"2019-09-19 09:15:19.000000000","tz":0},"subject":"Validate server_certs_key_passphrase is 32 chars","message":"Validate server_certs_key_passphrase is 32 chars\n\nFernet checks[1] for 32 characters long key, so Octavia should validate\nthe value provided for server_certs_key_passphrase, to reject an invalid\npassphrase as early as possible.\n\nThis[2] Red Hat Bug showed a case in which an invalid passphrase got\nconfigured, and as a result, Octavia was unable to create any\nload balancers.\n\nRelated-bug: #1833942\n\n[1] https://github.com/pyca/cryptography/blob/784676de3381f039f95f998505d45fb9d56bd300/src/cryptography/fernet.py#L36\n[2] https://bugzilla.redhat.com/show_bug.cgi?id\u003d1723051\n\nChange-Id: I334364d4654491bc0d289472ca9ab5fe462d5139\n(cherry picked from commit a77667339d735ec0757d1e46d80f0010b1bb3d4f)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/1769de3549e81a965ed93bca3cbbd9daa9a5b87a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/1769de3549e81a965ed93bca3cbbd9daa9a5b87a"}]},"branch":"refs/heads/stable/queens"}},"requirements":[],"submit_records":[],"submit_requirements":[]}