)]}'
{"octavia/api/v2/controllers/listener.py":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"da4eb65a89c0cad33023d87b3fc7e4ece292625c","unresolved":false,"context_lines":[{"line_number":445,"context_line":"                list(listener.insert_headers.keys()), db_listener.protocol)"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"        sni_containers \u003d listener.sni_container_refs or []"},{"line_number":448,"context_line":"        tls_refs \u003d sni_containers"},{"line_number":449,"context_line":"        if listener.default_tls_container_ref:"},{"line_number":450,"context_line":"            tls_refs.append(listener.default_tls_container_ref)"},{"line_number":451,"context_line":"        self._validate_tls_refs(tls_refs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_8d85a55c","line":448,"range":{"start_line":448,"start_character":8,"end_line":448,"end_character":33},"updated":"2019-09-25 13:34:53.000000000","message":"tls_refs will not copy sni_containers data but be a reference to listener_sni_containers_refs. This could be problematic as in L450 we append listener.default_tls_container_ref and \"listener\" is then used by the caller function.\n\nMaybe better make a copy with list(sni_containers)...?","commit_id":"676a1ba75bf9a245331ef710df5eeed4b02fa196"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"d3d577bde4a30daf8946acdebf3c31fa09548fee","unresolved":false,"context_lines":[{"line_number":445,"context_line":"                list(listener.insert_headers.keys()), db_listener.protocol)"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"        sni_containers \u003d listener.sni_container_refs or []"},{"line_number":448,"context_line":"        tls_refs \u003d sni_containers"},{"line_number":449,"context_line":"        if listener.default_tls_container_ref:"},{"line_number":450,"context_line":"            tls_refs.append(listener.default_tls_container_ref)"},{"line_number":451,"context_line":"        self._validate_tls_refs(tls_refs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_4db32d0b","line":448,"range":{"start_line":448,"start_character":8,"end_line":448,"end_character":33},"in_reply_to":"3fa7e38b_8d85a55c","updated":"2019-09-25 13:37:53.000000000","message":"Thanks for catching that.\nFixed","commit_id":"676a1ba75bf9a245331ef710df5eeed4b02fa196"}]}