)]}'
{"octavia/api/drivers/utils.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5b2dc9a75a15cfe880fc1f477b7a00a6e497a684","unresolved":false,"context_lines":[{"line_number":267,"context_line":"            if for_delete:"},{"line_number":268,"context_line":"                cert_dict \u003d {}"},{"line_number":269,"context_line":"            else:"},{"line_number":270,"context_line":"                raise"},{"line_number":271,"context_line":"        if \u0027tls_cert\u0027 in cert_dict and cert_dict[\u0027tls_cert\u0027]:"},{"line_number":272,"context_line":"            new_listener_dict[\u0027default_tls_container_data\u0027] \u003d ("},{"line_number":273,"context_line":"                cert_dict[\u0027tls_cert\u0027].to_dict(recurse\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_08265c69","line":270,"updated":"2019-10-14 20:37:26.000000000","message":"Should you use \u0027save_and_reraise_exception()\u0027 from oslo.utils to not have a bare raise here?  Then you could set ctxt.reraise\u003dFalse in the for_delete case.","commit_id":"78fade7998cbf404016166ae3d2442c191267aaf"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"007ce61af763fa9a37740d868f7cf35d61556349","unresolved":false,"context_lines":[{"line_number":267,"context_line":"            if for_delete:"},{"line_number":268,"context_line":"                cert_dict \u003d {}"},{"line_number":269,"context_line":"            else:"},{"line_number":270,"context_line":"                raise"},{"line_number":271,"context_line":"        if \u0027tls_cert\u0027 in cert_dict and cert_dict[\u0027tls_cert\u0027]:"},{"line_number":272,"context_line":"            new_listener_dict[\u0027default_tls_container_data\u0027] \u003d ("},{"line_number":273,"context_line":"                cert_dict[\u0027tls_cert\u0027].to_dict(recurse\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_8e5c954b","line":270,"in_reply_to":"3fa7e38b_08265c69","updated":"2019-10-17 22:30:53.000000000","message":"True. We don\u0027t use eventlet, so it is less important, but still a good practice.\nFixed.","commit_id":"78fade7998cbf404016166ae3d2442c191267aaf"}],"octavia/tests/functional/api/v2/test_listener.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"2936e58c39a061932d2299fa55e19db1ee5f3899","unresolved":false,"context_lines":[{"line_number":1851,"context_line":"                                            delete\u003dTrue)"},{"line_number":1852,"context_line":""},{"line_number":1853,"context_line":"    # Problems with TLS certs should not block a delete"},{"line_number":1854,"context_line":"    def test_delete_with_bad_tls_ref(self):"},{"line_number":1855,"context_line":"        listener \u003d self.create_listener(constants.PROTOCOL_TCP,"},{"line_number":1856,"context_line":"                                        443, self.lb_id)"},{"line_number":1857,"context_line":"        tls_uuid \u003d uuidutils.generate_uuid()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_61c4910f","line":1854,"updated":"2019-10-17 22:28:51.000000000","message":"Do you need to specifically mock out the barbican call to raise an exception for this to properly test the issue?","commit_id":"f2c9e4958dd242f4786f4a0ed1a40c0cd712dcde"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"77ecd20dfa5e6868018dc873171f55e4029a7f5f","unresolved":false,"context_lines":[{"line_number":1851,"context_line":"                                            delete\u003dTrue)"},{"line_number":1852,"context_line":""},{"line_number":1853,"context_line":"    # Problems with TLS certs should not block a delete"},{"line_number":1854,"context_line":"    def test_delete_with_bad_tls_ref(self):"},{"line_number":1855,"context_line":"        listener \u003d self.create_listener(constants.PROTOCOL_TCP,"},{"line_number":1856,"context_line":"                                        443, self.lb_id)"},{"line_number":1857,"context_line":"        tls_uuid \u003d uuidutils.generate_uuid()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_01fefd37","line":1854,"in_reply_to":"3fa7e38b_21e779af","updated":"2019-10-17 22:32:06.000000000","message":"Derp, missed that this was functional and not unit. :D","commit_id":"f2c9e4958dd242f4786f4a0ed1a40c0cd712dcde"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"007ce61af763fa9a37740d868f7cf35d61556349","unresolved":false,"context_lines":[{"line_number":1851,"context_line":"                                            delete\u003dTrue)"},{"line_number":1852,"context_line":""},{"line_number":1853,"context_line":"    # Problems with TLS certs should not block a delete"},{"line_number":1854,"context_line":"    def test_delete_with_bad_tls_ref(self):"},{"line_number":1855,"context_line":"        listener \u003d self.create_listener(constants.PROTOCOL_TCP,"},{"line_number":1856,"context_line":"                                        443, self.lb_id)"},{"line_number":1857,"context_line":"        tls_uuid \u003d uuidutils.generate_uuid()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_21e779af","line":1854,"in_reply_to":"3fa7e38b_61c4910f","updated":"2019-10-17 22:30:53.000000000","message":"No, I\u0027m having it run the code, but with a bogus certificate_id. See line 1857 and 1861.","commit_id":"f2c9e4958dd242f4786f4a0ed1a40c0cd712dcde"}]}