)]}'
{"octavia/common/config.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f355105b2f2b7ba9119395939d9b64861eac1afd","unresolved":false,"context_lines":[{"line_number":401,"context_line":"    cfg.ListOpt(\u0027amp_secgroup_list\u0027,"},{"line_number":402,"context_line":"                default\u003d\u0027\u0027,"},{"line_number":403,"context_line":"                help\u003d_(\u0027List of security groups to attach to the Amphora.\u0027)),"},{"line_number":404,"context_line":"    cfg.DictOpt(\u0027amp_meta\u0027,"},{"line_number":405,"context_line":"                default\u003d{},"},{"line_number":406,"context_line":"                help\u003d_(\u0027Dict of key/value metadata to the Amphora.\u0027)),"},{"line_number":407,"context_line":"    cfg.StrOpt(\u0027client_ca\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_129c7fbe","line":404,"updated":"2020-04-09 23:14:08.000000000","message":"This needs to be more descriptive.\ncompute_metadata maybe?","commit_id":"0b95bd42fee53c30bccda3ad6af173d9bc0ef965"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f355105b2f2b7ba9119395939d9b64861eac1afd","unresolved":false,"context_lines":[{"line_number":403,"context_line":"                help\u003d_(\u0027List of security groups to attach to the Amphora.\u0027)),"},{"line_number":404,"context_line":"    cfg.DictOpt(\u0027amp_meta\u0027,"},{"line_number":405,"context_line":"                default\u003d{},"},{"line_number":406,"context_line":"                help\u003d_(\u0027Dict of key/value metadata to the Amphora.\u0027)),"},{"line_number":407,"context_line":"    cfg.StrOpt(\u0027client_ca\u0027,"},{"line_number":408,"context_line":"               default\u003d\u0027/etc/octavia/certs/ca_01.pem\u0027,"},{"line_number":409,"context_line":"               help\u003d_(\u0027Client CA for the amphora agent to use\u0027)),"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_d28e9777","line":406,"updated":"2020-04-09 23:14:08.000000000","message":"This is really adding metadata to the compute instance.","commit_id":"0b95bd42fee53c30bccda3ad6af173d9bc0ef965"}],"octavia/controller/worker/v1/tasks/compute_tasks.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f355105b2f2b7ba9119395939d9b64861eac1afd","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def execute(self, amphora_id, config_drive_files\u003dNone,"},{"line_number":54,"context_line":"                build_type_priority\u003dconstants.LB_CREATE_NORMAL_PRIORITY,"},{"line_number":55,"context_line":"                server_group_id\u003dNone, ports\u003dNone, flavor\u003dNone, meta\u003dNone):"},{"line_number":56,"context_line":"        \"\"\"Create an amphora"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        :returns: an amphora"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_3280a346","line":55,"updated":"2020-04-09 23:14:08.000000000","message":"Nothing is using this.","commit_id":"0b95bd42fee53c30bccda3ad6af173d9bc0ef965"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"87db8ead96c1bea5c6dacd7389f2e6568975f051","unresolved":true,"context_lines":[{"line_number":114,"context_line":"            project_id \u003d project_id or \"undefined\""},{"line_number":115,"context_line":"            meta \u003d {constants.LOAD_BALANCER_NAME: load_balancer_name,"},{"line_number":116,"context_line":"                    constants.PROJECT_ID: project_id}"},{"line_number":117,"context_line":"            if metadata:"},{"line_number":118,"context_line":"                metadata.update(meta)"},{"line_number":119,"context_line":"            else:"},{"line_number":120,"context_line":"                metadata \u003d meta"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"            compute_id \u003d self.compute.build("},{"line_number":123,"context_line":"                name\u003d\"amphora-\" + amphora_id,"},{"line_number":124,"context_line":"                amphora_flavor\u003damp_compute_flavor,"}],"source_content_type":"text/x-python","patch_set":5,"id":"4562a9c3_711d7d48","line":121,"range":{"start_line":117,"start_character":12,"end_line":121,"end_character":0},"updated":"2020-12-01 07:01:53.000000000","message":"This logic is a bit confusing, if we set metadata in config we do not need to have loadbalancer name and project defined?","commit_id":"3fe107f01fa21fbd0d561c47e270196b2df38571"},{"author":{"_account_id":28910,"name":"DatLQ","email":"datlq3@viettel.com.vn","username":"datlq"},"change_message_id":"9fc0f461b25c4f114011be70d7ad4495af59222b","unresolved":true,"context_lines":[{"line_number":114,"context_line":"            project_id \u003d project_id or \"undefined\""},{"line_number":115,"context_line":"            meta \u003d {constants.LOAD_BALANCER_NAME: load_balancer_name,"},{"line_number":116,"context_line":"                    constants.PROJECT_ID: project_id}"},{"line_number":117,"context_line":"            if metadata:"},{"line_number":118,"context_line":"                metadata.update(meta)"},{"line_number":119,"context_line":"            else:"},{"line_number":120,"context_line":"                metadata \u003d meta"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"            compute_id \u003d self.compute.build("},{"line_number":123,"context_line":"                name\u003d\"amphora-\" + amphora_id,"},{"line_number":124,"context_line":"                amphora_flavor\u003damp_compute_flavor,"}],"source_content_type":"text/x-python","patch_set":5,"id":"8f47002b_d9579095","line":121,"range":{"start_line":117,"start_character":12,"end_line":121,"end_character":0},"in_reply_to":"4562a9c3_711d7d48","updated":"2020-12-01 09:08:43.000000000","message":"Loadbalancer name and project are set dynamically from each loadbalancer instance so that discovery service can collect loadbalancer name and project from amphora instances. In other hand, fixed metadata is only set in configuration file if user wants to insert static metadata in amphora instances. So, metadata needs to combine both types.","commit_id":"3fe107f01fa21fbd0d561c47e270196b2df38571"}],"octavia/controller/worker/v2/tasks/compute_tasks.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f355105b2f2b7ba9119395939d9b64861eac1afd","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def execute(self, amphora_id, config_drive_files\u003dNone,"},{"line_number":54,"context_line":"                build_type_priority\u003dconstants.LB_CREATE_NORMAL_PRIORITY,"},{"line_number":55,"context_line":"                server_group_id\u003dNone, ports\u003dNone, flavor\u003dNone, meta\u003dNone):"},{"line_number":56,"context_line":"        \"\"\"Create an amphora"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        :returns: an amphora"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_92988fc0","line":55,"updated":"2020-04-09 23:14:08.000000000","message":"Nothing is using this.","commit_id":"0b95bd42fee53c30bccda3ad6af173d9bc0ef965"}]}