)]}'
{"octavia/amphorae/drivers/haproxy/rest_api_driver.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"b1e8f02876db62df09b485931daa9f20c461d7f4","unresolved":false,"context_lines":[{"line_number":202,"context_line":"                    LOG.error(\u0027Unable to update listener {0} due to \"{1}\". \u0027"},{"line_number":203,"context_line":"                              \u0027Skipping this listener.\u0027.format("},{"line_number":204,"context_line":"                                  listener.id, str(e)))"},{"line_number":205,"context_line":"                    listener_repo \u003d repo.ListenerRepository()"},{"line_number":206,"context_line":"                    listener_repo.update(db_apis.get_session(), listener.id,"},{"line_number":207,"context_line":"                                         provisioning_status\u003dconsts.ERROR,"},{"line_number":208,"context_line":"                                         operating_status\u003dconsts.ERROR)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_6c0f9639","line":205,"updated":"2019-11-27 18:39:41.000000000","message":"I\u0027ve started to really dislike our use of these aliases everywhere, it\u0027s really not *so* long to just use the whole path, lol","commit_id":"e4c105feb3b2ae2f3375b564bda94d98f03856b5"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"c302c858012b4316fa1c2c3e26f7e137e488c6d2","unresolved":false,"context_lines":[{"line_number":202,"context_line":"                    LOG.error(\u0027Unable to update listener {0} due to \"{1}\". \u0027"},{"line_number":203,"context_line":"                              \u0027Skipping this listener.\u0027.format("},{"line_number":204,"context_line":"                                  listener.id, str(e)))"},{"line_number":205,"context_line":"                    listener_repo \u003d repo.ListenerRepository()"},{"line_number":206,"context_line":"                    listener_repo.update(db_apis.get_session(), listener.id,"},{"line_number":207,"context_line":"                                         provisioning_status\u003dconsts.ERROR,"},{"line_number":208,"context_line":"                                         operating_status\u003dconsts.ERROR)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_05af8c7d","line":205,"in_reply_to":"3fa7e38b_6c0f9639","updated":"2019-12-04 01:40:08.000000000","message":"Yeah, pasta","commit_id":"e4c105feb3b2ae2f3375b564bda94d98f03856b5"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"14086a5cd1dfa4dcc0602f98d1236a2e96fe8feb","unresolved":false,"context_lines":[{"line_number":205,"context_line":"                    listener_repo \u003d repo.ListenerRepository()"},{"line_number":206,"context_line":"                    listener_repo.update(db_apis.get_session(), listener.id,"},{"line_number":207,"context_line":"                                         provisioning_status\u003dconsts.ERROR,"},{"line_number":208,"context_line":"                                         operating_status\u003dconsts.ERROR)"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"        if has_tcp and not split_config:"},{"line_number":211,"context_line":"            if listeners_to_update:"}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_bf5c874c","line":208,"updated":"2019-12-03 22:34:19.000000000","message":"It is unclear to be when exactly to use DEGRADED operating status. I\u0027d tend to say a load balancer with child resources not in the desired state should be marked as DEGRADED?","commit_id":"e4c105feb3b2ae2f3375b564bda94d98f03856b5"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"c302c858012b4316fa1c2c3e26f7e137e488c6d2","unresolved":false,"context_lines":[{"line_number":205,"context_line":"                    listener_repo \u003d repo.ListenerRepository()"},{"line_number":206,"context_line":"                    listener_repo.update(db_apis.get_session(), listener.id,"},{"line_number":207,"context_line":"                                         provisioning_status\u003dconsts.ERROR,"},{"line_number":208,"context_line":"                                         operating_status\u003dconsts.ERROR)"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"        if has_tcp and not split_config:"},{"line_number":211,"context_line":"            if listeners_to_update:"}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_85e13c9e","line":208,"in_reply_to":"3fa7e38b_bf5c874c","updated":"2019-12-04 01:40:08.000000000","message":"That is a fair statement based on the API-REF.\nCurrently we are not bubbling DEGRADED up to the LB except when a listener is out of connection slots or a pool is degraded.\nI have opened https://storyboard.openstack.org/#!/story/2006981 to track this and fix it in a follow up patch.","commit_id":"e4c105feb3b2ae2f3375b564bda94d98f03856b5"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"b1e8f02876db62df09b485931daa9f20c461d7f4","unresolved":false,"context_lines":[{"line_number":226,"context_line":"                # no listeners hanging around. For example if this update"},{"line_number":227,"context_line":"                # was called from a listener delete."},{"line_number":228,"context_line":"                self.clients[amphora.api_version].delete_listener("},{"line_number":229,"context_line":"                    amphora, loadbalancer.id)"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    def _udp_update(self, listener, vip):"},{"line_number":232,"context_line":"        LOG.debug(\"Amphora %s keepalivedlvs, updating \""}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_c728e386","line":229,"updated":"2019-11-27 18:39:41.000000000","message":"ugh, it hurts me that \"delete_listener\" doesn\u0027t take a listener ID. T_T\n\nbut, I think this may be problematic? will this delete any existing listeners? so what if there was one listener we can\u0027t update because of barbican, and that is the only listener -- will we delete it instead of just leaving it alone? is that possible?","commit_id":"e4c105feb3b2ae2f3375b564bda94d98f03856b5"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"c302c858012b4316fa1c2c3e26f7e137e488c6d2","unresolved":false,"context_lines":[{"line_number":226,"context_line":"                # no listeners hanging around. For example if this update"},{"line_number":227,"context_line":"                # was called from a listener delete."},{"line_number":228,"context_line":"                self.clients[amphora.api_version].delete_listener("},{"line_number":229,"context_line":"                    amphora, loadbalancer.id)"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    def _udp_update(self, listener, vip):"},{"line_number":232,"context_line":"        LOG.debug(\"Amphora %s keepalivedlvs, updating \""}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_45bb4474","line":229,"in_reply_to":"3fa7e38b_2a09372a","updated":"2019-12-04 01:40:08.000000000","message":"Yes, if it was successful fetching them above, but if the listener isn\u0027t in the listeners_to_update list, we failed to fetch the required certs/keys.\nAlso remember, this can be called for any update to the LB configuration, including a change that did not modify the certificates or even a failover.","commit_id":"e4c105feb3b2ae2f3375b564bda94d98f03856b5"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"14086a5cd1dfa4dcc0602f98d1236a2e96fe8feb","unresolved":false,"context_lines":[{"line_number":226,"context_line":"                # no listeners hanging around. For example if this update"},{"line_number":227,"context_line":"                # was called from a listener delete."},{"line_number":228,"context_line":"                self.clients[amphora.api_version].delete_listener("},{"line_number":229,"context_line":"                    amphora, loadbalancer.id)"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    def _udp_update(self, listener, vip):"},{"line_number":232,"context_line":"        LOG.debug(\"Amphora %s keepalivedlvs, updating \""}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_2a09372a","line":229,"in_reply_to":"3fa7e38b_c728e386","updated":"2019-12-03 22:34:19.000000000","message":"Aren\u0027t the cert payloads already fetched and validated by the time this is called?","commit_id":"e4c105feb3b2ae2f3375b564bda94d98f03856b5"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"c302c858012b4316fa1c2c3e26f7e137e488c6d2","unresolved":false,"context_lines":[{"line_number":226,"context_line":"                # no listeners hanging around. For example if this update"},{"line_number":227,"context_line":"                # was called from a listener delete."},{"line_number":228,"context_line":"                self.clients[amphora.api_version].delete_listener("},{"line_number":229,"context_line":"                    amphora, loadbalancer.id)"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    def _udp_update(self, listener, vip):"},{"line_number":232,"context_line":"        LOG.debug(\"Amphora %s keepalivedlvs, updating \""}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_e557d026","line":229,"in_reply_to":"3fa7e38b_c728e386","updated":"2019-12-04 01:40:08.000000000","message":"Yeah, so this method is a nuke and replace type of deal. It fully re-deploys the configuration (It is one file now). So, if we fell down here with listeners_to_update \u003d None, there are no functional/valid listeners on the LB. We don\u0027t want to leave an old configuration running (or looping attempting to run) that is invalid. Otherwise you would not be able to delete a listener if the certs are missing from barbican.","commit_id":"e4c105feb3b2ae2f3375b564bda94d98f03856b5"}]}