)]}'
{"api-ref/source/parameters.yaml":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"0c28af8aed99de47b0b3c6300171131e1b4f9a09","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    The name of the availability zone to query."},{"line_number":13,"context_line":"  in: path"},{"line_number":14,"context_line":"  required: true"},{"line_number":15,"context_line":"  type: uuid"},{"line_number":16,"context_line":"path-availability-zone-profile-id:"},{"line_number":17,"context_line":"  description: |"},{"line_number":18,"context_line":"    The ID of the availability zone profile to query."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3fa7e38b_42b66c27","line":15,"updated":"2019-11-21 23:48:16.000000000","message":"I don\u0027t think this is a UUID is it?","commit_id":"2c71eb42c46c00df2a51ea285aa28eaefdfd8761"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"8b80ee1cd3ff0a5a807e14b814fe5c5a3decbf02","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    The name of the availability zone to query."},{"line_number":13,"context_line":"  in: path"},{"line_number":14,"context_line":"  required: true"},{"line_number":15,"context_line":"  type: uuid"},{"line_number":16,"context_line":"path-availability-zone-profile-id:"},{"line_number":17,"context_line":"  description: |"},{"line_number":18,"context_line":"    The ID of the availability zone profile to query."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3fa7e38b_e39afac2","line":15,"in_reply_to":"3fa7e38b_42b66c27","updated":"2019-11-22 05:58:37.000000000","message":"Correct!\nDone.","commit_id":"2c71eb42c46c00df2a51ea285aa28eaefdfd8761"}],"api-ref/source/v2/availabilityzone.inc":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"0c28af8aed99de47b0b3c6300171131e1b4f9a09","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"3fa7e38b_42f98cc2","updated":"2019-11-21 23:48:16.000000000","message":"This needs to be linked into the index.\nhttps://github.com/openstack/octavia/blob/master/api-ref/source/v2/index.rst","commit_id":"2c71eb42c46c00df2a51ea285aa28eaefdfd8761"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"8b80ee1cd3ff0a5a807e14b814fe5c5a3decbf02","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"3fa7e38b_23b49235","in_reply_to":"3fa7e38b_42f98cc2","updated":"2019-11-22 05:58:37.000000000","message":"Correct! Done.","commit_id":"2c71eb42c46c00df2a51ea285aa28eaefdfd8761"}],"api-ref/source/v2/availabilityzoneprofile.inc":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"0c28af8aed99de47b0b3c6300171131e1b4f9a09","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"3fa7e38b_023154a2","updated":"2019-11-21 23:48:16.000000000","message":"This needs to be linked into the index.\nhttps://github.com/openstack/octavia/blob/master/api-ref/source/v2/index.rst","commit_id":"2c71eb42c46c00df2a51ea285aa28eaefdfd8761"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"8b80ee1cd3ff0a5a807e14b814fe5c5a3decbf02","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"3fa7e38b_43af4edf","in_reply_to":"3fa7e38b_023154a2","updated":"2019-11-22 05:58:37.000000000","message":"Done","commit_id":"2c71eb42c46c00df2a51ea285aa28eaefdfd8761"}],"api-ref/source/v2/examples/availabilityzone-create-response.json":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"0c28af8aed99de47b0b3c6300171131e1b4f9a09","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"3fa7e38b_42bc2cb4","updated":"2019-11-21 23:48:16.000000000","message":"FYI, if this is the same content as the request body, you can use the same file and just point both locations to the single file.","commit_id":"2c71eb42c46c00df2a51ea285aa28eaefdfd8761"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"8b80ee1cd3ff0a5a807e14b814fe5c5a3decbf02","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"3fa7e38b_a3796282","in_reply_to":"3fa7e38b_42bc2cb4","updated":"2019-11-22 05:58:37.000000000","message":"Yeah, possibly... But it feels dirty because I wouldn\u0027t want to have one change and one not later, and it\u0027s going to forever look like a copy/paste error when people look at the link to it. :D","commit_id":"2c71eb42c46c00df2a51ea285aa28eaefdfd8761"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"0c28af8aed99de47b0b3c6300171131e1b4f9a09","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"availability_zone\": {"},{"line_number":3,"context_line":"            \"name\": \"my_az\","},{"line_number":4,"context_line":"            \"description\": \"My availability zone.\","},{"line_number":5,"context_line":"            \"enabled\": true,"},{"line_number":6,"context_line":"            \"availability_zone_profile_id\": \"5712097e-0092-45dc-bff0-ab68b61ad51a\""},{"line_number":7,"context_line":"    }"},{"line_number":8,"context_line":"}"}],"source_content_type":"application/json","patch_set":12,"id":"3fa7e38b_a2ade084","line":6,"range":{"start_line":3,"start_character":0,"end_line":6,"end_character":82},"updated":"2019-11-21 23:48:16.000000000","message":"nit: extra indent here that isn\u0027t necessary.","commit_id":"2c71eb42c46c00df2a51ea285aa28eaefdfd8761"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"8b80ee1cd3ff0a5a807e14b814fe5c5a3decbf02","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"availability_zone\": {"},{"line_number":3,"context_line":"            \"name\": \"my_az\","},{"line_number":4,"context_line":"            \"description\": \"My availability zone.\","},{"line_number":5,"context_line":"            \"enabled\": true,"},{"line_number":6,"context_line":"            \"availability_zone_profile_id\": \"5712097e-0092-45dc-bff0-ab68b61ad51a\""},{"line_number":7,"context_line":"    }"},{"line_number":8,"context_line":"}"}],"source_content_type":"application/json","patch_set":12,"id":"3fa7e38b_c37c9e72","line":6,"range":{"start_line":3,"start_character":0,"end_line":6,"end_character":82},"in_reply_to":"3fa7e38b_a2ade084","updated":"2019-11-22 05:58:37.000000000","message":"Done","commit_id":"2c71eb42c46c00df2a51ea285aa28eaefdfd8761"}],"api-ref/source/v2/examples/availabilityzone-show-response.json":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"0c28af8aed99de47b0b3c6300171131e1b4f9a09","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"availability_zone\": {"},{"line_number":3,"context_line":"            \"name\": \"my_az\","},{"line_number":4,"context_line":"            \"description\": \"My availability zone.\","},{"line_number":5,"context_line":"            \"enabled\": true,"},{"line_number":6,"context_line":"            \"availability_zone_profile_id\": \"5712097e-0092-45dc-bff0-ab68b61ad51a\""},{"line_number":7,"context_line":"    }"},{"line_number":8,"context_line":"}"}],"source_content_type":"application/json","patch_set":12,"id":"3fa7e38b_62f9287e","line":6,"range":{"start_line":3,"start_character":0,"end_line":6,"end_character":82},"updated":"2019-11-21 23:48:16.000000000","message":"nit: extra indention","commit_id":"2c71eb42c46c00df2a51ea285aa28eaefdfd8761"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"8b80ee1cd3ff0a5a807e14b814fe5c5a3decbf02","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"availability_zone\": {"},{"line_number":3,"context_line":"            \"name\": \"my_az\","},{"line_number":4,"context_line":"            \"description\": \"My availability zone.\","},{"line_number":5,"context_line":"            \"enabled\": true,"},{"line_number":6,"context_line":"            \"availability_zone_profile_id\": \"5712097e-0092-45dc-bff0-ab68b61ad51a\""},{"line_number":7,"context_line":"    }"},{"line_number":8,"context_line":"}"}],"source_content_type":"application/json","patch_set":12,"id":"3fa7e38b_8392269e","line":6,"range":{"start_line":3,"start_character":0,"end_line":6,"end_character":82},"in_reply_to":"3fa7e38b_62f9287e","updated":"2019-11-22 05:58:37.000000000","message":"Done","commit_id":"2c71eb42c46c00df2a51ea285aa28eaefdfd8761"}],"api-ref/source/v2/examples/availabilityzone-update-response.json":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"c5df53e129832a03da8be1aa1207a07a3eca1cdd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"availability_zone\": {"},{"line_number":3,"context_line":"            \"name\": \"my_az\","},{"line_number":4,"context_line":"            \"description\": \"My availability zone.\","},{"line_number":5,"context_line":"            \"enabled\": false,"},{"line_number":6,"context_line":"            \"availability_zone_profile_id\": \"5712097e-0092-45dc-bff0-ab68b61ad51a\""},{"line_number":7,"context_line":"    }"},{"line_number":8,"context_line":"}"}],"source_content_type":"application/json","patch_set":14,"id":"3fa7e38b_9ad5a0b9","line":7,"range":{"start_line":2,"start_character":0,"end_line":7,"end_character":5},"updated":"2019-11-22 16:25:45.000000000","message":"nit: extra indentation\nI guess I missed this one first pass, sorry about that.","commit_id":"ad34b788eb54bf9b58c2995cdda3c5895cd168c5"}],"octavia/api/drivers/amphora_driver/availability_zone_schema.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"0c28af8aed99de47b0b3c6300171131e1b4f9a09","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2018 Rackspace US Inc.  All rights reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":12,"id":"3fa7e38b_021714a5","line":1,"range":{"start_line":1,"start_character":2,"end_line":1,"end_character":29},"updated":"2019-11-21 23:48:16.000000000","message":"nit: Probably not the right copyright for this file.","commit_id":"2c71eb42c46c00df2a51ea285aa28eaefdfd8761"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"8b80ee1cd3ff0a5a807e14b814fe5c5a3decbf02","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2018 Rackspace US Inc.  All rights reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":12,"id":"3fa7e38b_238d727b","line":1,"range":{"start_line":1,"start_character":2,"end_line":1,"end_character":29},"in_reply_to":"3fa7e38b_021714a5","updated":"2019-11-22 05:58:37.000000000","message":"Yeah, I think for files I copy/pasted I left it alone because technically if I TOOK the code and just modified it slightly, it should still retain the same copyright? But I should probably ADD my own... This stuff is a little confusing.","commit_id":"2c71eb42c46c00df2a51ea285aa28eaefdfd8761"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"0c28af8aed99de47b0b3c6300171131e1b4f9a09","unresolved":false,"context_lines":[{"line_number":17,"context_line":"# This is a JSON schema validation dictionary"},{"line_number":18,"context_line":"# https://json-schema.org/latest/json-schema-validation.html"},{"line_number":19,"context_line":"#"},{"line_number":20,"context_line":"# Note: This is used to generate the amphora driver \"supported flavor"},{"line_number":21,"context_line":"#       metadata\" dictionary. Each property should include a description"},{"line_number":22,"context_line":"#       for the user to understand what this flavor setting does."},{"line_number":23,"context_line":"#"},{"line_number":24,"context_line":"# Where possible, the property name should match the configuration file name"}],"source_content_type":"text/x-python","patch_set":12,"id":"3fa7e38b_a2096084","line":21,"range":{"start_line":20,"start_character":63,"end_line":21,"end_character":16},"updated":"2019-11-21 23:48:16.000000000","message":"availability zone metadata","commit_id":"2c71eb42c46c00df2a51ea285aa28eaefdfd8761"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"8b80ee1cd3ff0a5a807e14b814fe5c5a3decbf02","unresolved":false,"context_lines":[{"line_number":17,"context_line":"# This is a JSON schema validation dictionary"},{"line_number":18,"context_line":"# https://json-schema.org/latest/json-schema-validation.html"},{"line_number":19,"context_line":"#"},{"line_number":20,"context_line":"# Note: This is used to generate the amphora driver \"supported flavor"},{"line_number":21,"context_line":"#       metadata\" dictionary. Each property should include a description"},{"line_number":22,"context_line":"#       for the user to understand what this flavor setting does."},{"line_number":23,"context_line":"#"},{"line_number":24,"context_line":"# Where possible, the property name should match the configuration file name"}],"source_content_type":"text/x-python","patch_set":12,"id":"3fa7e38b_a3ee421e","line":21,"range":{"start_line":20,"start_character":63,"end_line":21,"end_character":16},"in_reply_to":"3fa7e38b_a2096084","updated":"2019-11-22 05:58:37.000000000","message":"Done","commit_id":"2c71eb42c46c00df2a51ea285aa28eaefdfd8761"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"0c28af8aed99de47b0b3c6300171131e1b4f9a09","unresolved":false,"context_lines":[{"line_number":19,"context_line":"#"},{"line_number":20,"context_line":"# Note: This is used to generate the amphora driver \"supported flavor"},{"line_number":21,"context_line":"#       metadata\" dictionary. Each property should include a description"},{"line_number":22,"context_line":"#       for the user to understand what this flavor setting does."},{"line_number":23,"context_line":"#"},{"line_number":24,"context_line":"# Where possible, the property name should match the configuration file name"},{"line_number":25,"context_line":"# for the setting. The configuration file setting is the default when a"}],"source_content_type":"text/x-python","patch_set":12,"id":"3fa7e38b_6227e813","line":22,"range":{"start_line":22,"start_character":45,"end_line":22,"end_character":51},"updated":"2019-11-21 23:48:16.000000000","message":"availability zone","commit_id":"2c71eb42c46c00df2a51ea285aa28eaefdfd8761"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"8b80ee1cd3ff0a5a807e14b814fe5c5a3decbf02","unresolved":false,"context_lines":[{"line_number":19,"context_line":"#"},{"line_number":20,"context_line":"# Note: This is used to generate the amphora driver \"supported flavor"},{"line_number":21,"context_line":"#       metadata\" dictionary. Each property should include a description"},{"line_number":22,"context_line":"#       for the user to understand what this flavor setting does."},{"line_number":23,"context_line":"#"},{"line_number":24,"context_line":"# Where possible, the property name should match the configuration file name"},{"line_number":25,"context_line":"# for the setting. The configuration file setting is the default when a"}],"source_content_type":"text/x-python","patch_set":12,"id":"3fa7e38b_c3f1fe01","line":22,"range":{"start_line":22,"start_character":45,"end_line":22,"end_character":51},"in_reply_to":"3fa7e38b_6227e813","updated":"2019-11-22 05:58:37.000000000","message":"Done","commit_id":"2c71eb42c46c00df2a51ea285aa28eaefdfd8761"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"0c28af8aed99de47b0b3c6300171131e1b4f9a09","unresolved":false,"context_lines":[{"line_number":23,"context_line":"#"},{"line_number":24,"context_line":"# Where possible, the property name should match the configuration file name"},{"line_number":25,"context_line":"# for the setting. The configuration file setting is the default when a"},{"line_number":26,"context_line":"# setting is not defined in a flavor profile."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"SUPPORTED_AVAILABILITY_ZONE_SCHEMA \u003d {"},{"line_number":29,"context_line":"    \"$schema\": \"http://json-schema.org/draft-07/schema#\","}],"source_content_type":"text/x-python","patch_set":12,"id":"3fa7e38b_82222400","line":26,"range":{"start_line":26,"start_character":30,"end_line":26,"end_character":36},"updated":"2019-11-21 23:48:16.000000000","message":"availability zone","commit_id":"2c71eb42c46c00df2a51ea285aa28eaefdfd8761"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"8b80ee1cd3ff0a5a807e14b814fe5c5a3decbf02","unresolved":false,"context_lines":[{"line_number":23,"context_line":"#"},{"line_number":24,"context_line":"# Where possible, the property name should match the configuration file name"},{"line_number":25,"context_line":"# for the setting. The configuration file setting is the default when a"},{"line_number":26,"context_line":"# setting is not defined in a flavor profile."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"SUPPORTED_AVAILABILITY_ZONE_SCHEMA \u003d {"},{"line_number":29,"context_line":"    \"$schema\": \"http://json-schema.org/draft-07/schema#\","}],"source_content_type":"text/x-python","patch_set":12,"id":"3fa7e38b_83d7864f","line":26,"range":{"start_line":26,"start_character":30,"end_line":26,"end_character":36},"in_reply_to":"3fa7e38b_82222400","updated":"2019-11-22 05:58:37.000000000","message":"Done","commit_id":"2c71eb42c46c00df2a51ea285aa28eaefdfd8761"}],"octavia/api/v2/controllers/__init__.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"0c28af8aed99de47b0b3c6300171131e1b4f9a09","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"3fa7e38b_42a2ec40","updated":"2019-11-21 23:48:16.000000000","message":"Putting this here so I don\u0027t forget about it.\nThe updates to the provider controller for the AZ capabilities API are missing.","commit_id":"2c71eb42c46c00df2a51ea285aa28eaefdfd8761"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"8b80ee1cd3ff0a5a807e14b814fe5c5a3decbf02","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"3fa7e38b_23e25231","in_reply_to":"3fa7e38b_42a2ec40","updated":"2019-11-22 05:58:37.000000000","message":"Err, whichnow?","commit_id":"2c71eb42c46c00df2a51ea285aa28eaefdfd8761"}],"octavia/api/v2/controllers/availability_zone_profiles.py":[{"author":{"_account_id":3031,"name":"Sam Morrison","email":"sorrison@gmail.com","username":"sorrison"},"change_message_id":"31ee9d1e7e7c19afad5fa3f15941a221e5ea857a","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        except Exception:"},{"line_number":98,"context_line":"            raise exceptions.InvalidOption("},{"line_number":99,"context_line":"                value\u003davailability_zone_profile.availability_zone_data,"},{"line_number":100,"context_line":"                option\u003dconstants.FLAVOR_DATA)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        # Validate that the provider driver supports the metadata"},{"line_number":103,"context_line":"        driver \u003d driver_factory.get_driver("}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_25d2c8d2","line":100,"range":{"start_line":100,"start_character":33,"end_line":100,"end_character":44},"updated":"2019-11-14 21:45:23.000000000","message":"copy paste error :-)","commit_id":"1c3c767a547529bbb38c7922b15c914202ef4e79"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"22aef184543feadf940662bfce132292017e99c9","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        except Exception:"},{"line_number":98,"context_line":"            raise exceptions.InvalidOption("},{"line_number":99,"context_line":"                value\u003davailability_zone_profile.availability_zone_data,"},{"line_number":100,"context_line":"                option\u003dconstants.FLAVOR_DATA)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        # Validate that the provider driver supports the metadata"},{"line_number":103,"context_line":"        driver \u003d driver_factory.get_driver("}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_17649020","line":100,"range":{"start_line":100,"start_character":33,"end_line":100,"end_character":44},"in_reply_to":"3fa7e38b_25d2c8d2","updated":"2019-11-16 04:43:49.000000000","message":"AHA! managed to leave one after all.","commit_id":"1c3c767a547529bbb38c7922b15c914202ef4e79"}],"octavia/api/v2/controllers/availability_zones.py":[{"author":{"_account_id":3031,"name":"Sam Morrison","email":"sorrison@gmail.com","username":"sorrison"},"change_message_id":"0b5cda408293c79e7fc4b362d58adaeeb552921b","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    @wsme_pecan.wsexpose(availability_zone_types.AvailabilityZoneRootResponse,"},{"line_number":81,"context_line":"                         body\u003davailability_zone_types.AvailabilityZoneRootPOST,"},{"line_number":82,"context_line":"                         status_code\u003d201)"},{"line_number":83,"context_line":"    def post(self, availability_zone_):"},{"line_number":84,"context_line":"        \"\"\"Creates an Availability Zone.\"\"\""},{"line_number":85,"context_line":"        availability_zone \u003d availability_zone_.availability_zone"},{"line_number":86,"context_line":"        context \u003d pecan.request.context.get(\u0027octavia_context\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_3cc3b33a","line":83,"range":{"start_line":83,"start_character":36,"end_line":83,"end_character":37},"updated":"2019-11-14 21:52:20.000000000","message":"underscore here and below methods, also in the profile class","commit_id":"1c3c767a547529bbb38c7922b15c914202ef4e79"},{"author":{"_account_id":3031,"name":"Sam Morrison","email":"sorrison@gmail.com","username":"sorrison"},"change_message_id":"522d7a83de8cdb82f9a548cc6383e0d7234ad63f","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    @wsme_pecan.wsexpose(availability_zone_types.AvailabilityZoneRootResponse,"},{"line_number":81,"context_line":"                         body\u003davailability_zone_types.AvailabilityZoneRootPOST,"},{"line_number":82,"context_line":"                         status_code\u003d201)"},{"line_number":83,"context_line":"    def post(self, availability_zone_):"},{"line_number":84,"context_line":"        \"\"\"Creates an Availability Zone.\"\"\""},{"line_number":85,"context_line":"        availability_zone \u003d availability_zone_.availability_zone"},{"line_number":86,"context_line":"        context \u003d pecan.request.context.get(\u0027octavia_context\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_dc0e1f8b","line":83,"range":{"start_line":83,"start_character":36,"end_line":83,"end_character":37},"in_reply_to":"3fa7e38b_3cc3b33a","updated":"2019-11-14 22:00:39.000000000","message":"Just realised this is how it\u0027s meant to be","commit_id":"1c3c767a547529bbb38c7922b15c914202ef4e79"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"22aef184543feadf940662bfce132292017e99c9","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    @wsme_pecan.wsexpose(availability_zone_types.AvailabilityZoneRootResponse,"},{"line_number":81,"context_line":"                         body\u003davailability_zone_types.AvailabilityZoneRootPOST,"},{"line_number":82,"context_line":"                         status_code\u003d201)"},{"line_number":83,"context_line":"    def post(self, availability_zone_):"},{"line_number":84,"context_line":"        \"\"\"Creates an Availability Zone.\"\"\""},{"line_number":85,"context_line":"        availability_zone \u003d availability_zone_.availability_zone"},{"line_number":86,"context_line":"        context \u003d pecan.request.context.get(\u0027octavia_context\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_976f20f9","line":83,"range":{"start_line":83,"start_character":36,"end_line":83,"end_character":37},"in_reply_to":"3fa7e38b_dc0e1f8b","updated":"2019-11-16 04:43:49.000000000","message":"Yeah, it\u0027s an odd sort of workaround, and it\u0027s even weirder because we don\u0027t do it *consistently*. \u003c_\u003c","commit_id":"1c3c767a547529bbb38c7922b15c914202ef4e79"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"0c28af8aed99de47b0b3c6300171131e1b4f9a09","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        self._auth_validate_action(context, context.project_id,"},{"line_number":87,"context_line":"                                   constants.RBAC_POST)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        # TODO(johnsom) Validate the availability_zone profile ID"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        lock_session \u003d db_api.get_session(autocommit\u003dFalse)"},{"line_number":92,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":12,"id":"3fa7e38b_02987418","line":89,"updated":"2019-11-21 23:48:16.000000000","message":"This comment can go, the foreign key will cover this now.\nIt would probably be nice to update the exception handler below to give a nicer error message when they specify a non-existent profile ID. Not critical though as this is an operator API.","commit_id":"2c71eb42c46c00df2a51ea285aa28eaefdfd8761"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"8b80ee1cd3ff0a5a807e14b814fe5c5a3decbf02","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        self._auth_validate_action(context, context.project_id,"},{"line_number":87,"context_line":"                                   constants.RBAC_POST)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        # TODO(johnsom) Validate the availability_zone profile ID"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        lock_session \u003d db_api.get_session(autocommit\u003dFalse)"},{"line_number":92,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":12,"id":"3fa7e38b_03d5d642","line":89,"in_reply_to":"3fa7e38b_02987418","updated":"2019-11-22 05:58:37.000000000","message":"Done","commit_id":"2c71eb42c46c00df2a51ea285aa28eaefdfd8761"}],"octavia/common/data_models.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"85a6398e8a47011214c8ee8b371402ec67f19981","unresolved":false,"context_lines":[{"line_number":461,"context_line":"                 topology\u003dNone, vip\u003dNone, listeners\u003dNone, amphorae\u003dNone,"},{"line_number":462,"context_line":"                 pools\u003dNone, vrrp_group\u003dNone, server_group_id\u003dNone,"},{"line_number":463,"context_line":"                 created_at\u003dNone, updated_at\u003dNone, provider\u003dNone, tags\u003dNone,"},{"line_number":464,"context_line":"                 flavor_id\u003dNone):"},{"line_number":465,"context_line":""},{"line_number":466,"context_line":"        self.id \u003d id"},{"line_number":467,"context_line":"        self.project_id \u003d project_id"}],"source_content_type":"text/x-python","patch_set":12,"id":"3fa7e38b_7be9ea7c","line":464,"updated":"2019-11-21 00:38:00.000000000","message":"You need to add \"availability_zone\" here to support the octavia-lib provider drivers patch.","commit_id":"2c71eb42c46c00df2a51ea285aa28eaefdfd8761"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"c26161ee74e8e477c8dc23d4e9a0b11b814dc27f","unresolved":false,"context_lines":[{"line_number":461,"context_line":"                 topology\u003dNone, vip\u003dNone, listeners\u003dNone, amphorae\u003dNone,"},{"line_number":462,"context_line":"                 pools\u003dNone, vrrp_group\u003dNone, server_group_id\u003dNone,"},{"line_number":463,"context_line":"                 created_at\u003dNone, updated_at\u003dNone, provider\u003dNone, tags\u003dNone,"},{"line_number":464,"context_line":"                 flavor_id\u003dNone):"},{"line_number":465,"context_line":""},{"line_number":466,"context_line":"        self.id \u003d id"},{"line_number":467,"context_line":"        self.project_id \u003d project_id"}],"source_content_type":"text/x-python","patch_set":12,"id":"3fa7e38b_b6c53090","line":464,"in_reply_to":"3fa7e38b_7631f8ec","updated":"2019-11-21 12:30:25.000000000","message":"Nope, if I add this here, unit tests fail because it\u0027s missing in octavia-lib. :(","commit_id":"2c71eb42c46c00df2a51ea285aa28eaefdfd8761"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"7117797830e4d8e80b4a14422aacf9a1c274e9ed","unresolved":false,"context_lines":[{"line_number":461,"context_line":"                 topology\u003dNone, vip\u003dNone, listeners\u003dNone, amphorae\u003dNone,"},{"line_number":462,"context_line":"                 pools\u003dNone, vrrp_group\u003dNone, server_group_id\u003dNone,"},{"line_number":463,"context_line":"                 created_at\u003dNone, updated_at\u003dNone, provider\u003dNone, tags\u003dNone,"},{"line_number":464,"context_line":"                 flavor_id\u003dNone):"},{"line_number":465,"context_line":""},{"line_number":466,"context_line":"        self.id \u003d id"},{"line_number":467,"context_line":"        self.project_id \u003d project_id"}],"source_content_type":"text/x-python","patch_set":12,"id":"3fa7e38b_7631f8ec","line":464,"in_reply_to":"3fa7e38b_7be9ea7c","updated":"2019-11-21 12:20:51.000000000","message":"Will try it, but I thought that\u0027d break the other side.","commit_id":"2c71eb42c46c00df2a51ea285aa28eaefdfd8761"}],"octavia/compute/drivers/nova_driver.py":[{"author":{"_account_id":3031,"name":"Sam Morrison","email":"sorrison@gmail.com","username":"sorrison"},"change_message_id":"31ee9d1e7e7c19afad5fa3f15941a221e5ea857a","unresolved":false,"context_lines":[{"line_number":408,"context_line":"        :returns: None"},{"line_number":409,"context_line":"        \"\"\""},{"line_number":410,"context_line":"        try:"},{"line_number":411,"context_line":"            self.availability_zone_manager.get(availability_zone)"},{"line_number":412,"context_line":"        except nova_exceptions.NotFound:"},{"line_number":413,"context_line":"            LOG.info(\u0027Availability zone %s was not found in nova.\u0027,"},{"line_number":414,"context_line":"                     availability_zone)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_a5f6b85c","line":411,"range":{"start_line":411,"start_character":43,"end_line":411,"end_character":46},"updated":"2019-11-14 21:45:23.000000000","message":"no such method in novaclient. Do something like:\n\ncompute_zones \u003d [az.zoneName for az in self.availability_zone_manager.list(detailed\u003dFalse)]","commit_id":"1c3c767a547529bbb38c7922b15c914202ef4e79"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"22aef184543feadf940662bfce132292017e99c9","unresolved":false,"context_lines":[{"line_number":408,"context_line":"        :returns: None"},{"line_number":409,"context_line":"        \"\"\""},{"line_number":410,"context_line":"        try:"},{"line_number":411,"context_line":"            self.availability_zone_manager.get(availability_zone)"},{"line_number":412,"context_line":"        except nova_exceptions.NotFound:"},{"line_number":413,"context_line":"            LOG.info(\u0027Availability zone %s was not found in nova.\u0027,"},{"line_number":414,"context_line":"                     availability_zone)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_d76d9803","line":411,"range":{"start_line":411,"start_character":43,"end_line":411,"end_character":46},"in_reply_to":"3fa7e38b_a5f6b85c","updated":"2019-11-16 04:43:49.000000000","message":"Ah, you can\u0027t just get an AZ? :/\nOk, I\u0027ll have to test this in an actual env.\nOr actually... I think I already did test this, was aware of that issue, and wrote the code to do it, either in my original patch or in another CR somewhere...","commit_id":"1c3c767a547529bbb38c7922b15c914202ef4e79"}],"octavia/db/repositories.py":[{"author":{"_account_id":3031,"name":"Sam Morrison","email":"sorrison@gmail.com","username":"sorrison"},"change_message_id":"3da3d665c7d0d554be2f25f858c2c9b4f63559a7","unresolved":false,"context_lines":[{"line_number":1911,"context_line":"                session.query("},{"line_number":1912,"context_line":"                    models.AvailabilityZoneProfile.availability_zone_data)"},{"line_number":1913,"context_line":"                .filter(models.AvailabilityZone.id \u003d\u003d availability_zone_id)"},{"line_number":1914,"context_line":"                .filter(models.AvailabilityZone.flavor_profile_id \u003d\u003d"},{"line_number":1915,"context_line":"                        models.AvailabilityZoneProfile.id)"},{"line_number":1916,"context_line":"                .one()[0])"},{"line_number":1917,"context_line":"            result_dict \u003d ("}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_d75cb87e","line":1914,"range":{"start_line":1914,"start_character":48,"end_line":1914,"end_character":54},"updated":"2019-11-14 23:49:15.000000000","message":"az","commit_id":"1c3c767a547529bbb38c7922b15c914202ef4e79"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"22aef184543feadf940662bfce132292017e99c9","unresolved":false,"context_lines":[{"line_number":1911,"context_line":"                session.query("},{"line_number":1912,"context_line":"                    models.AvailabilityZoneProfile.availability_zone_data)"},{"line_number":1913,"context_line":"                .filter(models.AvailabilityZone.id \u003d\u003d availability_zone_id)"},{"line_number":1914,"context_line":"                .filter(models.AvailabilityZone.flavor_profile_id \u003d\u003d"},{"line_number":1915,"context_line":"                        models.AvailabilityZoneProfile.id)"},{"line_number":1916,"context_line":"                .one()[0])"},{"line_number":1917,"context_line":"            result_dict \u003d ("}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_377e6caf","line":1914,"range":{"start_line":1914,"start_character":48,"end_line":1914,"end_character":54},"in_reply_to":"3fa7e38b_d75cb87e","updated":"2019-11-16 04:43:49.000000000","message":"lol","commit_id":"1c3c767a547529bbb38c7922b15c914202ef4e79"},{"author":{"_account_id":3031,"name":"Sam Morrison","email":"sorrison@gmail.com","username":"sorrison"},"change_message_id":"3da3d665c7d0d554be2f25f858c2c9b4f63559a7","unresolved":false,"context_lines":[{"line_number":1923,"context_line":"        with session.begin(subtransactions\u003dTrue):"},{"line_number":1924,"context_line":"            return (session.query(models.AvailabilityZoneProfile.provider_name)"},{"line_number":1925,"context_line":"                    .filter(models.AvailabilityZone.id \u003d\u003d availability_zone_id)"},{"line_number":1926,"context_line":"                    .filter(models.AvailabilityZone.flavor_profile_id \u003d\u003d"},{"line_number":1927,"context_line":"                            models.AvailabilityZoneProfile.id).one()[0])"},{"line_number":1928,"context_line":""},{"line_number":1929,"context_line":"    def delete(self, serial_session, **filters):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_7753846d","line":1926,"range":{"start_line":1926,"start_character":52,"end_line":1926,"end_character":58},"updated":"2019-11-14 23:49:15.000000000","message":"az","commit_id":"1c3c767a547529bbb38c7922b15c914202ef4e79"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"22aef184543feadf940662bfce132292017e99c9","unresolved":false,"context_lines":[{"line_number":1923,"context_line":"        with session.begin(subtransactions\u003dTrue):"},{"line_number":1924,"context_line":"            return (session.query(models.AvailabilityZoneProfile.provider_name)"},{"line_number":1925,"context_line":"                    .filter(models.AvailabilityZone.id \u003d\u003d availability_zone_id)"},{"line_number":1926,"context_line":"                    .filter(models.AvailabilityZone.flavor_profile_id \u003d\u003d"},{"line_number":1927,"context_line":"                            models.AvailabilityZoneProfile.id).one()[0])"},{"line_number":1928,"context_line":""},{"line_number":1929,"context_line":"    def delete(self, serial_session, **filters):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_5779a8c2","line":1926,"range":{"start_line":1926,"start_character":52,"end_line":1926,"end_character":58},"in_reply_to":"3fa7e38b_7753846d","updated":"2019-11-16 04:43:49.000000000","message":"yep :D","commit_id":"1c3c767a547529bbb38c7922b15c914202ef4e79"},{"author":{"_account_id":3031,"name":"Sam Morrison","email":"sorrison@gmail.com","username":"sorrison"},"change_message_id":"79dfa9a931723aafe87bbcdf7ae19b06a5976731","unresolved":false,"context_lines":[{"line_number":1956,"context_line":"        \"\"\""},{"line_number":1957,"context_line":"        # TODO(sorrison): Uncomment this"},{"line_number":1958,"context_line":"        # (serial_session.query(models.LoadBalancer)."},{"line_number":1959,"context_line":"        #  filter(models.LoadBalancer.availability_zone_id \u003d\u003d filters[\u0027id\u0027])."},{"line_number":1960,"context_line":"        #  filter(models.LoadBalancer.provisioning_status \u003d\u003d consts.DELETED)."},{"line_number":1961,"context_line":"        #  update({models.LoadBalancer.availability_zone_id: consts.NIL_UUID},"},{"line_number":1962,"context_line":"        #         synchronize_session\u003dFalse))"}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_2f660253","line":1959,"range":{"start_line":1959,"start_character":56,"end_line":1959,"end_character":58},"updated":"2019-11-18 05:40:22.000000000","message":"name","commit_id":"f6603796f4fbc54dc63b324f1ad7f60ec113d86d"},{"author":{"_account_id":3031,"name":"Sam Morrison","email":"sorrison@gmail.com","username":"sorrison"},"change_message_id":"79dfa9a931723aafe87bbcdf7ae19b06a5976731","unresolved":false,"context_lines":[{"line_number":1960,"context_line":"        #  filter(models.LoadBalancer.provisioning_status \u003d\u003d consts.DELETED)."},{"line_number":1961,"context_line":"        #  update({models.LoadBalancer.availability_zone_id: consts.NIL_UUID},"},{"line_number":1962,"context_line":"        #         synchronize_session\u003dFalse))"},{"line_number":1963,"context_line":"        flavor \u003d (serial_session.query(self.model_class)."},{"line_number":1964,"context_line":"                  filter_by(**filters).one())"},{"line_number":1965,"context_line":"        serial_session.delete(flavor)"},{"line_number":1966,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_0f61c639","line":1963,"range":{"start_line":1963,"start_character":8,"end_line":1963,"end_character":14},"updated":"2019-11-18 05:40:22.000000000","message":"az","commit_id":"f6603796f4fbc54dc63b324f1ad7f60ec113d86d"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"65e988193f8e216b21b5af524a7a403fd4904336","unresolved":false,"context_lines":[{"line_number":1960,"context_line":"        #  filter(models.LoadBalancer.provisioning_status \u003d\u003d consts.DELETED)."},{"line_number":1961,"context_line":"        #  update({models.LoadBalancer.availability_zone_id: consts.NIL_UUID},"},{"line_number":1962,"context_line":"        #         synchronize_session\u003dFalse))"},{"line_number":1963,"context_line":"        flavor \u003d (serial_session.query(self.model_class)."},{"line_number":1964,"context_line":"                  filter_by(**filters).one())"},{"line_number":1965,"context_line":"        serial_session.delete(flavor)"},{"line_number":1966,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_3a3b979c","line":1963,"range":{"start_line":1963,"start_character":8,"end_line":1963,"end_character":14},"in_reply_to":"3fa7e38b_0f61c639","updated":"2019-11-18 15:08:19.000000000","message":"Done","commit_id":"f6603796f4fbc54dc63b324f1ad7f60ec113d86d"},{"author":{"_account_id":3031,"name":"Sam Morrison","email":"sorrison@gmail.com","username":"sorrison"},"change_message_id":"79dfa9a931723aafe87bbcdf7ae19b06a5976731","unresolved":false,"context_lines":[{"line_number":1909,"context_line":"    model_class \u003d models.AvailabilityZone"},{"line_number":1910,"context_line":""},{"line_number":1911,"context_line":"    def get_availability_zone_metadata_dict(self, session,"},{"line_number":1912,"context_line":"                                            availability_zone_id):"},{"line_number":1913,"context_line":"        with session.begin(subtransactions\u003dTrue):"},{"line_number":1914,"context_line":"            availability_zone_metadata_json \u003d ("},{"line_number":1915,"context_line":"                session.query("}],"source_content_type":"text/x-python","patch_set":10,"id":"3fa7e38b_4aeeccb5","line":1912,"range":{"start_line":1912,"start_character":62,"end_line":1912,"end_character":64},"updated":"2019-11-18 05:40:22.000000000","message":"name","commit_id":"56d2dd925dda2f1164af4322df9fe29f500ac78e"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"65e988193f8e216b21b5af524a7a403fd4904336","unresolved":false,"context_lines":[{"line_number":1909,"context_line":"    model_class \u003d models.AvailabilityZone"},{"line_number":1910,"context_line":""},{"line_number":1911,"context_line":"    def get_availability_zone_metadata_dict(self, session,"},{"line_number":1912,"context_line":"                                            availability_zone_id):"},{"line_number":1913,"context_line":"        with session.begin(subtransactions\u003dTrue):"},{"line_number":1914,"context_line":"            availability_zone_metadata_json \u003d ("},{"line_number":1915,"context_line":"                session.query("}],"source_content_type":"text/x-python","patch_set":10,"id":"3fa7e38b_bacb0770","line":1912,"range":{"start_line":1912,"start_character":62,"end_line":1912,"end_character":64},"in_reply_to":"3fa7e38b_4aeeccb5","updated":"2019-11-18 15:08:19.000000000","message":"Done","commit_id":"56d2dd925dda2f1164af4322df9fe29f500ac78e"},{"author":{"_account_id":3031,"name":"Sam Morrison","email":"sorrison@gmail.com","username":"sorrison"},"change_message_id":"79dfa9a931723aafe87bbcdf7ae19b06a5976731","unresolved":false,"context_lines":[{"line_number":1914,"context_line":"            availability_zone_metadata_json \u003d ("},{"line_number":1915,"context_line":"                session.query("},{"line_number":1916,"context_line":"                    models.AvailabilityZoneProfile.availability_zone_data)"},{"line_number":1917,"context_line":"                .filter(models.AvailabilityZone.id \u003d\u003d availability_zone_id)"},{"line_number":1918,"context_line":"                .filter(models.AvailabilityZone.availability_zone_profile_id \u003d\u003d"},{"line_number":1919,"context_line":"                        models.AvailabilityZoneProfile.id)"},{"line_number":1920,"context_line":"                .one()[0])"}],"source_content_type":"text/x-python","patch_set":10,"id":"3fa7e38b_6aeb88a3","line":1917,"range":{"start_line":1917,"start_character":48,"end_line":1917,"end_character":50},"updated":"2019-11-18 05:40:22.000000000","message":"name","commit_id":"56d2dd925dda2f1164af4322df9fe29f500ac78e"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"65e988193f8e216b21b5af524a7a403fd4904336","unresolved":false,"context_lines":[{"line_number":1914,"context_line":"            availability_zone_metadata_json \u003d ("},{"line_number":1915,"context_line":"                session.query("},{"line_number":1916,"context_line":"                    models.AvailabilityZoneProfile.availability_zone_data)"},{"line_number":1917,"context_line":"                .filter(models.AvailabilityZone.id \u003d\u003d availability_zone_id)"},{"line_number":1918,"context_line":"                .filter(models.AvailabilityZone.availability_zone_profile_id \u003d\u003d"},{"line_number":1919,"context_line":"                        models.AvailabilityZoneProfile.id)"},{"line_number":1920,"context_line":"                .one()[0])"}],"source_content_type":"text/x-python","patch_set":10,"id":"3fa7e38b_5ac45360","line":1917,"range":{"start_line":1917,"start_character":48,"end_line":1917,"end_character":50},"in_reply_to":"3fa7e38b_6aeb88a3","updated":"2019-11-18 15:08:19.000000000","message":"Done","commit_id":"56d2dd925dda2f1164af4322df9fe29f500ac78e"},{"author":{"_account_id":3031,"name":"Sam Morrison","email":"sorrison@gmail.com","username":"sorrison"},"change_message_id":"79dfa9a931723aafe87bbcdf7ae19b06a5976731","unresolved":false,"context_lines":[{"line_number":1956,"context_line":"        \"\"\""},{"line_number":1957,"context_line":"        # TODO(sorrison): Uncomment this"},{"line_number":1958,"context_line":"        # (serial_session.query(models.LoadBalancer)."},{"line_number":1959,"context_line":"        #  filter(models.LoadBalancer.availability_zone_id \u003d\u003d filters[\u0027id\u0027])."},{"line_number":1960,"context_line":"        #  filter(models.LoadBalancer.provisioning_status \u003d\u003d consts.DELETED)."},{"line_number":1961,"context_line":"        #  update({models.LoadBalancer.availability_zone_id: consts.NIL_UUID},"},{"line_number":1962,"context_line":"        #         synchronize_session\u003dFalse))"}],"source_content_type":"text/x-python","patch_set":10,"id":"3fa7e38b_0a2a14e6","line":1959,"range":{"start_line":1959,"start_character":56,"end_line":1959,"end_character":58},"updated":"2019-11-18 05:40:22.000000000","message":"name","commit_id":"56d2dd925dda2f1164af4322df9fe29f500ac78e"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"65e988193f8e216b21b5af524a7a403fd4904336","unresolved":false,"context_lines":[{"line_number":1956,"context_line":"        \"\"\""},{"line_number":1957,"context_line":"        # TODO(sorrison): Uncomment this"},{"line_number":1958,"context_line":"        # (serial_session.query(models.LoadBalancer)."},{"line_number":1959,"context_line":"        #  filter(models.LoadBalancer.availability_zone_id \u003d\u003d filters[\u0027id\u0027])."},{"line_number":1960,"context_line":"        #  filter(models.LoadBalancer.provisioning_status \u003d\u003d consts.DELETED)."},{"line_number":1961,"context_line":"        #  update({models.LoadBalancer.availability_zone_id: consts.NIL_UUID},"},{"line_number":1962,"context_line":"        #         synchronize_session\u003dFalse))"}],"source_content_type":"text/x-python","patch_set":10,"id":"3fa7e38b_daa5a3b5","line":1959,"range":{"start_line":1959,"start_character":56,"end_line":1959,"end_character":58},"in_reply_to":"3fa7e38b_0a2a14e6","updated":"2019-11-18 15:08:19.000000000","message":"I\u0027m going to let you fix these two in your patch, since changing it will make pep8 line length errors I don\u0027t want to deal with (and only while it\u0027s a comment because of the extra 2 characters).","commit_id":"56d2dd925dda2f1164af4322df9fe29f500ac78e"}],"octavia/tests/functional/db/base.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"0c28af8aed99de47b0b3c6300171131e1b4f9a09","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            name\u003d\u0027DELETED-PLACEHOLDER\u0027, enabled\u003dFalse,"},{"line_number":108,"context_line":"            description\u003d\u0027Placeholder for DELETED LBs with DELETED flavors\u0027)"},{"line_number":109,"context_line":"        session.add(deleted_flavor)"},{"line_number":110,"context_line":"        session.flush()"},{"line_number":111,"context_line":"        deleted_az_profile \u003d models.AvailabilityZoneProfile("},{"line_number":112,"context_line":"            id\u003dconstants.NIL_UUID, name\u003d\u0027DELETED-PLACEHOLDER\u0027,"},{"line_number":113,"context_line":"            provider_name\u003dconstants.DELETED, availability_zone_data\u003d\u0027{}\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"3fa7e38b_22033012","line":110,"range":{"start_line":110,"start_character":0,"end_line":110,"end_character":23},"updated":"2019-11-21 23:48:16.000000000","message":"Save water, only flush once!\nThis can be removed.","commit_id":"2c71eb42c46c00df2a51ea285aa28eaefdfd8761"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"8b80ee1cd3ff0a5a807e14b814fe5c5a3decbf02","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            name\u003d\u0027DELETED-PLACEHOLDER\u0027, enabled\u003dFalse,"},{"line_number":108,"context_line":"            description\u003d\u0027Placeholder for DELETED LBs with DELETED flavors\u0027)"},{"line_number":109,"context_line":"        session.add(deleted_flavor)"},{"line_number":110,"context_line":"        session.flush()"},{"line_number":111,"context_line":"        deleted_az_profile \u003d models.AvailabilityZoneProfile("},{"line_number":112,"context_line":"            id\u003dconstants.NIL_UUID, name\u003d\u0027DELETED-PLACEHOLDER\u0027,"},{"line_number":113,"context_line":"            provider_name\u003dconstants.DELETED, availability_zone_data\u003d\u0027{}\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"3fa7e38b_23bb320f","line":110,"range":{"start_line":110,"start_character":0,"end_line":110,"end_character":23},"in_reply_to":"3fa7e38b_22033012","updated":"2019-11-22 05:58:37.000000000","message":"Yeah, technically. Just after the bug I discovered because of lacking a flush before where it \"seemed safe\", I figured this really doesn\u0027t HURT. I mean, you\u0027re almost certainly right in this case, since the flavor stuff doesn\u0027t interact with the AZ stuff, but I was going to leave it just in case of copy/pastes that could happen later, etc... The performance impact from this is essentially nonexistent and is in test runs only.","commit_id":"2c71eb42c46c00df2a51ea285aa28eaefdfd8761"}]}