)]}'
{"octavia/controller/worker/v1/tasks/network_tasks.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"804d57e75911816489fa4748527587cb27449ee1","unresolved":false,"context_lines":[{"line_number":594,"context_line":"        \"\"\"Apply qos policy on the vrrp ports which are related with vip.\"\"\""},{"line_number":595,"context_line":"        qos_policy_id \u003d loadbalancer.vip.qos_policy_id"},{"line_number":596,"context_line":"        if not qos_policy_id and ("},{"line_number":597,"context_line":"            isinstance(update_dict, dict) and ("},{"line_number":598,"context_line":"                \u0027vip\u0027 not in update_dict or"},{"line_number":599,"context_line":"                \u0027qos_policy_id\u0027 not in update_dict[\u0027vip\u0027])):"},{"line_number":600,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_a655e6fa","line":597,"range":{"start_line":597,"start_character":12,"end_line":597,"end_character":22},"updated":"2019-11-22 18:05:06.000000000","message":"I\u0027m not sure I understand what this accomplishes.\nThere are three possible cases here right?\nNone\n{}\nand {\u0027something\u0027: \u0027something\u0027}\n\nThe original test would be false for both None and {}, so what else would the update_dict possibly be and why?","commit_id":"32b6c4c40aec3b2e52e6f71172253a7ae87d3a5d"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2ed4974c9213c439f6edd3a3b922fbe7cb7a8d02","unresolved":false,"context_lines":[{"line_number":594,"context_line":"        \"\"\"Apply qos policy on the vrrp ports which are related with vip.\"\"\""},{"line_number":595,"context_line":"        qos_policy_id \u003d loadbalancer.vip.qos_policy_id"},{"line_number":596,"context_line":"        if not qos_policy_id and ("},{"line_number":597,"context_line":"            isinstance(update_dict, dict) and ("},{"line_number":598,"context_line":"                \u0027vip\u0027 not in update_dict or"},{"line_number":599,"context_line":"                \u0027qos_policy_id\u0027 not in update_dict[\u0027vip\u0027])):"},{"line_number":600,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_9c1ca477","line":597,"range":{"start_line":597,"start_character":12,"end_line":597,"end_character":22},"in_reply_to":"3fa7e38b_946810f4","updated":"2019-11-25 20:50:05.000000000","message":"if not qos_policy_id and (\n    not update_dict or (...\n\n??","commit_id":"32b6c4c40aec3b2e52e6f71172253a7ae87d3a5d"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"fa53eefe28e93fdbf1e665b079c780a4835329e9","unresolved":false,"context_lines":[{"line_number":594,"context_line":"        \"\"\"Apply qos policy on the vrrp ports which are related with vip.\"\"\""},{"line_number":595,"context_line":"        qos_policy_id \u003d loadbalancer.vip.qos_policy_id"},{"line_number":596,"context_line":"        if not qos_policy_id and ("},{"line_number":597,"context_line":"            isinstance(update_dict, dict) and ("},{"line_number":598,"context_line":"                \u0027vip\u0027 not in update_dict or"},{"line_number":599,"context_line":"                \u0027qos_policy_id\u0027 not in update_dict[\u0027vip\u0027])):"},{"line_number":600,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_d4007db4","line":597,"range":{"start_line":597,"start_character":12,"end_line":597,"end_character":22},"in_reply_to":"3fa7e38b_9c1ca477","updated":"2019-11-28 19:19:43.000000000","message":"Done","commit_id":"32b6c4c40aec3b2e52e6f71172253a7ae87d3a5d"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"3b271eeee109a2805ec88ad39aed145ecc47be1c","unresolved":false,"context_lines":[{"line_number":594,"context_line":"        \"\"\"Apply qos policy on the vrrp ports which are related with vip.\"\"\""},{"line_number":595,"context_line":"        qos_policy_id \u003d loadbalancer.vip.qos_policy_id"},{"line_number":596,"context_line":"        if not qos_policy_id and ("},{"line_number":597,"context_line":"            isinstance(update_dict, dict) and ("},{"line_number":598,"context_line":"                \u0027vip\u0027 not in update_dict or"},{"line_number":599,"context_line":"                \u0027qos_policy_id\u0027 not in update_dict[\u0027vip\u0027])):"},{"line_number":600,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_946810f4","line":597,"range":{"start_line":597,"start_character":12,"end_line":597,"end_character":22},"in_reply_to":"3fa7e38b_a655e6fa","updated":"2019-11-22 21:01:36.000000000","message":"Taking the example of setting tags via loadbalancer PUT, update_dict is {}. The problem is bool({}) results in False, and thus _apply_qos_on_vrrp_ports in L601 runs with a LB that has no qos_policy_id set.\n\n\u003e\u003e\u003e bool({})\nFalse\n\u003e\u003e\u003e isinstance({}, dict)\nTrue","commit_id":"32b6c4c40aec3b2e52e6f71172253a7ae87d3a5d"}],"octavia/controller/worker/v2/tasks/network_tasks.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"676ec002ba3dda9fe61ceb896df4c1e88278b607","unresolved":false,"context_lines":[{"line_number":594,"context_line":"        \"\"\"Apply qos policy on the vrrp ports which are related with vip.\"\"\""},{"line_number":595,"context_line":"        qos_policy_id \u003d loadbalancer.vip.qos_policy_id"},{"line_number":596,"context_line":"        if not qos_policy_id and ("},{"line_number":597,"context_line":"            isinstance(update_dict) and ("},{"line_number":598,"context_line":"                \u0027vip\u0027 not in update_dict or"},{"line_number":599,"context_line":"                \u0027qos_policy_id\u0027 not in update_dict[\u0027vip\u0027])):"},{"line_number":600,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_17f3d474","line":597,"updated":"2019-11-21 22:03:36.000000000","message":"No classinfo?\nWhy is this different than the v1 change?","commit_id":"5df77fa69cbfa06531cdf08de0668773b45214e2"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"e83a3738ee6c91e78162ca908d953b91558e2167","unresolved":false,"context_lines":[{"line_number":594,"context_line":"        \"\"\"Apply qos policy on the vrrp ports which are related with vip.\"\"\""},{"line_number":595,"context_line":"        qos_policy_id \u003d loadbalancer.vip.qos_policy_id"},{"line_number":596,"context_line":"        if not qos_policy_id and ("},{"line_number":597,"context_line":"            isinstance(update_dict) and ("},{"line_number":598,"context_line":"                \u0027vip\u0027 not in update_dict or"},{"line_number":599,"context_line":"                \u0027qos_policy_id\u0027 not in update_dict[\u0027vip\u0027])):"},{"line_number":600,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_378e10d1","line":597,"in_reply_to":"3fa7e38b_17f3d474","updated":"2019-11-21 22:05:22.000000000","message":"Done","commit_id":"5df77fa69cbfa06531cdf08de0668773b45214e2"}],"octavia/tests/unit/controller/worker/v2/tasks/test_network_tasks.py":[{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"08149d072de4063f89e1ccd08c96d8b205dfa1d5","unresolved":false,"context_lines":[{"line_number":642,"context_line":"                           \u0027qos_policy_id\u0027: t_constants.MOCK_QOS_POLICY_ID1}}"},{"line_number":643,"context_line":"        tmp_lb.amphorae \u003d AMPS_DATA"},{"line_number":644,"context_line":"        tmp_lb.topology \u003d constants.TOPOLOGY_ACTIVE_STANDBY"},{"line_number":645,"context_line":"        net.execute(tmp_lb, update_dict\u003dupdate_dict)"},{"line_number":646,"context_line":"        mock_driver.apply_qos_on_port.assert_called_with("},{"line_number":647,"context_line":"            t_constants.MOCK_QOS_POLICY_ID1, mock.ANY)"},{"line_number":648,"context_line":"        self.assertEqual(2, mock_driver.apply_qos_on_port.call_count)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_7ff081ca","line":645,"range":{"start_line":645,"start_character":20,"end_line":645,"end_character":26},"updated":"2020-02-26 08:20:01.000000000","message":"should be provider dict","commit_id":"4850654df865e12d776fb5455057869fd459ceb7"}]}