)]}'
{"bin/create_dual_intermediate_CA.sh":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"be3382910dc51e1d7b6e6b0e6c9fe7d739c93190","unresolved":false,"context_lines":[{"line_number":44,"context_line":"echo 1000 \u003e serial"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"# Create the client CA private key"},{"line_number":47,"context_line":"# Note: This uses short key lengths to save entropy in the test gates."},{"line_number":48,"context_line":"#       This is not recommended for deployment use!"},{"line_number":49,"context_line":"openssl genrsa -aes128 -out private/ca.key.pem -passout pass:not-secure-passphrase 2048"},{"line_number":50,"context_line":"chmod 400 private/ca.key.pem"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"3fa7e38b_e4641a50","line":48,"range":{"start_line":47,"start_character":0,"end_line":48,"end_character":51},"updated":"2019-11-26 09:07:56.000000000","message":"This note could be removed now or updated to recommend \u003e\u003d2048.","commit_id":"73943de9f9801f2359ebc961b21a68da7d071ebd"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"ca3dc9abbe2e2dc809ca10dd4536fbceec4b88b0","unresolved":false,"context_lines":[{"line_number":44,"context_line":"echo 1000 \u003e serial"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"# Create the client CA private key"},{"line_number":47,"context_line":"# Note: This uses short key lengths to save entropy in the test gates."},{"line_number":48,"context_line":"#       This is not recommended for deployment use!"},{"line_number":49,"context_line":"openssl genrsa -aes128 -out private/ca.key.pem -passout pass:not-secure-passphrase 2048"},{"line_number":50,"context_line":"chmod 400 private/ca.key.pem"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"3fa7e38b_a72dc490","line":48,"range":{"start_line":47,"start_character":0,"end_line":48,"end_character":51},"in_reply_to":"3fa7e38b_e4641a50","updated":"2019-11-26 09:36:32.000000000","message":"Thanks, I\u0027ve updated comments to reflect the key size changes","commit_id":"73943de9f9801f2359ebc961b21a68da7d071ebd"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"e250f6bc7fd1027eb68f1614808231374eb1221c","unresolved":false,"context_lines":[{"line_number":17,"context_line":"echo \"https://docs.openstack.org/octavia/latest/admin/guides/certificates.html\""},{"line_number":18,"context_line":"echo \"!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# This script should be modified to use stronger encryption (aes256), better"},{"line_number":21,"context_line":"# pass phrases, and longer keys (4096)."},{"line_number":22,"context_line":"# Please see the Octavia Certificate Configuration guide:"},{"line_number":23,"context_line":"# https://docs.openstack.org/octavia/latest/admin/guides/certificates.html"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3fa7e38b_d5141b44","line":20,"range":{"start_line":20,"start_character":2,"end_line":20,"end_character":60},"updated":"2019-11-26 22:07:28.000000000","message":"nit: This is a bit odd wording, in that if this was the case why hasn\u0027t it been modified. Maybe we should say:\n\"This script uses weak security PKI to save testing resources. It should not be used for production deployments.\"\n\nOr something similar.","commit_id":"6b43965b95bf7f84d19dd36c5a7a246da7cf881a"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"76cf7f02fca543bd5988da00c19fc56051d43f4c","unresolved":false,"context_lines":[{"line_number":17,"context_line":"echo \"https://docs.openstack.org/octavia/latest/admin/guides/certificates.html\""},{"line_number":18,"context_line":"echo \"!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# This script should be modified to use stronger encryption (aes256), better"},{"line_number":21,"context_line":"# pass phrases, and longer keys (4096)."},{"line_number":22,"context_line":"# Please see the Octavia Certificate Configuration guide:"},{"line_number":23,"context_line":"# https://docs.openstack.org/octavia/latest/admin/guides/certificates.html"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3fa7e38b_05791e2f","line":20,"range":{"start_line":20,"start_character":2,"end_line":20,"end_character":60},"in_reply_to":"3fa7e38b_d5141b44","updated":"2019-11-27 10:50:48.000000000","message":"I reverted my changes in this paragraph","commit_id":"6b43965b95bf7f84d19dd36c5a7a246da7cf881a"}],"bin/create_single_CA_intermediate_CA.sh":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"e250f6bc7fd1027eb68f1614808231374eb1221c","unresolved":false,"context_lines":[{"line_number":18,"context_line":"echo \"https://docs.openstack.org/octavia/latest/admin/guides/certificates.html\""},{"line_number":19,"context_line":"echo \"!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# This script should be modified to use stronger encryption (aes256), better"},{"line_number":22,"context_line":"# pass phrases, and longer keys (4096)."},{"line_number":23,"context_line":"# It exists purely to test legacy migrations / deployments where someone"},{"line_number":24,"context_line":"# accidently used a single CA."},{"line_number":25,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"3fa7e38b_9528e385","line":22,"range":{"start_line":21,"start_character":2,"end_line":22,"end_character":39},"updated":"2019-11-26 22:07:28.000000000","message":"nit: same comment here about the wording.","commit_id":"6b43965b95bf7f84d19dd36c5a7a246da7cf881a"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"76cf7f02fca543bd5988da00c19fc56051d43f4c","unresolved":false,"context_lines":[{"line_number":18,"context_line":"echo \"https://docs.openstack.org/octavia/latest/admin/guides/certificates.html\""},{"line_number":19,"context_line":"echo \"!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# This script should be modified to use stronger encryption (aes256), better"},{"line_number":22,"context_line":"# pass phrases, and longer keys (4096)."},{"line_number":23,"context_line":"# It exists purely to test legacy migrations / deployments where someone"},{"line_number":24,"context_line":"# accidently used a single CA."},{"line_number":25,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"3fa7e38b_c572264b","line":22,"range":{"start_line":21,"start_character":2,"end_line":22,"end_character":39},"in_reply_to":"3fa7e38b_9528e385","updated":"2019-11-27 10:50:48.000000000","message":"same here","commit_id":"6b43965b95bf7f84d19dd36c5a7a246da7cf881a"}]}
