)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"eaf2e5d9653a9016fcd8023ea044ee9185117e9e","unresolved":false,"context_lines":[{"line_number":10,"context_line":"good to get info about mapping pair loadbalancer-amphora as"},{"line_number":11,"context_line":"soon as possible."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"For example, if admin needs to debug connectivity issues with amphora"},{"line_number":14,"context_line":"VMs - loadbalancer_id won\u0027t be set until AmphoraComputeConnectivityWait"},{"line_number":15,"context_line":"task succeeds (which is never for such case) so they have to go to worker"},{"line_number":16,"context_line":"logs to understand which amphora is related to a currently creating"},{"line_number":17,"context_line":"loadbalancer."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Co-Authored-By: Ann Taraday \u003cakamyshnikova@mirantis.com\u003e"},{"line_number":20,"context_line":"Change-Id: I865445af34bc63b90d965ef5e2c8f9f49aa9c2f3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3fa7e38b_af0b2721","line":17,"range":{"start_line":13,"start_character":0,"end_line":17,"end_character":13},"updated":"2020-02-03 19:10:34.000000000","message":"I don\u0027t follow this. If the LB create flow reverts, the amphora record will be deleted on cleanup, so the LB ID will be lost anyway.\nhttps://github.com/openstack/octavia/blob/master/octavia/controller/worker/v1/tasks/database_tasks.py#L129","commit_id":"005cd1e6a63f226285486a8287ec523e1d73a7ff"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"971a7be78b33a3f793bccf6c6b30fec0a0b69a86","unresolved":false,"context_lines":[{"line_number":10,"context_line":"good to get info about mapping pair loadbalancer-amphora as"},{"line_number":11,"context_line":"soon as possible."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"For example, if admin needs to debug connectivity issues with amphora"},{"line_number":14,"context_line":"VMs - loadbalancer_id won\u0027t be set until AmphoraComputeConnectivityWait"},{"line_number":15,"context_line":"task succeeds (which is never for such case) so they have to go to worker"},{"line_number":16,"context_line":"logs to understand which amphora is related to a currently creating"},{"line_number":17,"context_line":"loadbalancer."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Co-Authored-By: Ann Taraday \u003cakamyshnikova@mirantis.com\u003e"},{"line_number":20,"context_line":"Change-Id: I865445af34bc63b90d965ef5e2c8f9f49aa9c2f3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3fa7e38b_cf31c3f0","line":17,"range":{"start_line":13,"start_character":0,"end_line":17,"end_character":13},"in_reply_to":"3fa7e38b_af0b2721","updated":"2020-02-03 19:14:50.000000000","message":"Usually while debugging stuff like this, we have revert disabled, though it is also useful during the large number of minutes that the amp is still trying to boot during retries.","commit_id":"005cd1e6a63f226285486a8287ec523e1d73a7ff"}],"octavia/controller/worker/v1/tasks/database_tasks.py":[{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"e34709f0e09f46dd58d26ec929ebd3efd62e882f","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        amphora \u003d self.amphora_repo.create(db_apis.get_session(),"},{"line_number":99,"context_line":"                                           id\u003duuidutils.generate_uuid(),"},{"line_number":100,"context_line":"                                           loadbalancer_id\u003dloadbalancer_id,"},{"line_number":101,"context_line":"                                           status\u003dconstants.PENDING_CREATE,"},{"line_number":102,"context_line":"                                           cert_busy\u003dFalse)"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_8292d29f","line":100,"range":{"start_line":100,"start_character":43,"end_line":100,"end_character":58},"updated":"2019-12-17 13:59:36.000000000","message":"load_balancer_id","commit_id":"16ac9254f3bce9217f9dd404aa013b548af2ff88"}],"releasenotes/notes/link-amphora-to-loadbalancer-earlier-ab3dddec48b8da96.yaml":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"eaf2e5d9653a9016fcd8023ea044ee9185117e9e","unresolved":false,"context_lines":[{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Amphorae that are booting for a specific loadbalancer will now be linked to"},{"line_number":5,"context_line":"    that loadbalancer immediately upon creation. Previously this would not"},{"line_number":6,"context_line":"    happen until near the end of the process, leaving a gap during booting"},{"line_number":7,"context_line":"    during which is was difficult to understand which booting amphora belonged"},{"line_number":8,"context_line":"    to which loadbalancer. This was especially problematic when attempting to"},{"line_number":9,"context_line":"    troubleshoot loadbalancers that entered ERROR status due to boot issues."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3fa7e38b_54bc866a","line":6,"range":{"start_line":5,"start_character":49,"end_line":6,"end_character":44},"updated":"2020-02-03 19:10:34.000000000","message":"It really wasn\u0027t the end of the process, it was just seven steps farther down the flow where we associate the booted amphora to the load balancer and mark the amphora as \"allocated\".\nBasically, before this, we made sure the amphora was functional prior to tying it to the load balancer.\nhttps://docs.openstack.org/octavia/latest/_images/LoadBalancerFlows-get_create_load_balancer_flow.svg","commit_id":"005cd1e6a63f226285486a8287ec523e1d73a7ff"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"03f888c0f8c2ed94aefc3345239be982e0cbc088","unresolved":false,"context_lines":[{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Amphorae that are booting for a specific loadbalancer will now be linked to"},{"line_number":5,"context_line":"    that loadbalancer immediately upon creation. Previously this would not"},{"line_number":6,"context_line":"    happen until near the end of the process, leaving a gap during booting"},{"line_number":7,"context_line":"    during which is was difficult to understand which booting amphora belonged"},{"line_number":8,"context_line":"    to which loadbalancer. This was especially problematic when attempting to"},{"line_number":9,"context_line":"    troubleshoot loadbalancers that entered ERROR status due to boot issues."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3fa7e38b_efeb5f0e","line":6,"range":{"start_line":5,"start_character":49,"end_line":6,"end_character":44},"in_reply_to":"3fa7e38b_4f4b935d","updated":"2020-02-03 20:33:34.000000000","message":"There are still 25 more steps in that flow, so, really it\u0027s at the beginning of the process. I guess we agree to disagree on this one.","commit_id":"005cd1e6a63f226285486a8287ec523e1d73a7ff"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"971a7be78b33a3f793bccf6c6b30fec0a0b69a86","unresolved":false,"context_lines":[{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Amphorae that are booting for a specific loadbalancer will now be linked to"},{"line_number":5,"context_line":"    that loadbalancer immediately upon creation. Previously this would not"},{"line_number":6,"context_line":"    happen until near the end of the process, leaving a gap during booting"},{"line_number":7,"context_line":"    during which is was difficult to understand which booting amphora belonged"},{"line_number":8,"context_line":"    to which loadbalancer. This was especially problematic when attempting to"},{"line_number":9,"context_line":"    troubleshoot loadbalancers that entered ERROR status due to boot issues."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3fa7e38b_4f4b935d","line":6,"range":{"start_line":5,"start_character":49,"end_line":6,"end_character":44},"in_reply_to":"3fa7e38b_54bc866a","updated":"2020-02-03 19:14:50.000000000","message":"Timing-wise, that\u0027s essentially the end of the process.\nI would argue that the amphora still *belongs* to the loadbalancer during the create process, even if it\u0027s not ready yet (or even if it fails).","commit_id":"005cd1e6a63f226285486a8287ec523e1d73a7ff"}]}