)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"7de3e36e827d67bc26859f425c2af77e64bae656","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"75cc63e6_8d1133f4","updated":"2022-03-16 13:00:05.000000000","message":"from the octavia-v2-dsvm-scenario-haproxy-latest logs:\n\nMar 16 11:23:48.326335 nested-virt-centos-8-stream-ovh-bhs1-0028853478 octavia-worker[174723]: DEBUG octavia.controller.worker.v2.tasks.amphora_driver_tasks [-] Successfuly connected to amphora 7aaef793-6e87-4391-a03a-a0d9804a6d91: {\u0027hostname\u0027: \u0027amphora-7aaef793-6e87-4391-a03a-a0d9804a6d91.novalocal\u0027, \u0027haproxy_version\u0027: \u00272.5.5\u0027, \u0027api_version\u0027: \u00271.0\u0027, \u0027keepalived_version\u0027: \u00272.1.5\u0027, \u0027ipvsadm_version\u0027: \u00271.31\u0027} {{(pid\u003d174723) execute /opt/stack/octavia/octavia/controller/worker/v2/tasks/amphora_driver_tasks.py:555}}","commit_id":"ebecda0fba898018005308f819e836a96015cda2"}],"diskimage-create/README.rst":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"7ec63b252b3195301905cfc5708c73a62d5fdae1","unresolved":true,"context_lines":[{"line_number":259,"context_line":""},{"line_number":260,"context_line":"DIB_HAPROXY_SOURCE_OCTAVIA_HAPROXY_VERSION"},{"line_number":261,"context_line":"    - HAproxy version to use with haproxy-source backend"},{"line_number":262,"context_line":"    - Default: 2.2.1"},{"line_number":263,"context_line":"    - Example: 2.3-dev1"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"Using distribution packages for amphora agent"}],"source_content_type":"text/x-rst","patch_set":5,"id":"f5898f6a_dc355b45","line":262,"range":{"start_line":262,"start_character":15,"end_line":262,"end_character":20},"updated":"2021-01-04 09:04:45.000000000","message":"nit (no need to update change just for this): should we set default to a newer minor release (2.2.6 as of today)?","commit_id":"c83f42adc8c0e0baedd82bfdc8d0ed5b309a9e12"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"d77aa99742c6494282f9a45adc36104ba5f99157","unresolved":false,"context_lines":[{"line_number":259,"context_line":""},{"line_number":260,"context_line":"DIB_HAPROXY_SOURCE_OCTAVIA_HAPROXY_VERSION"},{"line_number":261,"context_line":"    - HAproxy version to use with haproxy-source backend"},{"line_number":262,"context_line":"    - Default: 2.2.1"},{"line_number":263,"context_line":"    - Example: 2.3-dev1"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"Using distribution packages for amphora agent"}],"source_content_type":"text/x-rst","patch_set":5,"id":"39e169e7_017bdb39","line":262,"range":{"start_line":262,"start_character":15,"end_line":262,"end_character":20},"in_reply_to":"f5898f6a_dc355b45","updated":"2021-01-28 11:17:57.000000000","message":"Done","commit_id":"c83f42adc8c0e0baedd82bfdc8d0ed5b309a9e12"}],"elements/haproxy-source-octavia/post-install.d/20-haproxy-tune-kernel":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"7ec63b252b3195301905cfc5708c73a62d5fdae1","unresolved":true,"context_lines":[{"line_number":17,"context_line":"sysctl-write-value fs.nr_open 2097152"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# It\u0027s ok for these to fail if conntrack module isn\u0027t loaded"},{"line_number":20,"context_line":"sysctl-write-value net.netfilter.nf_conntrack_buckets 125000 || true"},{"line_number":21,"context_line":"sysctl-write-value net.ipv4.netfilter.ip_conntrack_tcp_timeout_time_wait 5 || true"},{"line_number":22,"context_line":"sysctl-write-value net.ipv4.netfilter.ip_conntrack_tcp_timeout_fin_wait 5 || true"},{"line_number":23,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"2a4868f0_b4f31d61","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":68},"updated":"2021-01-04 09:04:45.000000000","message":"I think this line needs to be removed according to https://github.com/openstack/octavia/commit/64a301d4ec85a1bc9b208e60d7958a89e6972976#diff-076d931a02f39badc419d9c772344fe8404ab77952f572672d30c51a545fed58","commit_id":"c83f42adc8c0e0baedd82bfdc8d0ed5b309a9e12"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"d77aa99742c6494282f9a45adc36104ba5f99157","unresolved":false,"context_lines":[{"line_number":17,"context_line":"sysctl-write-value fs.nr_open 2097152"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# It\u0027s ok for these to fail if conntrack module isn\u0027t loaded"},{"line_number":20,"context_line":"sysctl-write-value net.netfilter.nf_conntrack_buckets 125000 || true"},{"line_number":21,"context_line":"sysctl-write-value net.ipv4.netfilter.ip_conntrack_tcp_timeout_time_wait 5 || true"},{"line_number":22,"context_line":"sysctl-write-value net.ipv4.netfilter.ip_conntrack_tcp_timeout_fin_wait 5 || true"},{"line_number":23,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"c2b2eb4e_87564986","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":68},"in_reply_to":"28296055_fcb4c355","updated":"2021-01-28 11:17:57.000000000","message":"thanks, I also removed tcp_tw_recycle and renamed some ip_conntrack_* stuff","commit_id":"c83f42adc8c0e0baedd82bfdc8d0ed5b309a9e12"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"05a15756eb5500c1f060206e5e116e8f15350778","unresolved":true,"context_lines":[{"line_number":17,"context_line":"sysctl-write-value fs.nr_open 2097152"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# It\u0027s ok for these to fail if conntrack module isn\u0027t loaded"},{"line_number":20,"context_line":"sysctl-write-value net.netfilter.nf_conntrack_buckets 125000 || true"},{"line_number":21,"context_line":"sysctl-write-value net.ipv4.netfilter.ip_conntrack_tcp_timeout_time_wait 5 || true"},{"line_number":22,"context_line":"sysctl-write-value net.ipv4.netfilter.ip_conntrack_tcp_timeout_fin_wait 5 || true"},{"line_number":23,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"28296055_fcb4c355","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":68},"in_reply_to":"2a4868f0_b4f31d61","updated":"2021-01-28 11:02:37.000000000","message":"Ah yes, this too.","commit_id":"c83f42adc8c0e0baedd82bfdc8d0ed5b309a9e12"}],"elements/haproxy-source-octavia/post-install.d/21-create-ping-wrapper":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"05a15756eb5500c1f060206e5e116e8f15350778","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"# Copyright 2017 Rackspace, US Inc."},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"a0e544cc_e79c2dd1","line":1,"updated":"2021-01-28 11:02:37.000000000","message":"We still need a ping wrapper? Didn\u0027t I kill off the PING type healthcheck? T_T","commit_id":"c83f42adc8c0e0baedd82bfdc8d0ed5b309a9e12"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3b6af11acf5c106c356ccca0898d8f5e72fbe966","unresolved":true,"context_lines":[{"line_number":18,"context_line":"set -o pipefail"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"ping_cmd\u003d$(command -v ping)"},{"line_number":21,"context_line":"ping6_cmd\u003d$(command -v ping6)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"cat \u003e /var/lib/octavia/ping-wrapper.sh \u003c\u003cEOF"},{"line_number":24,"context_line":"#!/bin/bash"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"b128d53e_934ad0ec","line":21,"updated":"2021-01-29 14:54:21.000000000","message":"Most new distros have an iputils-ping in which ping supports IPv6 addresses, I wonder when we can drop this?\n\n--\u003e ping ::1\nPING ::1(::1) 56 data bytes\n64 bytes from ::1: icmp_seq\u003d1 ttl\u003d64 time\u003d0.077 ms","commit_id":"c5f736f836d0b681dff9c5a7b6f83a43b796e393"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"88989cdeffdc67f4937411d6595704316817a85f","unresolved":true,"context_lines":[{"line_number":18,"context_line":"set -o pipefail"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"ping_cmd\u003d$(command -v ping)"},{"line_number":21,"context_line":"ping6_cmd\u003d$(command -v ping6)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"cat \u003e /var/lib/octavia/ping-wrapper.sh \u003c\u003cEOF"},{"line_number":24,"context_line":"#!/bin/bash"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"9855bf76_83c4c933","line":21,"in_reply_to":"b128d53e_934ad0ec","updated":"2021-01-29 14:59:08.000000000","message":"shame on me, this file is a copy of the very same file in elements/haproxy-octavia/... element :/\nperhaps we could remove both file later (PING health checks are not really useful)","commit_id":"c5f736f836d0b681dff9c5a7b6f83a43b796e393"}],"octavia/amphorae/backends/agent/api_server/amphora_info.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"5e419ea9958fa00bfb7eb26295f85e5ce8e7f6b7","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        try:"},{"line_number":100,"context_line":"            cmd \u003d self._osutils.cmd_get_version_of_installed_package(name)"},{"line_number":101,"context_line":"            version \u003d subprocess.check_output(cmd.split())"},{"line_number":102,"context_line":"        except subprocess.CalledProcessError as e:"},{"line_number":103,"context_line":"            version \u003d self._osutils.get_version_of_source_package(name)"},{"line_number":104,"context_line":"        return version"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_da71a4aa","line":102,"updated":"2020-07-24 13:05:26.000000000","message":"pep8: F841 local variable \u0027e\u0027 is assigned to but never used","commit_id":"d48cff74da65baee8d6cb4a417ff9da71cdc40bf"}]}