)]}'
{"lower-constraints.txt":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"e38ffc1f181ded62e477f4c68be8c81910072d61","unresolved":false,"context_lines":[{"line_number":114,"context_line":"pyflakes\u003d\u003d1.0.0"},{"line_number":115,"context_line":"Pygments\u003d\u003d2.2.0"},{"line_number":116,"context_line":"pyinotify\u003d\u003d0.9.6"},{"line_number":117,"context_line":"pylint\u003d\u003d1.9.2"},{"line_number":118,"context_line":"PyMySQL\u003d\u003d0.7.6"},{"line_number":119,"context_line":"PyNaCl\u003d\u003d1.2.1"},{"line_number":120,"context_line":"pyOpenSSL\u003d\u003d17.1.0"}],"source_content_type":"text/plain","patch_set":5,"id":"1fa4df85_dbdc2048","line":117,"updated":"2020-02-26 16:49:50.000000000","message":"Shouldn\u0027t this be bumped to 2.2.0 given the test-requirements.txt rule of \u003e\u003d2.2.0?","commit_id":"d592783b5b618fc4b7b20756b9f3063016d80643"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"f036769b91eee0bd9a1641b56edbb5d5e872d8cc","unresolved":false,"context_lines":[{"line_number":114,"context_line":"pyflakes\u003d\u003d1.0.0"},{"line_number":115,"context_line":"Pygments\u003d\u003d2.2.0"},{"line_number":116,"context_line":"pyinotify\u003d\u003d0.9.6"},{"line_number":117,"context_line":"pylint\u003d\u003d1.9.2"},{"line_number":118,"context_line":"PyMySQL\u003d\u003d0.7.6"},{"line_number":119,"context_line":"PyNaCl\u003d\u003d1.2.1"},{"line_number":120,"context_line":"pyOpenSSL\u003d\u003d17.1.0"}],"source_content_type":"text/plain","patch_set":5,"id":"1fa4df85_f626d3b7","line":117,"in_reply_to":"1fa4df85_dbdc2048","updated":"2020-02-26 17:17:30.000000000","message":"Honestly I don\u0027t really get the point of this lower-constraints file much with regards to *testing* libs... This is supposed to be for intercompat with other projects? But normally people run these in venvs these days anyway? And for testing, I doubt lower-constraints are going to come into play? I dunno, I just can\u0027t really make myself care a whole lot about trying to manually keep this file up to date.","commit_id":"d592783b5b618fc4b7b20756b9f3063016d80643"}],"octavia/api/common/pagination.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"e38ffc1f181ded62e477f4c68be8c81910072d61","unresolved":false,"context_lines":[{"line_number":346,"context_line":"                            model_attr.property.columns[0].type)"},{"line_number":347,"context_line":"                        attr \u003d sa_sql.expression.case("},{"line_number":348,"context_line":"                            # pylint: disable\u003dsingleton-comparison"},{"line_number":349,"context_line":"                            [(model_attr !\u003d None,  # noqa E711"},{"line_number":350,"context_line":"                              model_attr), ], else_\u003ddefault)"},{"line_number":351,"context_line":"                        crit_attrs.append((attr \u003d\u003d marker_values[j]))"},{"line_number":352,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_9bf8e8c4","line":349,"updated":"2020-02-26 16:49:50.000000000","message":"We should probably just change this to \"is not\"","commit_id":"d592783b5b618fc4b7b20756b9f3063016d80643"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"f036769b91eee0bd9a1641b56edbb5d5e872d8cc","unresolved":false,"context_lines":[{"line_number":346,"context_line":"                            model_attr.property.columns[0].type)"},{"line_number":347,"context_line":"                        attr \u003d sa_sql.expression.case("},{"line_number":348,"context_line":"                            # pylint: disable\u003dsingleton-comparison"},{"line_number":349,"context_line":"                            [(model_attr !\u003d None,  # noqa E711"},{"line_number":350,"context_line":"                              model_attr), ], else_\u003ddefault)"},{"line_number":351,"context_line":"                        crit_attrs.append((attr \u003d\u003d marker_values[j]))"},{"line_number":352,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_96699fbf","line":349,"in_reply_to":"1fa4df85_9bf8e8c4","updated":"2020-02-26 17:17:30.000000000","message":"LOL is that actually the error we\u0027re ignoring? :D\n... yes, why did we even ignore this to begin with? I was assuming this was a real issue \u003e_\u003c","commit_id":"d592783b5b618fc4b7b20756b9f3063016d80643"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8c387e99313fc21b513c1d726a88430613bcc5d4","unresolved":false,"context_lines":[{"line_number":346,"context_line":"                            model_attr.property.columns[0].type)"},{"line_number":347,"context_line":"                        attr \u003d sa_sql.expression.case("},{"line_number":348,"context_line":"                            # pylint: disable\u003dsingleton-comparison"},{"line_number":349,"context_line":"                            [(model_attr !\u003d None,  # noqa E711"},{"line_number":350,"context_line":"                              model_attr), ], else_\u003ddefault)"},{"line_number":351,"context_line":"                        crit_attrs.append((attr \u003d\u003d marker_values[j]))"},{"line_number":352,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1fa4df85_e7713fe2","line":349,"updated":"2020-02-26 21:22:11.000000000","message":"sqlalchemy doesn\u0027t allow this to be \"model_attr is not None\" since that\u0027s Python :-p\n\nThe only other possibility is \"model_attr.isnot(None)\" but I don\u0027t want to change that in this change since it\u0027s only fixing flake8 issues.","commit_id":"26dff0ea8b684f08b4b885672140a2ab25c7bddf"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1b1de46c14aec20cb5449d6334d431187bf9888d","unresolved":false,"context_lines":[{"line_number":346,"context_line":"                            model_attr.property.columns[0].type)"},{"line_number":347,"context_line":"                        attr \u003d sa_sql.expression.case("},{"line_number":348,"context_line":"                            # pylint: disable\u003dsingleton-comparison"},{"line_number":349,"context_line":"                            [(model_attr !\u003d None,  # noqa E711"},{"line_number":350,"context_line":"                              model_attr), ], else_\u003ddefault)"},{"line_number":351,"context_line":"                        crit_attrs.append((attr \u003d\u003d marker_values[j]))"},{"line_number":352,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1fa4df85_b7060b86","line":349,"in_reply_to":"1fa4df85_e7713fe2","updated":"2020-02-27 14:19:58.000000000","message":"And amazingly the other patch worked, let me know if you want me to roll that small change into here.\n\nhttps://review.opendev.org/#/c/710144/","commit_id":"26dff0ea8b684f08b4b885672140a2ab25c7bddf"}],"test-requirements.txt":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"5693b27067c2280a70aab7d3a600bd2a643279e5","unresolved":false,"context_lines":[{"line_number":10,"context_line":"mock\u003e\u003d2.0.0 # BSD"},{"line_number":11,"context_line":"python-subunit\u003e\u003d1.0.0 # Apache-2.0/BSD"},{"line_number":12,"context_line":"oslotest\u003e\u003d3.2.0 # Apache-2.0"},{"line_number":13,"context_line":"astroid\u003e\u003d2.1.0;python_version\u003e\u003d\u00273.0\u0027 # LGPLv2.1"},{"line_number":14,"context_line":"pylint\u003e\u003d2.2.0;python_version\u003e\u003d\u00273.0\u0027 # GPLv2"},{"line_number":15,"context_line":"testrepository\u003e\u003d0.0.18 # Apache-2.0/BSD"},{"line_number":16,"context_line":"testtools\u003e\u003d2.2.0 # MIT"}],"source_content_type":"text/plain","patch_set":3,"id":"3fa7e38b_e5a454ba","line":13,"updated":"2020-01-07 17:56:46.000000000","message":"Why do we need to add these? Shouldn\u0027t these come in as dependencies?\nI don\u0027t see us importing these anywhere in our test code.","commit_id":"4cc0873d3ac0543b011c4c8096add0d23707c9b5"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"80818fb9ebbd7ea2a5c5a8a75601b8cb06d70362","unresolved":false,"context_lines":[{"line_number":10,"context_line":"mock\u003e\u003d2.0.0 # BSD"},{"line_number":11,"context_line":"python-subunit\u003e\u003d1.0.0 # Apache-2.0/BSD"},{"line_number":12,"context_line":"oslotest\u003e\u003d3.2.0 # Apache-2.0"},{"line_number":13,"context_line":"astroid\u003e\u003d2.1.0;python_version\u003e\u003d\u00273.0\u0027 # LGPLv2.1"},{"line_number":14,"context_line":"pylint\u003e\u003d2.2.0;python_version\u003e\u003d\u00273.0\u0027 # GPLv2"},{"line_number":15,"context_line":"testrepository\u003e\u003d0.0.18 # Apache-2.0/BSD"},{"line_number":16,"context_line":"testtools\u003e\u003d2.2.0 # MIT"}],"source_content_type":"text/plain","patch_set":3,"id":"3fa7e38b_103e8c89","line":13,"in_reply_to":"3fa7e38b_e5a454ba","updated":"2020-01-07 18:52:48.000000000","message":"Because the cool kids are doing it? :)\n\nI based this on the neutron change which actually uses pycodestyle, so just an oversight, will remove them since things work without them and we are setting things in lower-contraints.txt.","commit_id":"4cc0873d3ac0543b011c4c8096add0d23707c9b5"}]}
