)]}'
{"octavia/common/validate.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b3e85ed6333c34c102c725335464ce4b6843b316","unresolved":false,"context_lines":[{"line_number":380,"context_line":"    if CONF.networking.valid_vip_networks and not valid_networks:"},{"line_number":381,"context_line":"        valid_networks \u003d CONF.networking.valid_vip_networks"},{"line_number":382,"context_line":"    if valid_networks:"},{"line_number":383,"context_line":"        valid_networks \u003d map(str.lower, valid_networks)"},{"line_number":384,"context_line":"        if network_id not in valid_networks:"},{"line_number":385,"context_line":"            raise exceptions.ValidationException(detail\u003d_("},{"line_number":386,"context_line":"                \u0027Supplied VIP network_id is not allowed by the configuration \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_cc8d47d5","line":383,"updated":"2019-12-18 17:45:18.000000000","message":"maybe you need to str.lower the network_id as well?","commit_id":"a524fc3f8a211a44e9ca6a24c2fed4c4ad1a6e92"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"82ed5977c7cd72a05c34715889ea7bd9ad102cf2","unresolved":false,"context_lines":[{"line_number":380,"context_line":"    if CONF.networking.valid_vip_networks and not valid_networks:"},{"line_number":381,"context_line":"        valid_networks \u003d CONF.networking.valid_vip_networks"},{"line_number":382,"context_line":"    if valid_networks:"},{"line_number":383,"context_line":"        valid_networks \u003d map(str.lower, valid_networks)"},{"line_number":384,"context_line":"        if network_id not in valid_networks:"},{"line_number":385,"context_line":"            raise exceptions.ValidationException(detail\u003d_("},{"line_number":386,"context_line":"                \u0027Supplied VIP network_id is not allowed by the configuration \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_9247647b","line":383,"in_reply_to":"3fa7e38b_cc8d47d5","updated":"2019-12-18 18:55:40.000000000","message":"not a bad idea, i think the assumption was that somehow it comes in as lowercase already, but assumptions are not great :D","commit_id":"a524fc3f8a211a44e9ca6a24c2fed4c4ad1a6e92"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"78e337fa5cb294828c748446938ceecd08d7948e","unresolved":false,"context_lines":[{"line_number":379,"context_line":"def network_allowed_by_config(network_id, valid_networks\u003dNone):"},{"line_number":380,"context_line":"    if CONF.networking.valid_vip_networks and not valid_networks:"},{"line_number":381,"context_line":"        valid_networks \u003d CONF.networking.valid_vip_networks"},{"line_number":382,"context_line":"    if valid_networks:"},{"line_number":383,"context_line":"        valid_networks \u003d map(str.lower, valid_networks)"},{"line_number":384,"context_line":"        if network_id.lower() not in valid_networks:"},{"line_number":385,"context_line":"            raise exceptions.ValidationException(detail\u003d_("}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_14b04edc","line":382,"updated":"2020-02-03 18:44:05.000000000","message":"Somewhere we need to document that this is an override and not an (CONF.networking.valid_vip_networks AND valid_networks).","commit_id":"cf3878342dc0b3e1321b1155d635fa88fe2444c6"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"bac801557691ed2db54c10cb016d19c22fad6d9e","unresolved":false,"context_lines":[{"line_number":379,"context_line":"def network_allowed_by_config(network_id, valid_networks\u003dNone):"},{"line_number":380,"context_line":"    if CONF.networking.valid_vip_networks and not valid_networks:"},{"line_number":381,"context_line":"        valid_networks \u003d CONF.networking.valid_vip_networks"},{"line_number":382,"context_line":"    if valid_networks:"},{"line_number":383,"context_line":"        valid_networks \u003d map(str.lower, valid_networks)"},{"line_number":384,"context_line":"        if network_id.lower() not in valid_networks:"},{"line_number":385,"context_line":"            raise exceptions.ValidationException(detail\u003d_("}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_f43ed2e1","line":382,"in_reply_to":"3fa7e38b_14b04edc","updated":"2020-02-03 19:09:17.000000000","message":"Done","commit_id":"cf3878342dc0b3e1321b1155d635fa88fe2444c6"}]}