)]}'
{"diskimage-create/diskimage-create.sh":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5d98edbbcb95cfee57a8651e270b8c9504b2b05e","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        i)"},{"line_number":128,"context_line":"            AMP_BASEOS\u003d$OPTARG"},{"line_number":129,"context_line":"            if [ $AMP_BASEOS !\u003d \"ubuntu\" ] \u0026\u0026 \\"},{"line_number":130,"context_line":"                [ $AMP_BASEOS !\u003d \"ubuntu-minimal\" ] \u0026\u0026 \\"},{"line_number":131,"context_line":"                [ $AMP_BASEOS !\u003d \"fedora\" ] \u0026\u0026 \\"},{"line_number":132,"context_line":"                [ $AMP_BASEOS !\u003d \"centos\" ] \u0026\u0026 \\"},{"line_number":133,"context_line":"                [ $AMP_BASEOS !\u003d \"centos-minimal\" ] \u0026\u0026 \\"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3fa7e38b_ed17cbee","line":130,"updated":"2019-12-19 19:14:29.000000000","message":"Do you need a debian check here as well?  i.e. is this called with \u0027-i debian\u0027 ?  if so here and L30 need updates.","commit_id":"8d2af086afb844f88f9b5333ac8e3f344ce08656"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"8d919ce32d9b2b85ea3a0d14650fe140ffe9c2af","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        i)"},{"line_number":128,"context_line":"            AMP_BASEOS\u003d$OPTARG"},{"line_number":129,"context_line":"            if [ $AMP_BASEOS !\u003d \"ubuntu\" ] \u0026\u0026 \\"},{"line_number":130,"context_line":"                [ $AMP_BASEOS !\u003d \"ubuntu-minimal\" ] \u0026\u0026 \\"},{"line_number":131,"context_line":"                [ $AMP_BASEOS !\u003d \"fedora\" ] \u0026\u0026 \\"},{"line_number":132,"context_line":"                [ $AMP_BASEOS !\u003d \"centos\" ] \u0026\u0026 \\"},{"line_number":133,"context_line":"                [ $AMP_BASEOS !\u003d \"centos-minimal\" ] \u0026\u0026 \\"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3fa7e38b_73c7113f","line":130,"in_reply_to":"3fa7e38b_ed17cbee","updated":"2019-12-25 10:43:29.000000000","message":"No, i don\u0027t need check for AMP_BASEOS, this patch is fixing only build on debian which is now failing, not adding support for Debian BASEOS. \n\nWhat currently not working on debian : \n\n(venv) root@openstack-controller:~/octavia/diskimage-create# ./diskimage-create.sh \n./diskimage-create.sh: line 366: rpm: command not found\nRequired package  qemu-img  is not installed.  Exiting.\nBinary dependencies on this platform are: qemu-img* git\n(venv) root@openstack-controller:~/octavia/diskimage-create# cat /etc/os-release | grep NAME\nPRETTY_NAME\u003d\"Debian GNU/Linux 10 (buster)\"\nNAME\u003d\"Debian GNU/Linux\"\nVERSION_CODENAME\u003dbuster","commit_id":"8d2af086afb844f88f9b5333ac8e3f344ce08656"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"43ab7c2ac7320a3381841c38231e97f61b207112","unresolved":false,"context_lines":[{"line_number":318,"context_line":"    done"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"    if [[ \"$platform\" \u003d \u0027Ubuntu\u0027 ]]; then"},{"line_number":321,"context_line":"        # Also check if we can build the BASEOS on this Ubuntu version"},{"line_number":322,"context_line":"        UBUNTU_VERSION\u003d`lsb_release -r | awk \u0027{print $2}\u0027`"},{"line_number":323,"context_line":"        if [ \"$AMP_BASEOS\" !\u003d \"ubuntu-minimal\" ] \u0026\u0026 \\"},{"line_number":324,"context_line":"            [ 1 -eq $(echo \"$UBUNTU_VERSION \u003c 14.04\" | bc) ]; then"},{"line_number":325,"context_line":"                echo \"Ubuntu minimum version 14.04 required to build $AMP_BASEOS.\""},{"line_number":326,"context_line":"                echo \"Earlier versions don\u0027t support the extended attributes required.\""}],"source_content_type":"text/x-sh","patch_set":3,"id":"3fa7e38b_7e4fa368","line":323,"range":{"start_line":321,"start_character":1,"end_line":323,"end_character":48},"updated":"2020-01-06 19:01:30.000000000","message":"I think these three lines could have been deduped as \"DEBUNTU_VERSION\", but it\u0027s honestly not a huge deal.","commit_id":"7f929bab966c44334ae6374becde189f74fc5ec0"}]}