)]}'
{"octavia/tests/unit/certificates/manager/test_barbican_legacy.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"7583fd9aee08ef878d97fb0a780f782ca5f14abd","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        self.secret1 \u003d mock.Mock(spec\u003ddir(secrets.Secret))"},{"line_number":82,"context_line":"        self.secret2 \u003d mock.Mock(spec\u003ddir(secrets.Secret))"},{"line_number":83,"context_line":"        self.secret3 \u003d mock.Mock(spec\u003ddir(secrets.Secret))"},{"line_number":84,"context_line":"        self.secret4 \u003d mock.Mock(spec\u003ddir(secrets.Secret))"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        # Mock out the client"},{"line_number":87,"context_line":"        self.bc \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_440ac378","line":84,"updated":"2020-02-17 20:18:55.000000000","message":"Why isn\u0027t test_barbican.py failing in the same way?  And codesearch didn\u0027t show anyone else using dir() with the Secret class.","commit_id":"dcb383c6af0a612efd3327c2fcb3da7e0b390206"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"99d8861bb7d261b29487fc0c95d169d2e27386b3","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        self.secret1 \u003d mock.Mock(spec\u003ddir(secrets.Secret))"},{"line_number":82,"context_line":"        self.secret2 \u003d mock.Mock(spec\u003ddir(secrets.Secret))"},{"line_number":83,"context_line":"        self.secret3 \u003d mock.Mock(spec\u003ddir(secrets.Secret))"},{"line_number":84,"context_line":"        self.secret4 \u003d mock.Mock(spec\u003ddir(secrets.Secret))"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        # Mock out the client"},{"line_number":87,"context_line":"        self.bc \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_5f24cc5f","line":84,"in_reply_to":"3fa7e38b_440ac378","updated":"2020-02-17 20:46:41.000000000","message":"Well, for the first question, it\u0027s not \"legacy\" so it\u0027s using the new barbicanManager interfaces to the barbican client.\nhttps://github.com/openstack/octavia/blob/master/octavia/tests/unit/certificates/manager/test_barbican.py#L59\n\nFrankly, mock should be (and probably was) doing the \"dir()\" for us, but I couldn\u0027t trace it back to which change in mock triggered this.","commit_id":"dcb383c6af0a612efd3327c2fcb3da7e0b390206"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"1d18ec0dedc1a2dfe0b5312dec3f4107a700d341","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        self.secret1 \u003d mock.Mock(spec\u003ddir(secrets.Secret))"},{"line_number":82,"context_line":"        self.secret2 \u003d mock.Mock(spec\u003ddir(secrets.Secret))"},{"line_number":83,"context_line":"        self.secret3 \u003d mock.Mock(spec\u003ddir(secrets.Secret))"},{"line_number":84,"context_line":"        self.secret4 \u003d mock.Mock(spec\u003ddir(secrets.Secret))"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        # Mock out the client"},{"line_number":87,"context_line":"        self.bc \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_84c3db05","line":84,"in_reply_to":"3fa7e38b_440ac378","updated":"2020-02-17 20:24:00.000000000","message":"https://review.opendev.org/707064","commit_id":"dcb383c6af0a612efd3327c2fcb3da7e0b390206"}]}
