)]}'
{"octavia/amphorae/drivers/driver_base.py":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"278bd820e338dc5ad21c69d6b141224908b93e43","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        :param amphorae_network_config: A data model containing information"},{"line_number":143,"context_line":"                                        about the subnets and ports that an"},{"line_number":144,"context_line":"                                        amphorae owns."},{"line_number":145,"context_line":"        :param vrrp_port: Optional for amphorav2 provider"},{"line_number":146,"context_line":"        :type vrrp_port: octavia.network.data_models.Port"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        :param vip_subnet: Optional for amphorav2 provider"}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_3f08b72b","line":145,"range":{"start_line":145,"start_character":35,"end_line":145,"end_character":57},"updated":"2020-03-16 10:34:37.000000000","message":"IIUC, this information is not limited to the amphorav2 provider. Other driver implementations could also use this information. Replace this with, for example, \"VRRP port associated with the load balancer\"?","commit_id":"be1eef4928848691bab3f26eb10de9476c668440"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"529c62bac589e89478707903ad5ed8a520fb62b8","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        :param amphorae_network_config: A data model containing information"},{"line_number":143,"context_line":"                                        about the subnets and ports that an"},{"line_number":144,"context_line":"                                        amphorae owns."},{"line_number":145,"context_line":"        :param vrrp_port: Optional for amphorav2 provider"},{"line_number":146,"context_line":"        :type vrrp_port: octavia.network.data_models.Port"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        :param vip_subnet: Optional for amphorav2 provider"}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_9a3699b4","line":145,"range":{"start_line":145,"start_character":35,"end_line":145,"end_character":57},"in_reply_to":"1fa4df85_3f08b72b","updated":"2020-03-16 10:51:24.000000000","message":"Done","commit_id":"be1eef4928848691bab3f26eb10de9476c668440"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"278bd820e338dc5ad21c69d6b141224908b93e43","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        :param vrrp_port: Optional for amphorav2 provider"},{"line_number":146,"context_line":"        :type vrrp_port: octavia.network.data_models.Port"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        :param vip_subnet: Optional for amphorav2 provider"},{"line_number":149,"context_line":"        :type vip_subnet: octavia.network.data_models.Subnet"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        :type vip_network: octavia.network.data_models.AmphoraNetworkConfig"}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_df064321","line":148,"range":{"start_line":148,"start_character":36,"end_line":148,"end_character":58},"updated":"2020-03-16 10:34:37.000000000","message":"ditto","commit_id":"be1eef4928848691bab3f26eb10de9476c668440"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"529c62bac589e89478707903ad5ed8a520fb62b8","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        :param vrrp_port: Optional for amphorav2 provider"},{"line_number":146,"context_line":"        :type vrrp_port: octavia.network.data_models.Port"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        :param vip_subnet: Optional for amphorav2 provider"},{"line_number":149,"context_line":"        :type vip_subnet: octavia.network.data_models.Subnet"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        :type vip_network: octavia.network.data_models.AmphoraNetworkConfig"}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_ba3915a4","line":148,"range":{"start_line":148,"start_character":36,"end_line":148,"end_character":58},"in_reply_to":"1fa4df85_df064321","updated":"2020-03-16 10:51:24.000000000","message":"Done","commit_id":"be1eef4928848691bab3f26eb10de9476c668440"}],"octavia/network/drivers/noop_driver/driver.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"715c46b6ed59ab221fcd5c9530edd14787a930b2","unresolved":false,"context_lines":[{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        class ItIsInsideMe(network_models.Subnet):"},{"line_number":155,"context_line":"            def to_dict(self, **kwargs):"},{"line_number":156,"context_line":"                return [{}]"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"            def __contains__(self, item):"},{"line_number":159,"context_line":"                return True"}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_00b0a042","line":156,"updated":"2020-03-04 16:53:41.000000000","message":"I\u0027m not sure on this bit? But, if it works, it works, this whole weird class thing is a hack I had to do to make any of the mocks work, so as long as it still works... T_T","commit_id":"be1eef4928848691bab3f26eb10de9476c668440"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"0a2ef2c9cb02a47fe1330a6f9fcb5e4a68d32785","unresolved":false,"context_lines":[{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        class ItIsInsideMe(network_models.Subnet):"},{"line_number":155,"context_line":"            def to_dict(self, **kwargs):"},{"line_number":156,"context_line":"                return [{}]"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"            def __contains__(self, item):"},{"line_number":159,"context_line":"                return True"}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_ef28c8e2","line":156,"in_reply_to":"1fa4df85_00b0a042","updated":"2020-03-05 07:19:07.000000000","message":"I have to do this as writing to db converts to json format and failed otherwise http://paste.openstack.org/show/790317/\nTesting change was failing without this https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_590/697213/23/check/octavia-v2-dsvm-noop-api/590bf73/controller/logs/screen-o-cw.txt\nAs proof 24 patch set was based on this change and pass all tests.","commit_id":"be1eef4928848691bab3f26eb10de9476c668440"}]}