)]}'
{"octavia/common/config.py":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"16bbc644a457cc3e4150eabb6a1dd6153ad31bb7","unresolved":false,"context_lines":[{"line_number":102,"context_line":"                      \"value means \u0027no limit\u0027.\")),"},{"line_number":103,"context_line":"    cfg.BoolOpt(\u0027healthcheck_enabled\u0027, default\u003dFalse,"},{"line_number":104,"context_line":"                help\u003d_(\"When True, the oslo middleware healthcheck endpoint \""},{"line_number":105,"context_line":"                       \"is enabled in the Octavia API.\")),"},{"line_number":106,"context_line":"]"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"# Options only used by the amphora agent"}],"source_content_type":"text/x-python","patch_set":6,"id":"1fa4df85_d2114855","line":105,"updated":"2020-03-17 09:31:37.000000000","message":"healthcheck_opts needs to be defined and registered around L723.\n\ndevstack@o-api.service[29594]: ERROR octavia oslo_config.cfg.NoSuchOptError: no such option healthcheck in group [DEFAULT]","commit_id":"ee4d6918a6e093704f0b705d107fea2d9867eb51"}],"octavia/common/keystone.py":[{"author":{"_account_id":3031,"name":"Sam Morrison","email":"sorrison@gmail.com","username":"sorrison"},"change_message_id":"236d4efb9a47aca34805ee347b5358a553a62f3a","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"_NOAUTH_PATHS \u003d [\u0027/\u0027, \u0027/load-balancer/\u0027, \u0027/healthcheck\u0027,"},{"line_number":25,"context_line":"                 \u0027/load-balancer/healthcheck\u0027]"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_83338c13","line":24,"range":{"start_line":24,"start_character":42,"end_line":24,"end_character":55},"updated":"2020-03-17 00:42:19.000000000","message":"Should have a trailing / I think too. Possibly needs both versions or the check could be changed to use startswith?","commit_id":"cfd99680f40b463391f3d693fbef8140433bfc4c"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ff6f8a253489832c6202356b8eb1d3f076b25c57","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"_NOAUTH_PATHS \u003d [\u0027/\u0027, \u0027/load-balancer/\u0027, \u0027/healthcheck\u0027,"},{"line_number":25,"context_line":"                 \u0027/load-balancer/healthcheck\u0027]"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_c6eaf2d6","line":24,"range":{"start_line":24,"start_character":42,"end_line":24,"end_character":55},"in_reply_to":"1fa4df85_83338c13","updated":"2020-03-17 01:25:21.000000000","message":"We can\u0027t do startswith for this list or all of the API would become noauth.\n\nAdding a / after healthcheck would change it from the document \u0027healthcheck\u0027 to the index of the directory \u0027healthcheck\u0027.\nFor example,\n/healthcheck/ is the same as /healthcheck/index.html\n\nPer the docs page (what there is): https://docs.openstack.org/oslo.middleware/latest/reference/healthcheck_plugins.html\n\nIt should not have a trailing \u0027/\u0027.\n\nIf you really need that, comment again and I will add the trailing slashes.","commit_id":"cfd99680f40b463391f3d693fbef8140433bfc4c"}]}