)]}'
{"id":"openstack%2Foctavia~711739","triplet_id":"openstack%2Foctavia~stable%2Frocky~Ia8ec209e2773483360e2490545b55d7ad5c3cbd1","project":"openstack/octavia","branch":"stable/rocky","topic":"story-2007371-rocky","hashtags":[],"change_id":"Ia8ec209e2773483360e2490545b55d7ad5c3cbd1","subject":"Revert \"Improve the error message for bad pkcs12 bundles\"","status":"ABANDONED","created":"2020-03-06 18:53:06.000000000","updated":"2020-03-18 16:27:13.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"4cd234bca29d6a281a6f5b7cfea9622f43191283","_number":711739,"virtual_id_number":711739,"owner":{"_account_id":2276,"name":"Jorge Niedbalski","email":"jorge.niedbalski@canonical.com","username":"niedbalski"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"tag":"autogenerated:zuul:check","value":1,"date":"2020-03-06 20:55:11.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"date":"2020-03-06 19:04:39.000000000","_account_id":2276,"name":"Jorge Niedbalski","email":"jorge.niedbalski@canonical.com","username":"niedbalski"},{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"all":[{"value":-2,"date":"2020-03-11 00:13:32.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":2276,"name":"Jorge Niedbalski","email":"jorge.niedbalski@canonical.com","username":"niedbalski"},{"value":-2,"date":"2020-03-06 18:54:07.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":2276,"name":"Jorge Niedbalski","email":"jorge.niedbalski@canonical.com","username":"niedbalski"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":2276,"name":"Jorge Niedbalski","email":"jorge.niedbalski@canonical.com","username":"niedbalski"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":2276,"name":"Jorge Niedbalski","email":"jorge.niedbalski@canonical.com","username":"niedbalski"},{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-03-06 18:54:07.000000000","updated_by":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"reviewer":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"state":"REVIEWER"},{"updated":"2020-03-06 20:55:11.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-03-11 00:13:32.000000000","updated_by":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"reviewer":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"state":"REVIEWER"}],"messages":[{"id":"188ea815823f5c777873c56ea8700ecc516f2ee9","author":{"_account_id":2276,"name":"Jorge Niedbalski","email":"jorge.niedbalski@canonical.com","username":"niedbalski"},"date":"2020-03-06 18:53:06.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"fe509e81f01f2ddfd16b665ce35113602b5e4cd0","author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"date":"2020-03-06 18:54:07.000000000","message":"Patch Set 1: Code-Review-2\n\nWe\u0027re going to move forward, not backward. This should be fixable, we just need to figure out why the exception is not happening correctly, and fix it.","accounts_in_message":[],"_revision_number":1},{"id":"8ced54600d6f54b0e433b3b1d3df1a996297146f","author":{"_account_id":2276,"name":"Jorge Niedbalski","email":"jorge.niedbalski@canonical.com","username":"niedbalski"},"date":"2020-03-06 19:04:39.000000000","message":"Patch Set 1:\n\nAdam, Thank you for looking, this change is not about an exception not being triggered. In fact, the exception is being raised correctly and as a consequence, the legacy barbican code that historically supported pkcs12 bundles broke.\n\nAs a clarification, this change actually broke deployments that relied on the legacy barbican pkcs functionality.\n\nJust for you to understand the rationale, this added functionality breaks back-compability with existing deployment therefore, there was no point in backporting this change to the stable releases (which by definition should remain stable).\n\nI would appreciate if you can spend some time to review the linked story and understand why this is causing a regression.\n\nThank you.","accounts_in_message":[],"_revision_number":1},{"id":"a9f50c222311526749baa331c60312947bf7a91a","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-06 20:55:11.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/ea165d7881a841d886dbe1c8d93e4a95 : SUCCESS in 11m 25s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/0a3ecbc9da0d4013ba9b67cfde8915ed : SUCCESS in 7m 40s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/5446ee1cb7064c8fb5ae72e337a9b4c1 : SUCCESS in 7m 01s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/c92e1da1d0db428ea738ae0805fb6ee5 : SUCCESS in 9m 24s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ee211681601e42e290e01c9c336d0d69 : SUCCESS in 6m 58s\n- neutron-lbaasv2-dsvm-api https://zuul.opendev.org/t/openstack/build/36d5b55f96364c9ab8fcaab17cdd62f9 : SUCCESS in 1h 18m 43s (non-voting)\n- neutron-lbaasv2-dsvm-py3x-api https://zuul.opendev.org/t/openstack/build/4efbeeb9fb7a4303bd4b2b568953e065 : SUCCESS in 1h 19m 28s\n- neutron-lbaasv2-dsvm-scenario https://zuul.opendev.org/t/openstack/build/f671e13ea6314aaea7c57dd20c60ab4b : SUCCESS in 1h 19m 00s (non-voting)\n- neutron-lbaasv2-dsvm-py3x-scenario https://zuul.opendev.org/t/openstack/build/c90b3fcd51ef4ec4a7202790e97a68d9 : SUCCESS in 1h 23m 17s (non-voting)\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/b32671b122df436fb8a66365ebcf8eef : SUCCESS in 9m 16s\n- openstack-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/d2412ea882294d10a1d299146464393c : SUCCESS in 9m 29s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/50df7d31c0d34d96aafb279ab262edf5 : SUCCESS in 8m 14s\n- octavia-v1-dsvm-scenario https://zuul.opendev.org/t/openstack/build/aa0cf03e9da04f1e9cb23da681489ade : SUCCESS in 1h 19m 20s\n- octavia-v1-dsvm-py3x-scenario https://zuul.opendev.org/t/openstack/build/c0c7c730d76d4c069e563242232d8ec1 : SUCCESS in 1h 02m 24s\n- octavia-v1-dsvm-scenario-multinode https://zuul.opendev.org/t/openstack/build/51144f55d9204d32b0138af979a42dd9 : FAILURE in 1h 24m 30s (non-voting)\n- octavia-v1-dsvm-py3x-scenario-multinode https://zuul.opendev.org/t/openstack/build/5b369eb29aff470a8df4616bd2f10147 : FAILURE in 1h 31m 46s (non-voting)\n- octavia-v1-dsvm-scenario-kvm-centos.7 https://zuul.opendev.org/t/openstack/build/3e248a093e6b41db990fe25a56110193 : FAILURE in 37m 34s (non-voting)\n- octavia-v2-dsvm-noop-api https://zuul.opendev.org/t/openstack/build/e1971bde74714d798ddab20c7ca73028 : SUCCESS in 50m 38s\n- octavia-v2-dsvm-noop-py35-api https://zuul.opendev.org/t/openstack/build/159a1ec4a7cd4f78994c9cc55a09eb20 : SUCCESS in 47m 51s\n- octavia-v2-dsvm-scenario https://zuul.opendev.org/t/openstack/build/58e5f0c4c6af47079079121739355190 : SUCCESS in 1h 48m 00s\n- octavia-v2-dsvm-py35-scenario https://zuul.opendev.org/t/openstack/build/07a691c1554b4b7eb1e611c9fb23d2cd : SUCCESS in 1h 31m 20s\n- octavia-grenade https://zuul.opendev.org/t/openstack/build/2f7f81cde418452cbc81ee00f785627f : SUCCESS in 1h 12m 32s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/fc9c207f839f4b02a1fe044cb0e76cf2 : SUCCESS in 9m 20s","accounts_in_message":[],"_revision_number":1},{"id":"502a2e053004facd8d03c901db9536fe27fa7118","author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"date":"2020-03-11 00:13:32.000000000","message":"Patch Set 1: Code-Review-2\n\nI also don\u0027t see a problem here and cannot reproduce this local.\nI have added some comments on the story here: https://storyboard.openstack.org/#!/story/2007371\nLet\u0027s debug this further before considering a revert.","accounts_in_message":[],"_revision_number":1},{"id":"0e4d7f1f102d558420f02feaf8d52edd7a3080dd","author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"date":"2020-03-18 16:27:13.000000000","message":"Abandoned\n\nAbandoning as the bug was identified in python-barbicanclient and the Octavia story has been closed:\nhttps://storyboard.openstack.org/#!/story/2007371","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"9cceb1da9f2a7ebb901ab77ed0a3d32c8eb2c1b0","revisions":{"9cceb1da9f2a7ebb901ab77ed0a3d32c8eb2c1b0":{"kind":"REWORK","_number":1,"created":"2020-03-06 18:53:06.000000000","uploader":{"_account_id":2276,"name":"Jorge Niedbalski","email":"jorge.niedbalski@canonical.com","username":"niedbalski"},"ref":"refs/changes/39/711739/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/octavia","ref":"refs/changes/39/711739/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/octavia refs/changes/39/711739/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/octavia refs/changes/39/711739/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/octavia refs/changes/39/711739/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/octavia refs/changes/39/711739/1"}}},"commit":{"parents":[{"commit":"e7376be7afec98192da969dc9382ad860b1cbe01","subject":"Fix uncaught DB exception when trying to get a spare amphora","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/e7376be7afec98192da969dc9382ad860b1cbe01"}]}],"author":{"name":"Jorge Niedbalski","email":"jorge.niedbalski@canonical.com","date":"2020-03-06 18:51:59.000000000","tz":-180},"committer":{"name":"Jorge Niedbalski","email":"jnr@metaklass.org","date":"2020-03-06 18:52:54.000000000","tz":-180},"subject":"Revert \"Improve the error message for bad pkcs12 bundles\"","message":"Revert \"Improve the error message for bad pkcs12 bundles\"\n\nThis reverts commit 08916abd2b6c24dc207dfe3560138901661c2922.\n\nOn stable releases with the addition of this change\nhttps://opendev.org/openstack/octavia/commit/a501714a76e04b33dfb24c4ead9956ed4696d1df\n(and posterior backport to stable releases) isn\u0027t longer possible to create listeners that\nuse barbican secret containers except for single secrets exported as pkcs12 directly.\n\nBefore that change, any exception raised when trying to to decode the\nPKCS12 bundle would have resulted on falling back to the legacy\nbarbican certificate manager code, which supports secret containers [2],\nwhile with the addition of this line, makes this exception to raise and not falling back\nto the legacy code anymore.\n\nPlease check the related story.\n\nChange-Id: Ia8ec209e2773483360e2490545b55d7ad5c3cbd1\nStory: 2007371\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/9cceb1da9f2a7ebb901ab77ed0a3d32c8eb2c1b0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/9cceb1da9f2a7ebb901ab77ed0a3d32c8eb2c1b0"}]},"branch":"refs/heads/stable/rocky"}},"requirements":[],"submit_records":[],"submit_requirements":[]}