)]}'
{"octavia/common/data_models.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"71ce53f00d0be516eff8f5fb3dd4bdbf940acf1b","unresolved":false,"context_lines":[{"line_number":537,"context_line":"                 tls_container_id\u003dNone):"},{"line_number":538,"context_line":"        self.listener_id \u003d listener_id"},{"line_number":539,"context_line":"        self.position \u003d position"},{"line_number":540,"context_line":"        self.listener \u003d listener"},{"line_number":541,"context_line":"        self.tls_container_id \u003d tls_container_id"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"    # SQLAlchemy kindly attaches the whole listener object so"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf51134e_8d32e35c","line":540,"range":{"start_line":540,"start_character":8,"end_line":540,"end_character":32},"updated":"2020-07-16 12:07:26.000000000","message":"I wonder if it\u0027s because we define this explicitly here? Do we actually want both the listener and the listener_id here? I forget whether this makes sense / if we actually use it (as opposed to navigating the DB objects via SQLAlchemy backrefs).","commit_id":"9e070e6e6df6468a0b8f792cb089de0d9fc180b5"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"0b029f473a771d14b5ca294ff576992584a023e9","unresolved":false,"context_lines":[{"line_number":537,"context_line":"                 tls_container_id\u003dNone):"},{"line_number":538,"context_line":"        self.listener_id \u003d listener_id"},{"line_number":539,"context_line":"        self.position \u003d position"},{"line_number":540,"context_line":"        self.listener \u003d listener"},{"line_number":541,"context_line":"        self.tls_container_id \u003d tls_container_id"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"    # SQLAlchemy kindly attaches the whole listener object so"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf51134e_199f2eb4","line":540,"range":{"start_line":540,"start_character":8,"end_line":540,"end_character":32},"in_reply_to":"bf51134e_8d32e35c","updated":"2020-07-16 18:09:01.000000000","message":"Yeah, it\u0027s because we are pulling the object in. I agree, I\u0027m not sure we need the listener object here.","commit_id":"9e070e6e6df6468a0b8f792cb089de0d9fc180b5"}],"octavia/db/repositories.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"71ce53f00d0be516eff8f5fb3dd4bdbf940acf1b","unresolved":false,"context_lines":[{"line_number":1076,"context_line":"            if \u0027sni_containers\u0027 in model_kwargs:"},{"line_number":1077,"context_line":"                # sni_container_refs is being updated. It is either being set"},{"line_number":1078,"context_line":"                # or unset/cleared. We need to update in DB side."},{"line_number":1079,"context_line":"                containers \u003d model_kwargs.pop(\u0027sni_containers\u0027, []) or []"},{"line_number":1080,"context_line":"                listener_db.sni_containers \u003d []"},{"line_number":1081,"context_line":"                if containers:"},{"line_number":1082,"context_line":"                    listener_db.sni_containers \u003d ["}],"source_content_type":"text/x-python","patch_set":6,"id":"bf51134e_4d156b9b","line":1079,"range":{"start_line":1079,"start_character":67,"end_line":1079,"end_character":73},"updated":"2020-07-16 12:07:26.000000000","message":"Nit: I don\u0027t think you technically need this, because you\u0027re not even using this if it doesn\u0027t pass a truthiness check on line 1081.","commit_id":"9e070e6e6df6468a0b8f792cb089de0d9fc180b5"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"0b029f473a771d14b5ca294ff576992584a023e9","unresolved":false,"context_lines":[{"line_number":1076,"context_line":"            if \u0027sni_containers\u0027 in model_kwargs:"},{"line_number":1077,"context_line":"                # sni_container_refs is being updated. It is either being set"},{"line_number":1078,"context_line":"                # or unset/cleared. We need to update in DB side."},{"line_number":1079,"context_line":"                containers \u003d model_kwargs.pop(\u0027sni_containers\u0027, []) or []"},{"line_number":1080,"context_line":"                listener_db.sni_containers \u003d []"},{"line_number":1081,"context_line":"                if containers:"},{"line_number":1082,"context_line":"                    listener_db.sni_containers \u003d ["}],"source_content_type":"text/x-python","patch_set":6,"id":"bf51134e_79f0eafd","line":1079,"range":{"start_line":1079,"start_character":67,"end_line":1079,"end_character":73},"in_reply_to":"bf51134e_4d156b9b","updated":"2020-07-16 18:09:01.000000000","message":"Agreed","commit_id":"9e070e6e6df6468a0b8f792cb089de0d9fc180b5"}],"octavia/tests/functional/api/v2/test_listener.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"71ce53f00d0be516eff8f5fb3dd4bdbf940acf1b","unresolved":false,"context_lines":[{"line_number":2288,"context_line":"        response \u003d self.put(listener_path, body, status\u003d400).json"},{"line_number":2289,"context_line":"        self.assertEqual("},{"line_number":2290,"context_line":"            \"Validation failure: Certificate container references are only \""},{"line_number":2291,"context_line":"            \"allowed on TERMINATED_HTTPS protocol listeners.\","},{"line_number":2292,"context_line":"            response[\u0027faultstring\u0027])"},{"line_number":2293,"context_line":"        get_listener \u003d self.get(listener_path).json[\u0027listener\u0027]"},{"line_number":2294,"context_line":"        self.assertEqual([], get_listener.get(\u0027sni_container_refs\u0027))"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf51134e_ed51df31","line":2291,"updated":"2020-07-16 12:07:26.000000000","message":"Do we really want to match the exact message? MAYBE YES? I don\u0027t know if this is good practice or not.","commit_id":"9e070e6e6df6468a0b8f792cb089de0d9fc180b5"}],"octavia/tests/unit/api/drivers/test_utils.py":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"7f42d211a25b6f73d8177cd624822389570e5d89","unresolved":false,"context_lines":[{"line_number":302,"context_line":"                                       \u0027sni_certs\u0027: [cert2, cert3]}"},{"line_number":303,"context_line":"        # Test with bad SNI content"},{"line_number":304,"context_line":"        test_listener \u003d copy.deepcopy(self.sample_data.test_listener1_dict)"},{"line_number":305,"context_line":"        test_listener[\u0027sni_containers\u0027] \u003d [()]"},{"line_number":306,"context_line":"        self.assertRaises(exceptions.ValidationException,"},{"line_number":307,"context_line":"                          utils.listener_dict_to_provider_dict,"},{"line_number":308,"context_line":"                          test_listener)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_a596e793","line":305,"updated":"2020-03-13 23:11:43.000000000","message":"This test probably needs some work.","commit_id":"cc213716740296665e0ef541a975f210c51940e0"}]}