)]}'
{"etc/octavia.conf":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"fe9e85f403f993508305b554f9f27315dffb2dca","unresolved":false,"context_lines":[{"line_number":62,"context_line":"# see https://owasp.org/www-project-cheat-sheets/cheatsheets/TLS_Cipher_String_Cheat_Sheet"},{"line_number":63,"context_line":"# default_listener_ciphers \u003d TLS_AES_256_GCM_SHA384:TLS_CHACHA20_POLY1305_SHA256:TLS_AES_128_GCM_SHA256:DHE-RSA-AES256-GCM-SHA384:DHE-RSA-AES128-GCM-SHA256:ECDHE-RSA-AES256-GCM-SHA384:ECDHE-RSA-AES128-GCM-SHA256:DHE-RSA-AES256-SHA256:DHE-RSA-AES128-SHA256:ECDHE-RSA-AES256-SHA384:ECDHE-RSA-AES128-SHA256"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"# Default cipher string for new TLS-enabled pools, in OpenSSL format."},{"line_number":66,"context_line":"# default_pool_ciphers \u003d ECDHE-RSA-AES256-GCM-SHA384:ECDHE-RSA-AES128-GCM-SHA256"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"[database]"}],"source_content_type":"text/plain","patch_set":1,"id":"df33271e_87409c09","line":65,"updated":"2020-04-07 16:07:54.000000000","message":"Could we align with the comments of default_listener_ciphers?","commit_id":"1c0e31889dc4f537717f713f286a0eb726b13f22"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"fe9e85f403f993508305b554f9f27315dffb2dca","unresolved":false,"context_lines":[{"line_number":63,"context_line":"# default_listener_ciphers \u003d TLS_AES_256_GCM_SHA384:TLS_CHACHA20_POLY1305_SHA256:TLS_AES_128_GCM_SHA256:DHE-RSA-AES256-GCM-SHA384:DHE-RSA-AES128-GCM-SHA256:ECDHE-RSA-AES256-GCM-SHA384:ECDHE-RSA-AES128-GCM-SHA256:DHE-RSA-AES256-SHA256:DHE-RSA-AES128-SHA256:ECDHE-RSA-AES256-SHA384:ECDHE-RSA-AES128-SHA256"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"# Default cipher string for new TLS-enabled pools, in OpenSSL format."},{"line_number":66,"context_line":"# default_pool_ciphers \u003d ECDHE-RSA-AES256-GCM-SHA384:ECDHE-RSA-AES128-GCM-SHA256"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"[database]"},{"line_number":69,"context_line":"# This line MUST be changed to actually run the plugin."}],"source_content_type":"text/plain","patch_set":1,"id":"df33271e_07e64c45","line":66,"updated":"2020-04-07 16:07:54.000000000","message":"This cipher list is different from the list set in default_listener_ciphers. Is there a reason for the diff?","commit_id":"1c0e31889dc4f537717f713f286a0eb726b13f22"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"9aa37c4cafeb8f63d4b1bf40fab693c0f09fc7f1","unresolved":false,"context_lines":[{"line_number":63,"context_line":"# default_listener_ciphers \u003d TLS_AES_256_GCM_SHA384:TLS_CHACHA20_POLY1305_SHA256:TLS_AES_128_GCM_SHA256:DHE-RSA-AES256-GCM-SHA384:DHE-RSA-AES128-GCM-SHA256:ECDHE-RSA-AES256-GCM-SHA384:ECDHE-RSA-AES128-GCM-SHA256:DHE-RSA-AES256-SHA256:DHE-RSA-AES128-SHA256:ECDHE-RSA-AES256-SHA384:ECDHE-RSA-AES128-SHA256"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"# Default cipher string for new TLS-enabled pools, in OpenSSL format."},{"line_number":66,"context_line":"# default_pool_ciphers \u003d ECDHE-RSA-AES256-GCM-SHA384:ECDHE-RSA-AES128-GCM-SHA256"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"[database]"},{"line_number":69,"context_line":"# This line MUST be changed to actually run the plugin."}],"source_content_type":"text/plain","patch_set":2,"id":"df33271e_675e3877","line":66,"updated":"2020-04-07 16:17:49.000000000","message":"Wouldn\u0027t this list have the same default value of the class B list?","commit_id":"e9e4fd1dd81ae75fae1ca1ee77d35d1e56319c16"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"485778d96769a04a22f18c29a2aca14dfdc2700b","unresolved":false,"context_lines":[{"line_number":63,"context_line":"# default_listener_ciphers \u003d TLS_AES_256_GCM_SHA384:TLS_CHACHA20_POLY1305_SHA256:TLS_AES_128_GCM_SHA256:DHE-RSA-AES256-GCM-SHA384:DHE-RSA-AES128-GCM-SHA256:ECDHE-RSA-AES256-GCM-SHA384:ECDHE-RSA-AES128-GCM-SHA256:DHE-RSA-AES256-SHA256:DHE-RSA-AES128-SHA256:ECDHE-RSA-AES256-SHA384:ECDHE-RSA-AES128-SHA256"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"# Default cipher string for new TLS-enabled pools, in OpenSSL format."},{"line_number":66,"context_line":"# default_pool_ciphers \u003d ECDHE-RSA-AES256-GCM-SHA384:ECDHE-RSA-AES128-GCM-SHA256"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"[database]"},{"line_number":69,"context_line":"# This line MUST be changed to actually run the plugin."}],"source_content_type":"text/plain","patch_set":2,"id":"df33271e_c7b0e48e","line":66,"in_reply_to":"df33271e_675e3877","updated":"2020-04-07 16:19:29.000000000","message":"+1. In line with my comment in patch set 1.","commit_id":"e9e4fd1dd81ae75fae1ca1ee77d35d1e56319c16"},{"author":{"_account_id":31568,"name":"Dawson Coleman","email":"dawsonmcoleman@gmail.com","username":"dawson"},"change_message_id":"92a43749f3883527a68af70c6b425fff80f42680","unresolved":false,"context_lines":[{"line_number":63,"context_line":"# default_listener_ciphers \u003d TLS_AES_256_GCM_SHA384:TLS_CHACHA20_POLY1305_SHA256:TLS_AES_128_GCM_SHA256:DHE-RSA-AES256-GCM-SHA384:DHE-RSA-AES128-GCM-SHA256:ECDHE-RSA-AES256-GCM-SHA384:ECDHE-RSA-AES128-GCM-SHA256:DHE-RSA-AES256-SHA256:DHE-RSA-AES128-SHA256:ECDHE-RSA-AES256-SHA384:ECDHE-RSA-AES128-SHA256"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"# Default cipher string for new TLS-enabled pools, in OpenSSL format."},{"line_number":66,"context_line":"# default_pool_ciphers \u003d ECDHE-RSA-AES256-GCM-SHA384:ECDHE-RSA-AES128-GCM-SHA256"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"[database]"},{"line_number":69,"context_line":"# This line MUST be changed to actually run the plugin."}],"source_content_type":"text/plain","patch_set":2,"id":"df33271e_3573acb3","line":66,"in_reply_to":"df33271e_675e3877","updated":"2020-04-08 01:37:32.000000000","message":"I think I initially wrote this as a less obnoxious example, but looking back, this would be pretty useless as an actual cipher string","commit_id":"e9e4fd1dd81ae75fae1ca1ee77d35d1e56319c16"}],"octavia/common/config.py":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"fe9e85f403f993508305b554f9f27315dffb2dca","unresolved":false,"context_lines":[{"line_number":109,"context_line":"                      \"TLS-enabled listeners.\")),"},{"line_number":110,"context_line":"    cfg.StrOpt(\u0027default_pool_ciphers\u0027,"},{"line_number":111,"context_line":"               default\u003dconstants.CIPHERS_OWASP_SUITE_B,"},{"line_number":112,"context_line":"               help\u003d_(\"Default OpenSSL cipher string for new \""},{"line_number":113,"context_line":"                      \"HTTPS pools.\")),"},{"line_number":114,"context_line":"]"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_475fb4e4","line":112,"updated":"2020-04-07 16:07:54.000000000","message":"Colon-separated.","commit_id":"1c0e31889dc4f537717f713f286a0eb726b13f22"}],"octavia/db/migration/alembic_migrations/versions/fbd705961c3a_add_pool_ciphers_column.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"42f2bd0d17921c2798be994726c2114a7778aaa3","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    op.add_column("},{"line_number":33,"context_line":"        \u0027pool\u0027,"},{"line_number":34,"context_line":"        sa.Column(\u0027tls_ciphers\u0027, sa.String(2048), nullable\u003dTrue)"},{"line_number":35,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_adc87b54","line":35,"updated":"2020-04-03 02:11:36.000000000","message":"pep8: W292 no newline at end of file","commit_id":"1c0e31889dc4f537717f713f286a0eb726b13f22"}]}