)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b8e298484e505a2996881b7a910563ecb67828b2","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Migrated to Neutron repository."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Depends-on: https://review.opendev.org/#/c/741719"},{"line_number":12,"context_line":"Depends-on: https://review.opendev.org/#/c/742027"},{"line_number":13,"context_line":"Change-Id: I814d4e1abf3cee686b9f4511373edd46d1f5f4e2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"9f560f44_e3f39de7","line":11,"updated":"2020-09-28 21:36:19.000000000","message":"Let me remove this dependency and see if the noop job fails again","commit_id":"cfc904d7d6e00a385aa8c6e20a8f58f9348345e1"}],"devstack/plugin.sh":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"df92459bf535e6d5bca8afba2529dcf1463bbb14","unresolved":false,"context_lines":[{"line_number":403,"context_line":"    if function_exists octavia_create_network_interface_device ; then"},{"line_number":404,"context_line":"        octavia_create_network_interface_device o-hm0 $MGMT_PORT_ID $MGMT_PORT_MAC"},{"line_number":405,"context_line":"    elif [[ $NEUTRON_AGENT \u003d\u003d \"openvswitch\" || $Q_AGENT \u003d\u003d \"openvswitch\" ]]; then"},{"line_number":406,"context_line":"        sudo ovs-vsctl -- --may-exist add-port ${OVS_BRIDGE:-br-int} o-hm0 -- set Interface o-hm0 type\u003dinternal -- set Interface o-hm0 external-ids:iface-status\u003dactive -- set Interface o-hm0 external-ids:attached-mac\u003d$MGMT_PORT_MAC -- set Interface o-hm0 external-ids:iface-id\u003d$MGMT_PORT_ID -- set Interface o-hm0 external-ids:skip_cleanup\u003dtrue"},{"line_number":407,"context_line":"    elif [[ $NEUTRON_AGENT \u003d\u003d \"linuxbridge\" || $Q_AGENT \u003d\u003d \"linuxbridge\" ]]; then"},{"line_number":408,"context_line":"        if ! ip link show o-hm0 ; then"},{"line_number":409,"context_line":"            sudo ip link add o-hm0 type veth peer name o-bhm0"}],"source_content_type":"text/x-sh","patch_set":1,"id":"ff570b3c_40fc346f","side":"PARENT","line":406,"updated":"2020-05-20 00:37:43.000000000","message":"So I wonder if we just have to keep these and have them do nothing, as grenade is bombing with them missing - the code in neutron should be doing the right thing.","commit_id":"8c6d64baa7c35f6c29ede2706f178dedb540bf37"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ee9261a7df8d94d2fc0012857d548a5eb21ba5c7","unresolved":false,"context_lines":[{"line_number":459,"context_line":"    elif [[ $NEUTRON_AGENT \u003d\u003d \"openvswitch\" || $Q_AGENT \u003d\u003d \"openvswitch\" ]]; then"},{"line_number":460,"context_line":"        : # Do nothing"},{"line_number":461,"context_line":"    elif [[ $NEUTRON_AGENT \u003d\u003d \"linuxbridge\" || $Q_AGENT \u003d\u003d \"linuxbridge\" ]]; then"},{"line_number":462,"context_line":"        : # Do nothing"},{"line_number":463,"context_line":"    else"},{"line_number":464,"context_line":"        die \"Unknown network controller. Please define octavia_create_network_interface_device\""},{"line_number":465,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"bf51134e_7880e1c0","line":462,"updated":"2020-07-16 22:11:53.000000000","message":"Looks like the include above fixed things, so I can remove these Do nothing\u0027s now.","commit_id":"245061b7aa0fe7d5b7b82510ff1cb8ef2f1b9ba6"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"399a4d66ee637f57c23d60c1c88ab40a035e7c5e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"set -e"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"# Octavia installation uses functions from this file"},{"line_number":7,"context_line":"source $DEST/neutron/devstack/lib/octavia"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# devstack plugin for octavia"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"bf51134e_db4e4737","line":7,"updated":"2020-07-16 22:48:52.000000000","message":"We cannot blanket import functions from neutron here. This should be in the neutron devstack setup.","commit_id":"29514f333f4af101235e3ea1f7335fa185265c2b"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"82cc5831af70a7cd010b8c98af6a94d556841a77","unresolved":false,"context_lines":[{"line_number":4,"context_line":"set -e"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"# Octavia installation uses functions from this file"},{"line_number":7,"context_line":"source $DEST/neutron/devstack/lib/octavia"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# devstack plugin for octavia"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"bf51134e_ce8e7c31","line":7,"in_reply_to":"bf51134e_13309be8","updated":"2020-07-17 15:37:23.000000000","message":"The neutron plugin should expose that function in the shell, just like the other plugins do it.","commit_id":"29514f333f4af101235e3ea1f7335fa185265c2b"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a041e761d89d9360f1fd6918007bdb3269fe083d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"set -e"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"# Octavia installation uses functions from this file"},{"line_number":7,"context_line":"source $DEST/neutron/devstack/lib/octavia"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# devstack plugin for octavia"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"bf51134e_13309be8","line":7,"in_reply_to":"bf51134e_db4e4737","updated":"2020-07-17 14:29:12.000000000","message":"The code for octavia_create_network_interface_device() is in the neutron tree now, i\u0027m not sure how else we\u0027d get access to it.","commit_id":"29514f333f4af101235e3ea1f7335fa185265c2b"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"7910ccf28602734cdb1894eacbc52be3eb5831f9","unresolved":false,"context_lines":[{"line_number":613,"context_line":""},{"line_number":614,"context_line":"    # Kill dhclient process started for o-hm0 interface"},{"line_number":615,"context_line":"    pids\u003d$(ps aux | awk \u0027/[o]-hm0/ { print $2 }\u0027)"},{"line_number":616,"context_line":"    [ ! -z \"$pids\" ] \u0026\u0026 sudo kill $pids"},{"line_number":617,"context_line":"    if function_exists octavia_delete_network_interface_device ; then"},{"line_number":618,"context_line":"        octavia_delete_network_interface_device o-hm0"},{"line_number":619,"context_line":"    elif [[ $NEUTRON_AGENT \u003d\u003d \"openvswitch\" || $Q_AGENT \u003d\u003d \"openvswitch\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":14,"id":"9f560f44_5ab871e4","line":616,"updated":"2020-08-27 22:38:25.000000000","message":"pep8: E040 Syntax error: syntax error near unexpected token `elif\u0027","commit_id":"b520b90b90c34d2ee58fa8a71a294a6a7d7314ec"}]}