)]}'
{"api-ref/source/v2/amphora.inc":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"501f557337a6e80334b047010b7c74b996b38ae9","unresolved":false,"context_lines":[{"line_number":310,"context_line":""},{"line_number":311,"context_line":"Removes an amphora and its associated configuration."},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"The API immediately purges any and all configuration data, depending on the"},{"line_number":314,"context_line":"configuration settings. You cannot recover it."},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"**New in version 2.16**"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"df33271e_1e05e5c2","line":313,"updated":"2020-04-08 06:17:16.000000000","message":"It would be worth noting that only amphorae in READY and ERROR status can be deleted.","commit_id":"f774401df86d709a469b3a01c22333e64abd33d3"}],"octavia/controller/worker/v1/controller_worker.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c22ba60331d4a293cce6c532fff42e6729abb4aa","unresolved":false,"context_lines":[{"line_number":132,"context_line":"            LOG.error(\u0027Failed to delete a amphora {0} due to: {1}\u0027.format("},{"line_number":133,"context_line":"                amphora_id, str(e)))"},{"line_number":134,"context_line":"            return"},{"line_number":135,"context_line":"        LOG.info(\u0027Finished deleting amphora %s.\u0027, amphora_id)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    @tenacity.retry("},{"line_number":138,"context_line":"        retry\u003dtenacity.retry_if_exception_type(db_exceptions.NoResultFound),"}],"source_content_type":"text/x-python","patch_set":3,"id":"df33271e_5d12c159","line":135,"updated":"2020-04-08 16:06:02.000000000","message":"There aren\u0027t any other LOG.info() calls for create, or other operations from what I can see around here.","commit_id":"f774401df86d709a469b3a01c22333e64abd33d3"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"566826fb635a5a9c3d270217c0488a6e859d6371","unresolved":false,"context_lines":[{"line_number":132,"context_line":"            LOG.error(\u0027Failed to delete a amphora {0} due to: {1}\u0027.format("},{"line_number":133,"context_line":"                amphora_id, str(e)))"},{"line_number":134,"context_line":"            return"},{"line_number":135,"context_line":"        LOG.info(\u0027Finished deleting amphora %s.\u0027, amphora_id)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    @tenacity.retry("},{"line_number":138,"context_line":"        retry\u003dtenacity.retry_if_exception_type(db_exceptions.NoResultFound),"}],"source_content_type":"text/x-python","patch_set":3,"id":"df33271e_ec02046f","line":135,"in_reply_to":"df33271e_5d12c159","updated":"2020-04-08 17:06:15.000000000","message":"Correct. I think this is a bug we should fix really.\nBut I didn\u0027t want to bloat this patch with unrelated work.\nCurrently there is only a \"starting\" info level message, but no \"finished\" info log. I think we should improve that.\nAre you proposing we should not log \"finished\" messages?","commit_id":"f774401df86d709a469b3a01c22333e64abd33d3"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"af6964719f032b3d1d46af9443768da1781cfac1","unresolved":false,"context_lines":[{"line_number":132,"context_line":"            LOG.error(\u0027Failed to delete a amphora {0} due to: {1}\u0027.format("},{"line_number":133,"context_line":"                amphora_id, str(e)))"},{"line_number":134,"context_line":"            return"},{"line_number":135,"context_line":"        LOG.info(\u0027Finished deleting amphora %s.\u0027, amphora_id)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    @tenacity.retry("},{"line_number":138,"context_line":"        retry\u003dtenacity.retry_if_exception_type(db_exceptions.NoResultFound),"}],"source_content_type":"text/x-python","patch_set":3,"id":"df33271e_1aaf912a","line":135,"in_reply_to":"df33271e_6f72664b","updated":"2020-04-08 22:00:03.000000000","message":"We already log that at the debug level.","commit_id":"f774401df86d709a469b3a01c22333e64abd33d3"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"31dcccbd5ee3a5403b850886c1a38940459aeef2","unresolved":false,"context_lines":[{"line_number":132,"context_line":"            LOG.error(\u0027Failed to delete a amphora {0} due to: {1}\u0027.format("},{"line_number":133,"context_line":"                amphora_id, str(e)))"},{"line_number":134,"context_line":"            return"},{"line_number":135,"context_line":"        LOG.info(\u0027Finished deleting amphora %s.\u0027, amphora_id)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    @tenacity.retry("},{"line_number":138,"context_line":"        retry\u003dtenacity.retry_if_exception_type(db_exceptions.NoResultFound),"}],"source_content_type":"text/x-python","patch_set":3,"id":"df33271e_6f72664b","line":135,"in_reply_to":"df33271e_ec02046f","updated":"2020-04-08 17:42:56.000000000","message":"I was really just noticing this was the anomaly in the bunch.\n\nAnd regarding logging, it can be a curse when the logs start growing as we know, maybe at LOG.debug level it would be more sane?  But it\u0027s your call.","commit_id":"f774401df86d709a469b3a01c22333e64abd33d3"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"43bea6000699659f1800a5868ca163667bc3973c","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        except Exception as e:"},{"line_number":115,"context_line":"            LOG.error(\u0027Failed to create an amphora due to: {}\u0027.format(str(e)))"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def delete_amphora(self, amphora_id):"},{"line_number":118,"context_line":"        \"\"\"Deletes an existing Amphora."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        :param amphora_id: ID of the amphora to delete"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_1c989968","line":117,"updated":"2020-05-25 08:20:16.000000000","message":"I think this should be introduced for v2 worker as well.","commit_id":"24888da23752f2a5d5c9ac7f4bda968e88a88520"}]}