)]}'
{"api-ref/source/parameters.yaml":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f75edecd23de53ff8506e338b322236cd17e3664","unresolved":false,"context_lines":[{"line_number":1569,"context_line":"  type: boolean"},{"line_number":1570,"context_line":"tls_versions:"},{"line_number":1571,"context_line":"  description: |"},{"line_number":1572,"context_line":"    Colon-separated list of TLS protocol versions."},{"line_number":1573,"context_line":"    Available versions: SSLv3, TLSv1, TLSv1.1, TLSv1.2, TLSv1.3"},{"line_number":1574,"context_line":"  in: body"},{"line_number":1575,"context_line":"  min_version: 2.15"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1f493fa4_ec527cdd","line":1572,"updated":"2020-05-01 20:40:03.000000000","message":"I think this should be a comma separated list.","commit_id":"a60a24bab72f6f7cb0e40377f2cfff569282d7ac"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"080c1d6acc0d9295e2154e755c465d43d0ab6499","unresolved":false,"context_lines":[{"line_number":1569,"context_line":"  type: boolean"},{"line_number":1570,"context_line":"tls_versions:"},{"line_number":1571,"context_line":"  description: |"},{"line_number":1572,"context_line":"    Colon-separated list of TLS protocol versions."},{"line_number":1573,"context_line":"    Available versions: SSLv3, TLSv1, TLSv1.1, TLSv1.2, TLSv1.3"},{"line_number":1574,"context_line":"  in: body"},{"line_number":1575,"context_line":"  min_version: 2.15"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1f493fa4_e7aa976e","line":1572,"in_reply_to":"1f493fa4_ec527cdd","updated":"2020-05-01 21:20:11.000000000","message":"I think it should be an ACTUAL list, not CSV","commit_id":"a60a24bab72f6f7cb0e40377f2cfff569282d7ac"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f75edecd23de53ff8506e338b322236cd17e3664","unresolved":false,"context_lines":[{"line_number":1572,"context_line":"    Colon-separated list of TLS protocol versions."},{"line_number":1573,"context_line":"    Available versions: SSLv3, TLSv1, TLSv1.1, TLSv1.2, TLSv1.3"},{"line_number":1574,"context_line":"  in: body"},{"line_number":1575,"context_line":"  min_version: 2.15"},{"line_number":1576,"context_line":"  required: true"},{"line_number":1577,"context_line":"  type: string"},{"line_number":1578,"context_line":"tls_versions-optional:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1f493fa4_0c3c0891","line":1575,"updated":"2020-05-01 20:40:03.000000000","message":"2.17","commit_id":"a60a24bab72f6f7cb0e40377f2cfff569282d7ac"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f75edecd23de53ff8506e338b322236cd17e3664","unresolved":false,"context_lines":[{"line_number":1574,"context_line":"  in: body"},{"line_number":1575,"context_line":"  min_version: 2.15"},{"line_number":1576,"context_line":"  required: true"},{"line_number":1577,"context_line":"  type: string"},{"line_number":1578,"context_line":"tls_versions-optional:"},{"line_number":1579,"context_line":"  description: |"},{"line_number":1580,"context_line":"    Colon-separated list of TLS protocol versions."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1f493fa4_4c5bb0f4","line":1577,"updated":"2020-05-01 20:40:03.000000000","message":"If we change it to a comma separated list, this would become \"array\" (javascript terms)","commit_id":"a60a24bab72f6f7cb0e40377f2cfff569282d7ac"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"080c1d6acc0d9295e2154e755c465d43d0ab6499","unresolved":false,"context_lines":[{"line_number":1574,"context_line":"  in: body"},{"line_number":1575,"context_line":"  min_version: 2.15"},{"line_number":1576,"context_line":"  required: true"},{"line_number":1577,"context_line":"  type: string"},{"line_number":1578,"context_line":"tls_versions-optional:"},{"line_number":1579,"context_line":"  description: |"},{"line_number":1580,"context_line":"    Colon-separated list of TLS protocol versions."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1f493fa4_07bd03b6","line":1577,"in_reply_to":"1f493fa4_4c5bb0f4","updated":"2020-05-01 21:20:11.000000000","message":"ah yes, array here means more than just \"comma separated list\" above/below, you might want to be more specific :D","commit_id":"a60a24bab72f6f7cb0e40377f2cfff569282d7ac"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f75edecd23de53ff8506e338b322236cd17e3664","unresolved":false,"context_lines":[{"line_number":1577,"context_line":"  type: string"},{"line_number":1578,"context_line":"tls_versions-optional:"},{"line_number":1579,"context_line":"  description: |"},{"line_number":1580,"context_line":"    Colon-separated list of TLS protocol versions."},{"line_number":1581,"context_line":"    Available versions: SSLv3, TLSv1, TLSv1.1, TLSv1.2, TLSv1.3"},{"line_number":1582,"context_line":"  in: body"},{"line_number":1583,"context_line":"  min_version: 2.15"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1f493fa4_ac4cf441","line":1580,"updated":"2020-05-01 20:40:03.000000000","message":"I think this should be a comma separated list.","commit_id":"a60a24bab72f6f7cb0e40377f2cfff569282d7ac"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f75edecd23de53ff8506e338b322236cd17e3664","unresolved":false,"context_lines":[{"line_number":1580,"context_line":"    Colon-separated list of TLS protocol versions."},{"line_number":1581,"context_line":"    Available versions: SSLv3, TLSv1, TLSv1.1, TLSv1.2, TLSv1.3"},{"line_number":1582,"context_line":"  in: body"},{"line_number":1583,"context_line":"  min_version: 2.15"},{"line_number":1584,"context_line":"  required: false"},{"line_number":1585,"context_line":"  type: string"},{"line_number":1586,"context_line":"total_connections:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1f493fa4_4c429010","line":1583,"updated":"2020-05-01 20:40:03.000000000","message":"2.17","commit_id":"a60a24bab72f6f7cb0e40377f2cfff569282d7ac"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f75edecd23de53ff8506e338b322236cd17e3664","unresolved":false,"context_lines":[{"line_number":1582,"context_line":"  in: body"},{"line_number":1583,"context_line":"  min_version: 2.15"},{"line_number":1584,"context_line":"  required: false"},{"line_number":1585,"context_line":"  type: string"},{"line_number":1586,"context_line":"total_connections:"},{"line_number":1587,"context_line":"  description: |"},{"line_number":1588,"context_line":"    The total connections handled."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1f493fa4_ac751466","line":1585,"updated":"2020-05-01 20:40:03.000000000","message":"If we change it to a comma separated list, this would become \"array\"","commit_id":"a60a24bab72f6f7cb0e40377f2cfff569282d7ac"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"860bc25f08f4764d5ed11d118dcf43c6e8974ac2","unresolved":false,"context_lines":[{"line_number":1569,"context_line":"  type: boolean"},{"line_number":1570,"context_line":"tls_versions:"},{"line_number":1571,"context_line":"  description: |"},{"line_number":1572,"context_line":"    A list of TLS protocol versions."},{"line_number":1573,"context_line":"    Available versions: SSLv3, TLSv1, TLSv1.1, TLSv1.2, TLSv1.3"},{"line_number":1574,"context_line":"  in: body"},{"line_number":1575,"context_line":"  min_version: 2.17"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"ff570b3c_97907445","line":1572,"updated":"2020-05-18 21:51:41.000000000","message":"We should tell users what the default value is here.","commit_id":"274f69ca41c32c2e5f5b0bc6aef6c2a268f4e048"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"d5b8378475dcfefd7d8e466236185b6e42876ac7","unresolved":false,"context_lines":[{"line_number":1569,"context_line":"  type: boolean"},{"line_number":1570,"context_line":"tls_versions:"},{"line_number":1571,"context_line":"  description: |"},{"line_number":1572,"context_line":"    A list of TLS protocol versions."},{"line_number":1573,"context_line":"    Available versions: SSLv3, TLSv1, TLSv1.1, TLSv1.2, TLSv1.3"},{"line_number":1574,"context_line":"  in: body"},{"line_number":1575,"context_line":"  min_version: 2.17"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"ff570b3c_53b9fe12","line":1572,"in_reply_to":"ff570b3c_318e74d0","updated":"2020-05-29 20:54:01.000000000","message":"Yeah, that is a good point. It is an operator setting.\nWe should leave it without a default statement.","commit_id":"274f69ca41c32c2e5f5b0bc6aef6c2a268f4e048"},{"author":{"_account_id":31568,"name":"Dawson Coleman","email":"dawsonmcoleman@gmail.com","username":"dawson"},"change_message_id":"bab5b9f789e8fdaa51bd99ce0a2da5df3c8ce762","unresolved":false,"context_lines":[{"line_number":1569,"context_line":"  type: boolean"},{"line_number":1570,"context_line":"tls_versions:"},{"line_number":1571,"context_line":"  description: |"},{"line_number":1572,"context_line":"    A list of TLS protocol versions."},{"line_number":1573,"context_line":"    Available versions: SSLv3, TLSv1, TLSv1.1, TLSv1.2, TLSv1.3"},{"line_number":1574,"context_line":"  in: body"},{"line_number":1575,"context_line":"  min_version: 2.17"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"ff570b3c_318e74d0","line":1572,"in_reply_to":"ff570b3c_97907445","updated":"2020-05-22 18:18:18.000000000","message":"We could put the built-in default here but that might not be accurate if they changed the default in the config, right?","commit_id":"274f69ca41c32c2e5f5b0bc6aef6c2a268f4e048"}],"api-ref/source/v2/examples/listener-create-curl":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f75edecd23de53ff8506e338b322236cd17e3664","unresolved":false,"context_lines":[{"line_number":1,"context_line":"curl -X POST -H \"Content-Type: application/json\" -H \"X-Auth-Token: \u003ctoken\u003e\" -d \u0027{\"listener\": {\"protocol\": \"TERMINATED_HTTPS\", \"description\": \"A great TLS listener\", \"admin_state_up\": true, \"connection_limit\": 200, \"protocol_port\": \"443\", \"loadbalancer_id\": \"607226db-27ef-4d41-ae89-f2a800e9c2db\", \"name\": \"great_tls_listener\", \"insert_headers\": {\"X-Forwarded-For\": \"true\", \"X-Forwarded-Port\": \"true\"}, \"default_tls_container_ref\": \"http://198.51.100.10:9311/v1/containers/a570068c-d295-4780-91d4-3046a325db51\", \"sni_container_refs\": [\"http://198.51.100.10:9311/v1/containers/a570068c-d295-4780-91d4-3046a325db51\", \"http://198.51.100.10:9311/v1/containers/aaebb31e-7761-4826-8cb4-2b829caca3ee\"], \"timeout_client_data\": 50000, \"timeout_member_connect\": 5000, \"timeout_member_data\": 50000, \"timeout_tcp_inspect\": 0, \"tags\": [\"test_tag\"], \"client_ca_tls_container_ref\": \"http://198.51.100.10:9311/v1/containers/35649991-49f3-4625-81ce-2465fe8932e5\", \"client_authentication\": \"MANDATORY\", \"client_crl_container_ref\": \"http://198.51.100.10:9311/v1/containers/e222b065-b93b-4e2a-9a02-804b7a118c3c\", \"allowed_cidrs\": [\"192.0.2.0/24\", \"198.51.100.0/24\"], \"tls_ciphers\": \"ECDHE-RSA-AES256-GCM-SHA384:ECDHE-RSA-AES128-GCM-SHA256\", \"tls_versions\": \"TLSv1.1:TLSv1.2\"}}\u0027 http://198.51.100.10:9876/v2/lbaas/listeners"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"1f493fa4_8c701874","line":1,"range":{"start_line":1,"start_character":1244,"end_line":1,"end_character":1245},"updated":"2020-05-01 20:40:03.000000000","message":"comma","commit_id":"a60a24bab72f6f7cb0e40377f2cfff569282d7ac"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"080c1d6acc0d9295e2154e755c465d43d0ab6499","unresolved":false,"context_lines":[{"line_number":1,"context_line":"curl -X POST -H \"Content-Type: application/json\" -H \"X-Auth-Token: \u003ctoken\u003e\" -d \u0027{\"listener\": {\"protocol\": \"TERMINATED_HTTPS\", \"description\": \"A great TLS listener\", \"admin_state_up\": true, \"connection_limit\": 200, \"protocol_port\": \"443\", \"loadbalancer_id\": \"607226db-27ef-4d41-ae89-f2a800e9c2db\", \"name\": \"great_tls_listener\", \"insert_headers\": {\"X-Forwarded-For\": \"true\", \"X-Forwarded-Port\": \"true\"}, \"default_tls_container_ref\": \"http://198.51.100.10:9311/v1/containers/a570068c-d295-4780-91d4-3046a325db51\", \"sni_container_refs\": [\"http://198.51.100.10:9311/v1/containers/a570068c-d295-4780-91d4-3046a325db51\", \"http://198.51.100.10:9311/v1/containers/aaebb31e-7761-4826-8cb4-2b829caca3ee\"], \"timeout_client_data\": 50000, \"timeout_member_connect\": 5000, \"timeout_member_data\": 50000, \"timeout_tcp_inspect\": 0, \"tags\": [\"test_tag\"], \"client_ca_tls_container_ref\": \"http://198.51.100.10:9311/v1/containers/35649991-49f3-4625-81ce-2465fe8932e5\", \"client_authentication\": \"MANDATORY\", \"client_crl_container_ref\": \"http://198.51.100.10:9311/v1/containers/e222b065-b93b-4e2a-9a02-804b7a118c3c\", \"allowed_cidrs\": [\"192.0.2.0/24\", \"198.51.100.0/24\"], \"tls_ciphers\": \"ECDHE-RSA-AES256-GCM-SHA384:ECDHE-RSA-AES128-GCM-SHA256\", \"tls_versions\": \"TLSv1.1:TLSv1.2\"}}\u0027 http://198.51.100.10:9876/v2/lbaas/listeners"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"1f493fa4_67b047de","line":1,"range":{"start_line":1,"start_character":1244,"end_line":1,"end_character":1245},"in_reply_to":"1f493fa4_8c701874","updated":"2020-05-01 21:20:11.000000000","message":"actual JSON list","commit_id":"a60a24bab72f6f7cb0e40377f2cfff569282d7ac"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"860bc25f08f4764d5ed11d118dcf43c6e8974ac2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"curl -X POST -H \"Content-Type: application/json\" -H \"X-Auth-Token: \u003ctoken\u003e\" -d \u0027{\"listener\": {\"protocol\": \"TERMINATED_HTTPS\", \"description\": \"A great TLS listener\", \"admin_state_up\": true, \"connection_limit\": 200, \"protocol_port\": \"443\", \"loadbalancer_id\": \"607226db-27ef-4d41-ae89-f2a800e9c2db\", \"name\": \"great_tls_listener\", \"insert_headers\": {\"X-Forwarded-For\": \"true\", \"X-Forwarded-Port\": \"true\"}, \"default_tls_container_ref\": \"http://198.51.100.10:9311/v1/containers/a570068c-d295-4780-91d4-3046a325db51\", \"sni_container_refs\": [\"http://198.51.100.10:9311/v1/containers/a570068c-d295-4780-91d4-3046a325db51\", \"http://198.51.100.10:9311/v1/containers/aaebb31e-7761-4826-8cb4-2b829caca3ee\"], \"timeout_client_data\": 50000, \"timeout_member_connect\": 5000, \"timeout_member_data\": 50000, \"timeout_tcp_inspect\": 0, \"tags\": [\"test_tag\"], \"client_ca_tls_container_ref\": \"http://198.51.100.10:9311/v1/containers/35649991-49f3-4625-81ce-2465fe8932e5\", \"client_authentication\": \"MANDATORY\", \"client_crl_container_ref\": \"http://198.51.100.10:9311/v1/containers/e222b065-b93b-4e2a-9a02-804b7a118c3c\", \"allowed_cidrs\": [\"192.0.2.0/24\", \"198.51.100.0/24\"], \"tls_ciphers\": \"ECDHE-RSA-AES256-GCM-SHA384:ECDHE-RSA-AES128-GCM-SHA256\", \"tls_versions\": \"TLSv1.1:TLSv1.2\", \"tls_versions\": [\"TLSv1.2\", \"TLSv1.3\"]}}\u0027 http://198.51.100.10:9876/v2/lbaas/listeners"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"ff570b3c_57eedcec","line":1,"range":{"start_line":1,"start_character":1220,"end_line":1,"end_character":1253},"updated":"2020-05-18 21:51:41.000000000","message":"This is duplicate to the next parameter (which I think is in the right form)","commit_id":"274f69ca41c32c2e5f5b0bc6aef6c2a268f4e048"}],"api-ref/source/v2/examples/listener-create-request.json":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f75edecd23de53ff8506e338b322236cd17e3664","unresolved":false,"context_lines":[{"line_number":29,"context_line":"            \"198.51.100.0/24\""},{"line_number":30,"context_line":"        ],"},{"line_number":31,"context_line":"        \"tls_ciphers\": \"ECDHE-RSA-AES256-GCM-SHA384:ECDHE-RSA-AES128-GCM-SHA256\","},{"line_number":32,"context_line":"        \"tls_protocols\": \"TLSv1.1:TLSv1.2\""},{"line_number":33,"context_line":"    }"},{"line_number":34,"context_line":"}"}],"source_content_type":"application/json","patch_set":5,"id":"1f493fa4_cc66a0bb","line":32,"range":{"start_line":32,"start_character":33,"end_line":32,"end_character":34},"updated":"2020-05-01 20:40:03.000000000","message":"comma","commit_id":"a60a24bab72f6f7cb0e40377f2cfff569282d7ac"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"080c1d6acc0d9295e2154e755c465d43d0ab6499","unresolved":false,"context_lines":[{"line_number":29,"context_line":"            \"198.51.100.0/24\""},{"line_number":30,"context_line":"        ],"},{"line_number":31,"context_line":"        \"tls_ciphers\": \"ECDHE-RSA-AES256-GCM-SHA384:ECDHE-RSA-AES128-GCM-SHA256\","},{"line_number":32,"context_line":"        \"tls_protocols\": \"TLSv1.1:TLSv1.2\""},{"line_number":33,"context_line":"    }"},{"line_number":34,"context_line":"}"}],"source_content_type":"application/json","patch_set":5,"id":"1f493fa4_a7a40fa7","line":32,"range":{"start_line":32,"start_character":33,"end_line":32,"end_character":34},"in_reply_to":"1f493fa4_cc66a0bb","updated":"2020-05-01 21:20:11.000000000","message":"this should be a REAL list, like allowed_cidrs above","commit_id":"a60a24bab72f6f7cb0e40377f2cfff569282d7ac"}],"api-ref/source/v2/examples/listener-create-response.json":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f75edecd23de53ff8506e338b322236cd17e3664","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            \"198.51.100.0/24\""},{"line_number":45,"context_line":"        ],"},{"line_number":46,"context_line":"        \"tls_ciphers\": \"ECDHE-RSA-AES256-GCM-SHA384:ECDHE-RSA-AES128-GCM-SHA256\","},{"line_number":47,"context_line":"        \"tls_protocols\": \"TLSv1.1:TLSv1.2\""},{"line_number":48,"context_line":"    }"},{"line_number":49,"context_line":"}"}],"source_content_type":"application/json","patch_set":5,"id":"1f493fa4_2c0744cc","line":47,"range":{"start_line":47,"start_character":33,"end_line":47,"end_character":34},"updated":"2020-05-01 20:40:03.000000000","message":"comma","commit_id":"a60a24bab72f6f7cb0e40377f2cfff569282d7ac"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"080c1d6acc0d9295e2154e755c465d43d0ab6499","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            \"198.51.100.0/24\""},{"line_number":45,"context_line":"        ],"},{"line_number":46,"context_line":"        \"tls_ciphers\": \"ECDHE-RSA-AES256-GCM-SHA384:ECDHE-RSA-AES128-GCM-SHA256\","},{"line_number":47,"context_line":"        \"tls_protocols\": \"TLSv1.1:TLSv1.2\""},{"line_number":48,"context_line":"    }"},{"line_number":49,"context_line":"}"}],"source_content_type":"application/json","patch_set":5,"id":"1f493fa4_a7cd2f67","line":47,"range":{"start_line":47,"start_character":33,"end_line":47,"end_character":34},"in_reply_to":"1f493fa4_2c0744cc","updated":"2020-05-01 21:20:11.000000000","message":"actual JSON list","commit_id":"a60a24bab72f6f7cb0e40377f2cfff569282d7ac"}],"api-ref/source/v2/examples/listener-show-response.json":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f75edecd23de53ff8506e338b322236cd17e3664","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            \"198.51.100.0/24\""},{"line_number":45,"context_line":"        ],"},{"line_number":46,"context_line":"        \"tls_ciphers\": \"ECDHE-RSA-AES256-GCM-SHA384:ECDHE-RSA-AES128-GCM-SHA256\","},{"line_number":47,"context_line":"        \"tls_protocols\": \"TLSv1.1:TLSv1.2\""},{"line_number":48,"context_line":"    }"},{"line_number":49,"context_line":"}"}],"source_content_type":"application/json","patch_set":5,"id":"1f493fa4_0c0a48d0","line":47,"range":{"start_line":47,"start_character":33,"end_line":47,"end_character":34},"updated":"2020-05-01 20:40:03.000000000","message":"comma","commit_id":"a60a24bab72f6f7cb0e40377f2cfff569282d7ac"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"080c1d6acc0d9295e2154e755c465d43d0ab6499","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            \"198.51.100.0/24\""},{"line_number":45,"context_line":"        ],"},{"line_number":46,"context_line":"        \"tls_ciphers\": \"ECDHE-RSA-AES256-GCM-SHA384:ECDHE-RSA-AES128-GCM-SHA256\","},{"line_number":47,"context_line":"        \"tls_protocols\": \"TLSv1.1:TLSv1.2\""},{"line_number":48,"context_line":"    }"},{"line_number":49,"context_line":"}"}],"source_content_type":"application/json","patch_set":5,"id":"1f493fa4_e7c3b736","line":47,"range":{"start_line":47,"start_character":33,"end_line":47,"end_character":34},"in_reply_to":"1f493fa4_0c0a48d0","updated":"2020-05-01 21:20:11.000000000","message":"actual JSON list","commit_id":"a60a24bab72f6f7cb0e40377f2cfff569282d7ac"}],"api-ref/source/v2/examples/listener-update-curl":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f75edecd23de53ff8506e338b322236cd17e3664","unresolved":false,"context_lines":[{"line_number":1,"context_line":"curl -X PUT -H \"Content-Type: application/json\" -H \"X-Auth-Token: \u003ctoken\u003e\" -d \u0027{\"listener\": {\"description\": \"An updated great TLS listener\", \"admin_state_up\": true, \"connection_limit\": 200, \"name\": \"great_updated_tls_listener\", \"insert_headers\": {\"X-Forwarded-For\": \"false\", \"X-Forwarded-Port\": \"true\"}, \"default_tls_container_ref\": \"http://198.51.100.10:9311/v1/containers/a570068c-d295-4780-91d4-3046a325db51\", \"sni_container_refs\": [\"http://198.51.100.10:9311/v1/containers/a570068c-d295-4780-91d4-3046a325db51\", \"http://198.51.100.10:9311/v1/containers/aaebb31e-7761-4826-8cb4-2b829caca3ee\"], \"timeout_client_data\": 100000, \"timeout_member_connect\": 1000, \"timeout_member_data\": 100000, \"timeout_tcp_inspect\": 5, \"tags\": [\"updated_tag\"], \"client_ca_tls_container_ref\": null, \"allowed_cidrs\": [\"192.0.2.0/24\", \"198.51.100.0/24\"], \"tls_ciphers\": \"ECDHE-RSA-AES256-GCM-SHA384:ECDHE-RSA-AES128-GCM-SHA256\", \"tls_versions\": \"TLSv1.1:TLSv1.2\"}}\u0027 http://198.51.100.10:9876/v2/lbaas/listeners/023f2e34-7806-443b-bfae-16c324569a3d"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"1f493fa4_2c30e49e","line":1,"range":{"start_line":1,"start_character":931,"end_line":1,"end_character":932},"updated":"2020-05-01 20:40:03.000000000","message":"comma","commit_id":"a60a24bab72f6f7cb0e40377f2cfff569282d7ac"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"080c1d6acc0d9295e2154e755c465d43d0ab6499","unresolved":false,"context_lines":[{"line_number":1,"context_line":"curl -X PUT -H \"Content-Type: application/json\" -H \"X-Auth-Token: \u003ctoken\u003e\" -d \u0027{\"listener\": {\"description\": \"An updated great TLS listener\", \"admin_state_up\": true, \"connection_limit\": 200, \"name\": \"great_updated_tls_listener\", \"insert_headers\": {\"X-Forwarded-For\": \"false\", \"X-Forwarded-Port\": \"true\"}, \"default_tls_container_ref\": \"http://198.51.100.10:9311/v1/containers/a570068c-d295-4780-91d4-3046a325db51\", \"sni_container_refs\": [\"http://198.51.100.10:9311/v1/containers/a570068c-d295-4780-91d4-3046a325db51\", \"http://198.51.100.10:9311/v1/containers/aaebb31e-7761-4826-8cb4-2b829caca3ee\"], \"timeout_client_data\": 100000, \"timeout_member_connect\": 1000, \"timeout_member_data\": 100000, \"timeout_tcp_inspect\": 5, \"tags\": [\"updated_tag\"], \"client_ca_tls_container_ref\": null, \"allowed_cidrs\": [\"192.0.2.0/24\", \"198.51.100.0/24\"], \"tls_ciphers\": \"ECDHE-RSA-AES256-GCM-SHA384:ECDHE-RSA-AES128-GCM-SHA256\", \"tls_versions\": \"TLSv1.1:TLSv1.2\"}}\u0027 http://198.51.100.10:9876/v2/lbaas/listeners/023f2e34-7806-443b-bfae-16c324569a3d"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"1f493fa4_47e8abb1","line":1,"range":{"start_line":1,"start_character":931,"end_line":1,"end_character":932},"in_reply_to":"1f493fa4_2c30e49e","updated":"2020-05-01 21:20:11.000000000","message":"actual JSON list","commit_id":"a60a24bab72f6f7cb0e40377f2cfff569282d7ac"}],"api-ref/source/v2/examples/listener-update-request.json":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f75edecd23de53ff8506e338b322236cd17e3664","unresolved":false,"context_lines":[{"line_number":25,"context_line":"            \"198.51.100.0/24\""},{"line_number":26,"context_line":"        ],"},{"line_number":27,"context_line":"        \"tls_ciphers\": \"ECDHE-RSA-AES256-GCM-SHA384:ECDHE-RSA-AES128-GCM-SHA256\","},{"line_number":28,"context_line":"        \"tls_versions\": \"TLSv1.1:TLSv1.2\""},{"line_number":29,"context_line":"    }"},{"line_number":30,"context_line":"}"}],"source_content_type":"application/json","patch_set":5,"id":"1f493fa4_0c3368ac","line":28,"range":{"start_line":28,"start_character":32,"end_line":28,"end_character":33},"updated":"2020-05-01 20:40:03.000000000","message":"comma","commit_id":"a60a24bab72f6f7cb0e40377f2cfff569282d7ac"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"080c1d6acc0d9295e2154e755c465d43d0ab6499","unresolved":false,"context_lines":[{"line_number":25,"context_line":"            \"198.51.100.0/24\""},{"line_number":26,"context_line":"        ],"},{"line_number":27,"context_line":"        \"tls_ciphers\": \"ECDHE-RSA-AES256-GCM-SHA384:ECDHE-RSA-AES128-GCM-SHA256\","},{"line_number":28,"context_line":"        \"tls_versions\": \"TLSv1.1:TLSv1.2\""},{"line_number":29,"context_line":"    }"},{"line_number":30,"context_line":"}"}],"source_content_type":"application/json","patch_set":5,"id":"1f493fa4_a7d24ffe","line":28,"range":{"start_line":28,"start_character":32,"end_line":28,"end_character":33},"in_reply_to":"1f493fa4_0c3368ac","updated":"2020-05-01 21:20:11.000000000","message":"actual JSON list","commit_id":"a60a24bab72f6f7cb0e40377f2cfff569282d7ac"}],"api-ref/source/v2/examples/listener-update-response.json":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f75edecd23de53ff8506e338b322236cd17e3664","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            \"198.51.100.0/24\""},{"line_number":45,"context_line":"        ],"},{"line_number":46,"context_line":"        \"tls_ciphers\": \"ECDHE-RSA-AES256-GCM-SHA384:ECDHE-RSA-AES128-GCM-SHA256\","},{"line_number":47,"context_line":"        \"tls_versions\": \"TLSv1.1:TLSv1.2\""},{"line_number":48,"context_line":"    }"},{"line_number":49,"context_line":"}"}],"source_content_type":"application/json","patch_set":5,"id":"1f493fa4_6c266c6a","line":47,"range":{"start_line":47,"start_character":32,"end_line":47,"end_character":33},"updated":"2020-05-01 20:40:03.000000000","message":"comma","commit_id":"a60a24bab72f6f7cb0e40377f2cfff569282d7ac"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"080c1d6acc0d9295e2154e755c465d43d0ab6499","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            \"198.51.100.0/24\""},{"line_number":45,"context_line":"        ],"},{"line_number":46,"context_line":"        \"tls_ciphers\": \"ECDHE-RSA-AES256-GCM-SHA384:ECDHE-RSA-AES128-GCM-SHA256\","},{"line_number":47,"context_line":"        \"tls_versions\": \"TLSv1.1:TLSv1.2\""},{"line_number":48,"context_line":"    }"},{"line_number":49,"context_line":"}"}],"source_content_type":"application/json","patch_set":5,"id":"1f493fa4_87cd935e","line":47,"range":{"start_line":47,"start_character":32,"end_line":47,"end_character":33},"in_reply_to":"1f493fa4_6c266c6a","updated":"2020-05-01 21:20:11.000000000","message":"actual JSON list","commit_id":"a60a24bab72f6f7cb0e40377f2cfff569282d7ac"}],"api-ref/source/v2/examples/listeners-list-response.json":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f75edecd23de53ff8506e338b322236cd17e3664","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                \"198.51.100.0/24\""},{"line_number":47,"context_line":"            ],"},{"line_number":48,"context_line":"            \"tls_ciphers\": \"ECDHE-RSA-AES256-GCM-SHA384:ECDHE-RSA-AES128-GCM-SHA256\","},{"line_number":49,"context_line":"            \"tls_versions\": \"TLSv1.1:TLSv1.2\""},{"line_number":50,"context_line":"        }"},{"line_number":51,"context_line":"    ]"},{"line_number":52,"context_line":"}"}],"source_content_type":"application/json","patch_set":5,"id":"1f493fa4_ac235455","line":49,"range":{"start_line":49,"start_character":36,"end_line":49,"end_character":37},"updated":"2020-05-01 20:40:03.000000000","message":"comma","commit_id":"a60a24bab72f6f7cb0e40377f2cfff569282d7ac"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"080c1d6acc0d9295e2154e755c465d43d0ab6499","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                \"198.51.100.0/24\""},{"line_number":47,"context_line":"            ],"},{"line_number":48,"context_line":"            \"tls_ciphers\": \"ECDHE-RSA-AES256-GCM-SHA384:ECDHE-RSA-AES128-GCM-SHA256\","},{"line_number":49,"context_line":"            \"tls_versions\": \"TLSv1.1:TLSv1.2\""},{"line_number":50,"context_line":"        }"},{"line_number":51,"context_line":"    ]"},{"line_number":52,"context_line":"}"}],"source_content_type":"application/json","patch_set":5,"id":"1f493fa4_c7d31b00","line":49,"range":{"start_line":49,"start_character":36,"end_line":49,"end_character":37},"in_reply_to":"1f493fa4_ac235455","updated":"2020-05-01 21:20:11.000000000","message":"actual JSON list","commit_id":"a60a24bab72f6f7cb0e40377f2cfff569282d7ac"}],"etc/octavia.conf":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f75edecd23de53ff8506e338b322236cd17e3664","unresolved":false,"context_lines":[{"line_number":68,"context_line":"# see https://cheatsheetseries.owasp.org/cheatsheets/TLS_Cipher_String_Cheat_Sheet.html"},{"line_number":69,"context_line":"# default_pool_ciphers \u003d TLS_AES_256_GCM_SHA384:TLS_CHACHA20_POLY1305_SHA256:TLS_AES_128_GCM_SHA256:DHE-RSA-AES256-GCM-SHA384:DHE-RSA-AES128-GCM-SHA256:ECDHE-RSA-AES256-GCM-SHA384:ECDHE-RSA-AES128-GCM-SHA256:DHE-RSA-AES256-SHA256:DHE-RSA-AES128-SHA256:ECDHE-RSA-AES256-SHA384:ECDHE-RSA-AES128-SHA256"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"# Colon-separated list of default TLS versions to be used on new TLS-terminated"},{"line_number":72,"context_line":"# listeners.  Available versions: SSLv3, TLSv1, TLSv1.1, TLSv1.2, TLSv1.3"},{"line_number":73,"context_line":"# default_listener_tls_versions \u003d TLSv1.2"},{"line_number":74,"context_line":""}],"source_content_type":"text/plain","patch_set":5,"id":"1f493fa4_4cde103e","line":71,"updated":"2020-05-01 20:40:03.000000000","message":"comma","commit_id":"a60a24bab72f6f7cb0e40377f2cfff569282d7ac"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"080c1d6acc0d9295e2154e755c465d43d0ab6499","unresolved":false,"context_lines":[{"line_number":68,"context_line":"# see https://cheatsheetseries.owasp.org/cheatsheets/TLS_Cipher_String_Cheat_Sheet.html"},{"line_number":69,"context_line":"# default_pool_ciphers \u003d TLS_AES_256_GCM_SHA384:TLS_CHACHA20_POLY1305_SHA256:TLS_AES_128_GCM_SHA256:DHE-RSA-AES256-GCM-SHA384:DHE-RSA-AES128-GCM-SHA256:ECDHE-RSA-AES256-GCM-SHA384:ECDHE-RSA-AES128-GCM-SHA256:DHE-RSA-AES256-SHA256:DHE-RSA-AES128-SHA256:ECDHE-RSA-AES256-SHA384:ECDHE-RSA-AES128-SHA256"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"# Colon-separated list of default TLS versions to be used on new TLS-terminated"},{"line_number":72,"context_line":"# listeners.  Available versions: SSLv3, TLSv1, TLSv1.1, TLSv1.2, TLSv1.3"},{"line_number":73,"context_line":"# default_listener_tls_versions \u003d TLSv1.2"},{"line_number":74,"context_line":""}],"source_content_type":"text/plain","patch_set":5,"id":"1f493fa4_2708ff8f","line":71,"in_reply_to":"1f493fa4_4cde103e","updated":"2020-05-01 21:20:11.000000000","message":"actual JSON list","commit_id":"a60a24bab72f6f7cb0e40377f2cfff569282d7ac"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f75edecd23de53ff8506e338b322236cd17e3664","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"# Colon-separated list of default TLS versions to be used on new TLS-terminated"},{"line_number":72,"context_line":"# listeners.  Available versions: SSLv3, TLSv1, TLSv1.1, TLSv1.2, TLSv1.3"},{"line_number":73,"context_line":"# default_listener_tls_versions \u003d TLSv1.2"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"[database]"},{"line_number":76,"context_line":"# This line MUST be changed to actually run the plugin."}],"source_content_type":"text/plain","patch_set":5,"id":"1f493fa4_ace874e1","line":73,"updated":"2020-05-01 20:40:03.000000000","message":"I think we can include TLSv1.3 here.","commit_id":"a60a24bab72f6f7cb0e40377f2cfff569282d7ac"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"cb33531c78acd26b973d5586a9d1820ef14f0857","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"# List of default TLS versions to be used on new TLS-terminated"},{"line_number":76,"context_line":"# listeners.  Available versions: SSLv3, TLSv1, TLSv1.1, TLSv1.2, TLSv1.3"},{"line_number":77,"context_line":"# default_listener_tls_versions \u003d TLSv1.2, TLSv1.3"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"[database]"}],"source_content_type":"text/plain","patch_set":11,"id":"ff570b3c_2fe30436","line":77,"updated":"2020-06-03 09:06:47.000000000","message":"This should be communicated in the release notes, probably in the upgrade or security section? People should realize that suddenly the default is to stop allowing older versions -- assuming HAProxy didn\u0027t already default to this.","commit_id":"5743fd44d0cff78ac44f41399bb0f68f564ed861"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"21e9d578833bb7425a5f70d7a5a02ee0cefcbad1","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"# List of default TLS versions to be used on new TLS-terminated"},{"line_number":76,"context_line":"# listeners.  Available versions: SSLv3, TLSv1, TLSv1.1, TLSv1.2, TLSv1.3"},{"line_number":77,"context_line":"# default_listener_tls_versions \u003d TLSv1.2, TLSv1.3"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"[database]"}],"source_content_type":"text/plain","patch_set":11,"id":"ff570b3c_6de5f6db","line":77,"in_reply_to":"ff570b3c_2fe30436","updated":"2020-06-03 21:44:21.000000000","message":"Yeah, this is a good point. I think the previous default was all are allowed.","commit_id":"5743fd44d0cff78ac44f41399bb0f68f564ed861"}],"octavia/api/v2/types/listener.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f75edecd23de53ff8506e338b322236cd17e3664","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    client_crl_container_ref \u003d wtypes.wsattr(wtypes.StringType())"},{"line_number":64,"context_line":"    allowed_cidrs \u003d wtypes.wsattr([types.CidrType()])"},{"line_number":65,"context_line":"    tls_ciphers \u003d wtypes.StringType()"},{"line_number":66,"context_line":"    tls_versions \u003d wtypes.StringType()"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    @classmethod"},{"line_number":69,"context_line":"    def from_data_model(cls, data_model, children\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f493fa4_4c01f069","line":66,"updated":"2020-05-01 20:40:03.000000000","message":"wtypes.wsattr(wtypes.ArrayType(wtypes.StringType()))","commit_id":"a60a24bab72f6f7cb0e40377f2cfff569282d7ac"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f75edecd23de53ff8506e338b322236cd17e3664","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    client_crl_container_ref \u003d wtypes.StringType(max_length\u003d255)"},{"line_number":154,"context_line":"    allowed_cidrs \u003d wtypes.wsattr([types.CidrType()])"},{"line_number":155,"context_line":"    tls_ciphers \u003d wtypes.StringType(max_length\u003d2048)"},{"line_number":156,"context_line":"    tls_versions \u003d wtypes.StringType(max_length\u003d128)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"class ListenerRootPOST(types.BaseType):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f493fa4_8cc81855","line":156,"updated":"2020-05-01 20:40:03.000000000","message":"wtypes.wsattr(wtypes.ArrayType(wtypes.StringType(max_length\u003d32)))\nI\u0027m saying 32 here as each string can be up to 32 characters. This gives a bit of buffer in case something new is longer than the current strings.","commit_id":"a60a24bab72f6f7cb0e40377f2cfff569282d7ac"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f75edecd23de53ff8506e338b322236cd17e3664","unresolved":false,"context_lines":[{"line_number":192,"context_line":"    client_crl_container_ref \u003d wtypes.StringType(max_length\u003d255)"},{"line_number":193,"context_line":"    allowed_cidrs \u003d wtypes.wsattr([types.CidrType()])"},{"line_number":194,"context_line":"    tls_ciphers \u003d wtypes.StringType(max_length\u003d2048)"},{"line_number":195,"context_line":"    tls_versions \u003d wtypes.StringType(max_length\u003d128)"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"class ListenerRootPUT(types.BaseType):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f493fa4_ecd8bc1e","line":195,"range":{"start_line":195,"start_character":19,"end_line":195,"end_character":52},"updated":"2020-05-01 20:40:03.000000000","message":"wtypes.wsattr(wtypes.ArrayType(wtypes.StringType(max_length\u003d32)))","commit_id":"a60a24bab72f6f7cb0e40377f2cfff569282d7ac"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f75edecd23de53ff8506e338b322236cd17e3664","unresolved":false,"context_lines":[{"line_number":244,"context_line":"    client_crl_container_ref \u003d wtypes.StringType(max_length\u003d255)"},{"line_number":245,"context_line":"    allowed_cidrs \u003d wtypes.wsattr([types.CidrType()])"},{"line_number":246,"context_line":"    tls_ciphers \u003d wtypes.StringType(max_length\u003d2048)"},{"line_number":247,"context_line":"    tls_versions \u003d wtypes.StringType(max_length\u003d128)"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"class ListenerStatusResponse(BaseListenerType):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f493fa4_2c08e48f","line":247,"range":{"start_line":247,"start_character":19,"end_line":247,"end_character":52},"updated":"2020-05-01 20:40:03.000000000","message":"wtypes.wsattr(wtypes.ArrayType(wtypes.StringType(max_length\u003d32)))","commit_id":"a60a24bab72f6f7cb0e40377f2cfff569282d7ac"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"cb33531c78acd26b973d5586a9d1820ef14f0857","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    client_crl_container_ref \u003d wtypes.wsattr(wtypes.StringType())"},{"line_number":64,"context_line":"    allowed_cidrs \u003d wtypes.wsattr([types.CidrType()])"},{"line_number":65,"context_line":"    tls_ciphers \u003d wtypes.StringType()"},{"line_number":66,"context_line":"    tls_versions \u003d wtypes.wsattr(wtypes.ArrayType(wtypes.StringType()))"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    @classmethod"},{"line_number":69,"context_line":"    def from_data_model(cls, data_model, children\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":11,"id":"ff570b3c_2fd784f0","line":66,"updated":"2020-06-03 09:06:47.000000000","message":"Nit: we typically just use `[ ]` rather than ArrayType, so now this is inconsistent. I can\u0027t say why we do something things the pedantic/verbose way and some the shorthand way, but consistency \u003e all.\n\nSame applies for all of the tls_version lines in this file.","commit_id":"5743fd44d0cff78ac44f41399bb0f68f564ed861"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"21e9d578833bb7425a5f70d7a5a02ee0cefcbad1","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    client_crl_container_ref \u003d wtypes.wsattr(wtypes.StringType())"},{"line_number":64,"context_line":"    allowed_cidrs \u003d wtypes.wsattr([types.CidrType()])"},{"line_number":65,"context_line":"    tls_ciphers \u003d wtypes.StringType()"},{"line_number":66,"context_line":"    tls_versions \u003d wtypes.wsattr(wtypes.ArrayType(wtypes.StringType()))"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    @classmethod"},{"line_number":69,"context_line":"    def from_data_model(cls, data_model, children\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":11,"id":"ff570b3c_0d30ba55","line":66,"in_reply_to":"ff570b3c_2fd784f0","updated":"2020-06-03 21:44:21.000000000","message":"These are not used for validation, so the shorthand is fine. However, below on POST/PUT it should use the ArrayType as the content of the array will be validated against the type.\nAligning all of these type files is out tech debt. I will add it to the tech debt list from the PTG and maybe address that soonish.","commit_id":"5743fd44d0cff78ac44f41399bb0f68f564ed861"}],"octavia/common/config.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f75edecd23de53ff8506e338b322236cd17e3664","unresolved":false,"context_lines":[{"line_number":112,"context_line":"               default\u003dconstants.CIPHERS_OWASP_SUITE_B,"},{"line_number":113,"context_line":"               help\u003d_(\"Default OpenSSL cipher string (colon-separated) for \""},{"line_number":114,"context_line":"                      \"new TLS-enabled pools.\")),"},{"line_number":115,"context_line":"    cfg.StrOpt(\u0027default_listener_tls_versions\u0027,"},{"line_number":116,"context_line":"               default\u003dconstants.TLS_VERSIONS_OWASP_SUITE_B,"},{"line_number":117,"context_line":"               help\u003d_(\u0027Colon separated list of TLS versions to use for new\u0027"},{"line_number":118,"context_line":"                      \u0027TLS-enabled listeners.\u0027))"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f493fa4_acb07444","line":115,"updated":"2020-05-01 20:40:03.000000000","message":"I think this should be a comma separated list. These are typically used/referred to as a comma separated list, unlike the ciphers which is OpenSSL colon separated list.\nWe could then use the ListOpt type.","commit_id":"a60a24bab72f6f7cb0e40377f2cfff569282d7ac"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"080c1d6acc0d9295e2154e755c465d43d0ab6499","unresolved":false,"context_lines":[{"line_number":112,"context_line":"               default\u003dconstants.CIPHERS_OWASP_SUITE_B,"},{"line_number":113,"context_line":"               help\u003d_(\"Default OpenSSL cipher string (colon-separated) for \""},{"line_number":114,"context_line":"                      \"new TLS-enabled pools.\")),"},{"line_number":115,"context_line":"    cfg.StrOpt(\u0027default_listener_tls_versions\u0027,"},{"line_number":116,"context_line":"               default\u003dconstants.TLS_VERSIONS_OWASP_SUITE_B,"},{"line_number":117,"context_line":"               help\u003d_(\u0027Colon separated list of TLS versions to use for new\u0027"},{"line_number":118,"context_line":"                      \u0027TLS-enabled listeners.\u0027))"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f493fa4_4701cb69","line":115,"in_reply_to":"1f493fa4_acb07444","updated":"2020-05-01 21:20:11.000000000","message":"Reading your other comments, half of them make me think you\u0027re asking for a CSV, but half seem like you want an ACTUAL list (which is not CSV, but ... different quotes altogether). I believe the latter is the correct way to go, and probably what you actually meant.","commit_id":"a60a24bab72f6f7cb0e40377f2cfff569282d7ac"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"080c1d6acc0d9295e2154e755c465d43d0ab6499","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                      \"new TLS-enabled pools.\")),"},{"line_number":115,"context_line":"    cfg.StrOpt(\u0027default_listener_tls_versions\u0027,"},{"line_number":116,"context_line":"               default\u003dconstants.TLS_VERSIONS_OWASP_SUITE_B,"},{"line_number":117,"context_line":"               help\u003d_(\u0027Colon separated list of TLS versions to use for new\u0027"},{"line_number":118,"context_line":"                      \u0027TLS-enabled listeners.\u0027))"},{"line_number":119,"context_line":"]"},{"line_number":120,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1f493fa4_07306355","line":117,"range":{"start_line":117,"start_character":23,"end_line":117,"end_character":39},"updated":"2020-05-01 21:20:11.000000000","message":"\"List of TLS versions\"\nnot colon or comma separated.","commit_id":"a60a24bab72f6f7cb0e40377f2cfff569282d7ac"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f75edecd23de53ff8506e338b322236cd17e3664","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                      \"new TLS-enabled pools.\")),"},{"line_number":115,"context_line":"    cfg.StrOpt(\u0027default_listener_tls_versions\u0027,"},{"line_number":116,"context_line":"               default\u003dconstants.TLS_VERSIONS_OWASP_SUITE_B,"},{"line_number":117,"context_line":"               help\u003d_(\u0027Colon separated list of TLS versions to use for new\u0027"},{"line_number":118,"context_line":"                      \u0027TLS-enabled listeners.\u0027))"},{"line_number":119,"context_line":"]"},{"line_number":120,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1f493fa4_4c8450d3","line":117,"range":{"start_line":117,"start_character":23,"end_line":117,"end_character":28},"updated":"2020-05-01 20:40:03.000000000","message":"comma","commit_id":"a60a24bab72f6f7cb0e40377f2cfff569282d7ac"}],"octavia/common/constants.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"9a431a639150b6c601be86e59f1d59bd2330815f","unresolved":false,"context_lines":[{"line_number":786,"context_line":"                         \u0027DHE-RSA-AES128-SHA256:ECDHE-RSA-AES256-SHA384:\u0027"},{"line_number":787,"context_line":"                         \u0027ECDHE-RSA-AES128-SHA256\u0027)"},{"line_number":788,"context_line":""},{"line_number":789,"context_line":"# TODO(dawson) OWASP recommendation is 1.2 \"or better\", add 1.3 when implemented"},{"line_number":790,"context_line":"# TLS_VERSIONS_OWASP_SUITE_B \u003d \"TLSv1.2:TLSv1.3\""},{"line_number":791,"context_line":"TLS_VERSIONS_OWASP_SUITE_B \u003d \"TLSv1.2\""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_47938150","line":789,"updated":"2020-04-21 01:24:42.000000000","message":"pep8: E501 line too long (80 \u003e 79 characters)","commit_id":"b0e882f6838351d620304b0609a1838480108dbd"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f75edecd23de53ff8506e338b322236cd17e3664","unresolved":false,"context_lines":[{"line_number":789,"context_line":"# TODO(dawson) OWASP recommendation is 1.2 \"or better\","},{"line_number":790,"context_line":"# add TLSv1.3 when ciphersuites is implemented"},{"line_number":791,"context_line":"# TLS_VERSIONS_OWASP_SUITE_B \u003d \"TLSv1.2:TLSv1.3\""},{"line_number":792,"context_line":"TLS_VERSIONS_OWASP_SUITE_B \u003d \"TLSv1.2\""}],"source_content_type":"text/x-python","patch_set":5,"id":"1f493fa4_4c5d7077","line":792,"range":{"start_line":792,"start_character":29,"end_line":792,"end_character":38},"updated":"2020-05-01 20:40:03.000000000","message":"This should use the constant from octavia_lib.\n\nlib_consts.TLS_VERSION_1_2","commit_id":"a60a24bab72f6f7cb0e40377f2cfff569282d7ac"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f75edecd23de53ff8506e338b322236cd17e3664","unresolved":false,"context_lines":[{"line_number":789,"context_line":"# TODO(dawson) OWASP recommendation is 1.2 \"or better\","},{"line_number":790,"context_line":"# add TLSv1.3 when ciphersuites is implemented"},{"line_number":791,"context_line":"# TLS_VERSIONS_OWASP_SUITE_B \u003d \"TLSv1.2:TLSv1.3\""},{"line_number":792,"context_line":"TLS_VERSIONS_OWASP_SUITE_B \u003d \"TLSv1.2\""}],"source_content_type":"text/x-python","patch_set":5,"id":"1f493fa4_6ccaeca0","line":792,"updated":"2020-05-01 20:40:03.000000000","message":"We can add TLSv1.3 now as it will still work and just pick up the default ciphers.","commit_id":"a60a24bab72f6f7cb0e40377f2cfff569282d7ac"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"101e9b6e718baabfd9db5ccd159cae6d726ec71b","unresolved":false,"context_lines":[{"line_number":788,"context_line":"TLS_VERSIONS_OWASP_SUITE_B \u003d [lib_consts.TLS_VERSION_1_2,"},{"line_number":789,"context_line":"                              lib_consts.TLS_VERSION_1_3]"},{"line_number":790,"context_line":""},{"line_number":791,"context_line":"TLS_ALL_VERSIONS \u003d ["},{"line_number":792,"context_line":"    lib_consts.SSL_VERSION_3,"},{"line_number":793,"context_line":"    lib_consts.TLS_VERSION_1,"},{"line_number":794,"context_line":"    lib_consts.TLS_VERSION_1_1,"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff570b3c_d3298e37","line":791,"updated":"2020-05-29 21:08:15.000000000","message":"Can you please add a comment here that the order of this list is important?","commit_id":"80e011f632676e456c65cf5ba224e8ec7fe1c834"}],"octavia/common/jinja/haproxy/combined_listeners/jinja_cfg.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"080c1d6acc0d9295e2154e755c465d43d0ab6499","unresolved":false,"context_lines":[{"line_number":286,"context_line":"            if listener.tls_ciphers is not None:"},{"line_number":287,"context_line":"                ret_value[\u0027tls_ciphers\u0027] \u003d listener.tls_ciphers"},{"line_number":288,"context_line":"            if listener.tls_versions is not None:"},{"line_number":289,"context_line":"                ret_value[\u0027tls_versions\u0027] \u003d listener.tls_versions.split(\u0027:\u0027)"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"        pools \u003d []"},{"line_number":292,"context_line":"        pool_gen \u003d (pool for pool in listener.pools if"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f493fa4_67332763","line":289,"updated":"2020-05-01 21:20:11.000000000","message":"If this is a real list, it\u0027ll just be:\n\nret_value[\u0027tls_versions\u0027] \u003d listener.tls_versions\n\nunless we\u0027re storing it as a CSV in the DB? in which case, either this or a comma, depending on how we pickle","commit_id":"a60a24bab72f6f7cb0e40377f2cfff569282d7ac"}],"octavia/common/jinja/haproxy/combined_listeners/templates/macros.j2":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f75edecd23de53ff8506e338b322236cd17e3664","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    {% endif %}"},{"line_number":51,"context_line":"    {% set tls_versions_opt \u003d \"\" %}"},{"line_number":52,"context_line":"    {% if listener.tls_versions is defined %}"},{"line_number":53,"context_line":"        {% if \"SSLv3\" not in listener.tls_versions %}"},{"line_number":54,"context_line":"            {% set tls_versions_opt \u003d tls_versions_opt + \" no-sslv3\" %}"},{"line_number":55,"context_line":"        {% endif %}"},{"line_number":56,"context_line":"        {% if \"TLSv1\" not in listener.tls_versions %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"1f493fa4_6ce82c7b","line":53,"range":{"start_line":53,"start_character":14,"end_line":53,"end_character":21},"updated":"2020-05-01 20:40:03.000000000","message":"These should be constants. This macro already imports the octavia constants, it should be extended to pull in the octavia_lib constants and use the string from there.","commit_id":"a60a24bab72f6f7cb0e40377f2cfff569282d7ac"}],"octavia/common/validate.py":[{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"cb33531c78acd26b973d5586a9d1820ef14f0857","unresolved":false,"context_lines":[{"line_number":462,"context_line":""},{"line_number":463,"context_line":""},{"line_number":464,"context_line":"def check_tls_version_list(versions):"},{"line_number":465,"context_line":"    if versions \u003d\u003d []:"},{"line_number":466,"context_line":"        raise exceptions.ValidationException("},{"line_number":467,"context_line":"            detail\u003d_(\u0027Empty TLS version list. Either specify at least one TLS \u0027"},{"line_number":468,"context_line":"                     \u0027version or remove this parameter to use the default.\u0027))"}],"source_content_type":"text/x-python","patch_set":11,"id":"ff570b3c_0fde00d9","line":465,"updated":"2020-06-03 09:06:47.000000000","message":"I think `if not versions:` is technically more pythonic here but I don\u0027t know offhand if there\u0027s some possibility of that evaluating in an unexpected way... As long as we\u0027re sure this is always actually a `list()` then I suppose this is fine.","commit_id":"5743fd44d0cff78ac44f41399bb0f68f564ed861"}],"octavia/db/migration/alembic_migrations/versions/e5493ae5f9a7_add_listener_tls_versions_column.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f75edecd23de53ff8506e338b322236cd17e3664","unresolved":false,"context_lines":[{"line_number":15,"context_line":"\"\"\"add listener tls versions column"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Revision ID: e5493ae5f9a7"},{"line_number":18,"context_line":"Revises: fbd705961c3a"},{"line_number":19,"context_line":"Create Date: 2020-04-19 02:35:28.502424"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"1f493fa4_ac619407","line":18,"updated":"2020-05-01 20:40:03.000000000","message":"e37941b010db ?","commit_id":"a60a24bab72f6f7cb0e40377f2cfff569282d7ac"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f75edecd23de53ff8506e338b322236cd17e3664","unresolved":false,"context_lines":[{"line_number":31,"context_line":"def upgrade():"},{"line_number":32,"context_line":"    op.add_column("},{"line_number":33,"context_line":"        \u0027listener\u0027,"},{"line_number":34,"context_line":"        sa.Column(\u0027tls_versions\u0027, sa.String(128), nullable\u003dTrue)"},{"line_number":35,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f493fa4_eca9dc23","line":34,"range":{"start_line":34,"start_character":44,"end_line":34,"end_character":48},"updated":"2020-05-01 20:40:03.000000000","message":"Let\u0027s make this 512 for now, that should give us some room to grow.","commit_id":"a60a24bab72f6f7cb0e40377f2cfff569282d7ac"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"080c1d6acc0d9295e2154e755c465d43d0ab6499","unresolved":false,"context_lines":[{"line_number":31,"context_line":"def upgrade():"},{"line_number":32,"context_line":"    op.add_column("},{"line_number":33,"context_line":"        \u0027listener\u0027,"},{"line_number":34,"context_line":"        sa.Column(\u0027tls_versions\u0027, sa.String(128), nullable\u003dTrue)"},{"line_number":35,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f493fa4_27163fa9","line":34,"range":{"start_line":34,"start_character":44,"end_line":34,"end_character":48},"in_reply_to":"1f493fa4_eca9dc23","updated":"2020-05-01 21:20:11.000000000","message":"So hold on. How are we storing this? I guess if we *store* as a CSV then yeah we need to just make this big enough to hold all current versions and future versions for ... a long time, ideally... which I guess 512 will probably do?\n\nI hope octavia is in use long enough that people come back and look at this comment and say \"ha, here\u0027s where that bug originated. ok, time to pack up and head back to my space-house on mars\" and then make fun of my idea of the future AND my idea that 512 was enough forever :D","commit_id":"a60a24bab72f6f7cb0e40377f2cfff569282d7ac"}],"octavia/db/models.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f75edecd23de53ff8506e338b322236cd17e3664","unresolved":false,"context_lines":[{"line_number":522,"context_line":"        nullable\u003dFalse, default\u003dconstants.CLIENT_AUTH_NONE)"},{"line_number":523,"context_line":"    client_crl_container_id \u003d sa.Column(sa.String(255), nullable\u003dTrue)"},{"line_number":524,"context_line":"    tls_ciphers \u003d sa.Column(sa.String(2048), nullable\u003dTrue)"},{"line_number":525,"context_line":"    tls_versions \u003d sa.Column(sa.String(128), nullable\u003dTrue)"},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"    _tags \u003d orm.relationship("},{"line_number":528,"context_line":"        \u0027Tags\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f493fa4_8c5c984b","line":525,"range":{"start_line":525,"start_character":39,"end_line":525,"end_character":42},"updated":"2020-05-01 20:40:03.000000000","message":"512","commit_id":"a60a24bab72f6f7cb0e40377f2cfff569282d7ac"}],"octavia/db/prepare.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b4a7cf12e1c764a6f1b7917c4f109765be870725","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        listener_dict[\u0027tls_ciphers\u0027] \u003d ("},{"line_number":111,"context_line":"            CONF.api_settings.default_listener_ciphers)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    if (listener_dict[\u0027protocol\u0027] \u003d\u003d constants.PROTOCOL_TERMINATED_HTTPS and"},{"line_number":114,"context_line":"            (\u0027tls_versions\u0027 not in listener_dict or"},{"line_number":115,"context_line":"             listener_dict[\u0027tls_versions\u0027] is None)):"},{"line_number":116,"context_line":"        listener_dict[\u0027tls_versions\u0027] \u003d ("}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_bacb2b51","line":113,"updated":"2020-04-23 22:19:14.000000000","message":"I guess like jinja_cfg.py you could have both this and the above tls_ciphers check under the same HTTPS check.","commit_id":"13a8ee7710d24c7dc26decaadfa6162b033c40c5"}],"octavia/tests/functional/api/v2/test_load_balancer.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"9a431a639150b6c601be86e59f1d59bd2330815f","unresolved":false,"context_lines":[{"line_number":2672,"context_line":"            expected_listener[\u0027allowed_cidrs\u0027] \u003d expected_allowed_cidrs"},{"line_number":2673,"context_line":"        if create_protocol \u003d\u003d constants.PROTOCOL_TERMINATED_HTTPS:"},{"line_number":2674,"context_line":"            expected_listener[\u0027tls_ciphers\u0027] \u003d constants.CIPHERS_OWASP_SUITE_B"},{"line_number":2675,"context_line":"            expected_listener[\u0027tls_versions\u0027] \u003d constants.TLS_VERSIONS_OWASP_SUITE_B"},{"line_number":2676,"context_line":""},{"line_number":2677,"context_line":"        return create_listener, expected_listener"},{"line_number":2678,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_678e7d28","line":2675,"updated":"2020-04-21 01:24:42.000000000","message":"pep8: E501 line too long (84 \u003e 79 characters)","commit_id":"b0e882f6838351d620304b0609a1838480108dbd"}],"octavia/tests/unit/api/drivers/test_utils.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f75edecd23de53ff8506e338b322236cd17e3664","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                        \u0027flavor_id\u0027: \u0027flavor_id\u0027,"},{"line_number":127,"context_line":"                        \u0027provider\u0027: \u0027noop_driver\u0027}"},{"line_number":128,"context_line":"        ref_listeners \u003d copy.deepcopy(self.sample_data.provider_listeners)"},{"line_number":129,"context_line":"        # TODO(johnsom) Remove when versions implemented"},{"line_number":130,"context_line":"        for listener in ref_listeners:"},{"line_number":131,"context_line":"            delattr(listener, lib_constants.TLS_VERSIONS)"},{"line_number":132,"context_line":"        expect_pools \u003d copy.deepcopy(self.sample_data.provider_pools,)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f493fa4_6c394cf0","side":"PARENT","line":129,"updated":"2020-05-01 20:40:03.000000000","message":"Please remove the comment as well","commit_id":"07a93de755c0ec461f51b94e3465708700ff1549"},{"author":{"_account_id":31568,"name":"Dawson Coleman","email":"dawsonmcoleman@gmail.com","username":"dawson"},"change_message_id":"fbbca3c695ca5b125b9c10c225fb9d3b71a996ce","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                        \u0027flavor_id\u0027: \u0027flavor_id\u0027,"},{"line_number":127,"context_line":"                        \u0027provider\u0027: \u0027noop_driver\u0027}"},{"line_number":128,"context_line":"        ref_listeners \u003d copy.deepcopy(self.sample_data.provider_listeners)"},{"line_number":129,"context_line":"        # TODO(johnsom) Remove when versions implemented"},{"line_number":130,"context_line":"        for listener in ref_listeners:"},{"line_number":131,"context_line":"            delattr(listener, lib_constants.TLS_VERSIONS)"},{"line_number":132,"context_line":"        expect_pools \u003d copy.deepcopy(self.sample_data.provider_pools,)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f493fa4_470f0b87","side":"PARENT","line":129,"in_reply_to":"1f493fa4_6c394cf0","updated":"2020-05-01 21:18:17.000000000","message":"I left it here since there\u0027s still the fix for the pool in here.  It does get removed, but in the next patch (for pools)","commit_id":"07a93de755c0ec461f51b94e3465708700ff1549"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"860bc25f08f4764d5ed11d118dcf43c6e8974ac2","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                        \u0027flavor_id\u0027: \u0027flavor_id\u0027,"},{"line_number":127,"context_line":"                        \u0027provider\u0027: \u0027noop_driver\u0027}"},{"line_number":128,"context_line":"        ref_listeners \u003d copy.deepcopy(self.sample_data.provider_listeners)"},{"line_number":129,"context_line":"        # TODO(johnsom) Remove when versions implemented"},{"line_number":130,"context_line":"        expect_pools \u003d copy.deepcopy(self.sample_data.provider_pools,)"},{"line_number":131,"context_line":"        for pool in expect_pools:"},{"line_number":132,"context_line":"            delattr(pool, lib_constants.TLS_VERSIONS)"}],"source_content_type":"text/x-python","patch_set":9,"id":"ff570b3c_faac37ee","line":129,"updated":"2020-05-18 21:51:41.000000000","message":"This comment should be removed too.","commit_id":"274f69ca41c32c2e5f5b0bc6aef6c2a268f4e048"},{"author":{"_account_id":31568,"name":"Dawson Coleman","email":"dawsonmcoleman@gmail.com","username":"dawson"},"change_message_id":"767a7b305fea0f348f0715f65f02b12a1057aa64","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                        \u0027flavor_id\u0027: \u0027flavor_id\u0027,"},{"line_number":127,"context_line":"                        \u0027provider\u0027: \u0027noop_driver\u0027}"},{"line_number":128,"context_line":"        ref_listeners \u003d copy.deepcopy(self.sample_data.provider_listeners)"},{"line_number":129,"context_line":"        # TODO(johnsom) Remove when versions implemented"},{"line_number":130,"context_line":"        expect_pools \u003d copy.deepcopy(self.sample_data.provider_pools,)"},{"line_number":131,"context_line":"        for pool in expect_pools:"},{"line_number":132,"context_line":"            delattr(pool, lib_constants.TLS_VERSIONS)"}],"source_content_type":"text/x-python","patch_set":9,"id":"ff570b3c_912f80a6","line":129,"in_reply_to":"ff570b3c_31a79452","updated":"2020-05-22 18:18:59.000000000","message":"[removing the comment, I mean]","commit_id":"274f69ca41c32c2e5f5b0bc6aef6c2a268f4e048"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"d5b8378475dcfefd7d8e466236185b6e42876ac7","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                        \u0027flavor_id\u0027: \u0027flavor_id\u0027,"},{"line_number":127,"context_line":"                        \u0027provider\u0027: \u0027noop_driver\u0027}"},{"line_number":128,"context_line":"        ref_listeners \u003d copy.deepcopy(self.sample_data.provider_listeners)"},{"line_number":129,"context_line":"        # TODO(johnsom) Remove when versions implemented"},{"line_number":130,"context_line":"        expect_pools \u003d copy.deepcopy(self.sample_data.provider_pools,)"},{"line_number":131,"context_line":"        for pool in expect_pools:"},{"line_number":132,"context_line":"            delattr(pool, lib_constants.TLS_VERSIONS)"}],"source_content_type":"text/x-python","patch_set":9,"id":"ff570b3c_1395c687","line":129,"in_reply_to":"ff570b3c_912f80a6","updated":"2020-05-29 20:54:01.000000000","message":"Ah, I see it now. cool, no problem.","commit_id":"274f69ca41c32c2e5f5b0bc6aef6c2a268f4e048"},{"author":{"_account_id":31568,"name":"Dawson Coleman","email":"dawsonmcoleman@gmail.com","username":"dawson"},"change_message_id":"bab5b9f789e8fdaa51bd99ce0a2da5df3c8ce762","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                        \u0027flavor_id\u0027: \u0027flavor_id\u0027,"},{"line_number":127,"context_line":"                        \u0027provider\u0027: \u0027noop_driver\u0027}"},{"line_number":128,"context_line":"        ref_listeners \u003d copy.deepcopy(self.sample_data.provider_listeners)"},{"line_number":129,"context_line":"        # TODO(johnsom) Remove when versions implemented"},{"line_number":130,"context_line":"        expect_pools \u003d copy.deepcopy(self.sample_data.provider_pools,)"},{"line_number":131,"context_line":"        for pool in expect_pools:"},{"line_number":132,"context_line":"            delattr(pool, lib_constants.TLS_VERSIONS)"}],"source_content_type":"text/x-python","patch_set":9,"id":"ff570b3c_31a79452","line":129,"in_reply_to":"ff570b3c_faac37ee","updated":"2020-05-22 18:18:18.000000000","message":"This change is part of the corresponding pools patch (with only this patch, this hack is still required)","commit_id":"274f69ca41c32c2e5f5b0bc6aef6c2a268f4e048"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"cb33531c78acd26b973d5586a9d1820ef14f0857","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                        \u0027flavor_id\u0027: \u0027flavor_id\u0027,"},{"line_number":127,"context_line":"                        \u0027provider\u0027: \u0027noop_driver\u0027}"},{"line_number":128,"context_line":"        ref_listeners \u003d copy.deepcopy(self.sample_data.provider_listeners)"},{"line_number":129,"context_line":"        # TODO(johnsom) Remove when versions implemented"},{"line_number":130,"context_line":"        expect_pools \u003d copy.deepcopy(self.sample_data.provider_pools,)"},{"line_number":131,"context_line":"        for pool in expect_pools:"},{"line_number":132,"context_line":"            delattr(pool, lib_constants.TLS_VERSIONS)"}],"source_content_type":"text/x-python","patch_set":11,"id":"ff570b3c_afb43483","line":129,"updated":"2020-06-03 09:06:47.000000000","message":"Nit: Missed this comment line. This will be extra confusing later. :D","commit_id":"5743fd44d0cff78ac44f41399bb0f68f564ed861"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"21e9d578833bb7425a5f70d7a5a02ee0cefcbad1","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                        \u0027flavor_id\u0027: \u0027flavor_id\u0027,"},{"line_number":127,"context_line":"                        \u0027provider\u0027: \u0027noop_driver\u0027}"},{"line_number":128,"context_line":"        ref_listeners \u003d copy.deepcopy(self.sample_data.provider_listeners)"},{"line_number":129,"context_line":"        # TODO(johnsom) Remove when versions implemented"},{"line_number":130,"context_line":"        expect_pools \u003d copy.deepcopy(self.sample_data.provider_pools,)"},{"line_number":131,"context_line":"        for pool in expect_pools:"},{"line_number":132,"context_line":"            delattr(pool, lib_constants.TLS_VERSIONS)"}],"source_content_type":"text/x-python","patch_set":11,"id":"ff570b3c_ed4626c0","line":129,"in_reply_to":"ff570b3c_afb43483","updated":"2020-06-03 21:44:21.000000000","message":"I had the same comment and he responded already. This is still valid for the \"pools\" hack below that is removed in the next patch.","commit_id":"5743fd44d0cff78ac44f41399bb0f68f564ed861"}],"octavia/tests/unit/common/jinja/haproxy/combined_listeners/test_jinja_cfg.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"9a431a639150b6c601be86e59f1d59bd2330815f","unresolved":false,"context_lines":[{"line_number":300,"context_line":"            rendered_obj)"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    def test_render_template_http(self):"},{"line_number":304,"context_line":"        be \u003d (\"backend sample_pool_id_1:sample_listener_id_1\\n\""},{"line_number":305,"context_line":"              \"    mode http\\n\""},{"line_number":306,"context_line":"              \"    balance roundrobin\\n\""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_0774d934","line":303,"updated":"2020-04-21 01:24:42.000000000","message":"pep8: E303 too many blank lines (2)","commit_id":"b0e882f6838351d620304b0609a1838480108dbd"}]}