)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"9e99a60e1a6f16ede47783551a85702cb8ad3ec7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     archiephan \u003cchungphan7819@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-04-23 04:26:48 +0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix healthmonitor not update amphora health when LB disable"},{"line_number":8,"context_line":"fix pep8"},{"line_number":9,"context_line":"Story: 2007587"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1f493fa4_b6419e0e","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":59},"updated":"2020-04-23 06:24:31.000000000","message":"Title should be separated from commit message body with new line.","commit_id":"ead6745364490615dd807529be0f5ece6ab1a502"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"9e99a60e1a6f16ede47783551a85702cb8ad3ec7","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2020-04-23 04:26:48 +0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix healthmonitor not update amphora health when LB disable"},{"line_number":8,"context_line":"fix pep8"},{"line_number":9,"context_line":"Story: 2007587"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ia6d3f40ae1b9b352492162513c9262748ee67e6f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1f493fa4_96cf42af","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":8},"updated":"2020-04-23 06:24:31.000000000","message":"you don\u0027t need to mention this in commit message","commit_id":"ead6745364490615dd807529be0f5ece6ab1a502"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"9e99a60e1a6f16ede47783551a85702cb8ad3ec7","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix healthmonitor not update amphora health when LB disable"},{"line_number":8,"context_line":"fix pep8"},{"line_number":9,"context_line":"Story: 2007587"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ia6d3f40ae1b9b352492162513c9262748ee67e6f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1f493fa4_d66eea94","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":14},"updated":"2020-04-23 06:24:31.000000000","message":"You should add task info as well\nTask: 39521","commit_id":"ead6745364490615dd807529be0f5ece6ab1a502"}],"octavia/controller/healthmanager/health_drivers/update_db.py":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"679353d646560548b64318560186cf674ef3f85a","unresolved":false,"context_lines":[{"line_number":164,"context_line":"            expected_listener_count \u003d 0"},{"line_number":165,"context_line":"            if \u0027PENDING\u0027 in db_lb[\u0027provisioning_status\u0027]:"},{"line_number":166,"context_line":"                ignore_listener_count \u003d True"},{"line_number":167,"context_line":"            if not db_lb[\u0027enabled\u0027]:"},{"line_number":168,"context_line":"                ignore_listener_count \u003d True"},{"line_number":169,"context_line":"            else:"},{"line_number":170,"context_line":"                for key, listener in db_lb.get(\u0027listeners\u0027, {}).items():"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_971e2e0a","line":167,"range":{"start_line":167,"start_character":12,"end_line":167,"end_character":35},"updated":"2020-04-22 15:42:24.000000000","message":"That if statement breaks the logic for load balancers in \"PENDING_*\" state, it should be an \"elif\", or the condition can be used in the previous \"if\" block to avoid code duplication.","commit_id":"6a1d31489090c81c1fef4031282d4659f26575bc"},{"author":{"_account_id":30636,"name":"Chung Phan","email":"chungphan7819@gmail.com","username":"archiephan"},"change_message_id":"768a2f4bb7208b93b3d1736ec55208967b3191f2","unresolved":false,"context_lines":[{"line_number":164,"context_line":"            expected_listener_count \u003d 0"},{"line_number":165,"context_line":"            if \u0027PENDING\u0027 in db_lb[\u0027provisioning_status\u0027]:"},{"line_number":166,"context_line":"                ignore_listener_count \u003d True"},{"line_number":167,"context_line":"            if not db_lb[\u0027enabled\u0027]:"},{"line_number":168,"context_line":"                ignore_listener_count \u003d True"},{"line_number":169,"context_line":"            else:"},{"line_number":170,"context_line":"                for key, listener in db_lb.get(\u0027listeners\u0027, {}).items():"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_7a8387cd","line":167,"range":{"start_line":167,"start_character":12,"end_line":167,"end_character":35},"in_reply_to":"1f493fa4_971e2e0a","updated":"2020-04-23 03:42:49.000000000","message":"\u003e That if statement breaks the logic for load balancers in\n \u003e \"PENDING_*\" state, it should be an \"elif\", or the condition can be\n \u003e used in the previous \"if\" block to avoid code duplication.\n\nthanks for comment, i pushed a patch fixing it","commit_id":"6a1d31489090c81c1fef4031282d4659f26575bc"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"1ad94c580409cdf071bad4919ef975541a50a9cb","unresolved":false,"context_lines":[{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        if db_lb:"},{"line_number":164,"context_line":"            expected_listener_count \u003d 0"},{"line_number":165,"context_line":"            if \u0027PENDING\u0027 in db_lb[\u0027provisioning_status\u0027] or not db_lb[\u0027enabled\u0027]:"},{"line_number":166,"context_line":"                ignore_listener_count \u003d True"},{"line_number":167,"context_line":"            else:"},{"line_number":168,"context_line":"                for key, listener in db_lb.get(\u0027listeners\u0027, {}).items():"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_465cf624","line":165,"updated":"2020-04-22 18:32:48.000000000","message":"pep8: E501 line too long (81 \u003e 79 characters)","commit_id":"30499584b9b286a02a8d0bc990856af778b572c0"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"9e99a60e1a6f16ede47783551a85702cb8ad3ec7","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        if db_lb:"},{"line_number":164,"context_line":"            expected_listener_count \u003d 0"},{"line_number":165,"context_line":"            if (\u0027PENDING\u0027 in db_lb[\u0027provisioning_status\u0027] or"},{"line_number":166,"context_line":"               not db_lb[\u0027enabled\u0027]):"},{"line_number":167,"context_line":"                ignore_listener_count \u003d True"},{"line_number":168,"context_line":"            else:"},{"line_number":169,"context_line":"                for key, listener in db_lb.get(\u0027listeners\u0027, {}).items():"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f493fa4_56877a62","line":166,"range":{"start_line":166,"start_character":15,"end_line":166,"end_character":36},"updated":"2020-04-23 06:24:31.000000000","message":"It would be a good practice to cover this case with unittest as it done for pending status https://github.com/openstack/octavia/blob/22fa179edc9f4b82795ed9c024a0a04938bfcbff/octavia/tests/unit/controller/healthmanager/health_drivers/test_update_db.py#L161","commit_id":"ead6745364490615dd807529be0f5ece6ab1a502"}],"releasenotes/notes/Fix-healthmanager-not-update-amphora-health-when-LB-disabled-46a4fb295c6d0850.yaml":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"fb9894000b8c6cb503204f260a5d3386c5a7e08e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixed an issue when Octavia Heath Manager keep failover the amphora when"},{"line_number":5,"context_line":"    loadbalancer disabled."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1f493fa4_272a7a8f","line":4,"range":{"start_line":4,"start_character":46,"end_line":4,"end_character":71},"updated":"2020-04-23 10:02:46.000000000","message":"\"keeps failover amphorae\" (? non native english speaker here, don\u0027t know if it\u0027s correct)","commit_id":"d7d785853e217c2c4787a40384b47fd849937611"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"fb9894000b8c6cb503204f260a5d3386c5a7e08e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixed an issue when Octavia Heath Manager keep failover the amphora when"},{"line_number":5,"context_line":"    loadbalancer disabled."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1f493fa4_472fc6a0","line":4,"range":{"start_line":4,"start_character":32,"end_line":4,"end_character":37},"updated":"2020-04-23 10:02:46.000000000","message":"Health","commit_id":"d7d785853e217c2c4787a40384b47fd849937611"},{"author":{"_account_id":30636,"name":"Chung Phan","email":"chungphan7819@gmail.com","username":"archiephan"},"change_message_id":"cc36f22b2a839cd852fb16fb39d4714ef201ebbb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixed an issue when Octavia Heath Manager keep failover the amphora when"},{"line_number":5,"context_line":"    loadbalancer disabled."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1f493fa4_0d131d5e","line":4,"range":{"start_line":4,"start_character":46,"end_line":4,"end_character":71},"in_reply_to":"1f493fa4_272a7a8f","updated":"2020-04-23 13:24:22.000000000","message":"thanks for your suggestions, i havent used English for a long time","commit_id":"d7d785853e217c2c4787a40384b47fd849937611"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"fb9894000b8c6cb503204f260a5d3386c5a7e08e","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixed an issue when Octavia Heath Manager keep failover the amphora when"},{"line_number":5,"context_line":"    loadbalancer disabled."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1f493fa4_871a6e7a","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":25},"updated":"2020-04-23 10:02:46.000000000","message":"a loadbalancer is disabled","commit_id":"d7d785853e217c2c4787a40384b47fd849937611"}]}