)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2efce3ed558d9bae455a9dc99837b2cb652fb1ff","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     wu.chunyang \u003cwuchunyang@yovole.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-11-29 20:13:45 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add notifications specification documens"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1. implement notifications for octavia"},{"line_number":10,"context_line":"2. ps[1] or ps[2] maybe helpful"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"f366f127_ccb44be6","line":7,"range":{"start_line":7,"start_character":32,"end_line":7,"end_character":40},"updated":"2020-11-30 16:48:27.000000000","message":"s/document","commit_id":"218bd3608a9d4b1ea4c98205e20203e952c5082d"}],"specs/version1.2/notifications_support.rst":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"34d14cd007da2d1f3a1ff45d591027877cdfc109","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Add octavia notification support"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Similarly to other OpenStack services octavia should  emits notifications to"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f65232a_2d953a41","line":8,"range":{"start_line":8,"start_character":4,"end_line":8,"end_character":11},"updated":"2020-10-27 15:51:15.000000000","message":"s/Octavia\n\nShould be done throughout","commit_id":"3c0ea9af63fee96e50722002693fcf17875fa74f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"34d14cd007da2d1f3a1ff45d591027877cdfc109","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Add octavia notification support"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Similarly to other OpenStack services octavia should  emits notifications to"},{"line_number":12,"context_line":"the message bus with"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f65232a_edb6a2fa","line":9,"updated":"2020-10-27 15:51:15.000000000","message":"nit: extra \u003d\u003d\u003d here","commit_id":"3c0ea9af63fee96e50722002693fcf17875fa74f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"34d14cd007da2d1f3a1ff45d591027877cdfc109","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Add octavia notification support"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Similarly to other OpenStack services octavia should  emits notifications to"},{"line_number":12,"context_line":"the message bus with"},{"line_number":13,"context_line":"the Notifier class provided by oslo.messaging_"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f65232a_8da44ebb","line":11,"range":{"start_line":11,"start_character":29,"end_line":11,"end_character":59},"updated":"2020-10-27 15:51:15.000000000","message":"s/services, Octavia should emit","commit_id":"3c0ea9af63fee96e50722002693fcf17875fa74f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"34d14cd007da2d1f3a1ff45d591027877cdfc109","unresolved":false,"context_lines":[{"line_number":18,"context_line":"Problem description"},{"line_number":19,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"1. 3rd party application can monitor the provisioning status of objects and"},{"line_number":22,"context_line":"   provide it like web-socket for quick display in a frontend."},{"line_number":23,"context_line":"2. 3rd party application can catch object changes and update"},{"line_number":24,"context_line":"   billing information."}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f65232a_4d9a366e","line":21,"range":{"start_line":21,"start_character":13,"end_line":21,"end_character":24},"updated":"2020-10-27 15:51:15.000000000","message":"s/applications\n\nsame in below lines","commit_id":"3c0ea9af63fee96e50722002693fcf17875fa74f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"34d14cd007da2d1f3a1ff45d591027877cdfc109","unresolved":false,"context_lines":[{"line_number":28,"context_line":"Proposed change"},{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Create loadbalance notification:"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    * Send a notification to inform the Ceilometer the loadbalance"},{"line_number":34,"context_line":"      create begins."}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f65232a_8d8d6e33","line":31,"range":{"start_line":31,"start_character":7,"end_line":31,"end_character":18},"updated":"2020-10-27 15:51:15.000000000","message":"s/loadbalancer\n\nsame in below lines","commit_id":"3c0ea9af63fee96e50722002693fcf17875fa74f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"34d14cd007da2d1f3a1ff45d591027877cdfc109","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Create loadbalance notification:"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    * Send a notification to inform the Ceilometer the loadbalance"},{"line_number":34,"context_line":"      create begins."},{"line_number":35,"context_line":"    * Send a notification to inform the Ceilometer the loadbalance"},{"line_number":36,"context_line":"      create ends."}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f65232a_2d7eda18","line":33,"range":{"start_line":33,"start_character":36,"end_line":33,"end_character":39},"updated":"2020-10-27 15:51:15.000000000","message":"\u0027the\u0027 can be deleted in all these sentences","commit_id":"3c0ea9af63fee96e50722002693fcf17875fa74f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"34d14cd007da2d1f3a1ff45d591027877cdfc109","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Update loadbalance notification:"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    * send a notification to inform the Ceilometer the loadbalance"},{"line_number":48,"context_line":"      update begins."},{"line_number":49,"context_line":"    * send a notification to inform the Ceilometer the loadbalance"},{"line_number":50,"context_line":"      update ends."}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f65232a_0d795e2e","line":47,"range":{"start_line":47,"start_character":6,"end_line":47,"end_character":10},"updated":"2020-10-27 15:51:15.000000000","message":"s/Send\n\nbelow as well","commit_id":"3c0ea9af63fee96e50722002693fcf17875fa74f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"34d14cd007da2d1f3a1ff45d591027877cdfc109","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":"Delete rule notification:"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    * Send a notification to inform the Ceilometer the rule Delete begins."},{"line_number":147,"context_line":"    * Send a notification to inform the Ceilometer the rule Delete ends."},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"Update rule notification:"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f65232a_2da37aa0","line":146,"range":{"start_line":146,"start_character":60,"end_line":146,"end_character":66},"updated":"2020-10-27 15:51:15.000000000","message":"s/delete\n\nbelow as well","commit_id":"3c0ea9af63fee96e50722002693fcf17875fa74f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"34d14cd007da2d1f3a1ff45d591027877cdfc109","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"Update rule notification:"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    * Send a notification to inform the Ceilometer the rule Update begins."},{"line_number":152,"context_line":"    * Send a notification to inform the Ceilometer the rule Update ends."},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"Progress notification:"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f65232a_adb82ac8","line":151,"range":{"start_line":151,"start_character":60,"end_line":151,"end_character":66},"updated":"2020-10-27 15:51:15.000000000","message":"s/update\n\nsame below","commit_id":"3c0ea9af63fee96e50722002693fcf17875fa74f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"34d14cd007da2d1f3a1ff45d591027877cdfc109","unresolved":false,"context_lines":[{"line_number":154,"context_line":"Progress notification:"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    * It is possible that some drivers can send a create.progress"},{"line_number":157,"context_line":"      notifications periodically"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"The octavia loadbalance information send to notification bus includes id,"},{"line_number":160,"context_line":"project id, name, provisioning_status, operating_status,create_time,"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f65232a_cdb5a6cf","line":157,"range":{"start_line":157,"start_character":6,"end_line":157,"end_character":19},"updated":"2020-10-27 15:51:15.000000000","message":"s/notification","commit_id":"3c0ea9af63fee96e50722002693fcf17875fa74f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"34d14cd007da2d1f3a1ff45d591027877cdfc109","unresolved":false,"context_lines":[{"line_number":156,"context_line":"    * It is possible that some drivers can send a create.progress"},{"line_number":157,"context_line":"      notifications periodically"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"The octavia loadbalance information send to notification bus includes id,"},{"line_number":160,"context_line":"project id, name, provisioning_status, operating_status,create_time,"},{"line_number":161,"context_line":"provider and fail reason."},{"line_number":162,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f65232a_0dc79e47","line":159,"range":{"start_line":159,"start_character":12,"end_line":159,"end_character":23},"updated":"2020-10-27 15:51:15.000000000","message":"s/loadbalancer","commit_id":"3c0ea9af63fee96e50722002693fcf17875fa74f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"34d14cd007da2d1f3a1ff45d591027877cdfc109","unresolved":false,"context_lines":[{"line_number":156,"context_line":"    * It is possible that some drivers can send a create.progress"},{"line_number":157,"context_line":"      notifications periodically"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"The octavia loadbalance information send to notification bus includes id,"},{"line_number":160,"context_line":"project id, name, provisioning_status, operating_status,create_time,"},{"line_number":161,"context_line":"provider and fail reason."},{"line_number":162,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f65232a_4dc1962e","line":159,"range":{"start_line":159,"start_character":36,"end_line":159,"end_character":43},"updated":"2020-10-27 15:51:15.000000000","message":"s/sent to the","commit_id":"3c0ea9af63fee96e50722002693fcf17875fa74f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"34d14cd007da2d1f3a1ff45d591027877cdfc109","unresolved":false,"context_lines":[{"line_number":202,"context_line":"Security impact"},{"line_number":203,"context_line":"---------------"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"the notifications sent onto notification bus should don\u0027t contain"},{"line_number":206,"context_line":"security content."},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"Notifications impact"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f65232a_cd2be62d","line":205,"range":{"start_line":205,"start_character":0,"end_line":205,"end_character":3},"updated":"2020-10-27 15:51:15.000000000","message":"s/The","commit_id":"3c0ea9af63fee96e50722002693fcf17875fa74f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"34d14cd007da2d1f3a1ff45d591027877cdfc109","unresolved":false,"context_lines":[{"line_number":202,"context_line":"Security impact"},{"line_number":203,"context_line":"---------------"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"the notifications sent onto notification bus should don\u0027t contain"},{"line_number":206,"context_line":"security content."},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"Notifications impact"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f65232a_0d1dde0e","line":205,"range":{"start_line":205,"start_character":52,"end_line":205,"end_character":57},"updated":"2020-10-27 15:51:15.000000000","message":"s/not","commit_id":"3c0ea9af63fee96e50722002693fcf17875fa74f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"34d14cd007da2d1f3a1ff45d591027877cdfc109","unresolved":false,"context_lines":[{"line_number":208,"context_line":"Notifications impact"},{"line_number":209,"context_line":"--------------------"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"yes, this feature is to implemented notification."},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"Other end user impact"},{"line_number":214,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f65232a_eddd0243","line":211,"range":{"start_line":211,"start_character":0,"end_line":211,"end_character":3},"updated":"2020-10-27 15:51:15.000000000","message":"s/Yes","commit_id":"3c0ea9af63fee96e50722002693fcf17875fa74f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"34d14cd007da2d1f3a1ff45d591027877cdfc109","unresolved":false,"context_lines":[{"line_number":208,"context_line":"Notifications impact"},{"line_number":209,"context_line":"--------------------"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"yes, this feature is to implemented notification."},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"Other end user impact"},{"line_number":214,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f65232a_6df1f2cd","line":211,"range":{"start_line":211,"start_character":18,"end_line":211,"end_character":48},"updated":"2020-10-27 15:51:15.000000000","message":"s/implements notifications","commit_id":"3c0ea9af63fee96e50722002693fcf17875fa74f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"34d14cd007da2d1f3a1ff45d591027877cdfc109","unresolved":false,"context_lines":[{"line_number":218,"context_line":"Performance Impact"},{"line_number":219,"context_line":"------------------"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"this code will be called everytime unless set the drvier to noop."},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"Other deployer impact"},{"line_number":224,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f65232a_cd5da6ea","line":221,"range":{"start_line":221,"start_character":0,"end_line":221,"end_character":4},"updated":"2020-10-27 15:51:15.000000000","message":"s/This","commit_id":"3c0ea9af63fee96e50722002693fcf17875fa74f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"34d14cd007da2d1f3a1ff45d591027877cdfc109","unresolved":false,"context_lines":[{"line_number":218,"context_line":"Performance Impact"},{"line_number":219,"context_line":"------------------"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"this code will be called everytime unless set the drvier to noop."},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"Other deployer impact"},{"line_number":224,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f65232a_2d741a68","line":221,"range":{"start_line":221,"start_character":42,"end_line":221,"end_character":56},"updated":"2020-10-27 15:51:15.000000000","message":"s/the driver is set","commit_id":"3c0ea9af63fee96e50722002693fcf17875fa74f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"34d14cd007da2d1f3a1ff45d591027877cdfc109","unresolved":false,"context_lines":[{"line_number":240,"context_line":"    wu.chunyang"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"Other contributors:"},{"line_number":243,"context_line":"  others"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"Work Items"},{"line_number":246,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f65232a_8d63aeb1","line":243,"range":{"start_line":243,"start_character":2,"end_line":243,"end_character":8},"updated":"2020-10-27 15:51:15.000000000","message":"Are there specific people helping?","commit_id":"3c0ea9af63fee96e50722002693fcf17875fa74f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"34d14cd007da2d1f3a1ff45d591027877cdfc109","unresolved":false,"context_lines":[{"line_number":245,"context_line":"Work Items"},{"line_number":246,"context_line":"----------"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    * Add the notification for the loadbalance usage When create/delete/update"},{"line_number":249,"context_line":"      a loadbalance."},{"line_number":250,"context_line":"    * Add the notification for the listener usage When create/delete/update"},{"line_number":251,"context_line":"      a listener."}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f65232a_cdcf66ae","line":248,"range":{"start_line":248,"start_character":35,"end_line":248,"end_character":46},"updated":"2020-10-27 15:51:15.000000000","message":"s/loadbalancer","commit_id":"3c0ea9af63fee96e50722002693fcf17875fa74f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"34d14cd007da2d1f3a1ff45d591027877cdfc109","unresolved":false,"context_lines":[{"line_number":246,"context_line":"----------"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    * Add the notification for the loadbalance usage When create/delete/update"},{"line_number":249,"context_line":"      a loadbalance."},{"line_number":250,"context_line":"    * Add the notification for the listener usage When create/delete/update"},{"line_number":251,"context_line":"      a listener."},{"line_number":252,"context_line":"    * Add the notification for the pool usage When create/delete/update"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f65232a_2dc6da9b","line":249,"range":{"start_line":249,"start_character":8,"end_line":249,"end_character":19},"updated":"2020-10-27 15:51:15.000000000","message":"s/loadbalancer","commit_id":"3c0ea9af63fee96e50722002693fcf17875fa74f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"34d14cd007da2d1f3a1ff45d591027877cdfc109","unresolved":false,"context_lines":[{"line_number":256,"context_line":"    * Add the notification for the healthmonitor usage When"},{"line_number":257,"context_line":"      create/delete/update a healthmonitor."},{"line_number":258,"context_line":"    * Add the notification for the l7policy usage When"},{"line_number":259,"context_line":"      create/delete/update a l7policy."},{"line_number":260,"context_line":"    * Add the notification for the rule usage When"},{"line_number":261,"context_line":"      create/delete/update a rule."},{"line_number":262,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f65232a_8d3a8e95","line":259,"range":{"start_line":259,"start_character":27,"end_line":259,"end_character":28},"updated":"2020-10-27 15:51:15.000000000","message":"s/an","commit_id":"3c0ea9af63fee96e50722002693fcf17875fa74f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"34d14cd007da2d1f3a1ff45d591027877cdfc109","unresolved":false,"context_lines":[{"line_number":269,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"Add unit test."},{"line_number":272,"context_line":"this feature just has impacts on octavia project. so unit test is sufficient."},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"Documentation Impact"},{"line_number":275,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f65232a_6d5572c6","line":272,"range":{"start_line":272,"start_character":48,"end_line":272,"end_character":49},"updated":"2020-10-27 15:51:15.000000000","message":"s/,","commit_id":"3c0ea9af63fee96e50722002693fcf17875fa74f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"34d14cd007da2d1f3a1ff45d591027877cdfc109","unresolved":false,"context_lines":[{"line_number":269,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"Add unit test."},{"line_number":272,"context_line":"this feature just has impacts on octavia project. so unit test is sufficient."},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"Documentation Impact"},{"line_number":275,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f65232a_0d467e22","line":272,"range":{"start_line":272,"start_character":0,"end_line":272,"end_character":4},"updated":"2020-10-27 15:51:15.000000000","message":"s/This","commit_id":"3c0ea9af63fee96e50722002693fcf17875fa74f"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"87fa126606c9f50971bdcc3e1f1495c49fec979b","unresolved":false,"context_lines":[{"line_number":269,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"Add unit test."},{"line_number":272,"context_line":"this feature just has impacts on octavia project. so unit test is sufficient."},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"Documentation Impact"},{"line_number":275,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":8,"id":"2cc5ddd0_53dcb010","line":272,"range":{"start_line":272,"start_character":48,"end_line":272,"end_character":49},"in_reply_to":"3f65232a_6d5572c6","updated":"2020-11-29 11:52:28.000000000","message":"done","commit_id":"3c0ea9af63fee96e50722002693fcf17875fa74f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2efce3ed558d9bae455a9dc99837b2cb652fb1ff","unresolved":true,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://storyboard.openstack.org/#!/story/2004122"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Similarly to other OpenStack services, Octavia should  emits notifications to"},{"line_number":14,"context_line":"the message bus with the Notifier class provided by oslo.messaging_"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":".. _oslo.messaging: https://docs.openstack.org/oslo.messaging/latest/"}],"source_content_type":"text/x-rst","patch_set":10,"id":"8e0e2efc_81874fe2","line":13,"range":{"start_line":13,"start_character":55,"end_line":13,"end_character":60},"updated":"2020-11-30 16:48:27.000000000","message":"s/emit\n\nand there is an extra space before it","commit_id":"218bd3608a9d4b1ea4c98205e20203e952c5082d"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2efce3ed558d9bae455a9dc99837b2cb652fb1ff","unresolved":true,"context_lines":[{"line_number":27,"context_line":"4. 3rd party applications can audit and log actions with objects."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Proposed change"},{"line_number":30,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Create loadbalancer notification:"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"74dd5fb0_f0eb98a5","line":30,"updated":"2020-11-30 16:48:27.000000000","message":"I think you should put a short paragraph here describing the proposed changes, even if it\u0027s something as simple as:\n\n\"Change Octavia to emit notifications to the message bus for the following events.\"","commit_id":"218bd3608a9d4b1ea4c98205e20203e952c5082d"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2efce3ed558d9bae455a9dc99837b2cb652fb1ff","unresolved":true,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Proposed change"},{"line_number":30,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Create loadbalancer notification:"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    * Send a notification to inform Ceilometer the loadbalance"}],"source_content_type":"text/x-rst","patch_set":10,"id":"c61a39b0_4cbe53eb","line":31,"updated":"2020-11-30 16:48:27.000000000","message":"The below sections render with a grey bar in front of a bullet, should probably just be a bullet.\n\nhttps://38c022455dae90616aa1-8156621505f6355ffb6896f9b15e0b7a.ssl.cf2.rackcdn.com/727915/10/check/openstack-tox-docs/fa8a9e4/docs/contributor/specs/version1.2/notifications_support.html","commit_id":"218bd3608a9d4b1ea4c98205e20203e952c5082d"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2efce3ed558d9bae455a9dc99837b2cb652fb1ff","unresolved":true,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    * It is possible that some drivers can send a create.progress"},{"line_number":158,"context_line":"      notifications periodically"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"The Octavia loadbalancer information send to the notification bus includes id,"},{"line_number":161,"context_line":"project id, name, provisioning_status, operating_status,create_time,"},{"line_number":162,"context_line":"provider and fail reason."}],"source_content_type":"text/x-rst","patch_set":10,"id":"6539ee13_e6c8cbe2","line":159,"updated":"2020-11-30 16:48:27.000000000","message":"The below sentences each refer to (possibly) multiple sections above, maybe it would be better to organize things differently?  Just a thought, for exampe:\n\nRule notifications\n* Sent to inform Ceilometer when a rule create, delete or update begins and ends.\n* The rule information sent must include ID, project ID, ...","commit_id":"218bd3608a9d4b1ea4c98205e20203e952c5082d"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2efce3ed558d9bae455a9dc99837b2cb652fb1ff","unresolved":true,"context_lines":[{"line_number":157,"context_line":"    * It is possible that some drivers can send a create.progress"},{"line_number":158,"context_line":"      notifications periodically"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"The Octavia loadbalancer information send to the notification bus includes id,"},{"line_number":161,"context_line":"project id, name, provisioning_status, operating_status,create_time,"},{"line_number":162,"context_line":"provider and fail reason."},{"line_number":163,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"6b94c8ad_942a138f","line":160,"range":{"start_line":160,"start_character":37,"end_line":160,"end_character":41},"updated":"2020-11-30 16:48:27.000000000","message":"s/sent\n\nSame in paragraphs right below this as well.  Sorry I didn\u0027t notice the first time.","commit_id":"218bd3608a9d4b1ea4c98205e20203e952c5082d"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2efce3ed558d9bae455a9dc99837b2cb652fb1ff","unresolved":true,"context_lines":[{"line_number":204,"context_line":"Security impact"},{"line_number":205,"context_line":"---------------"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"The notifications sent onto notification bus should not contain"},{"line_number":208,"context_line":"security content."},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"Notifications impact"}],"source_content_type":"text/x-rst","patch_set":10,"id":"bb69e3de_162bdc6d","line":207,"range":{"start_line":207,"start_character":23,"end_line":207,"end_character":27},"updated":"2020-11-30 16:48:27.000000000","message":"s/onto the","commit_id":"218bd3608a9d4b1ea4c98205e20203e952c5082d"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2efce3ed558d9bae455a9dc99837b2cb652fb1ff","unresolved":true,"context_lines":[{"line_number":210,"context_line":"Notifications impact"},{"line_number":211,"context_line":"--------------------"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"Yes, this feature implements notification."},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"Other end user impact"},{"line_number":216,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":10,"id":"9651a3b1_f958dd4c","line":213,"range":{"start_line":213,"start_character":29,"end_line":213,"end_character":41},"updated":"2020-11-30 16:48:27.000000000","message":"s/notifications","commit_id":"218bd3608a9d4b1ea4c98205e20203e952c5082d"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2efce3ed558d9bae455a9dc99837b2cb652fb1ff","unresolved":true,"context_lines":[{"line_number":268,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"Add unit test."},{"line_number":271,"context_line":"This feature just has impacts on Octavia project, so unit test is sufficient."},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"Documentation Impact"},{"line_number":274,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":10,"id":"413a0a5f_2877a03a","line":271,"range":{"start_line":271,"start_character":30,"end_line":271,"end_character":32},"updated":"2020-11-30 16:48:27.000000000","message":"s/on the","commit_id":"218bd3608a9d4b1ea4c98205e20203e952c5082d"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2efce3ed558d9bae455a9dc99837b2cb652fb1ff","unresolved":true,"context_lines":[{"line_number":268,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"Add unit test."},{"line_number":271,"context_line":"This feature just has impacts on Octavia project, so unit test is sufficient."},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"Documentation Impact"},{"line_number":274,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":10,"id":"9dd22457_50b7ea24","line":271,"range":{"start_line":271,"start_character":58,"end_line":271,"end_character":62},"updated":"2020-11-30 16:48:27.000000000","message":"s/testing","commit_id":"218bd3608a9d4b1ea4c98205e20203e952c5082d"}]}