)]}'
{"octavia/amphorae/drivers/haproxy/rest_api_driver.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"113443fb937d96253fdfaa168121c4e72fad8760","unresolved":false,"context_lines":[{"line_number":699,"context_line":"            except requests.exceptions.SSLError as e:"},{"line_number":700,"context_line":"                # requests.exceptions.SSLError inherits from"},{"line_number":701,"context_line":"                # requests.ConnectionError, it should be tested first"},{"line_number":702,"context_line":"                raise driver_except.AmpSSLConnectionError("},{"line_number":703,"context_line":"                    exception\u003dstr(e)) from None"},{"line_number":704,"context_line":"            except (requests.ConnectionError, requests.Timeout) as e:"},{"line_number":705,"context_line":"                exception \u003d e"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_a2f7ad59","line":702,"updated":"2020-09-16 19:40:42.000000000","message":"Help me understand the benefit and use case around this.\nWe have the retries here to get around transient or timing related issues. Why should this case have no retries at all over the other failure cases?","commit_id":"bba3a3f2fa8f157c77fde23629c9d3727516ba7d"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"16ff43d4e8eb159b800b88a9b1585628b2749e29","unresolved":false,"context_lines":[{"line_number":699,"context_line":"            except requests.exceptions.SSLError as e:"},{"line_number":700,"context_line":"                # requests.exceptions.SSLError inherits from"},{"line_number":701,"context_line":"                # requests.ConnectionError, it should be tested first"},{"line_number":702,"context_line":"                raise driver_except.AmpSSLConnectionError("},{"line_number":703,"context_line":"                    exception\u003dstr(e)) from None"},{"line_number":704,"context_line":"            except (requests.ConnectionError, requests.Timeout) as e:"},{"line_number":705,"context_line":"                exception \u003d e"}],"source_content_type":"text/x-python","patch_set":1,"id":"935bce71_96bf4be1","line":702,"in_reply_to":"9f560f44_a2f7ad59","updated":"2021-02-03 09:25:04.000000000","message":"SSLError means that the amphora-agent replies to the client but there\u0027s probably a certificate issue. It happened to me with expired certificates, and there\u0027s no chance that an expired certificate will work after a few retries.\n\nSSLError might include some other errors as well, so perhaps we can add a retry on SSLError but with a very small timeout?","commit_id":"bba3a3f2fa8f157c77fde23629c9d3727516ba7d"}]}