)]}'
{"diskimage-create/diskimage-create.sh":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"fa9f699f51217c18b149eff8d4fa59b41fd4a63f","unresolved":false,"context_lines":[{"line_number":255,"context_line":""},{"line_number":256,"context_line":"AMP_DISABLE_TMP_FS\u003d${AMP_DISABLE_TMP_FS:-\"\"}"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"#if [ [ \"$AMP_BASEOS\" \u003d \"rhel\" ] || [ \"$AMP_BASEOS\" \u003d \"centos-minimal\" ] || [ \"$AMP_BASEOS\" \u003d \"fedora\" ] ] \u0026\u0026 [ \"$AMP_IMAGESIZE\" -lt 3 ]; then"},{"line_number":259,"context_line":"if [[ \"$AMP_BASEOS\" \u003d~ ^(rhel|centos-minimal|fedora)$ ]] \u0026\u0026 [[ \"$AMP_IMAGESIZE\" -lt 3 ]]; then"},{"line_number":260,"context_line":"    echo \"RHEL/CentOS based amphora requires an image size of at least 3GB\""},{"line_number":261,"context_line":"    exit 1"}],"source_content_type":"text/x-sh","patch_set":2,"id":"bf51134e_1088386f","line":258,"updated":"2020-06-18 21:22:51.000000000","message":"I don\u0027t think we need this comment.","commit_id":"28795fbc872174fcf69c1ec0e334531281105f19"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"893453eae4670048fe6ff0f645ed8ccad348ac2f","unresolved":false,"context_lines":[{"line_number":338,"context_line":"        # Also check if we can build the BASEOS on this Ubuntu version"},{"line_number":339,"context_line":"        UBUNTU_VERSION\u003d$(lsb_release -r | awk \u0027{print $2}\u0027)"},{"line_number":340,"context_line":"        if [ \"$AMP_BASEOS\" !\u003d \"ubuntu-minimal\" ] \u0026\u0026 \\"},{"line_number":341,"context_line":"            [ 1 -eq \"$(echo \"$UBUNTU_VERSION \u003c 16.04\" | bc)\" ]; then"},{"line_number":342,"context_line":"                echo \"Ubuntu minimum version 16.04 required to build $AMP_BASEOS.\""},{"line_number":343,"context_line":"                echo \"Earlier versions don\u0027t support the extended attributes required.\""},{"line_number":344,"context_line":"                exit 1"}],"source_content_type":"text/x-sh","patch_set":2,"id":"bf51134e_cb55751f","line":341,"updated":"2020-06-18 22:58:56.000000000","message":"pep8: E044 Use [[ for non-POSIX comparisions","commit_id":"28795fbc872174fcf69c1ec0e334531281105f19"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"893453eae4670048fe6ff0f645ed8ccad348ac2f","unresolved":false,"context_lines":[{"line_number":348,"context_line":"        DEBIAN_VERSION\u003d$(lsb_release -r | awk \u0027{print $2}\u0027)"},{"line_number":349,"context_line":"        # As minimal Ubuntu version is 14.04, for debian it is Debian 8 Jessie"},{"line_number":350,"context_line":"        if [ \"$AMP_BASEOS\" !\u003d \"ubuntu-minimal\" ] \u0026\u0026 \\"},{"line_number":351,"context_line":"            [ 1 -eq \"$(echo \"$DEBIAN_VERSION \u003c 8\" | bc)\" ]; then"},{"line_number":352,"context_line":"                echo \"Debian minimum version 8 required to build $AMP_BASEOS.\""},{"line_number":353,"context_line":"                echo \"Earlier versions don\u0027t support the extended attributes required.\""},{"line_number":354,"context_line":"                exit 1"}],"source_content_type":"text/x-sh","patch_set":2,"id":"bf51134e_2b323111","line":351,"updated":"2020-06-18 22:58:56.000000000","message":"pep8: E044 Use [[ for non-POSIX comparisions","commit_id":"28795fbc872174fcf69c1ec0e334531281105f19"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"7482ce63c6e8af637906571bba136b229f9730f8","unresolved":false,"context_lines":[{"line_number":255,"context_line":""},{"line_number":256,"context_line":"AMP_DISABLE_TMP_FS\u003d${AMP_DISABLE_TMP_FS:-\"\"}"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"if [[ \"$AMP_BASEOS\" \u003d~ ^(rhel|centos-minimal|fedora)$ ]] \u0026\u0026 [[ \"$AMP_IMAGESIZE\" -lt 3 ]]; then"},{"line_number":259,"context_line":"    echo \"RHEL/CentOS based amphora requires an image size of at least 3GB\""},{"line_number":260,"context_line":"    exit 1"},{"line_number":261,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"bf51134e_ebcf84ad","line":258,"updated":"2020-06-19 19:46:14.000000000","message":"I\u0027ve been meaning to make this change for a long time. Thanks!","commit_id":"d8d722b54d890caff988a4a97e75fa27b23adbed"}]}