)]}'
{"octavia/common/config.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"bc2b154863f930349846de4a33633060b4f178cd","unresolved":false,"context_lines":[{"line_number":480,"context_line":"               choices\u003dconstants.SUPPORTED_VOLUME_DRIVERS,"},{"line_number":481,"context_line":"               help\u003d_(\u0027Name of the volume driver to use\u0027)),"},{"line_number":482,"context_line":"    cfg.StrOpt(\u0027image_driver\u0027,"},{"line_number":483,"context_line":"               default\u003dconstants.IMAGE_NOOP_DRIVER,"},{"line_number":484,"context_line":"               choices\u003dconstants.SUPPORTED_IMAGE_DRIVERS,"},{"line_number":485,"context_line":"               help\u003d_(\u0027Name of the image driver to use\u0027)),"},{"line_number":486,"context_line":"    cfg.StrOpt(\u0027distributor_driver\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_97d1a9fe","line":483,"updated":"2020-07-09 21:50:36.000000000","message":"Why not have glance as the default? That would mirror the behavior prior to this patch.\nIt seems like this will break all of the deployer projects.","commit_id":"4fb7f3e4ea30209f9494ab3bb2fe96326995c9c1"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"107e58920412a2e597572f95081081f138f38186","unresolved":false,"context_lines":[{"line_number":480,"context_line":"               choices\u003dconstants.SUPPORTED_VOLUME_DRIVERS,"},{"line_number":481,"context_line":"               help\u003d_(\u0027Name of the volume driver to use\u0027)),"},{"line_number":482,"context_line":"    cfg.StrOpt(\u0027image_driver\u0027,"},{"line_number":483,"context_line":"               default\u003dconstants.IMAGE_NOOP_DRIVER,"},{"line_number":484,"context_line":"               choices\u003dconstants.SUPPORTED_IMAGE_DRIVERS,"},{"line_number":485,"context_line":"               help\u003d_(\u0027Name of the image driver to use\u0027)),"},{"line_number":486,"context_line":"    cfg.StrOpt(\u0027distributor_driver\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_c7ea1c0d","line":483,"in_reply_to":"9f560f44_47d28c29","updated":"2020-08-25 19:26:55.000000000","message":"I would be more in favor of switching the other defaults to live drivers as that is less likely to break people (it\u0027s ok if they already have settings defined for these, it will just override the new default).\nI don\u0027t like adding a new setting for an existing capability that breaks deployments by it\u0027s default setting.","commit_id":"4fb7f3e4ea30209f9494ab3bb2fe96326995c9c1"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"e20f2547617faa6833dab93fd26d77001269cdd1","unresolved":false,"context_lines":[{"line_number":480,"context_line":"               choices\u003dconstants.SUPPORTED_VOLUME_DRIVERS,"},{"line_number":481,"context_line":"               help\u003d_(\u0027Name of the volume driver to use\u0027)),"},{"line_number":482,"context_line":"    cfg.StrOpt(\u0027image_driver\u0027,"},{"line_number":483,"context_line":"               default\u003dconstants.IMAGE_NOOP_DRIVER,"},{"line_number":484,"context_line":"               choices\u003dconstants.SUPPORTED_IMAGE_DRIVERS,"},{"line_number":485,"context_line":"               help\u003d_(\u0027Name of the image driver to use\u0027)),"},{"line_number":486,"context_line":"    cfg.StrOpt(\u0027distributor_driver\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_f8660dbb","line":483,"in_reply_to":"bf51134e_97d1a9fe","updated":"2020-07-10 20:34:42.000000000","message":"True on the deployer projects part. I set the default to the noop driver to be in line with compute, network and volume. I don\u0027t see a point in having a mixed environment but maybe I\u0027m missing something. We can also discuss changing these interface driver defaults to recommended ones (i.e. nova for compute, neutron AAP for network).","commit_id":"4fb7f3e4ea30209f9494ab3bb2fe96326995c9c1"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1ea7dce4fe42112e0b4d0575971682d532ed95d7","unresolved":false,"context_lines":[{"line_number":480,"context_line":"               choices\u003dconstants.SUPPORTED_VOLUME_DRIVERS,"},{"line_number":481,"context_line":"               help\u003d_(\u0027Name of the volume driver to use\u0027)),"},{"line_number":482,"context_line":"    cfg.StrOpt(\u0027image_driver\u0027,"},{"line_number":483,"context_line":"               default\u003dconstants.IMAGE_NOOP_DRIVER,"},{"line_number":484,"context_line":"               choices\u003dconstants.SUPPORTED_IMAGE_DRIVERS,"},{"line_number":485,"context_line":"               help\u003d_(\u0027Name of the image driver to use\u0027)),"},{"line_number":486,"context_line":"    cfg.StrOpt(\u0027distributor_driver\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_47d28c29","line":483,"in_reply_to":"bf51134e_f8660dbb","updated":"2020-08-06 22:32:35.000000000","message":"I would still argue the pain to the deployment projects out weights the \"do it like the above drivers\". Maybe other cores will have an opinion.","commit_id":"4fb7f3e4ea30209f9494ab3bb2fe96326995c9c1"}],"octavia/image/drivers/glance_driver.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"bc2b154863f930349846de4a33633060b4f178cd","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        :return: image id"},{"line_number":51,"context_line":"        \"\"\""},{"line_number":52,"context_line":"        filters \u003d {\u0027tag\u0027: [image_tag],"},{"line_number":53,"context_line":"                   \u0027owner\u0027: image_owner,"},{"line_number":54,"context_line":"                   \u0027status\u0027: constants.GLANCE_IMAGE_ACTIVE}"},{"line_number":55,"context_line":"        if image_owner:"},{"line_number":56,"context_line":"            filters.update({\u0027owner\u0027: image_owner})"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_d745e1b5","line":53,"updated":"2020-07-09 21:50:36.000000000","message":"This is duplicate to line 56","commit_id":"4fb7f3e4ea30209f9494ab3bb2fe96326995c9c1"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"e6f1e85bbf9ef09a308408efa0fbef83860a1e5c","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        :return: image id"},{"line_number":51,"context_line":"        \"\"\""},{"line_number":52,"context_line":"        filters \u003d {\u0027tag\u0027: [image_tag],"},{"line_number":53,"context_line":"                   \u0027owner\u0027: image_owner,"},{"line_number":54,"context_line":"                   \u0027status\u0027: constants.GLANCE_IMAGE_ACTIVE}"},{"line_number":55,"context_line":"        if image_owner:"},{"line_number":56,"context_line":"            filters.update({\u0027owner\u0027: image_owner})"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_592138fc","line":53,"in_reply_to":"bf51134e_d745e1b5","updated":"2020-07-23 12:38:26.000000000","message":"Done","commit_id":"4fb7f3e4ea30209f9494ab3bb2fe96326995c9c1"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"cfd089322aaf38f9548b6e1b2c1636b5a087f696","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        filters \u003d {\u0027tag\u0027: [image_tag],"},{"line_number":53,"context_line":"                   \u0027owner\u0027: image_owner,"},{"line_number":54,"context_line":"                   \u0027status\u0027: constants.GLANCE_IMAGE_ACTIVE}"},{"line_number":55,"context_line":"        if image_owner:"},{"line_number":56,"context_line":"            filters.update({\u0027owner\u0027: image_owner})"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        images \u003d list(self.manager.list("}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_f767454c","line":55,"updated":"2020-07-09 21:51:38.000000000","message":"Missing branch test coverage.","commit_id":"4fb7f3e4ea30209f9494ab3bb2fe96326995c9c1"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"e6f1e85bbf9ef09a308408efa0fbef83860a1e5c","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        filters \u003d {\u0027tag\u0027: [image_tag],"},{"line_number":53,"context_line":"                   \u0027owner\u0027: image_owner,"},{"line_number":54,"context_line":"                   \u0027status\u0027: constants.GLANCE_IMAGE_ACTIVE}"},{"line_number":55,"context_line":"        if image_owner:"},{"line_number":56,"context_line":"            filters.update({\u0027owner\u0027: image_owner})"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        images \u003d list(self.manager.list("}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_b92054f9","line":55,"in_reply_to":"bf51134e_f767454c","updated":"2020-07-23 12:38:26.000000000","message":"Done","commit_id":"4fb7f3e4ea30209f9494ab3bb2fe96326995c9c1"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"036bc3370acea97960e182b9f1ff9ab33308a270","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            raise exceptions.ImageGetException(tag\u003dimage_tag)"},{"line_number":62,"context_line":"        image_id \u003d images[0][\u0027id\u0027]"},{"line_number":63,"context_line":"        num_images \u003d len(images)"},{"line_number":64,"context_line":"        if num_images \u003e 1:"},{"line_number":65,"context_line":"            LOG.warning(\"A single Glance image should be tagged with %(tag)s \""},{"line_number":66,"context_line":"                        \"tag, but at least two were found. Using \""},{"line_number":67,"context_line":"                        \"%(image_id)s.\","}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_b316af48","line":64,"updated":"2020-09-03 20:00:44.000000000","message":"nit: num_images is only used for this test, so why assign it? it could just be \"if len(images) \u003e 1:\"","commit_id":"f9205e569a2af89b23065da9aa5e6a0f413f56fc"}],"releasenotes/notes/add-c9b9401b831efb25.yaml":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"bc2b154863f930349846de4a33633060b4f178cd","unresolved":false,"context_lines":[{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    When the amphora provider driver is enabled, operators need to set option"},{"line_number":9,"context_line":"    ``[controller_worker]/image_driver``. The default image driver is"},{"line_number":10,"context_line":"    ``image_noop_driver``. Real deployments require ``image_glance_driver``."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bf51134e_f77e25e2","line":10,"updated":"2020-07-09 21:50:36.000000000","message":"I think the default should be set like real deployments will need it set.","commit_id":"4fb7f3e4ea30209f9494ab3bb2fe96326995c9c1"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"e20f2547617faa6833dab93fd26d77001269cdd1","unresolved":false,"context_lines":[{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    When the amphora provider driver is enabled, operators need to set option"},{"line_number":9,"context_line":"    ``[controller_worker]/image_driver``. The default image driver is"},{"line_number":10,"context_line":"    ``image_noop_driver``. Real deployments require ``image_glance_driver``."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bf51134e_d821894f","line":10,"in_reply_to":"bf51134e_f77e25e2","updated":"2020-07-10 20:34:42.000000000","message":"Same comment here: we don´t set the compute, network (and volume) to their production/non no-nop drivers by default either.","commit_id":"4fb7f3e4ea30209f9494ab3bb2fe96326995c9c1"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"543dc2a247be9fe44f6679c854431eb4a3f96186","unresolved":false,"context_lines":[{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    When the amphora provider driver is enabled, operators need to set option"},{"line_number":9,"context_line":"    ``[controller_worker]/image_driver``. The default image driver is"},{"line_number":10,"context_line":"    ``image_noop_driver``. Real deployments require ``image_glance_driver``."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9f560f44_20ea5e0d","line":10,"range":{"start_line":10,"start_character":6,"end_line":10,"end_character":23},"updated":"2020-09-02 19:15:02.000000000","message":"Isn\u0027t the default image_glance_driver?  Or maybe I\u0027m misunderstanding the upgrade issue.","commit_id":"d9ba715e7801683147569e857ba58e47be9193e0"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"82c35bedb3fcbd064ebb19694a75f789a5f2f9ab","unresolved":false,"context_lines":[{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    When the amphora provider driver is enabled, operators need to set option"},{"line_number":9,"context_line":"    ``[controller_worker]/image_driver``. The default image driver is"},{"line_number":10,"context_line":"    ``image_noop_driver``. Real deployments require ``image_glance_driver``."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9f560f44_aecad89d","line":10,"range":{"start_line":10,"start_character":6,"end_line":10,"end_character":23},"in_reply_to":"9f560f44_20ea5e0d","updated":"2020-09-03 06:31:36.000000000","message":"Seems it was not fixed to fit latest patch set.","commit_id":"d9ba715e7801683147569e857ba58e47be9193e0"}]}