)]}'
{"id":"openstack%2Foctavia~738070","triplet_id":"openstack%2Foctavia~master~I7b8f7c7d653b37395f9a660be67f954a3a6f26d9","project":"openstack/octavia","branch":"master","hashtags":[],"change_id":"I7b8f7c7d653b37395f9a660be67f954a3a6f26d9","subject":"Fix neutron subnet lookup ignoring endpoint_type","status":"MERGED","created":"2020-06-25 17:09:05.000000000","updated":"2020-06-26 19:26:31.000000000","submitted":"2020-06-26 19:23:45.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"738070-1593199426074-9fea2b71","meta_rev_id":"890305b159281a156baa7da094887d8c48c5dbdd","_number":738070,"virtual_id_number":738070,"owner":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},{"value":0,"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},{"value":0,"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},{"value":0,"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-06-26 19:23:45.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"all":[{"value":2,"date":"2020-06-26 16:48:27.000000000","_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},{"value":2,"date":"2020-06-25 20:21:01.000000000","_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},{"value":1,"date":"2020-06-25 20:31:13.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},{"value":0,"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"all":[{"value":1,"date":"2020-06-26 16:48:27.000000000","_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},{"value":0,"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},{"value":0,"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},{"value":0,"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"approved":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"all":[{"value":0,"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},{"value":0,"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},{"value":0,"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},{"value":2,"date":"2020-06-25 17:10:41.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-06-25 20:21:01.000000000","updated_by":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"reviewer":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"state":"REVIEWER"},{"updated":"2020-06-25 20:31:13.000000000","updated_by":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"reviewer":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"state":"REVIEWER"},{"updated":"2020-06-26 16:48:27.000000000","updated_by":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"reviewer":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"state":"REVIEWER"},{"updated":"2020-06-26 19:23:45.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"2df19931c0fd1266a12b1afdbf8bfd3e1e46b2fa","author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"date":"2020-06-25 17:09:05.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"87ac6c03c1cdbae2bf9fb5c79c2a6d21a12d9dde","author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"date":"2020-06-25 17:09:34.000000000","message":"Patch Set 1: Backport-Candidate+2\n\nThis needs to be backported.","accounts_in_message":[],"_revision_number":1},{"id":"0f28b3e455279e089b70092a262c05a1790381bb","author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"date":"2020-06-25 17:10:41.000000000","message":"Patch Set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"2bdeb3e5690a537a16650ddef139b4feed0c7dc5","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-25 20:12:55.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/bf4200291c70489595d03b0aba41cd71 : SUCCESS in 10m 32s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/b1736ab156dd44669cd7555e80224587 : SUCCESS in 11m 10s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a85ccbf921e14d7fab1decc0d1e943bd : SUCCESS in 7m 38s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/bcfd2f2b2ffc4a4ab9755d86de7504ea : SUCCESS in 8m 27s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/6040746a8a3e43f6b43b1abc8d707f47 : SUCCESS in 5m 21s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/249530d3311e403d82d491fd0e9adb9b : SUCCESS in 10m 42s\n- octavia-tox-py37-tips https://zuul.opendev.org/t/openstack/build/c09c5f41c62e4fed8b8c543f5dc79342 : SUCCESS in 5m 14s\n- octavia-tox-functional-py37-tips https://zuul.opendev.org/t/openstack/build/220d9eb302834b81bd78b580fb1c5e29 : SUCCESS in 8m 31s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/b15616ed2b014e63bf9ed429af510b3a : SUCCESS in 7m 33s\n- octavia-v2-dsvm-noop-api https://zuul.opendev.org/t/openstack/build/9829bb5da1994e6c829b85659e5efa0f : SUCCESS in 46m 19s\n- octavia-v2-dsvm-scenario https://zuul.opendev.org/t/openstack/build/36cb702ea54542e3b5e27221c9c7abca : SUCCESS in 56m 24s\n- octavia-v2-dsvm-tls-barbican https://zuul.opendev.org/t/openstack/build/965d660451da4257a8b939801c1272f9 : SUCCESS in 1h 00m 27s\n- octavia-v2-dsvm-spare-pool https://zuul.opendev.org/t/openstack/build/ed437ce46a954f48887852ab042e8394 : SUCCESS in 1h 00m 36s\n- octavia-v2-act-stdby-dsvm-scenario https://zuul.opendev.org/t/openstack/build/f0a9442bafd241d89e9975352d46170b : SUCCESS in 1h 03m 53s\n- octavia-grenade https://zuul.opendev.org/t/openstack/build/2983980568d548d88c26821342af8f45 : SUCCESS in 1h 37m 59s\n- octavia-v2-dsvm-cinder-amphora https://zuul.opendev.org/t/openstack/build/e0917adc6837480a8e201f15da83d6ee : SUCCESS in 1h 59m 07s (non-voting)\n- octavia-v2-dsvm-scenario-two-node https://zuul.opendev.org/t/openstack/build/77851f22e963455384dbda6cc4b61962 : SUCCESS in 2h 06m 33s (non-voting)\n- octavia-v2-dsvm-scenario-amphora-v2 https://zuul.opendev.org/t/openstack/build/3fb0e8993044494eaecdebfbbd235f8f : SUCCESS in 45m 18s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"1e6d92adf035200ac96664fedeb8972df2148fe5","author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"date":"2020-06-25 20:21:01.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"8cb844713bb315c629147e6aac160eb79dbb1b68","author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"date":"2020-06-25 20:31:13.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"086c4b196cc3440966907980b21ae652f7807125","author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"date":"2020-06-26 16:48:27.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"1ee23f336c637383b6d218c2cb642ad440cd2484","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-26 16:48:45.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"418a307662d2e1c24cf212159c1fa30810ad157c","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-26 19:23:45.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/5e4fc2a474694a73ae2a0ee4462828b9 : SUCCESS in 13m 22s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/f2ae807cff954b4fae82775febd7ef2c : SUCCESS in 9m 13s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/ad0f9f8d4dc4462eb620d99944f5a99e : SUCCESS in 9m 20s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/36a1f98e59064045963efb17a3bb045b : SUCCESS in 10m 05s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/42d48fdd74db4dfc93bd6156f90b9237 : SUCCESS in 18m 46s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/09cd0c970b45461f9080b3e2a32e2645 : SUCCESS in 12m 03s\n- octavia-v2-dsvm-noop-api https://zuul.opendev.org/t/openstack/build/72da0b8e3f614bcab74f216c76fa1024 : SUCCESS in 57m 48s\n- octavia-v2-dsvm-scenario https://zuul.opendev.org/t/openstack/build/6974f7179ded45faacee100311abcef3 : SUCCESS in 1h 14m 05s\n- octavia-v2-dsvm-tls-barbican https://zuul.opendev.org/t/openstack/build/c503dd7f390c4300a446dfd1e246b0ff : SUCCESS in 1h 02m 57s\n- octavia-v2-dsvm-spare-pool https://zuul.opendev.org/t/openstack/build/83db005aaaa949ab96423525449ae3bd : SUCCESS in 59m 43s\n- octavia-v2-act-stdby-dsvm-scenario https://zuul.opendev.org/t/openstack/build/ff17b61104fe47e9ae43b8ba9986a554 : SUCCESS in 1h 03m 52s\n- octavia-grenade https://zuul.opendev.org/t/openstack/build/997e750e995c44ff8d6193730e62dcfa : SUCCESS in 1h 42m 43s","accounts_in_message":[],"_revision_number":2},{"id":"ae18d96892c7f7f0b2125c0c75cc4f5f49bb0276","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-26 19:23:46.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"e010498d92a42892da4a5a9e652be2770664e244","author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"date":"2020-06-26 19:24:32.000000000","message":"Patch Set 2: Cherry Picked\n\nThis patchset was cherry picked to branch stable/ussuri as commit b4bc92ebf1a5610cb340299d6230a134f202bfbb","accounts_in_message":[],"_revision_number":2},{"id":"890305b159281a156baa7da094887d8c48c5dbdd","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-26 19:26:31.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/79b67511f6424ce6aa6a0f76ae10e59a : SUCCESS in 2m 21s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"40731e572f2b503a3ccc603642a3721a5ce1cf7a","revisions":{"b4b0fa01009b1dc71db1a1c6e8179831f6dd85c8":{"kind":"REWORK","_number":1,"created":"2020-06-25 17:09:05.000000000","uploader":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"ref":"refs/changes/70/738070/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/octavia","ref":"refs/changes/70/738070/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/octavia refs/changes/70/738070/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/octavia refs/changes/70/738070/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/octavia refs/changes/70/738070/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/octavia refs/changes/70/738070/1"}}},"commit":{"parents":[{"commit":"41c628a084002017d2003926cf0e25ba3ffeee0c","subject":"Fix missing params in amphora base and noop driver","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/41c628a084002017d2003926cf0e25ba3ffeee0c"}]}],"author":{"name":"Michael Johnson","email":"johnsomor@gmail.com","date":"2020-06-25 17:05:54.000000000","tz":-420},"committer":{"name":"Michael Johnson","email":"johnsomor@gmail.com","date":"2020-06-25 17:09:04.000000000","tz":-420},"subject":"Fix neutron subnet lookup ignoring endpoint_type","message":"Fix neutron subnet lookup ignoring endpoint_type\n\nThe recent patch that adds a neutron subnet lookup using the user\ncontext is not honoring the interface/endpoint_type or region_name\nsettings for neutron in the octavia configuration file.\nThis is causing problems for deployments that use the \"internal\"\nendpoint for neutron and the current code will always return\nthe \"public\" endpoint.\nThis patch corrects this problem by including those filter\nparameters when the neutron endpoint is looked up in keystone.\n\nChange-Id: I7b8f7c7d653b37395f9a660be67f954a3a6f26d9\nStory: 2007863\nTask: 40173\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/b4b0fa01009b1dc71db1a1c6e8179831f6dd85c8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/b4b0fa01009b1dc71db1a1c6e8179831f6dd85c8"}]},"branch":"refs/heads/master"},"40731e572f2b503a3ccc603642a3721a5ce1cf7a":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2020-06-25 17:10:41.000000000","uploader":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"ref":"refs/changes/70/738070/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/octavia","ref":"refs/changes/70/738070/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/octavia refs/changes/70/738070/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/octavia refs/changes/70/738070/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/octavia refs/changes/70/738070/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/octavia refs/changes/70/738070/2"}}},"commit":{"parents":[{"commit":"41c628a084002017d2003926cf0e25ba3ffeee0c","subject":"Fix missing params in amphora base and noop driver","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/41c628a084002017d2003926cf0e25ba3ffeee0c"}]}],"author":{"name":"Michael Johnson","email":"johnsomor@gmail.com","date":"2020-06-25 17:05:54.000000000","tz":-420},"committer":{"name":"Michael Johnson","email":"johnsomor@gmail.com","date":"2020-06-25 17:10:38.000000000","tz":0},"subject":"Fix neutron subnet lookup ignoring endpoint_type","message":"Fix neutron subnet lookup ignoring endpoint_type\n\nThe recent patch[1] that adds a neutron subnet lookup using the user\ncontext is not honoring the interface/endpoint_type or region_name\nsettings for neutron in the octavia configuration file.\nThis is causing problems for deployments that use the \"internal\"\nendpoint for neutron and the current code will always return\nthe \"public\" endpoint.\nThis patch corrects this problem by including those filter\nparameters when the neutron endpoint is looked up in keystone.\n\n[1] https://review.opendev.org/726042\n\nChange-Id: I7b8f7c7d653b37395f9a660be67f954a3a6f26d9\nStory: 2007863\nTask: 40173\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/40731e572f2b503a3ccc603642a3721a5ce1cf7a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/40731e572f2b503a3ccc603642a3721a5ce1cf7a"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}