)]}'
{"devstack/plugin.sh":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"94e8eb33f5da840d8a81110c2fc984a39c8d858e","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        exit 1"},{"line_number":123,"context_line":"    fi"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    upload_image file://${OCTAVIA_AMP_IMAGE_FILE} $TOKEN"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"}"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-sh","patch_set":11,"id":"bf51134e_001fca07","line":125,"updated":"2020-06-26 15:40:37.000000000","message":"I think we need to add a step after this which tags the image as aarch64 in glance.\n\nhttps://docs.openstack.org/python-glanceclient/latest/cli/property-keys.html","commit_id":"92229e0eb882df09e1536c157fd478e11831a5b6"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"c44f9eb9d413e3181ce71a7b86d56e3c5fa31fbd","unresolved":true,"context_lines":[{"line_number":102,"context_line":"    if [[ ${OCTAVIA_AMP_IMAGE_SIZE:+1} ]] ; then"},{"line_number":103,"context_line":"        export PARAM_OCTAVIA_AMP_IMAGE_SIZE\u003d\u0027-s \u0027$OCTAVIA_AMP_IMAGE_SIZE"},{"line_number":104,"context_line":"    fi"},{"line_number":105,"context_line":"    if [[ ${OCTAVIA_AMP_IMAGE_ARCH:+1} ]] ; then"},{"line_number":106,"context_line":"        export PARAM_OCTAVIA_AMP_IMAGE_ARCH\u003d\u0027-a \u0027$OCTAVIA_AMP_IMAGE_ARCH"},{"line_number":107,"context_line":"    fi"},{"line_number":108,"context_line":"    if [[ \"$(trueorfalse False OCTAVIA_AMP_DISABLE_TMP_FS)\" \u003d\u003d \"True\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":33,"id":"48982b12_7fbc6bc6","line":105,"updated":"2021-03-06 22:58:15.000000000","message":"This implies that OCTAVIA_AMP_IMAGE_ARCH could possibly be unset -- see below comment for why this matters. I see there is a default set in our plugin, but we should either REQUIRE IT (and not have to guard here) or not require it, which would require a guard below.","commit_id":"281300033b9f13933af9f374d74a9a92766f4dfd"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"1d0ad643335ccdd852050c31a94142e1466bf2bd","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    if [[ ${OCTAVIA_AMP_IMAGE_SIZE:+1} ]] ; then"},{"line_number":103,"context_line":"        export PARAM_OCTAVIA_AMP_IMAGE_SIZE\u003d\u0027-s \u0027$OCTAVIA_AMP_IMAGE_SIZE"},{"line_number":104,"context_line":"    fi"},{"line_number":105,"context_line":"    if [[ ${OCTAVIA_AMP_IMAGE_ARCH:+1} ]] ; then"},{"line_number":106,"context_line":"        export PARAM_OCTAVIA_AMP_IMAGE_ARCH\u003d\u0027-a \u0027$OCTAVIA_AMP_IMAGE_ARCH"},{"line_number":107,"context_line":"    fi"},{"line_number":108,"context_line":"    if [[ \"$(trueorfalse False OCTAVIA_AMP_DISABLE_TMP_FS)\" \u003d\u003d \"True\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":33,"id":"b7d22bbc_d424c1b7","line":105,"in_reply_to":"48982b12_7fbc6bc6","updated":"2021-03-09 09:34:00.000000000","message":"Done","commit_id":"281300033b9f13933af9f374d74a9a92766f4dfd"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"c44f9eb9d413e3181ce71a7b86d56e3c5fa31fbd","unresolved":true,"context_lines":[{"line_number":577,"context_line":"function create_amphora_flavor {"},{"line_number":578,"context_line":"    disk_size\u003d${OCTAVIA_AMP_IMAGE_SIZE:-2}"},{"line_number":579,"context_line":"    if [[ \"$OCTAVIA_AMP_IMAGE_ARCH\" \u003d~ (aarch64|arm64) ]]; then"},{"line_number":580,"context_line":"        # DIB produces images larger than size specified, add another GB to the flavor disk"},{"line_number":581,"context_line":"        disk_size\u003d$((disk_size + 1))"},{"line_number":582,"context_line":"    fi"},{"line_number":583,"context_line":"    # Pass even if it exists to avoid race condition on multinode"}],"source_content_type":"text/x-sh","patch_set":33,"id":"3676ae56_3b220851","line":580,"updated":"2021-03-06 22:58:15.000000000","message":"Weird. DIB bug?","commit_id":"281300033b9f13933af9f374d74a9a92766f4dfd"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"1d0ad643335ccdd852050c31a94142e1466bf2bd","unresolved":true,"context_lines":[{"line_number":577,"context_line":"function create_amphora_flavor {"},{"line_number":578,"context_line":"    disk_size\u003d${OCTAVIA_AMP_IMAGE_SIZE:-2}"},{"line_number":579,"context_line":"    if [[ \"$OCTAVIA_AMP_IMAGE_ARCH\" \u003d~ (aarch64|arm64) ]]; then"},{"line_number":580,"context_line":"        # DIB produces images larger than size specified, add another GB to the flavor disk"},{"line_number":581,"context_line":"        disk_size\u003d$((disk_size + 1))"},{"line_number":582,"context_line":"    fi"},{"line_number":583,"context_line":"    # Pass even if it exists to avoid race condition on multinode"}],"source_content_type":"text/x-sh","patch_set":33,"id":"1a0f0ae9_7ce4bc1f","line":580,"in_reply_to":"3676ae56_3b220851","updated":"2021-03-09 09:34:00.000000000","message":"Either bug in DIB or in underlaying tools. The produced image is slightly larger than the requested size (few kilobytes larger than expected IIRC). Admittedly, I don\u0027t have the stamina to chase it down now. Let me know if this workaround is a blocker in your view.","commit_id":"281300033b9f13933af9f374d74a9a92766f4dfd"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"c44f9eb9d413e3181ce71a7b86d56e3c5fa31fbd","unresolved":true,"context_lines":[{"line_number":762,"context_line":"            hw_arch\u003d$OCTAVIA_AMP_IMAGE_ARCH"},{"line_number":763,"context_line":"            if [[ \"$OCTAVIA_AMP_IMAGE_ARCH\" \u003d\u003d \"amd64\" ]]; then"},{"line_number":764,"context_line":"                hw_arch\u003d\"x86_64\""},{"line_number":765,"context_line":"            elif [[ \"$OCTAVIA_AMP_IMAGE_ARCH\" \u003d\u003d \"arm64\" ]]; then"},{"line_number":766,"context_line":"                hw_arch\u003d\"aarch64\""},{"line_number":767,"context_line":"            fi"},{"line_number":768,"context_line":"            openstack image set --tag ${OCTAVIA_AMP_IMAGE_TAG} --property hw_architecture\u003d${hw_arch} --property hw_rng_model\u003dvirtio ${OCTAVIA_AMP_IMAGE_ID}"}],"source_content_type":"text/x-sh","patch_set":33,"id":"495f632a_76be37ce","line":765,"updated":"2021-03-06 22:58:15.000000000","message":"Will OCTAVIA_AMP_IMAGE_ARCH always be set? The check further up in this file (see comment) implies no. If not, this will leave it blank, then the property below would be empty. We should maybe guard here, or treat amd64 as the default the way we do other places?","commit_id":"281300033b9f13933af9f374d74a9a92766f4dfd"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"1d0ad643335ccdd852050c31a94142e1466bf2bd","unresolved":false,"context_lines":[{"line_number":762,"context_line":"            hw_arch\u003d$OCTAVIA_AMP_IMAGE_ARCH"},{"line_number":763,"context_line":"            if [[ \"$OCTAVIA_AMP_IMAGE_ARCH\" \u003d\u003d \"amd64\" ]]; then"},{"line_number":764,"context_line":"                hw_arch\u003d\"x86_64\""},{"line_number":765,"context_line":"            elif [[ \"$OCTAVIA_AMP_IMAGE_ARCH\" \u003d\u003d \"arm64\" ]]; then"},{"line_number":766,"context_line":"                hw_arch\u003d\"aarch64\""},{"line_number":767,"context_line":"            fi"},{"line_number":768,"context_line":"            openstack image set --tag ${OCTAVIA_AMP_IMAGE_TAG} --property hw_architecture\u003d${hw_arch} --property hw_rng_model\u003dvirtio ${OCTAVIA_AMP_IMAGE_ID}"}],"source_content_type":"text/x-sh","patch_set":33,"id":"98c2d3a5_8390559f","line":765,"in_reply_to":"495f632a_76be37ce","updated":"2021-03-09 09:34:00.000000000","message":"Done","commit_id":"281300033b9f13933af9f374d74a9a92766f4dfd"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ab6ddfcf3eedfd4b4f6bbc72b21608c8786fd9d7","unresolved":true,"context_lines":[{"line_number":577,"context_line":"function create_amphora_flavor {"},{"line_number":578,"context_line":"    disk_size\u003d${OCTAVIA_AMP_IMAGE_SIZE:-2}"},{"line_number":579,"context_line":"    if [[ \"$OCTAVIA_AMP_IMAGE_ARCH\" \u003d~ (aarch64|arm64) ]]; then"},{"line_number":580,"context_line":"        # DIB produces images larger than size specified, add another GB to the flavor disk"},{"line_number":581,"context_line":"        disk_size\u003d$((disk_size + 1))"},{"line_number":582,"context_line":"    fi"},{"line_number":583,"context_line":"    # Pass even if it exists to avoid race condition on multinode"}],"source_content_type":"text/x-sh","patch_set":34,"id":"d011701a_578fa6e8","line":580,"updated":"2021-03-09 19:20:34.000000000","message":"Is there a bug report we can link here?","commit_id":"4109c5eaa79b4eb71c50c4701df87b81f6a4d802"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"aa9ea8e4e10c1e156188954490af696196162c1e","unresolved":false,"context_lines":[{"line_number":577,"context_line":"function create_amphora_flavor {"},{"line_number":578,"context_line":"    disk_size\u003d${OCTAVIA_AMP_IMAGE_SIZE:-2}"},{"line_number":579,"context_line":"    if [[ \"$OCTAVIA_AMP_IMAGE_ARCH\" \u003d~ (aarch64|arm64) ]]; then"},{"line_number":580,"context_line":"        # DIB produces images larger than size specified, add another GB to the flavor disk"},{"line_number":581,"context_line":"        disk_size\u003d$((disk_size + 1))"},{"line_number":582,"context_line":"    fi"},{"line_number":583,"context_line":"    # Pass even if it exists to avoid race condition on multinode"}],"source_content_type":"text/x-sh","patch_set":34,"id":"f8b1b33d_e12f7f90","line":580,"in_reply_to":"d011701a_578fa6e8","updated":"2021-03-10 17:55:53.000000000","message":"Done","commit_id":"4109c5eaa79b4eb71c50c4701df87b81f6a4d802"}],"zuul.d/projects.yaml":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"2ebf5f1a656e8ba3f7b68fa19ac78259997248a2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Note: Some official OpenStack wide jobs are still defined in the"},{"line_number":2,"context_line":"#       project-config repository"},{"line_number":3,"context_line":"- project:"},{"line_number":4,"context_line":"    # templates:"},{"line_number":5,"context_line":"    #   - check-requirements"},{"line_number":6,"context_line":"    #   - periodic-stable-jobs-neutron"},{"line_number":7,"context_line":"    #   - openstack-cover-jobs"},{"line_number":8,"context_line":"    #   - openstack-lower-constraints-jobs"},{"line_number":9,"context_line":"    #   - openstack-python3-victoria-jobs"},{"line_number":10,"context_line":"    #   - publish-openstack-docs-pti"},{"line_number":11,"context_line":"    #   - release-notes-jobs-python3"},{"line_number":12,"context_line":"    #   - octavia-tox-tips"},{"line_number":13,"context_line":"    # check:"},{"line_number":14,"context_line":"    #   jobs:"},{"line_number":15,"context_line":"    #     - openstack-tox-functional-py36:"},{"line_number":16,"context_line":"    #         irrelevant-files:"},{"line_number":17,"context_line":"    #           - ^.*\\.rst$"},{"line_number":18,"context_line":"    #           - ^api-ref/.*$"},{"line_number":19,"context_line":"    #           - ^doc/.*$"},{"line_number":20,"context_line":"    #           - ^etc/.*$"},{"line_number":21,"context_line":"    #           - ^octavia/tests/unit/.*$"},{"line_number":22,"context_line":"    #           - ^releasenotes/.*$"},{"line_number":23,"context_line":"    #     - octavia-v2-dsvm-noop-api:"},{"line_number":24,"context_line":"    #         irrelevant-files: \u0026irrelevant-files"},{"line_number":25,"context_line":"    #           - ^.*\\.rst$"},{"line_number":26,"context_line":"    #           - ^api-ref/.*$"},{"line_number":27,"context_line":"    #           - ^doc/.*$"},{"line_number":28,"context_line":"    #           - ^octavia/tests/.*$"},{"line_number":29,"context_line":"    #           - ^releasenotes/.*$"},{"line_number":30,"context_line":"    #     - octavia-v2-dsvm-scenario:"},{"line_number":31,"context_line":"    #         irrelevant-files: *irrelevant-files"},{"line_number":32,"context_line":"    #     - octavia-v2-dsvm-tls-barbican:"},{"line_number":33,"context_line":"    #         irrelevant-files: *irrelevant-files"},{"line_number":34,"context_line":"    #     - octavia-v2-dsvm-spare-pool:"},{"line_number":35,"context_line":"    #         irrelevant-files: *irrelevant-files"},{"line_number":36,"context_line":"    #     - octavia-v2-act-stdby-dsvm-scenario:"},{"line_number":37,"context_line":"    #         irrelevant-files: *irrelevant-files"},{"line_number":38,"context_line":"    #     - octavia-grenade:"},{"line_number":39,"context_line":"    #         irrelevant-files:"},{"line_number":40,"context_line":"    #           - ^.*\\.rst$"},{"line_number":41,"context_line":"    #           - ^api-ref/.*$"},{"line_number":42,"context_line":"    #           - ^doc/.*$"},{"line_number":43,"context_line":"    #           - ^octavia/tests/.*$"},{"line_number":44,"context_line":"    #           - ^releasenotes/.*$"},{"line_number":45,"context_line":"    #           - ^setup.cfg$"},{"line_number":46,"context_line":"    #           - ^tools/.*$"},{"line_number":47,"context_line":"    #           - ^(test-|)requirements.txt$"},{"line_number":48,"context_line":"    #           - ^tox.ini$"},{"line_number":49,"context_line":"    #     - octavia-v2-dsvm-cinder-amphora:"},{"line_number":50,"context_line":"    #         irrelevant-files: *irrelevant-files"},{"line_number":51,"context_line":"    #         voting: false"},{"line_number":52,"context_line":"    #     - octavia-v2-dsvm-scenario-two-node:"},{"line_number":53,"context_line":"    #         irrelevant-files: *irrelevant-files"},{"line_number":54,"context_line":"    #         voting: false"},{"line_number":55,"context_line":"    #     - octavia-v2-dsvm-scenario-amphora-v2:"},{"line_number":56,"context_line":"    #         irrelevant-files: *irrelevant-files"},{"line_number":57,"context_line":"    #         voting: false"},{"line_number":58,"context_line":"    check-arm64:"},{"line_number":59,"context_line":"      jobs:"},{"line_number":60,"context_line":"        - octavia-v2-dsvm-scenario-arm64"},{"line_number":61,"context_line":"    gate:"},{"line_number":62,"context_line":"      fail-fast: true"},{"line_number":63,"context_line":"      queue: octavia"},{"line_number":64,"context_line":"      jobs:"},{"line_number":65,"context_line":"        - openstack-tox-functional-py36:"},{"line_number":66,"context_line":"            irrelevant-files:"},{"line_number":67,"context_line":"              - ^.*\\.rst$"},{"line_number":68,"context_line":"              - ^api-ref/.*$"},{"line_number":69,"context_line":"              - ^doc/.*$"},{"line_number":70,"context_line":"              - ^etc/.*$"},{"line_number":71,"context_line":"              - ^octavia/tests/unit/.*$"},{"line_number":72,"context_line":"              - ^releasenotes/.*$"},{"line_number":73,"context_line":"        - octavia-v2-dsvm-noop-api"},{"line_number":74,"context_line":"        - octavia-v2-dsvm-scenario"},{"line_number":75,"context_line":"        - octavia-v2-dsvm-tls-barbican"},{"line_number":76,"context_line":"        - octavia-v2-dsvm-spare-pool"},{"line_number":77,"context_line":"        - octavia-v2-act-stdby-dsvm-scenario"},{"line_number":78,"context_line":"        - octavia-grenade"},{"line_number":79,"context_line":"    periodic:"},{"line_number":80,"context_line":"      jobs:"},{"line_number":81,"context_line":"        - publish-openstack-octavia-amphora-image-bionic:"},{"line_number":82,"context_line":"            branches: ^(?!stable/.*).*$"},{"line_number":83,"context_line":"        - publish-openstack-octavia-amphora-image-centos8:"},{"line_number":84,"context_line":"            branches: ^(?!stable/.*).*$"},{"line_number":85,"context_line":"        - octavia-amphora-image-build"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"bf51134e_20b12e48","line":85,"range":{"start_line":3,"start_character":2,"end_line":85,"end_character":0},"updated":"2020-06-26 15:26:47.000000000","message":"Job octavia-v2-dsvm-scenario-arm64 not defined","commit_id":"4778cae689a7a51ab43fc4e762a61a6cc37d420a"}]}
