)]}'
{"octavia/api/drivers/amphora_driver/v2/driver.py":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"79f8b2aa607a569546df6f85a22970dda4997b71","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        if listener_dict.get(consts.DEFAULT_TLS_CONTAINER_DATA, False):"},{"line_number":140,"context_line":"            container_data \u003d listener_dict[consts.DEFAULT_TLS_CONTAINER_DATA]"},{"line_number":141,"context_line":"            for key, val in container_data.items():"},{"line_number":142,"context_line":"                if isinstance(val, bytes):"},{"line_number":143,"context_line":"                    container_data[key] \u003d self.fernet.encrypt(val)"},{"line_number":144,"context_line":"        if listener_dict.get(consts.SNI_CONTAINER_DATA, False):"},{"line_number":145,"context_line":"            sni_list \u003d []"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_68a19d95","line":142,"range":{"start_line":142,"start_character":16,"end_line":142,"end_character":42},"updated":"2020-09-22 12:25:42.000000000","message":"Question: do we want to encrypt every field in DEFAULT_TLS_CONTAINER_DATA? it seems that it also contains a list, which is kept unmodified here","commit_id":"5bc92fc3c8e9a79f513ae2e13370508d933dad3f"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"45ba9f5f738fc7b9fa41db2269b07367ed755f7a","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        if listener_dict.get(consts.DEFAULT_TLS_CONTAINER_DATA, False):"},{"line_number":140,"context_line":"            container_data \u003d listener_dict[consts.DEFAULT_TLS_CONTAINER_DATA]"},{"line_number":141,"context_line":"            for key, val in container_data.items():"},{"line_number":142,"context_line":"                if isinstance(val, bytes):"},{"line_number":143,"context_line":"                    container_data[key] \u003d self.fernet.encrypt(val)"},{"line_number":144,"context_line":"        if listener_dict.get(consts.SNI_CONTAINER_DATA, False):"},{"line_number":145,"context_line":"            sni_list \u003d []"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_653531f6","line":142,"range":{"start_line":142,"start_character":16,"end_line":142,"end_character":42},"in_reply_to":"9f560f44_05bb95c3","updated":"2020-09-23 12:30:04.000000000","message":"I\u0027ve found that doc that contains the definition of a TLS Container object:\nhttps://opendev.org/openstack/octavia/blame/branch/master/doc/source/contributor/guides/providers.rst#L464\n\nit contains: \"intermediates | List   | A list of intermediate PEM certificates.\"\nperhaps encryption is not required here","commit_id":"5bc92fc3c8e9a79f513ae2e13370508d933dad3f"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"c350fcfe4abc8c597d44e028eed71b240a503cd9","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        if listener_dict.get(consts.DEFAULT_TLS_CONTAINER_DATA, False):"},{"line_number":140,"context_line":"            container_data \u003d listener_dict[consts.DEFAULT_TLS_CONTAINER_DATA]"},{"line_number":141,"context_line":"            for key, val in container_data.items():"},{"line_number":142,"context_line":"                if isinstance(val, bytes):"},{"line_number":143,"context_line":"                    container_data[key] \u003d self.fernet.encrypt(val)"},{"line_number":144,"context_line":"        if listener_dict.get(consts.SNI_CONTAINER_DATA, False):"},{"line_number":145,"context_line":"            sni_list \u003d []"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_05bb95c3","line":142,"range":{"start_line":142,"start_character":16,"end_line":142,"end_character":42},"in_reply_to":"9f560f44_68a19d95","updated":"2020-09-23 12:08:41.000000000","message":"problem with changes that got reviews since almost 3 months from being published - remember something :)\n\nAs far as I recall - we want to encrypt certificates in values and this check works fine for me.\nDoes this list contains some keys? Do you have an example with that?","commit_id":"5bc92fc3c8e9a79f513ae2e13370508d933dad3f"}]}