)]}'
{"octavia/controller/queue/v2/consumer.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"52403933915b5cb699c340d62de0754ebc146e5e","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from oslo_log import log as logging"},{"line_number":18,"context_line":"import oslo_messaging as messaging"},{"line_number":19,"context_line":"from oslo_messaging.rpc import dispatcher"},{"line_number":20,"context_line":"from oslo_utils import excutils"},{"line_number":21,"context_line":"from oslo_utils import uuidutils"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from octavia.common import constants"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_495f9840","line":20,"updated":"2020-07-08 14:05:49.000000000","message":"pep8: F401 \u0027oslo_utils.excutils\u0027 imported but unused","commit_id":"992c0b7b6bcf393090459d0556b11cae0dd92069"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"32826c4148f2359227bf535f205214d96b343c50","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                except Exception as exc:"},{"line_number":61,"context_line":"                    LOG.exception(\"Failed to run jobboard conductor due to: \""},{"line_number":62,"context_line":"                                  \"%s\", exc)"},{"line_number":63,"context_line":"                    break"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def terminate(self):"},{"line_number":66,"context_line":"        if self.message_listener:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_ebbae46b","line":63,"updated":"2020-07-08 12:58:44.000000000","message":"Do we want to break or call the other endpoints?","commit_id":"992c0b7b6bcf393090459d0556b11cae0dd92069"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"804b39403037830e1e3140e074a29146fe7aed89","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                except Exception as exc:"},{"line_number":61,"context_line":"                    LOG.exception(\"Failed to run jobboard conductor due to: \""},{"line_number":62,"context_line":"                                  \"%s\", exc)"},{"line_number":63,"context_line":"                    break"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def terminate(self):"},{"line_number":66,"context_line":"        if self.message_listener:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_f71905d7","line":63,"in_reply_to":"bf51134e_0e35a646","updated":"2020-07-09 21:48:55.000000000","message":"Ok, the \u0027for e in self.endpoints:\u0027 made it seem like there were others.","commit_id":"992c0b7b6bcf393090459d0556b11cae0dd92069"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"9f39cc934b85dcc92cb56e3b1fb1c4fe31cd4cbd","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                except Exception as exc:"},{"line_number":61,"context_line":"                    LOG.exception(\"Failed to run jobboard conductor due to: \""},{"line_number":62,"context_line":"                                  \"%s\", exc)"},{"line_number":63,"context_line":"                    break"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def terminate(self):"},{"line_number":66,"context_line":"        if self.message_listener:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_0e35a646","line":63,"in_reply_to":"bf51134e_ebbae46b","updated":"2020-07-08 13:23:48.000000000","message":"endpoints for amphora are running by separate v1 consumer, so not sure there is something else to call here.","commit_id":"992c0b7b6bcf393090459d0556b11cae0dd92069"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"9015cef6a7d37006e732936c4463da62057d741d","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                    except Exception as exc:"},{"line_number":61,"context_line":"                        LOG.exception(\"Failed to run jobboard conductor due \""},{"line_number":62,"context_line":"                                      \"to: %s\", exc)"},{"line_number":63,"context_line":"                        break"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def terminate(self):"},{"line_number":66,"context_line":"        if self.message_listener:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_cdc0927f","line":63,"updated":"2020-09-23 23:57:12.000000000","message":"So this will just leave some endpoints without a conductor? What are the ramifications?\nIt seems like this would leave a worker non-functional.","commit_id":"18151e4c313b6acff8de4f57ff37036a65a811e0"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"3643f2deee1d62dab05bf2181db1503d9ece10db","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                    except Exception as exc:"},{"line_number":61,"context_line":"                        LOG.exception(\"Failed to run jobboard conductor due \""},{"line_number":62,"context_line":"                                      \"to: %s\", exc)"},{"line_number":63,"context_line":"                        break"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def terminate(self):"},{"line_number":66,"context_line":"        if self.message_listener:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_55d524b6","line":63,"in_reply_to":"9f560f44_cdc0927f","updated":"2020-09-24 07:15:50.000000000","message":"This is v2 consumer and jobboard_enabled is set True, so we expect to have workers that will run conductor here, if conductor can not start worker is not functional at all.\nExample of situation I\u0027m fixing here - if redis-py client was not installed - worker is not functional at all, but no error in logs just endless messages \"Starting V2 consumer...\" as it silently try to run conductor in the loop.\nYes, with try-except we don\u0027t have functional worker but we have clear error in logs that conductor cannot start.","commit_id":"18151e4c313b6acff8de4f57ff37036a65a811e0"}]}