)]}'
{"octavia/controller/worker/v2/controller_worker.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"321510707498ad3cd18c6e5d5c4b9871db3d9b8e","unresolved":false,"context_lines":[{"line_number":759,"context_line":"                 constants.LISTENERS: listeners_dicts,"},{"line_number":760,"context_line":"                 constants.L7POLICY_ID: db_l7policy.id,"},{"line_number":761,"context_line":"                 constants.LOADBALANCER_ID: load_balancer.id,"},{"line_number":762,"context_line":"                 constants.PROJECT_ID: load_balancer.project_id,"},{"line_number":763,"context_line":"                 }"},{"line_number":764,"context_line":"        self.services_controller.run_poster("},{"line_number":765,"context_line":"            flow_utils.get_delete_l7rule_flow,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_0ab0b542","line":762,"updated":"2020-08-05 16:41:00.000000000","message":"The l7rule should already have the project_id as part of the dictionary: https://docs.openstack.org/octavia/latest/contributor/guides/providers.html#l7-rule\nand\nhttps://github.com/openstack/octavia/blob/master/octavia/api/drivers/amphora_driver/v2/driver.py#L328","commit_id":"bebc0a4cfcf1543113357f09f8c342801e50bca7"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"0cd45583f0cff03d11f2c3879d07edabf54a032e","unresolved":false,"context_lines":[{"line_number":759,"context_line":"                 constants.LISTENERS: listeners_dicts,"},{"line_number":760,"context_line":"                 constants.L7POLICY_ID: db_l7policy.id,"},{"line_number":761,"context_line":"                 constants.LOADBALANCER_ID: load_balancer.id,"},{"line_number":762,"context_line":"                 constants.PROJECT_ID: load_balancer.project_id,"},{"line_number":763,"context_line":"                 }"},{"line_number":764,"context_line":"        self.services_controller.run_poster("},{"line_number":765,"context_line":"            flow_utils.get_delete_l7rule_flow,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_12110205","line":762,"in_reply_to":"9f560f44_0ab0b542","updated":"2020-08-06 07:17:14.000000000","message":"I\u0027ve done this to have unity between all Decrement*Quota tasks which use only project_id. But as DecrementL7policyQuota will still require whole dict to be passed, this may be not such strong point.","commit_id":"bebc0a4cfcf1543113357f09f8c342801e50bca7"}],"octavia/controller/worker/v2/flows/l7rule_flows.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"321510707498ad3cd18c6e5d5c4b9871db3d9b8e","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        delete_l7rule_flow.add(database_tasks.DeleteL7RuleInDB("},{"line_number":66,"context_line":"            requires\u003dconstants.L7RULE))"},{"line_number":67,"context_line":"        delete_l7rule_flow.add(database_tasks.DecrementL7ruleQuota("},{"line_number":68,"context_line":"            requires\u003dconstants.PROJECT_ID))"},{"line_number":69,"context_line":"        delete_l7rule_flow.add(database_tasks.MarkL7PolicyActiveInDB("},{"line_number":70,"context_line":"            requires\u003dconstants.L7POLICY))"},{"line_number":71,"context_line":"        delete_l7rule_flow.add(database_tasks.MarkLBAndListenersActiveInDB("}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_6aefb11d","line":68,"updated":"2020-08-05 16:41:00.000000000","message":"Same here, I don\u0027t think this needs to change, the l7rule dict should have the project_id already.","commit_id":"bebc0a4cfcf1543113357f09f8c342801e50bca7"}],"octavia/controller/worker/v2/tasks/database_tasks.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"321510707498ad3cd18c6e5d5c4b9871db3d9b8e","unresolved":false,"context_lines":[{"line_number":2941,"context_line":"    Since sqlalchemy will likely retry by itself always revert if it fails"},{"line_number":2942,"context_line":"    \"\"\""},{"line_number":2943,"context_line":""},{"line_number":2944,"context_line":"    def execute(self, project_id):"},{"line_number":2945,"context_line":"        \"\"\"Decrements the l7rule quota."},{"line_number":2946,"context_line":""},{"line_number":2947,"context_line":"        :param l7rule: The l7rule to decrement the quota on."}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_eac3c187","line":2944,"updated":"2020-08-05 16:41:00.000000000","message":"Same here, I don\u0027t think this needs to change.","commit_id":"bebc0a4cfcf1543113357f09f8c342801e50bca7"}]}