)]}'
{"id":"openstack%2Foctavia~745683","triplet_id":"openstack%2Foctavia~master~I3b82180c8fcf2e2f053c6bcce405f1ea730f62ba","project":"openstack/octavia","branch":"master","hashtags":[],"change_id":"I3b82180c8fcf2e2f053c6bcce405f1ea730f62ba","subject":"Set amphora-agent build-only packages","status":"MERGED","created":"2020-08-11 14:30:52.000000000","updated":"2020-08-18 18:22:01.000000000","submitted":"2020-08-18 18:20:44.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"745683-1597774844531-ff0595dd","meta_rev_id":"05c8d85dfcd28eb39a3b0954f2f50d3b897a880b","_number":745683,"virtual_id_number":745683,"owner":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},{"value":0,"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-08-18 18:20:44.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"all":[{"value":2,"date":"2020-08-18 16:43:06.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},{"value":2,"date":"2020-08-18 16:50:30.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"all":[{"value":0,"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},{"value":1,"date":"2020-08-18 16:50:30.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},{"value":0,"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-08-18 16:43:06.000000000","updated_by":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"reviewer":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"state":"REVIEWER"},{"updated":"2020-08-18 16:50:30.000000000","updated_by":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"reviewer":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"state":"REVIEWER"},{"updated":"2020-08-18 18:20:44.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"4bf092de815a58246eae9c449c721626412ab5b6","author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"date":"2020-08-11 14:30:52.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"be4049c042acd526f4ca865c271351a9a1fdd42a","author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"date":"2020-08-11 15:21:42.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"26b14969b81089cdab4d410c822575fc33b3057b","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-11 18:27:40.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/f8448b2274124e4483a4f48d9f6552d4 : SUCCESS in 9m 19s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/7fbfdf3f22584744a8d1b6b387dda6a0 : SUCCESS in 10m 17s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/8a5ac3205e0a4dceb2ab84229d327d41 : SUCCESS in 6m 36s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/67bf2bdabc154e00ab60803f697e0eee : SUCCESS in 5m 14s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/0bde5b84a02c406293d8b1457ac10c23 : SUCCESS in 5m 43s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/30016215324146b7a45e0a38e5ab1b32 : SUCCESS in 15m 16s\n- octavia-tox-py37-tips https://zuul.opendev.org/t/openstack/build/0412b5111603497996ae41bd49803bab : SUCCESS in 7m 23s\n- octavia-tox-functional-py37-tips https://zuul.opendev.org/t/openstack/build/266c5764f6524aa4b4483e029f03ee41 : SUCCESS in 10m 42s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/6ec5cf7ac7fd421fa103699e64f755aa : SUCCESS in 7m 26s\n- octavia-v2-dsvm-noop-api https://zuul.opendev.org/t/openstack/build/5d2130729dd442029b5bff63a1012ddc : SUCCESS in 47m 11s\n- octavia-v2-dsvm-scenario https://zuul.opendev.org/t/openstack/build/fed0f599501548418d7ddb3850bec1b0 : SUCCESS in 39m 39s\n- octavia-v2-dsvm-tls-barbican https://zuul.opendev.org/t/openstack/build/743740ec7e5144d28775673fc722393f : SUCCESS in 39m 48s\n- octavia-v2-dsvm-spare-pool https://zuul.opendev.org/t/openstack/build/7d57dffeeafe4d32a2fc0e3b906bfc7c : SUCCESS in 38m 42s\n- octavia-v2-act-stdby-dsvm-scenario https://zuul.opendev.org/t/openstack/build/fcca900071ee4fc7926cebc718485eb2 : SUCCESS in 59m 28s\n- octavia-grenade https://zuul.opendev.org/t/openstack/build/48d0f0ebdcb64b068e0780c530f1c142 : SUCCESS in 1h 22m 33s\n- octavia-v2-dsvm-cinder-amphora https://zuul.opendev.org/t/openstack/build/90eddbe72b624a929e8aacf911ed5fba : SUCCESS in 44m 58s (non-voting)\n- octavia-v2-dsvm-scenario-two-node https://zuul.opendev.org/t/openstack/build/10189b6c93ec46caa76b5192140bf3cc : SUCCESS in 1h 02m 47s (non-voting)\n- octavia-v2-dsvm-scenario-ipv6-only https://zuul.opendev.org/t/openstack/build/795fb50381134dbd8ed5467a77b7a935 : SUCCESS in 41m 49s (non-voting)\n- octavia-v2-dsvm-scenario-amphora-v2 https://zuul.opendev.org/t/openstack/build/0e4aa6051ae140698025a71422885893 : FAILURE in 2h 25m 18s (non-voting)\n- octavia-v2-dsvm-scenario-centos-8 https://zuul.opendev.org/t/openstack/build/68484d48eeb247858f066bfc9b977665 : SUCCESS in 1h 04m 19s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"42ab693abfa83d074451e04cf6a2e993291d013c","author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"date":"2020-08-18 16:43:06.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"d532ff45bf626842a2265e0e06a28afd4752400a","author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"date":"2020-08-18 16:50:30.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nLGTM","accounts_in_message":[],"_revision_number":2},{"id":"ffb3be7cbb3ff6760095de919b55aa4200dea22a","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-18 16:50:41.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"37026d31519e6060ab95b8e308cb2450b1c1d528","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-18 18:20:44.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/cf9ae04714cf4f9eae105f2df60514e0 : SUCCESS in 8m 57s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/60df16975df24b29b7c324e7a9700801 : SUCCESS in 5m 35s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/ffbebfc390784d9c8af60083f2fc8934 : SUCCESS in 5m 05s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/85b0fc82b6db4be18afe48e09f71dc29 : SUCCESS in 5m 22s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/209c518ad83547f7b4c4b2e2a6ced283 : SUCCESS in 11m 48s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/028718258a864261a5e3c76892e2ec99 : SUCCESS in 6m 29s\n- octavia-v2-dsvm-noop-api https://zuul.opendev.org/t/openstack/build/e4116b2d6bdd4cc5a4eaee34ef84e449 : SUCCESS in 49m 18s\n- octavia-v2-dsvm-scenario https://zuul.opendev.org/t/openstack/build/82ba38bf92e345a2b9589a1ca54304f2 : SUCCESS in 43m 17s\n- octavia-v2-dsvm-tls-barbican https://zuul.opendev.org/t/openstack/build/83d9c440964f4aca8b567f9fe889c149 : SUCCESS in 31m 37s\n- octavia-v2-dsvm-spare-pool https://zuul.opendev.org/t/openstack/build/19171c7fa9f4473cbda438dfb986a103 : SUCCESS in 51m 11s\n- octavia-v2-act-stdby-dsvm-scenario https://zuul.opendev.org/t/openstack/build/c27c144194a54c49bf39e52a27e6a2f3 : SUCCESS in 54m 22s\n- octavia-grenade https://zuul.opendev.org/t/openstack/build/8149a33f4db34f3e8faaa793cacd8ba9 : SUCCESS in 1h 26m 45s","accounts_in_message":[],"_revision_number":2},{"id":"4435cc41f599c3ab9bc0bb9fc9b21c94bd4e72c9","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-18 18:20:44.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"05c8d85dfcd28eb39a3b0954f2f50d3b897a880b","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-18 18:22:01.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f7469cce019b4e7db71407749f9da629 : SUCCESS in 56s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"fa1c5ef6dd15ce81c4a169307b7ab9970e9052d2","revisions":{"34885b6cab941507a5b3797e27c3f60ab540cad9":{"kind":"REWORK","_number":1,"created":"2020-08-11 14:30:52.000000000","uploader":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"ref":"refs/changes/83/745683/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/octavia","ref":"refs/changes/83/745683/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/octavia refs/changes/83/745683/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/octavia refs/changes/83/745683/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/octavia refs/changes/83/745683/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/octavia refs/changes/83/745683/1"}}},"commit":{"parents":[{"commit":"6a762f8a072ab3b3eaede32c6d471d874f2ad945","subject":"Merge \"[Trivial]Add missing space between words\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/6a762f8a072ab3b3eaede32c6d471d874f2ad945"}]}],"author":{"name":"Carlos Goncalves","email":"cgoncalves@redhat.com","date":"2020-08-11 13:55:57.000000000","tz":120},"committer":{"name":"Carlos Goncalves","email":"cgoncalves@redhat.com","date":"2020-08-11 14:30:16.000000000","tz":120},"subject":"Set amphora-agent build-only packages","message":"Set amphora-agent build-only packages\n\nA recent change in DIB [1] broke our CentOS 8 amphora image builds only\nbecause we\u0027ve not been handling package dependencies propertly.\n\nThe DIB change now installs package \"python3\" which provides\n/usr/bin/python3 and is a requirement of scripts in later build phases.\nIt so happens that we are removing package \"python3-pip\", a dependency\nof \"python36\" too early so builds fail when bin python3 is required.\n\nDIB package-installs element provides property \"build-only\". When set,\nit will cause packages to be added both to the list of packages\ninstalled and list of packages to be uninstalled. This allows expressing\nbuild-time dependencies that should not end up in the final image as is\nthe case of packages like \"build-essential\" and \"libffi-dev\" in our\namphora-agent element.\n\nAs for the removal of Git, we do not explicitely install it so we should\nnot uninstall it either. Git is a fake dependency of source-repositories\nelement and will be abstent in the final image with [2].\n\n[1] https://review.opendev.org/#/c/741868/\n[2] https://review.opendev.org/#/c/745678/\n\nDepends-On: https://review.opendev.org/#/c/745678/\n\nChange-Id: I3b82180c8fcf2e2f053c6bcce405f1ea730f62ba\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/34885b6cab941507a5b3797e27c3f60ab540cad9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/34885b6cab941507a5b3797e27c3f60ab540cad9"}]},"branch":"refs/heads/master"},"fa1c5ef6dd15ce81c4a169307b7ab9970e9052d2":{"kind":"REWORK","_number":2,"created":"2020-08-11 15:21:42.000000000","uploader":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"ref":"refs/changes/83/745683/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/octavia","ref":"refs/changes/83/745683/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/octavia refs/changes/83/745683/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/octavia refs/changes/83/745683/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/octavia refs/changes/83/745683/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/octavia refs/changes/83/745683/2"}}},"commit":{"parents":[{"commit":"13fe928c8ad979568f66ba738b86cc2d91e936fa","subject":"Add line terminator to certificate list file","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/13fe928c8ad979568f66ba738b86cc2d91e936fa"}]}],"author":{"name":"Carlos Goncalves","email":"cgoncalves@redhat.com","date":"2020-08-11 13:55:57.000000000","tz":120},"committer":{"name":"Carlos Goncalves","email":"cgoncalves@redhat.com","date":"2020-08-11 15:21:27.000000000","tz":120},"subject":"Set amphora-agent build-only packages","message":"Set amphora-agent build-only packages\n\nA recent change in DIB [1] broke our CentOS 8 amphora image builds only\nbecause we\u0027ve not been handling package dependencies propertly.\n\nThe DIB change now installs package \"python3\" which provides\n/usr/bin/python3 and is a requirement of scripts in later build phases.\nIt so happens that we are removing package \"python3-pip\", a dependency\nof \"python36\" too early so builds fail when bin python3 is required.\n\nDIB package-installs element provides property \"build-only\". When set,\nit will cause packages to be added both to the list of packages\ninstalled and list of packages to be uninstalled. This allows expressing\nbuild-time dependencies that should not end up in the final image as is\nthe case of packages like \"build-essential\" and \"libffi-dev\" in our\namphora-agent element.\n\nAs for the removal of Git, we do not explicitely install it so we should\nnot uninstall it either. Git is a fake dependency of source-repositories\nelement and will be abstent in the final image with [2].\n\n[1] https://review.opendev.org/#/c/741868/\n[2] https://review.opendev.org/#/c/745678/\n\nDepends-On: https://review.opendev.org/#/c/745678/\n\nChange-Id: I3b82180c8fcf2e2f053c6bcce405f1ea730f62ba\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/fa1c5ef6dd15ce81c4a169307b7ab9970e9052d2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/octavia/commit/fa1c5ef6dd15ce81c4a169307b7ab9970e9052d2"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}