)]}'
{"octavia/controller/worker/v1/controller_worker.py":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"f10953491b722c04b828f6b8489cc9e008372469","unresolved":false,"context_lines":[{"line_number":1110,"context_line":""},{"line_number":1111,"context_line":"        amp \u003d self._amphora_repo.get(db_apis.get_session(),"},{"line_number":1112,"context_line":"                                     id\u003damphora_id)"},{"line_number":1113,"context_line":"        LOG.info(\"Start amphora cert rotation, amphora\u0027s id is: %s\", amp.id)"},{"line_number":1114,"context_line":""},{"line_number":1115,"context_line":"        certrotation_amphora_tf \u003d self._taskflow_load("},{"line_number":1116,"context_line":"            self._amphora_flows.cert_rotate_amphora_flow(),"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_f45d1149","line":1113,"updated":"2020-08-12 06:40:47.000000000","message":"To be consistent, can you also add a similar log message here +v2?","commit_id":"7c3e1e6916ba6d749f760989b35454265a8c96aa"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"701da317c125024a7ad2b75e0346fa9e4c4b1c39","unresolved":false,"context_lines":[{"line_number":1110,"context_line":""},{"line_number":1111,"context_line":"        amp \u003d self._amphora_repo.get(db_apis.get_session(),"},{"line_number":1112,"context_line":"                                     id\u003damphora_id)"},{"line_number":1113,"context_line":"        LOG.info(\"Start amphora cert rotation, amphora\u0027s id is: %s\", amp.id)"},{"line_number":1114,"context_line":""},{"line_number":1115,"context_line":"        certrotation_amphora_tf \u003d self._taskflow_load("},{"line_number":1116,"context_line":"            self._amphora_flows.cert_rotate_amphora_flow(),"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_df87f4b5","line":1113,"in_reply_to":"9f560f44_f45d1149","updated":"2020-08-18 17:12:20.000000000","message":"+1 makes sense to me.","commit_id":"7c3e1e6916ba6d749f760989b35454265a8c96aa"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"f10953491b722c04b828f6b8489cc9e008372469","unresolved":false,"context_lines":[{"line_number":1149,"context_line":"        with tf_logging.DynamicLoggingListener(update_amphora_tf,"},{"line_number":1150,"context_line":"                                               log\u003dLOG):"},{"line_number":1151,"context_line":"            update_amphora_tf.run()"},{"line_number":1152,"context_line":"        LOG.info(\"Finished amphora agent configuration update, amphora\u0027s id \""},{"line_number":1153,"context_line":"                 \"was: %s\", amphora_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_b46b99ef","line":1152,"updated":"2020-08-12 06:40:47.000000000","message":"Add same log message to controller v2","commit_id":"7c3e1e6916ba6d749f760989b35454265a8c96aa"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"d9b1ce52325c333bf6dc3ee7dbe3055054e07a4d","unresolved":false,"context_lines":[{"line_number":1120,"context_line":"        with tf_logging.DynamicLoggingListener(certrotation_amphora_tf,"},{"line_number":1121,"context_line":"                                               log\u003dLOG):"},{"line_number":1122,"context_line":"            certrotation_amphora_tf.run()"},{"line_number":1123,"context_line":"        LOG.info(\"Finished amphora cert rotation, amphora\u0027s id is: %s\", amp.id)"},{"line_number":1124,"context_line":""},{"line_number":1125,"context_line":"    def update_amphora_agent_config(self, amphora_id):"},{"line_number":1126,"context_line":"        \"\"\"Update the amphora agent configuration."}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_db3547dc","line":1123,"updated":"2020-08-18 17:25:45.000000000","message":"Why not amphora_id?","commit_id":"a20052f57cd1a264f253b109a6904652b48ef778"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"0968f8c81bf45de535eab71ffb40fded6e841759","unresolved":false,"context_lines":[{"line_number":1120,"context_line":"        with tf_logging.DynamicLoggingListener(certrotation_amphora_tf,"},{"line_number":1121,"context_line":"                                               log\u003dLOG):"},{"line_number":1122,"context_line":"            certrotation_amphora_tf.run()"},{"line_number":1123,"context_line":"        LOG.info(\"Finished amphora cert rotation, amphora\u0027s id is: %s\", amp.id)"},{"line_number":1124,"context_line":""},{"line_number":1125,"context_line":"    def update_amphora_agent_config(self, amphora_id):"},{"line_number":1126,"context_line":"        \"\"\"Update the amphora agent configuration."}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_3bcf23b1","line":1123,"range":{"start_line":1123,"start_character":63,"end_line":1123,"end_character":65},"updated":"2020-08-18 17:36:19.000000000","message":"s/is/was/","commit_id":"a20052f57cd1a264f253b109a6904652b48ef778"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"0968f8c81bf45de535eab71ffb40fded6e841759","unresolved":false,"context_lines":[{"line_number":1120,"context_line":"        with tf_logging.DynamicLoggingListener(certrotation_amphora_tf,"},{"line_number":1121,"context_line":"                                               log\u003dLOG):"},{"line_number":1122,"context_line":"            certrotation_amphora_tf.run()"},{"line_number":1123,"context_line":"        LOG.info(\"Finished amphora cert rotation, amphora\u0027s id is: %s\", amp.id)"},{"line_number":1124,"context_line":""},{"line_number":1125,"context_line":"    def update_amphora_agent_config(self, amphora_id):"},{"line_number":1126,"context_line":"        \"\"\"Update the amphora agent configuration."}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_1bd21f5d","line":1123,"in_reply_to":"9f560f44_db3547dc","updated":"2020-08-18 17:36:19.000000000","message":"Consistency? Does it even matter if amp.id or amphora_id?","commit_id":"a20052f57cd1a264f253b109a6904652b48ef778"}]}