)]}'
{"octavia/db/repositories.py":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"2b6d440aa9a2f8d461323b9d62b58525d71e476d","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        with session.begin(subtransactions\u003dTrue):"},{"line_number":108,"context_line":"            session.query(self.model_class).filter_by("},{"line_number":109,"context_line":"                id\u003did).update(model_kwargs)"},{"line_number":110,"context_line":"            tags \u003d model_kwargs.pop(\u0027tags\u0027, None)"},{"line_number":111,"context_line":"            if tags is not None:"},{"line_number":112,"context_line":"                resource \u003d session.query(self.model_class).get(id)"},{"line_number":113,"context_line":"                resource.tags \u003d tags"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_44c38eed","line":110,"range":{"start_line":110,"start_character":12,"end_line":110,"end_character":49},"updated":"2020-11-17 06:05:49.000000000","message":"tags should be removed from model_kwargs _before_ calling \".update(model_kwargs)\"","commit_id":"67f55569ba025f181856f1c6cd441546304f5b2b"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3b5f9b3c55d46bb8f4a63d1b220c8609341d6088","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        with session.begin(subtransactions\u003dTrue):"},{"line_number":108,"context_line":"            session.query(self.model_class).filter_by("},{"line_number":109,"context_line":"                id\u003did).update(model_kwargs)"},{"line_number":110,"context_line":"            tags \u003d model_kwargs.pop(\u0027tags\u0027, None)"},{"line_number":111,"context_line":"            if tags is not None:"},{"line_number":112,"context_line":"                resource \u003d session.query(self.model_class).get(id)"},{"line_number":113,"context_line":"                resource.tags \u003d tags"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_ed6f1625","line":110,"range":{"start_line":110,"start_character":12,"end_line":110,"end_character":49},"in_reply_to":"1f621f24_44c38eed","updated":"2020-11-17 14:14:17.000000000","message":"You\u0027re right, I mistakenly thought this was like the code below, which Carlos asked to move:\n\n\"These lines should be moved above L1145-1148. In L1147, if the listener does not exist in the database but its model_kwargs includes tags, it will fail in L1148. So, he must make sure the listener DB object exists before anything else.\"\n\nI\u0027ll change this back but leave the below alone since it\u0027s just doing a query().","commit_id":"67f55569ba025f181856f1c6cd441546304f5b2b"}]}
