)]}'
{"octavia/common/data_models.py":[{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"4557169e288cf2a244143a6b33b5c0740de1f1dc","unresolved":false,"context_lines":[{"line_number":342,"context_line":"                try:"},{"line_number":343,"context_line":"                    self.load_balancer.pools.remove(pool)"},{"line_number":344,"context_line":"                except ValueError:"},{"line_number":345,"context_line":"                    pass"},{"line_number":346,"context_line":"                break"},{"line_number":347,"context_line":"        for l7policy in self.l7policies:"},{"line_number":348,"context_line":"            if l7policy.redirect_pool_id \u003d\u003d self.id:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_16c9e077","line":345,"updated":"2020-10-13 07:30:51.000000000","message":"I think we should log this, may be valuable for analysis.","commit_id":"fffdd92ca9b1075e3bc61d84847ef0a84a8689bf"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"f22dc01d772d3c635fb57bc326e943b8e4f6c978","unresolved":false,"context_lines":[{"line_number":342,"context_line":"                try:"},{"line_number":343,"context_line":"                    self.load_balancer.pools.remove(pool)"},{"line_number":344,"context_line":"                except ValueError:"},{"line_number":345,"context_line":"                    pass"},{"line_number":346,"context_line":"                break"},{"line_number":347,"context_line":"        for l7policy in self.l7policies:"},{"line_number":348,"context_line":"            if l7policy.redirect_pool_id \u003d\u003d self.id:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_cddeb60e","line":345,"in_reply_to":"9f560f44_16c9e077","updated":"2020-10-13 09:11:30.000000000","message":"I considered that but I could not really see value in even a LOG.debug message. What sort of analysis would one do, could you give an example?\nIt seems to only affect when on no-op drivers and is not 100% reproducible.","commit_id":"fffdd92ca9b1075e3bc61d84847ef0a84a8689bf"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"72deade027d66be2d601346dfea467e2fb45ce1d","unresolved":false,"context_lines":[{"line_number":342,"context_line":"                try:"},{"line_number":343,"context_line":"                    self.load_balancer.pools.remove(pool)"},{"line_number":344,"context_line":"                except ValueError:"},{"line_number":345,"context_line":"                    pass"},{"line_number":346,"context_line":"                break"},{"line_number":347,"context_line":"        for l7policy in self.l7policies:"},{"line_number":348,"context_line":"            if l7policy.redirect_pool_id \u003d\u003d self.id:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_5e7c0a1f","line":345,"in_reply_to":"9f560f44_80bbe5bb","updated":"2020-10-13 11:37:49.000000000","message":"Done","commit_id":"fffdd92ca9b1075e3bc61d84847ef0a84a8689bf"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"90ef42c1e4ea42c1f136069af419d92857ee762a","unresolved":false,"context_lines":[{"line_number":342,"context_line":"                try:"},{"line_number":343,"context_line":"                    self.load_balancer.pools.remove(pool)"},{"line_number":344,"context_line":"                except ValueError:"},{"line_number":345,"context_line":"                    pass"},{"line_number":346,"context_line":"                break"},{"line_number":347,"context_line":"        for l7policy in self.l7policies:"},{"line_number":348,"context_line":"            if l7policy.redirect_pool_id \u003d\u003d self.id:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_80bbe5bb","line":345,"in_reply_to":"9f560f44_cddeb60e","updated":"2020-10-13 09:55:22.000000000","message":"For me it\u0027s just a bad practice to silently skip exceptions and I don\u0027t see any harm in logging this giving some details what is going on.\n\nFrom my experience when we have prod issue to investigate, when we do not have ability to debug - all logging very useful. \n\nI don\u0027t have an example here, this is more about best practices we should follow.","commit_id":"fffdd92ca9b1075e3bc61d84847ef0a84a8689bf"}]}