)]}'
{"octavia/db/repositories.py":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"1a934ac25990765a4adbd2f7ed1d5b3e9dc4064f","unresolved":false,"context_lines":[{"line_number":1146,"context_line":"            if tags:"},{"line_number":1147,"context_line":"                resource \u003d session.query(self.model_class).get(id)"},{"line_number":1148,"context_line":"                resource.tags \u003d tags"},{"line_number":1149,"context_line":"            listener_db \u003d session.query(self.model_class).filter_by("},{"line_number":1150,"context_line":"                id\u003did).first()"},{"line_number":1151,"context_line":"            if not listener_db:"},{"line_number":1152,"context_line":"                raise exceptions.NotFound("},{"line_number":1153,"context_line":"                    resource\u003ddata_models.Listener._name(), id\u003did)"},{"line_number":1154,"context_line":"            # Verify any newly specified default_pool_id exists"},{"line_number":1155,"context_line":"            default_pool_id \u003d model_kwargs.get(\u0027default_pool_id\u0027)"},{"line_number":1156,"context_line":"            if default_pool_id:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_f5fa8740","line":1153,"range":{"start_line":1149,"start_character":12,"end_line":1153,"end_character":65},"updated":"2020-11-11 07:22:36.000000000","message":"These lines should be moved above L1145-1148. In L1147, if the listener does not exist in the database but its model_kwargs includes tags, it will fail in L1148. So, he must make sure the listener DB object exists before anything else.","commit_id":"b50f38b5b80e62f60391ed59b8f67fd4d3005ff7"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"6c7fb582c0e972eb0446d49bbe4db6b887c413be","unresolved":false,"context_lines":[{"line_number":1146,"context_line":"            if tags:"},{"line_number":1147,"context_line":"                resource \u003d session.query(self.model_class).get(id)"},{"line_number":1148,"context_line":"                resource.tags \u003d tags"},{"line_number":1149,"context_line":"            listener_db \u003d session.query(self.model_class).filter_by("},{"line_number":1150,"context_line":"                id\u003did).first()"},{"line_number":1151,"context_line":"            if not listener_db:"},{"line_number":1152,"context_line":"                raise exceptions.NotFound("},{"line_number":1153,"context_line":"                    resource\u003ddata_models.Listener._name(), id\u003did)"},{"line_number":1154,"context_line":"            # Verify any newly specified default_pool_id exists"},{"line_number":1155,"context_line":"            default_pool_id \u003d model_kwargs.get(\u0027default_pool_id\u0027)"},{"line_number":1156,"context_line":"            if default_pool_id:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_3a405507","line":1153,"range":{"start_line":1149,"start_character":12,"end_line":1153,"end_character":65},"in_reply_to":"1f621f24_d82216b9","updated":"2020-11-12 14:49:49.000000000","message":"Plus, during my debugging (with a LOG.debug here) I never triggered any issues with tags, it was always on the session.query() not finding the listener.  I\u0027ll update both places but I don\u0027t like expanding the scope of one fix to fix another.","commit_id":"b50f38b5b80e62f60391ed59b8f67fd4d3005ff7"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"de30656bda39207d2d2525256c603377aeaffca7","unresolved":false,"context_lines":[{"line_number":1146,"context_line":"            if tags:"},{"line_number":1147,"context_line":"                resource \u003d session.query(self.model_class).get(id)"},{"line_number":1148,"context_line":"                resource.tags \u003d tags"},{"line_number":1149,"context_line":"            listener_db \u003d session.query(self.model_class).filter_by("},{"line_number":1150,"context_line":"                id\u003did).first()"},{"line_number":1151,"context_line":"            if not listener_db:"},{"line_number":1152,"context_line":"                raise exceptions.NotFound("},{"line_number":1153,"context_line":"                    resource\u003ddata_models.Listener._name(), id\u003did)"},{"line_number":1154,"context_line":"            # Verify any newly specified default_pool_id exists"},{"line_number":1155,"context_line":"            default_pool_id \u003d model_kwargs.get(\u0027default_pool_id\u0027)"},{"line_number":1156,"context_line":"            if default_pool_id:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_d82216b9","line":1153,"range":{"start_line":1149,"start_character":12,"end_line":1153,"end_character":65},"in_reply_to":"1f621f24_f5fa8740","updated":"2020-11-11 21:51:41.000000000","message":"Can I do this in a separate change as it seems a different bug, and it\u0027s also broken on L108.","commit_id":"b50f38b5b80e62f60391ed59b8f67fd4d3005ff7"}]}