)]}'
{"octavia/controller/worker/v1/flows/load_balancer_flows.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8f8a4bd5879b86d7d36179cbecd7f4f245895a22","unresolved":false,"context_lines":[{"line_number":395,"context_line":"                CONF.haproxy_amphora.active_connection_rety_interval}"},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"        if failed_amp:"},{"line_number":398,"context_line":"            # NOTE(haleyb): could we get an amp with role \u003d\u003d \u0027MASTER\u0027?"},{"line_number":399,"context_line":"            if failed_amp.role in (constants.ROLE_PRIMARY,"},{"line_number":400,"context_line":"                                   constants.ROLE_BACKUP):"},{"line_number":401,"context_line":"                amp_role \u003d \u0027primary_or_backup\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"fffc6b78_54932e50","line":398,"updated":"2020-11-19 23:06:15.000000000","message":"This was my basic question, and applies in other places as well.  Don\u0027t want to break backwards-compat with an amphora created before this update.","commit_id":"c3d2fa3628d3c0461b8c5b839b4ab2f7e3d3b20d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"332ef64ee2e87dbb0a98fc4b9f2dbd0cc2e3595b","unresolved":false,"context_lines":[{"line_number":395,"context_line":"                CONF.haproxy_amphora.active_connection_rety_interval}"},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"        if failed_amp:"},{"line_number":398,"context_line":"            # NOTE(haleyb): could we get an amp with role \u003d\u003d \u0027MASTER\u0027?"},{"line_number":399,"context_line":"            if failed_amp.role in (constants.ROLE_PRIMARY,"},{"line_number":400,"context_line":"                                   constants.ROLE_BACKUP):"},{"line_number":401,"context_line":"                amp_role \u003d \u0027primary_or_backup\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"fffc6b78_34c5ca3d","line":398,"in_reply_to":"fffc6b78_54932e50","updated":"2020-11-19 23:12:54.000000000","message":"The only place that \"role\" will come from is the DB amphora table. It\u0027s just a setting we store in the DB to write out the keepalived config correctly.\nWe only use it in the amp when we write out the keepalived configuration file.","commit_id":"c3d2fa3628d3c0461b8c5b839b4ab2f7e3d3b20d"}],"octavia/db/migration/alembic_migrations/versions/c45de297d68f_add_primary_amphora_role.py":[{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"938ab6b53ea11bc2ef91f0517e30053f146d388b","unresolved":true,"context_lines":[{"line_number":41,"context_line":"        ["},{"line_number":42,"context_line":"            {\u0027name\u0027: \u0027PRIMARY\u0027}"},{"line_number":43,"context_line":"        ]"},{"line_number":44,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":2,"id":"dbd31fc3_942b3439","line":44,"updated":"2021-01-14 08:50:09.000000000","message":"Should we also update existing data to use PRIMARY?","commit_id":"7875a9b37f04c67faf8e6b08bccf65e23bddcf1a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2471af4f7bb433ede1172232d7814ceafb4ec61a","unresolved":true,"context_lines":[{"line_number":41,"context_line":"        ["},{"line_number":42,"context_line":"            {\u0027name\u0027: \u0027PRIMARY\u0027}"},{"line_number":43,"context_line":"        ]"},{"line_number":44,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":2,"id":"792b5fc2_92460c0e","line":44,"in_reply_to":"dbd31fc3_942b3439","updated":"2021-02-01 23:04:53.000000000","message":"Yes, that is a good question.  I suppose so, I\u0027ll try and figure out the alembic-fu to do that.  But Carlos might have an opinion on that, it might be leaving the old ones alone is Ok as long as the API still works the same.\n\nThe other part of this is backwards-compatibility in the API.  \u0027openstack loadbalancer amphora list --role MASTER\u0027 should also still be supported, and should give the same output as --role PRIMARY.","commit_id":"7875a9b37f04c67faf8e6b08bccf65e23bddcf1a"}]}