)]}'
{"octavia/cmd/status.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"8630369f19cca63e8157cff436eb091c482ca508","unresolved":true,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    _upgrade_checks \u003d ("},{"line_number":115,"context_line":"        (_(\u0027AmphoraV2 Check\u0027), _check_amphorav2),"},{"line_number":116,"context_line":"        (_(\u0027YAML Policy File\u0027), _check_yaml_policy),"},{"line_number":117,"context_line":"        (_(\u0027Policy File JSON to YAML Migration\u0027),"},{"line_number":118,"context_line":"         (common_checks.check_policy_json, {\u0027conf\u0027: CONF})),"},{"line_number":119,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":1,"id":"428871e5_aa88f2ae","line":116,"updated":"2020-11-29 06:36:11.000000000","message":"Like this one???","commit_id":"b346a02bedfb84eedaa48d1dc2ab6efab60aed81"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b10c4fd60213c080147e7200173d6c988c9e328f","unresolved":true,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    _upgrade_checks \u003d ("},{"line_number":115,"context_line":"        (_(\u0027AmphoraV2 Check\u0027), _check_amphorav2),"},{"line_number":116,"context_line":"        (_(\u0027YAML Policy File\u0027), _check_yaml_policy),"},{"line_number":117,"context_line":"        (_(\u0027Policy File JSON to YAML Migration\u0027),"},{"line_number":118,"context_line":"         (common_checks.check_policy_json, {\u0027conf\u0027: CONF})),"},{"line_number":119,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":1,"id":"704a6d3e_056281a0","line":116,"in_reply_to":"428871e5_aa88f2ae","updated":"2020-11-30 15:36:28.000000000","message":"ah that check just check for file extension not of file is actually JSON formatted or not. new check added in this patch use the oslo utils method which try to load the file using JSON or YAML lib.","commit_id":"b346a02bedfb84eedaa48d1dc2ab6efab60aed81"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f4a24781953a8141d7bf4a29b01e6657c4ea5ef3","unresolved":true,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    _upgrade_checks \u003d ("},{"line_number":115,"context_line":"        (_(\u0027AmphoraV2 Check\u0027), _check_amphorav2),"},{"line_number":116,"context_line":"        (_(\u0027YAML Policy File\u0027), _check_yaml_policy),"},{"line_number":117,"context_line":"        (_(\u0027Policy File JSON to YAML Migration\u0027),"},{"line_number":118,"context_line":"         (common_checks.check_policy_json, {\u0027conf\u0027: CONF})),"},{"line_number":119,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":1,"id":"f197fe5b_1fec1e87","line":116,"in_reply_to":"704a6d3e_056281a0","updated":"2020-11-30 15:38:44.000000000","message":"here - https://review.opendev.org/c/openstack/oslo.upgradecheck/+/763484/3/oslo_upgradecheck/common_checks.py","commit_id":"b346a02bedfb84eedaa48d1dc2ab6efab60aed81"}],"octavia/common/policy.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"9c751f68fcfda0e9914d5763898e3ea89da9f209","unresolved":true,"context_lines":[{"line_number":28,"context_line":"# TODO(gmann): Remove setting the default value of config policy_file"},{"line_number":29,"context_line":"# once oslo_policy change the default value to \u0027policy.yaml\u0027."},{"line_number":30,"context_line":"# https://github.com/openstack/oslo.policy/blob/a626ad12fe5a3abd49d70e3e5b95589d279ab578/oslo_policy/opts.py#L49"},{"line_number":31,"context_line":"DEFAULT_POLICY_FILE \u003d \u0027policy.yaml\u0027"},{"line_number":32,"context_line":"opts.set_defaults(cfg.CONF, DEFAULT_POLICY_FILE)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"bb553f11_3b24881d","line":31,"updated":"2021-03-08 16:29:24.000000000","message":"nit: we usually try to centralize constants(common/constants.py), but since this is a temporary (TODO) this is just a nit and not a required change IMO.","commit_id":"e34992bade582a277c02941c2b36674dfee10152"}],"requirements.txt":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"9c751f68fcfda0e9914d5763898e3ea89da9f209","unresolved":true,"context_lines":[{"line_number":22,"context_line":"oslo.log\u003e\u003d4.3.0 # Apache-2.0"},{"line_number":23,"context_line":"oslo.messaging\u003e\u003d12.4.0 # Apache-2.0"},{"line_number":24,"context_line":"oslo.middleware\u003e\u003d4.0.1 # Apache-2.0"},{"line_number":25,"context_line":"oslo.policy\u003e\u003d3.6.0 # Apache-2.0"},{"line_number":26,"context_line":"oslo.reports\u003e\u003d1.18.0 # Apache-2.0"},{"line_number":27,"context_line":"oslo.serialization\u003e\u003d2.28.1 # Apache-2.0"},{"line_number":28,"context_line":"oslo.upgradecheck\u003e\u003d1.3.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":14,"id":"f023e9c8_f1000665","line":25,"updated":"2021-03-08 16:29:24.000000000","message":"This is going to merge conflict with 775957 that bumps this higher due to bugs in oslo.policy.","commit_id":"e34992bade582a277c02941c2b36674dfee10152"}],"setup.cfg":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1b46c45347ee66905ddb10d1b9de62490ea84cc3","unresolved":true,"context_lines":[{"line_number":101,"context_line":"oslo.config.opts \u003d"},{"line_number":102,"context_line":"    octavia \u003d octavia.opts:list_opts"},{"line_number":103,"context_line":"oslo.config.opts.defaults \u003d"},{"line_number":104,"context_line":"    nova.conf \u003d octavia.common.config:set_lib_defaults"},{"line_number":105,"context_line":"oslo.policy.policies \u003d"},{"line_number":106,"context_line":"    octavia \u003d octavia.policies:list_rules"},{"line_number":107,"context_line":"oslo.policy.enforcer \u003d"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"1601c5de_ddc4d479","line":104,"updated":"2020-11-29 06:34:53.000000000","message":"We are not nova","commit_id":"b346a02bedfb84eedaa48d1dc2ab6efab60aed81"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b10c4fd60213c080147e7200173d6c988c9e328f","unresolved":true,"context_lines":[{"line_number":101,"context_line":"oslo.config.opts \u003d"},{"line_number":102,"context_line":"    octavia \u003d octavia.opts:list_opts"},{"line_number":103,"context_line":"oslo.config.opts.defaults \u003d"},{"line_number":104,"context_line":"    nova.conf \u003d octavia.common.config:set_lib_defaults"},{"line_number":105,"context_line":"oslo.policy.policies \u003d"},{"line_number":106,"context_line":"    octavia \u003d octavia.policies:list_rules"},{"line_number":107,"context_line":"oslo.policy.enforcer \u003d"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"95d9ce59_a3889b4f","line":104,"in_reply_to":"1601c5de_ddc4d479","updated":"2020-11-30 15:36:28.000000000","message":"ah my bad. done","commit_id":"b346a02bedfb84eedaa48d1dc2ab6efab60aed81"}]}