)]}'
{"octavia/amphorae/drivers/haproxy/rest_api_driver.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"4de230840a559e3705e284bdddd2e8c3e650933b","unresolved":true,"context_lines":[{"line_number":460,"context_line":"        cert_filename_list \u003d []"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"        data \u003d cert_parser.load_certificates_data("},{"line_number":463,"context_line":"            self.cert_manager, listener)"},{"line_number":464,"context_line":"        if data[\u0027tls_cert\u0027] is not None:"},{"line_number":465,"context_line":"            tls_cert \u003d data[\u0027tls_cert\u0027]"},{"line_number":466,"context_line":"            # Note, the first cert is the TLS default cert"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f873f61_471aa63d","line":463,"updated":"2021-01-05 20:15:32.000000000","message":"So just thinking about this again, is this the call raising the exception?  Seems it will raise CertificateRetrievalException() in certain cases.  If that\u0027s the case then perhaps the try/except should be here and it just returns similar to L489?","commit_id":"988ad63c2e76c0d42e7f07dbf7daa1d6418c9677"},{"author":{"_account_id":29870,"name":"sunxifa","email":"sunxifa@inspur.com","username":"sunxifa"},"change_message_id":"3fad1823020e367fb543931ae32cafe4dd92cd41","unresolved":true,"context_lines":[{"line_number":460,"context_line":"        cert_filename_list \u003d []"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"        data \u003d cert_parser.load_certificates_data("},{"line_number":463,"context_line":"            self.cert_manager, listener)"},{"line_number":464,"context_line":"        if data[\u0027tls_cert\u0027] is not None:"},{"line_number":465,"context_line":"            tls_cert \u003d data[\u0027tls_cert\u0027]"},{"line_number":466,"context_line":"            # Note, the first cert is the TLS default cert"}],"source_content_type":"text/x-python","patch_set":3,"id":"c130e9b7_2b2717ea","line":463,"in_reply_to":"1f873f61_471aa63d","updated":"2021-01-06 03:01:30.000000000","message":"It is indeed the call raising the exception, but when the CertificateRetrievalException() occurs, it indicates that something wrong with the tls listener and the exception should float up. so for updating the listener, we can just raise the exception and set it provisioning status error, but for deleting the listener, we should ignore the exception and let the process carries on.","commit_id":"988ad63c2e76c0d42e7f07dbf7daa1d6418c9677"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"f00459168a975fdecdf99f1cd5ee0824d265bc8a","unresolved":true,"context_lines":[{"line_number":345,"context_line":"                certs_to_delete.add(certs[\u0027tls_cert\u0027].id)"},{"line_number":346,"context_line":"            for sni_cert in certs[\u0027sni_certs\u0027]:"},{"line_number":347,"context_line":"                certs_to_delete.add(sni_cert.id)"},{"line_number":348,"context_line":"        except Exception as e:"},{"line_number":349,"context_line":"            LOG.warning(\u0027Unable to retrieve certificate(s) due to %s\u0027,"},{"line_number":350,"context_line":"                        str(e))"},{"line_number":351,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7844a36d_10169e75","line":348,"range":{"start_line":348,"start_character":15,"end_line":348,"end_character":30},"updated":"2021-01-12 08:12:03.000000000","message":"I think we should be able to catch more specific exception here or verify its message.","commit_id":"a9068f8cc4362e92c8f7bc925546497fc2d418fa"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"f00459168a975fdecdf99f1cd5ee0824d265bc8a","unresolved":true,"context_lines":[{"line_number":346,"context_line":"            for sni_cert in certs[\u0027sni_certs\u0027]:"},{"line_number":347,"context_line":"                certs_to_delete.add(sni_cert.id)"},{"line_number":348,"context_line":"        except Exception as e:"},{"line_number":349,"context_line":"            LOG.warning(\u0027Unable to retrieve certificate(s) due to %s\u0027,"},{"line_number":350,"context_line":"                        str(e))"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"        # Delete them (they\u0027ll be recreated before the reload if they are"}],"source_content_type":"text/x-python","patch_set":4,"id":"297b1d33_12699765","line":349,"range":{"start_line":349,"start_character":25,"end_line":349,"end_character":58},"updated":"2021-01-12 08:12:03.000000000","message":"I would expect warning like: Certs cannot be found, so won\u0027t be deleted.","commit_id":"a9068f8cc4362e92c8f7bc925546497fc2d418fa"}]}