)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"d697ae26f7ca81e5caa98011e9d1d445267cd5aa","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Fix vip security group update"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Updating lb will fail when the lb vip security group rule\u0027s"},{"line_number":10,"context_line":"ingress protocol is None. In particular situation, it does happen."},{"line_number":11,"context_line":"We assure the updating process normal regardless of the rules."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I902fb01ee0a62c5399e495aacc961fd254f07b4d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"e5162d3c_9c4e0ecd","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":24},"updated":"2021-10-26 09:38:47.000000000","message":"It seems that Octavia always sets the ingress protocol when adding SG rules. Do you have a reproducer for this issue?","commit_id":"154e826fa8ff4fc530f34f778873dac4001099ea"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"d697ae26f7ca81e5caa98011e9d1d445267cd5aa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"46e0a03b_ff715ecc","updated":"2021-10-26 09:38:47.000000000","message":"CR-1 to raise awareness for my question","commit_id":"154e826fa8ff4fc530f34f778873dac4001099ea"}],"octavia/network/drivers/neutron/allowed_address_pairs.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"561d0b0dbfc26a8d496b607c6bb6cb4830656b61","unresolved":true,"context_lines":[{"line_number":185,"context_line":"            # Don\u0027t remove egress rules and don\u0027t confuse other protocols with"},{"line_number":186,"context_line":"            # None ports with the egress rules.  VRRP uses protocol 51 and 112"},{"line_number":187,"context_line":"            if (rule.get(\u0027direction\u0027) \u003d\u003d \u0027egress\u0027 or"},{"line_number":188,"context_line":"                not rule.get(\u0027protocol\u0027, \u0027\u0027) or"},{"line_number":189,"context_line":"                rule.get(\u0027protocol\u0027, \u0027\u0027).upper() not in"},{"line_number":190,"context_line":"                    [constants.PROTOCOL_TCP, constants.PROTOCOL_UDP,"},{"line_number":191,"context_line":"                     lib_consts.PROTOCOL_SCTP]):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ee96896_5fad00f2","line":188,"updated":"2021-01-04 17:17:04.000000000","message":"I don\u0027t think this line is required with the change below.","commit_id":"7dc658c7a78ee878469a526f88341b7c7658d717"}]}
