)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"708e30f77aa3d1f0ac0eaa40c4769f3152e72bd5","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Gregory Thiemonge \u003cgthiemon@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-01-06 08:22:38 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix lower-constraints"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: If830a35fbcb679943e94adb821755eadf828c248"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"373ef703_058863c7","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":21},"updated":"2021-01-06 14:26:11.000000000","message":"I would add here some more detail about the patch, e.g.:\n- lower-constraints fix\n- devstack plugin fix\n- cap bandit to 1.6.2 (due to wrong package release for py27)\n- tox.ini refactor of bandit command","commit_id":"d3ab65408a71e70ac20ca9969224c62ae5ec2a3f"}],"devstack/plugin.sh":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"c7cedcb59735f9211ddbedf4a7c15e5022468930","unresolved":true,"context_lines":[{"line_number":45,"context_line":"}"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"function build_octavia_worker_image {"},{"line_number":48,"context_line":"    pip_install -r $OCTAVIA_DIR/diskimage-create/requirements.txt"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    # Pull in DIB local elements if they are defined in devstack"},{"line_number":51,"context_line":"    if [ -n \"$DIB_LOCAL_ELEMENTS\" ]; then"}],"source_content_type":"text/x-sh","patch_set":7,"id":"eba520e2_9c530c4c","line":48,"updated":"2021-01-07 22:51:59.000000000","message":"This will install those requirements globally, which could mask issues in the main Octavia code. Maybe we should run DIB from a venv?\nWhy didn\u0027t other branches require this change?","commit_id":"cc932ec1390685940a07628d675e55fec71eeb85"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"445d42b96a0c0884bf849aa03ea5808a1e33cb35","unresolved":true,"context_lines":[{"line_number":45,"context_line":"}"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"function build_octavia_worker_image {"},{"line_number":48,"context_line":"    pip_install -r $OCTAVIA_DIR/diskimage-create/requirements.txt"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    # Pull in DIB local elements if they are defined in devstack"},{"line_number":51,"context_line":"    if [ -n \"$DIB_LOCAL_ELEMENTS\" ]; then"}],"source_content_type":"text/x-sh","patch_set":7,"id":"7b0a7ec6_f29ed9d2","line":48,"in_reply_to":"eba520e2_9c530c4c","updated":"2021-01-11 08:42:33.000000000","message":"I struggled to make the main requirement to work correctly with dib.\nI checked how other branches are handling dib, and the most recent branches install it in a very same way from the devstack plugin: https://opendev.org/openstack/octavia/src/branch/stable/victoria/devstack/plugin.sh#L56\n\nI will take another try, but if I cannot have a smaller change, we might be stuck with that command.","commit_id":"cc932ec1390685940a07628d675e55fec71eeb85"}]}