)]}'
{"octavia/api/drivers/amphora_driver/v1/driver.py":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"201772a1b6a5df6d38994c8b640f12da348773a8","unresolved":true,"context_lines":[{"line_number":45,"context_line":"    consts.LB_ALGORITHM_LEAST_CONNECTIONS]"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"AMPHORA_SUPPORTED_PROTOCOLS \u003d ["},{"line_number":48,"context_line":"    consts.PROTOCOL_TCP,"},{"line_number":49,"context_line":"    consts.PROTOCOL_HTTP,"},{"line_number":50,"context_line":"    consts.PROTOCOL_HTTPS,"},{"line_number":51,"context_line":"    consts.PROTOCOL_TERMINATED_HTTPS,"},{"line_number":52,"context_line":"    consts.PROTOCOL_PROXY,"},{"line_number":53,"context_line":"    lib_consts.PROTOCOL_PROXYV2,"},{"line_number":54,"context_line":"    consts.PROTOCOL_UDP,"},{"line_number":55,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"ae47b1dd_d42f54a6","line":52,"range":{"start_line":48,"start_character":4,"end_line":52,"end_character":26},"updated":"2021-01-21 08:31:04.000000000","message":"These are deprecated since Stein. Please use lib_consts.*","commit_id":"0031d9c6544da55ef4af50ec3269844bc8e36b0d"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"8b6419f622ca6a0951905d4240d91bc6402f7b36","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    consts.LB_ALGORITHM_LEAST_CONNECTIONS]"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"AMPHORA_SUPPORTED_PROTOCOLS \u003d ["},{"line_number":48,"context_line":"    consts.PROTOCOL_TCP,"},{"line_number":49,"context_line":"    consts.PROTOCOL_HTTP,"},{"line_number":50,"context_line":"    consts.PROTOCOL_HTTPS,"},{"line_number":51,"context_line":"    consts.PROTOCOL_TERMINATED_HTTPS,"},{"line_number":52,"context_line":"    consts.PROTOCOL_PROXY,"},{"line_number":53,"context_line":"    lib_consts.PROTOCOL_PROXYV2,"},{"line_number":54,"context_line":"    consts.PROTOCOL_UDP,"},{"line_number":55,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"8700feff_aa34904a","line":52,"range":{"start_line":48,"start_character":4,"end_line":52,"end_character":26},"in_reply_to":"ae47b1dd_d42f54a6","updated":"2021-01-21 09:38:24.000000000","message":"done","commit_id":"0031d9c6544da55ef4af50ec3269844bc8e36b0d"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"201772a1b6a5df6d38994c8b640f12da348773a8","unresolved":true,"context_lines":[{"line_number":51,"context_line":"    consts.PROTOCOL_TERMINATED_HTTPS,"},{"line_number":52,"context_line":"    consts.PROTOCOL_PROXY,"},{"line_number":53,"context_line":"    lib_consts.PROTOCOL_PROXYV2,"},{"line_number":54,"context_line":"    consts.PROTOCOL_UDP,"},{"line_number":55,"context_line":"]"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"84a71629_c556f8ec","line":54,"range":{"start_line":54,"start_character":4,"end_line":54,"end_character":23},"updated":"2021-01-21 08:31:04.000000000","message":"ditto","commit_id":"0031d9c6544da55ef4af50ec3269844bc8e36b0d"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"8b6419f622ca6a0951905d4240d91bc6402f7b36","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    consts.PROTOCOL_TERMINATED_HTTPS,"},{"line_number":52,"context_line":"    consts.PROTOCOL_PROXY,"},{"line_number":53,"context_line":"    lib_consts.PROTOCOL_PROXYV2,"},{"line_number":54,"context_line":"    consts.PROTOCOL_UDP,"},{"line_number":55,"context_line":"]"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1e74a7_5bc95904","line":54,"range":{"start_line":54,"start_character":4,"end_line":54,"end_character":23},"in_reply_to":"84a71629_c556f8ec","updated":"2021-01-21 09:38:24.000000000","message":"Done","commit_id":"0031d9c6544da55ef4af50ec3269844bc8e36b0d"}],"octavia/api/drivers/amphora_driver/v2/driver.py":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"201772a1b6a5df6d38994c8b640f12da348773a8","unresolved":true,"context_lines":[{"line_number":46,"context_line":"    consts.LB_ALGORITHM_LEAST_CONNECTIONS]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"AMPHORA_SUPPORTED_PROTOCOLS \u003d ["},{"line_number":49,"context_line":"    consts.PROTOCOL_TCP,"},{"line_number":50,"context_line":"    consts.PROTOCOL_HTTP,"},{"line_number":51,"context_line":"    consts.PROTOCOL_HTTPS,"},{"line_number":52,"context_line":"    consts.PROTOCOL_TERMINATED_HTTPS,"},{"line_number":53,"context_line":"    consts.PROTOCOL_PROXY,"},{"line_number":54,"context_line":"    lib_consts.PROTOCOL_PROXYV2,"},{"line_number":55,"context_line":"    consts.PROTOCOL_UDP,"},{"line_number":56,"context_line":"]"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"d60de914_d3b26e07","line":55,"range":{"start_line":49,"start_character":4,"end_line":55,"end_character":24},"updated":"2021-01-21 08:31:04.000000000","message":"ditto","commit_id":"0031d9c6544da55ef4af50ec3269844bc8e36b0d"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"8b6419f622ca6a0951905d4240d91bc6402f7b36","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    consts.LB_ALGORITHM_LEAST_CONNECTIONS]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"AMPHORA_SUPPORTED_PROTOCOLS \u003d ["},{"line_number":49,"context_line":"    consts.PROTOCOL_TCP,"},{"line_number":50,"context_line":"    consts.PROTOCOL_HTTP,"},{"line_number":51,"context_line":"    consts.PROTOCOL_HTTPS,"},{"line_number":52,"context_line":"    consts.PROTOCOL_TERMINATED_HTTPS,"},{"line_number":53,"context_line":"    consts.PROTOCOL_PROXY,"},{"line_number":54,"context_line":"    lib_consts.PROTOCOL_PROXYV2,"},{"line_number":55,"context_line":"    consts.PROTOCOL_UDP,"},{"line_number":56,"context_line":"]"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dcaf2521_7d7d5907","line":55,"range":{"start_line":49,"start_character":4,"end_line":55,"end_character":24},"in_reply_to":"d60de914_d3b26e07","updated":"2021-01-21 09:38:24.000000000","message":"Done","commit_id":"0031d9c6544da55ef4af50ec3269844bc8e36b0d"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"1b7111eafd92ff9bc2bea7d658a4144650c030d9","unresolved":true,"context_lines":[{"line_number":45,"context_line":"    consts.LB_ALGORITHM_SOURCE_IP,"},{"line_number":46,"context_line":"    consts.LB_ALGORITHM_LEAST_CONNECTIONS]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"AMPHORA_SUPPORTED_PROTOCOLS \u003d ["},{"line_number":49,"context_line":"    lib_consts.PROTOCOL_TCP,"},{"line_number":50,"context_line":"    lib_consts.PROTOCOL_HTTP,"},{"line_number":51,"context_line":"    lib_consts.PROTOCOL_HTTPS,"}],"source_content_type":"text/x-python","patch_set":2,"id":"be33e917_3b4ffd3c","line":48,"updated":"2021-01-26 07:54:51.000000000","message":"Why we have it defined here? Not in constants file?","commit_id":"fbbc5f9024b0408d5ff70bb8f2c4c690f0304c33"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"e3d1440e7e6d54352c9b904da698c86ae184d5e7","unresolved":true,"context_lines":[{"line_number":45,"context_line":"    consts.LB_ALGORITHM_SOURCE_IP,"},{"line_number":46,"context_line":"    consts.LB_ALGORITHM_LEAST_CONNECTIONS]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"AMPHORA_SUPPORTED_PROTOCOLS \u003d ["},{"line_number":49,"context_line":"    lib_consts.PROTOCOL_TCP,"},{"line_number":50,"context_line":"    lib_consts.PROTOCOL_HTTP,"},{"line_number":51,"context_line":"    lib_consts.PROTOCOL_HTTPS,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bfd0471e_7bf0b404","line":48,"in_reply_to":"3a3cfce3_089d1126","updated":"2021-01-26 08:13:34.000000000","message":"I had the same thought as Ann. I\u0027m okay with defining the constant here because\n1) Our constants.py file is/should be more generic to the Octavia service.\n2) There is a precedent (see AMPHORA_SUPPORTED_LB_ALGORITHMS in L48).","commit_id":"fbbc5f9024b0408d5ff70bb8f2c4c690f0304c33"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"835e601f7d3cbecb7fac36847cb64e70d51af6db","unresolved":true,"context_lines":[{"line_number":45,"context_line":"    consts.LB_ALGORITHM_SOURCE_IP,"},{"line_number":46,"context_line":"    consts.LB_ALGORITHM_LEAST_CONNECTIONS]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"AMPHORA_SUPPORTED_PROTOCOLS \u003d ["},{"line_number":49,"context_line":"    lib_consts.PROTOCOL_TCP,"},{"line_number":50,"context_line":"    lib_consts.PROTOCOL_HTTP,"},{"line_number":51,"context_line":"    lib_consts.PROTOCOL_HTTPS,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a3cfce3_089d1126","line":48,"in_reply_to":"be33e917_3b4ffd3c","updated":"2021-01-26 08:03:49.000000000","message":"I added this list here because it\u0027s only used in this file (ok: 2 files, in v1 and v2)\n\nBut I can move it, any other opinions?","commit_id":"fbbc5f9024b0408d5ff70bb8f2c4c690f0304c33"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"61762fcf7aecbeffe6e5085b5eac37b3bb6b7ea1","unresolved":true,"context_lines":[{"line_number":45,"context_line":"    consts.LB_ALGORITHM_SOURCE_IP,"},{"line_number":46,"context_line":"    consts.LB_ALGORITHM_LEAST_CONNECTIONS]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"AMPHORA_SUPPORTED_PROTOCOLS \u003d ["},{"line_number":49,"context_line":"    lib_consts.PROTOCOL_TCP,"},{"line_number":50,"context_line":"    lib_consts.PROTOCOL_HTTP,"},{"line_number":51,"context_line":"    lib_consts.PROTOCOL_HTTPS,"}],"source_content_type":"text/x-python","patch_set":2,"id":"096fa510_79f5a088","line":48,"in_reply_to":"bfd0471e_7bf0b404","updated":"2021-01-26 08:25:35.000000000","message":"Generally it is good to define constants in one place (amphora_constants.py ?) As I recon in constants file we already have bunch of amphora specific ones. I asked as I may miss some specific here. \nAnyway this won\u0027t prevent us from merging this one.","commit_id":"fbbc5f9024b0408d5ff70bb8f2c4c690f0304c33"}]}